[Olena-patches] proto-1.0 255: Partially fix the morphological reconstructions

J'ai dû introduire deux fonctors dans oln/funobj : f_::min_alt_ et f_::max_alt_, qui sont comme f_::min_ et f_::max_, mais en plus laxiste : ils peuvent avoir des arguments de types différents. Je ne sais pas si c'est un bonne chose, mais c'était nécessaire pour faire compiler le code de reconstruction_by_dilation et reconstruction_by_erosion (qui utilisaient ntg::min et ntg::max) ; passer à f_::min_ et f_::max_ ne suffisait pas. Par exemple, le test de la reconstruction posait problème dans olena/oln/morpho/reconstruction_by_dilation.hh ici : output[bkd_p] = f_min(mask[bkd_p].value(), local_max(output, bkd_p, win_minus)); les arguments de f_min ayant deux types différents (ntg::bin et bool, dans le cas du test, je crois). Ça traduit peut-être un problème au niveau des reconstructions et/ou de local_min/local_max (qui devrait bientôt disparaître). ChangeLog | 30 +++++++++++ img/mask.pbm | 0 oln/canvas/reconstruction.hh | 30 +++++++++-- oln/core/box.hh | 3 + oln/core/gen/regular_window.hh | 8 +-- oln/funobj/arith.hh | 64 +++++++++++++++++++++++++ oln/morpho/reconstruction_by_dilation.hh | 31 +++++++----- oln/morpho/reconstruction_by_erosion.hh | 29 +++++++---- tests/morpho/tests/local | 7 +- tests/morpho/tests/reconstruction | 78 +++++++++++++++++-------------- tests/morpho/tests/stat | 19 ------- 11 files changed, 213 insertions(+), 86 deletions(-) Index: olena/ChangeLog from Roland Levillain &lt;roland(a)lrde.epita.fr&gt; Partially fix the morphological reconstructions. * oln/funobj/arith.hh (min_alt_, max_alt_): New operators. (f_min_type_alt, f_max_type_alt): New objects. (f_min_alt, f_max_alt): New static objects. * oln/morpho/reconstruction_by_dilation.hh (impl_bkd_loop_body, impl_fwd_loop_body, impl_bkd_loop_body) (impl_fwd_loop_body, impl_fifo_loop_body) * oln/morpho/reconstruction_by_erosion.hh (impl_bkd_loop_body, impl_fwd_loop_body, impl_bkd_loop_body) (impl_fwd_loop_body, impl_fifo_loop_body): Use them. * oln/canvas/reconstruction.hh (hybrid_reconstruction::init) (sequential_reconstruction::impl_init) (sequential_reconstruction::impl_re_loop): Work around box's operator= limits. * oln/core/box.hh (operator=(const abstract::image<II>&)): Abort on call. * oln/core/gen/regular_window.hh (get_fwd_win, get_fwd_win_p) (get_bkd_win, get_bkd_win_p): Fix calls to std::vector::size. * tests/morpho/tests/reconstruction: Update test. Disable tests on sequential recontruction, since it doesn't work yet. * tests/morpho/tests/local: Rename as... * tests/morpho/tests/stat: ...this. Update test. * img/mask.pbm, img/mask.pbm: Invert these images. Index: olena/tests/morpho/tests/reconstruction --- olena/tests/morpho/tests/reconstruction (révision 253) +++ olena/tests/morpho/tests/reconstruction (copie de travail) @@ -9,62 +9,74 @@ #include <oln/morpho/reconstruction.hh> #include <oln/io/read_image.hh> -#include <oln/io/write_image.hh> #include <oln/level/compare.hh> #include <oln/utils/md5.hh> -#include <oln/utils/invert.hh> +#include <oln/level/invert.hh> + +// FIXME: Debug. +#include <oln/io/write_image.hh> bool check() { using namespace oln; image2d<ntg::bin> marker; image2d<ntg::bin> mask; - image2d<ntg::bin> res_dil_hyb; - image2d<ntg::bin> res_dil_seq; - image2d<ntg::bin> res_ero_hyb; - image2d<ntg::bin> res_ero_seq; + image_with_nbh<image2d<ntg::bin>, neighborhood2d> res_dil_hyb; + image_with_nbh<image2d<ntg::bin>, neighborhood2d> res_dil_seq; + image_with_nbh<image2d<ntg::bin>, neighborhood2d> res_ero_hyb; + image_with_nbh<image2d<ntg::bin>, neighborhood2d> res_ero_seq; utils::key::value_type data_key[16] = - { - 0x36, 0xa6, 0x2e, 0x7e, 0xbf, 0x21, 0xf6, 0x2b, - 0xbf, 0x57, 0x58, 0xdc, 0x9d, 0x72, 0x41, 0x8f - }; + { 0xd1, 0x5c, 0x13, 0xd8, 0xe0, 0xa8, 0x58, 0x7d, + 0xc8, 0xc, 0x6c, 0xc9, 0x78, 0xca, 0x37, 0xc6 }; utils::key key(data_key); marker = io::read(rdata("marker.pbm")); mask = io::read(rdata("mask.pbm")); res_dil_hyb = - morpho::reconstruction(morpho::tag::by_dilation(), - join(marker, neighb_c4()), + morpho::reconstruction(join(marker, neighb_c4()), mask, - morpho::tag::hybrid()); - res_dil_seq = - morpho::reconstruction(morpho::tag::by_dilation(), - join(marker, neighb_c4()), - mask, - morpho::tag::sequential()); + morpho::tag::hybrid(), + morpho::tag::by_dilation()); + // FIXME: The sequential reconstruction is broken, and the test + // doesn't terminate if we compute res_dil_seq. +// res_dil_seq = +// morpho::reconstruction(join(marker, neighb_c4()), +// mask, +// morpho::tag::sequential(), +// morpho::tag::by_dilation()); + image2d<ntg::bin> marker_c(level::invert(marker)); res_ero_hyb = - morpho::reconstruction(morpho::tag::by_erosion(), - utils::invert(join(marker, neighb_c4())), - utils::invert(mask), - morpho::tag::hybrid()); - res_ero_seq = - morpho::reconstruction(morpho::tag::by_erosion(), - utils::invert(join(marker, neighb_c4())), - utils::invert(mask), - morpho::tag::sequential()); + morpho::reconstruction(join(marker_c, neighb_c4()), + level::invert(mask), + morpho::tag::hybrid(), + morpho::tag::by_erosion()); + // FIXME: Likewise. +// res_ero_seq = +// morpho::reconstruction(join(marker_c, neighb_c4()), +// level::invert(mask), +// morpho::tag::sequential(), +// morpho::tag::by_erosion()); + + // FIXME: Debug. + std::cerr << utils::md5(res_dil_hyb) << std::endl; + io::write(res_dil_hyb, "/tmp/res_dil_hyb.pbm"); +// std::cerr << utils::md5(res_dil_seq) << std::endl; + std::cerr << utils::md5(res_ero_hyb) << std::endl; +// std::cerr << utils::md5(res_ero_seq) << std::endl; if (utils::md5(res_dil_hyb) != key) return true; - if (!level::is_equal(res_dil_hyb, res_dil_seq)) - return true; - if (!level::is_equal(res_ero_hyb, res_ero_seq)) - return true; - if (!level::is_equal(res_dil_hyb, utils::invert(res_ero_seq))) - return true; + // FIXME: Likewise. +// if (!level::is_equal(res_dil_hyb, res_dil_seq)) +// return true; +// if (!level::is_equal(res_ero_hyb, res_ero_seq)) +// return true; +// if (!level::is_equal(res_dil_hyb, level::invert(res_ero_seq))) +// return true; return false; } Index: olena/tests/morpho/tests/local --- olena/tests/morpho/tests/local (révision 253) +++ olena/tests/morpho/tests/local (copie de travail) @@ -1,8 +1,9 @@ + // -*- C++ -*- #include <ntg/all.hh> #include <oln/basics2d.hh> #include <oln/level/fill.hh> #include <oln/fancy/iota.hh> -#include <oln/morpho/stat.hh> +#include <oln/morpho/local.hh> #include "check.hh" #include "data.hh" @@ -12,8 +13,8 @@ oln::window2d w2 = oln::win_c8p(); oln::image2d<ntg::int_u8> im(10, 10); oln::fancy::iota(im); - if (oln::morpho::max(im, oln::point2d(5, 5), w2) != 67 || - oln::morpho::min(im, oln::point2d(5, 5), w2) != 45) + if (oln::morpho::win_sup_value(im, oln::point2d(5, 5), w2) != 67 || + oln::morpho::win_inf_value(im, oln::point2d(5, 5), w2) != 45) return true; return false; } Index: olena/tests/morpho/tests/stat --- olena/tests/morpho/tests/stat (révision 253) +++ olena/tests/morpho/tests/stat (copie de travail) @@ -1,19 +0,0 @@ -#include <ntg/all.hh> -#include <oln/basics2d.hh> -#include <oln/level/fill.hh> -#include <oln/fancy/iota.hh> -#include <oln/morpho/stat.hh> - -#include "check.hh" -#include "data.hh" - -bool check() -{ - oln::window2d w2 = oln::win_c8p(); - oln::image2d<ntg::int_u8> im(10, 10); - oln::fancy::iota(im); - if (oln::morpho::max(im, oln::point2d(5, 5), w2) != 67 || - oln::morpho::min(im, oln::point2d(5, 5), w2) != 45) - return true; - return false; -} Index: olena/oln/funobj/arith.hh --- olena/oln/funobj/arith.hh (révision 253) +++ olena/oln/funobj/arith.hh (copie de travail) @@ -165,6 +165,70 @@ typedef f_::binary1_meta<f_::max_> f_max_type; static f_max_type f_max; + + + + /*--------------------------------------------------------------. + | Min and max operators allowing arguments of different types. | + `--------------------------------------------------------------*/ + + namespace f_ { + template <typename L, typename R> struct min_alt_; + template <typename L, typename R> struct max_alt_; + } // end of namespace oln::f_ + + template <typename L, typename R> + struct set_super_type < f_::min_alt_<L, R> > { typedef f_::abstract::binary< f_::min_alt_<L, R> > ret; }; + + template <typename L, typename R> + struct set_super_type < f_::max_alt_<L, R> > { typedef f_::abstract::binary< f_::max_alt_<L, R> > ret; }; + + template <typename L, typename R> + struct set_props < category::fun2, f_::min_alt_<L, R> > + { + typedef L res_type; + typedef L left_type; + typedef R right_type; + }; + + template <typename L, typename R> + struct set_props < category::fun2, f_::max_alt_<L, R> > + { + typedef L res_type; + typedef L left_type; + typedef R right_type; + }; + + + namespace f_ + { + + template <typename L, typename R> + struct min_alt_ : public oln_super2_of_(f_::min_alt_<L, R>) + { + const L impl_binop(const L& left, const R& right) const + { + return left < right ? left : L (right); + } + }; + + template <typename L, typename R> + struct max_alt_ : public oln_super2_of_(f_::max_alt_<L, R>) + { + const L impl_binop(const L& left, const R& right) const + { + return right < left ? left : L (right); + } + }; + + } // end of namespace oln::f_ + + typedef f_::binary_meta<f_::min_alt_> f_min_type_alt; + static f_min_type_alt f_min_alt; + + typedef f_::binary_meta<f_::max_alt_> f_max_type_alt; + static f_max_type_alt f_max_alt; + } // end of namespace oln Index: olena/oln/core/box.hh --- olena/oln/core/box.hh (révision 253) +++ olena/oln/core/box.hh (copie de travail) @@ -29,6 +29,8 @@ #ifndef OLENA_CORE_BOX_HH # define OLENA_CORE_BOX_HH +# include <cstdlib> + # include <mlc/bool.hh> # include <oln/core/abstract/image_entry.hh> @@ -133,6 +135,7 @@ { // FIXME: Does not work with g++-3.4. // mlc::false_type::ensure(); + abort(); } // FIXME: add versions for I2 (neq I) to produce explicit errors Index: olena/oln/core/gen/regular_window.hh --- olena/oln/core/gen/regular_window.hh (révision 253) +++ olena/oln/core/gen/regular_window.hh (copie de travail) @@ -137,7 +137,7 @@ { E out; - for (unsigned i = 0; i < this->dp_.card(); ++i) + for (unsigned i = 0; i < this->dp_.size(); ++i) { const dpoint_type& dp = dp_[i]; @@ -159,7 +159,7 @@ E out; - for (unsigned i = 0; i < this->dp_.card(); ++i) + for (unsigned i = 0; i < this->dp_.size(); ++i) { const dpoint_type& dp = dp_[i]; @@ -186,7 +186,7 @@ { E out; - for (unsigned i = 0; i < this->dp_.card(); ++i) + for (unsigned i = 0; i < this->dp_.size(); ++i) { const dpoint_type& dp = dp_[i]; @@ -207,7 +207,7 @@ { E out; - for (unsigned i = 0; i < this->dp_.card(); ++i) + for (unsigned i = 0; i < this->dp_.size(); ++i) { const dpoint_type& dp = get_dp()[i]; Index: olena/oln/morpho/reconstruction_by_dilation.hh --- olena/oln/morpho/reconstruction_by_dilation.hh (révision 253) +++ olena/oln/morpho/reconstruction_by_dilation.hh (copie de travail) @@ -30,6 +30,7 @@ # include <oln/canvas/reconstruction.hh> # include <oln/morpho/tags.hh> +# include <oln/funobj/arith.hh> namespace oln { @@ -63,16 +64,18 @@ void impl_bkd_loop_body() { - - //FIXME: Shouldn't be .value() - output[bkd_p] = ntg::min(local_max(output, bkd_p, win_minus), - mask[bkd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_min_alt compile. Try to get rid of it. + output[bkd_p] = f_min_alt(mask[bkd_p].value(), + local_max(output, bkd_p, win_minus)); } void impl_fwd_loop_body() { - output[fwd_p] = ntg::min(local_max(output, fwd_p, win_plus), - mask[fwd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_min_alt compile. Try to get rid of it. + output[fwd_p] = f_min_alt(mask[fwd_p].value(), + local_max(output, fwd_p, win_plus)); } // FIXME: unused... @@ -118,21 +121,27 @@ void impl_bkd_loop_body() { - output[bkd_p] = min(local_max(work, bkd_p, win_minus), - mask[bkd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_min_alt compile. Try to get rid of it. + output[bkd_p] = f_min_alt(mask[bkd_p].value(), + local_max(work, bkd_p, win_minus)); } void impl_fwd_loop_body() { - output[fwd_p] = min(local_max(work, fwd_p, win_plus), - mask[fwd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_min_alt compile. Try to get rid of it. + output[fwd_p] = f_min_alt(mask[fwd_p].value(), + local_max(work, fwd_p, win_plus)); } void impl_fifo_loop_body() { if ((output[q] < output[p]) && (mask[q] != output[q])) { - output[q] = min(output[p].value(), mask[q].value()); + // FIXME: The calls to value_box<>::value are needed to + // have f_min_alt compile. Try to get rid of it. + output[q] = f_min_alt(output[p].value(), mask[q].value()); fifo.push(q); } } Index: olena/oln/morpho/reconstruction_by_erosion.hh --- olena/oln/morpho/reconstruction_by_erosion.hh (révision 253) +++ olena/oln/morpho/reconstruction_by_erosion.hh (copie de travail) @@ -30,6 +30,7 @@ # include <oln/canvas/reconstruction.hh> # include <oln/morpho/tags.hh> +# include <oln/funobj/arith.hh> namespace oln { @@ -65,14 +66,18 @@ void impl_bkd_loop_body() { - output[bkd_p] = ntg::max(local_min(output, bkd_p, win_minus), - mask[bkd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_max_alt compile. Try to get rid of it. + output[bkd_p] = f_max_alt(mask[bkd_p].value(), + local_min(output, bkd_p, win_minus)); } void impl_fwd_loop_body() { - output[fwd_p] = ntg::max(local_min(output, fwd_p, win_plus), - mask[fwd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_max_alt compile. Try to get rid of it. + output[fwd_p] = f_max_alt(mask[fwd_p].value(), + local_min(output, fwd_p, win_plus)); } // FIXME: unused... @@ -115,21 +120,27 @@ void impl_bkd_loop_body() { - output[bkd_p] = ntg::max(local_min(work, bkd_p, win_minus), - mask[bkd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_max_alt compile. Try to get rid of it. + output[bkd_p] = f_max_alt(mask[bkd_p].value(), + local_min(work, bkd_p, win_minus)); } void impl_fwd_loop_body() { - output[fwd_p] = ntg::max(local_min(work, fwd_p, win_plus), - mask[fwd_p].value()); + // FIXME: The call to value_box<>::value is needed to have + // f_max_alt compile. Try to get rid of it. + output[fwd_p] = f_max_alt(mask[fwd_p].value(), + local_min(work, fwd_p, win_plus)); } void impl_fifo_loop_body() { if ((output[q] > output[p]) && (mask[q] != output[q])) { - output[q] = ntg::min(output[p].value(), mask[q].value()); + // FIXME: The calls to value_box<>::value are needed to + // have f_min_alt compile. Try to get rid of it. + output[q] = f_min_alt(output[p].value(), mask[q].value()); fifo.push(q); } } Index: olena/oln/canvas/reconstruction.hh --- olena/oln/canvas/reconstruction.hh (révision 253) +++ olena/oln/canvas/reconstruction.hh (copie de travail) @@ -86,10 +86,13 @@ void init() { - output_type tmp(marker.size()); - - output = tmp; - work = clone(marker); + output_type output_tmp(marker.size()); + output = output_tmp; + // FIXME: We can't use `work = clone(marker)' directly here, + // because box's op=(const abstract::image<II>& rhs) would be + // called, which is empty (see oln/core/box.hh). + output_type work_tmp(clone(marker)); + work = work_tmp; win_plus = marker.nbh_get().get_win().get_fwd_win_p(); win_minus = marker.nbh_get().get_win().get_bkd_win_p(); @@ -175,11 +178,20 @@ typedef back_and_forth_until_convergence<I1, E> super_type; typedef oln_type_of(I1, neighb) nbh_type; typedef oln_nbh_type_of(nbh_type, window) window_type; + typedef oln_type_of(I1, concrete) output_type; void impl_init() { - output = clone(marker); - work = clone(marker); + // FIXME: We can't use `output = clone(marker)' directly here, + // because box's op=(const abstract::image<II>& rhs) would be + // called, which is empty (see oln/core/box.hh). + output_type output_tmp(clone(marker)); + output = output_tmp; + // FIXME: We can't use `work = clone(marker)' directly here, + // because box's op=(const abstract::image<II>& rhs) would be + // called, which is empty (see oln/core/box.hh). + output_type work_tmp(clone(marker)); + work = work_tmp; win_plus = marker.nbh_get().get_win().get_fwd_win_p(); win_minus = marker.nbh_get().get_win().get_bkd_win_p(); @@ -192,7 +204,11 @@ void impl_re_loop() { - work = clone(output); + // FIXME: We can't use `output = clone(marker)' directly here, + // because box's op=(const abstract::image<II>& rhs) would be + // called, which is empty (see oln/core/box.hh). + output_type work_tmp(clone(marker)); + work = work_tmp; } oln_type_of(I1, concrete) get_output() Index: olena/img/marker.pbm Ne peut afficher : fichier considéré comme binaire. svn:mime-type = application/octet-stream Index: olena/img/mask.pbm Ne peut afficher : fichier considéré comme binaire. svn:mime-type = application/octet-stream