#160: Revamp complexes (and faces)
--------------------------+-------------------------------------------------
Reporter: levill_r | Owner: levill_r
Type: enhancement | Status: assigned
Priority: minor | Milestone: Olena 1.0
Component: Milena | Version: 1.0
Resolution: | Keywords: cleanup rename
--------------------------+-------------------------------------------------
Old description:
* ~~Move complexes from `mln/core/` to `mln/topo/`.~~
(Done in r2399,
r2400 and r2401.)
* ~~The '''dynamic''' access(es) to the set of
''n''-faces of a complex
(e.g., `mln::complex::nfaces(unsigned)`) has (have) a linear complexity!
We should get rid of that. We could create an index at the creation of
the complex, mapping dynamic dimension numbers to the corresponding
(static) mixin/data. Ask Roland for details.~~ (Moved to #168.)
* ~~Suggestions from
source:branches/cleanup-2008/milena/mln/topo/face.hh:2399~~. (Done in
r2412, r2413, r2414, r2415 and r2416).
* Fix constness problems w.r.t. complexes and face handles (faces
handles require a mutable pointer to their complex for construction
reasons).
* Rename `face_id` (and its accessors) as `id`?
* Factor redundant code in
source:branches/cleanup-2008/milena/tests/topo/complex.cc
New description:
* ~~Move complexes from `mln/core/` to `mln/topo/`.~~ (Done in r2399,
r2400 and r2401.)
* ~~The '''dynamic''' access(es) to the set of
''n''-faces of a complex
(e.g., `mln::complex::nfaces(unsigned)`) has (have) a linear complexity!
We should get rid of that. We could create an index at the creation of
the complex, mapping dynamic dimension numbers to the corresponding
(static) mixin/data. Ask Roland for details.~~ (Moved to #168.)
* ~~Suggestions from
source:branches/cleanup-2008/milena/mln/topo/face.hh:2399~~. (Done in
r2412, r2413, r2414, r2415 and r2416).
* Fix constness problems w.r.t. complexes and face handles (faces handles
require a mutable pointer to their complex for construction reasons).
* Rename `n` (and its accessors) as `dim`?
* Rename `face_id` (and its accessors) as `id`?
* Factor redundant code in
source:branches/cleanup-2008/milena/tests/topo/complex.cc
Comment (by levill_r):
More suggestions.
--
Ticket URL: <https://trac.lrde.org/olena/ticket/160#comment:9>
Olena <http://olena.lrde.epita.fr>
Olena, a generic and efficient C++ image processing library.