Roland Levillain <roland(a)lrde.epita.fr> writes:
I'll try to review the recent patches in Olena.
Please take my
comments (and Théo's, of course!) into account and fix the pointed
problems.
OK, I know you might be working within a subdirectory of
milena/sandbox/ sometime (before checkin them into the ``main
branch'' milena/), *but* I'll still try to review your patches
because:
- it's easier to read small patches (vs ``final'', big patches) ;
- two pieces of advice are better than one; moreover, this internship
is part of your curriculum, and to my mind we should give you as
much comments as possible on your work (that's a part of your
education!)
- this acts as both a problem tracker (which records bugs and issues
within the mailing list) and a reminder (``did you fix this ?'').
BTW, do you (all interns) use `svn copy' to propagate your changes
from milena/sandbox/ to milena/?