19 Feb
2008
19 Feb
'08
2:35 p.m.
Le 5 févr. 08 à 20:23, Caroline Vigouroux a écrit :
URL: https://svn.lrde.epita.fr/svn/oln/trunk/milena
ChangeLog:
2008-02-05 Caroline Vigouroux <vigour_c(a)epita.fr>
Added personal folder and color files in sandbox.
* sandbox/vigouroux/color.hh: New.
* sandbox/vigouroux/color/color.hh: New.
* sandbox/vigouroux/color/hsi.hh: New.
* sandbox/vigouroux/color/hsl.hh: New.
* sandbox/vigouroux/color/hsv.hh: New.
* sandbox/vigouroux/color/nrgb.hh: New.
* sandbox/vigouroux/color/rgb.hh: New.
* sandbox/vigouroux/color/xyz.hh: New.
* sandbox/vigouroux/color/yiq.hh: New.
* sandbox/vigouroux/color/yuv.hh: New.
* sandbox/vigouroux/color: New.
* sandbox/vigouroux/convert/abstract/colorconv.hh: New.
* sandbox/vigouroux/convert/abstract/conversion.hh: New.
* sandbox/vigouroux/convert/abstract: New.
* sandbox/vigouroux/convert/basics.hh: New.
* sandbox/vigouroux/convert/bound.hh: New.
* sandbox/vigouroux/convert/cast.hh: New.
* sandbox/vigouroux/convert/conversion.hh: New.
* sandbox/vigouroux/convert/conversion_ng_se.hh: New.
* sandbox/vigouroux/convert/force.hh: New.
* sandbox/vigouroux/convert/nrgbxyz.hh: New.
* sandbox/vigouroux/convert/rgbhsi.hh: New.
* sandbox/vigouroux/convert/rgbhsl.hh: New.
* sandbox/vigouroux/convert/rgbhsv.hh: New.
* sandbox/vigouroux/convert/rgbnrgb.hh: New.
* sandbox/vigouroux/convert/rgbxyz.hh: New.
* sandbox/vigouroux/convert/rgbyiq.hh: New.
* sandbox/vigouroux/convert/rgbyuv.hh: New.
* sandbox/vigouroux/convert/stretch.hh: New.
* sandbox/vigouroux/convert/value_to_point.hh: New.
* sandbox/vigouroux/convert: New folder.
* sandbox/vigouroux: New folder.
First of all, even if ChangeLogs are filled bottom-up, the information
in each entry is read top-down: this should drive the way you mention/
comment your changes. In this case, the « New folder » information
should have preceded the creation of all the files holding them.
svn-wrapper is great, but it's just a tool: it won't do your job when
semantics are at stake. So, reordering the items of a pre-filled
ChangeLog entry is a requirement, whenever the order proposed by svn-
wrapper (presmuably a lexicographical one) is meaningless.
Then, you probably did not write all those files. :) I suppose you
imported them from Olena 0.11. Even if those files are admittedly «
new » to the distribution of Milena, you should mention their origin
(« Imported from Olena 0.11 »).
Last, I did not check all the dependencies, but are you sure you
needed to import all those files to have color conversions work? In
particular, this guy seems suspect:
* sandbox/vigouroux/convert/conversion_ng_se.hh: New.
If you can get rid of the things you don't need/use, it's better. But
as it's your sandbox, you obviously have some freedom with respect to
what you store in it, of course.