Olena-patches

olena-patches@lrde.epita.fr

9625 discussions

598: Fix the inheritance of oln::point2d_ and oln::dpoint2d_.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk/olena Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Fix the inheritance of oln::point2d_ and oln::dpoint2d_. * oln/core/2d/point2d.hh (oln::set_super_type< point2d_<C> >): New. (oln::point2d_): Use stc_get_supers to set the base class. (oln::point2d_::super_t): Use stc_get_super to define it. (oln::point2d_::point2d_(coord_t, coord_t)): Use xtd::mk_vec to initialize the base class. * oln/core/2d/dpoint2d.hh (oln::set_super_type< dpoint2d_<C> >): Re-enable it. (oln::dpoint2d_): Use stc_get_supers to set the base class. (oln::dpoint2d_::super_t): Use stc_get_super to define it. dpoint2d.hh | 24 +++++++++++++----------- point2d.hh | 25 ++++++++++++++++--------- 2 files changed, 29 insertions(+), 20 deletions(-) Index: oln/core/2d/point2d.hh --- oln/core/2d/point2d.hh (revision 597) +++ oln/core/2d/point2d.hh (working copy) @@ -1,4 +1,5 @@ -// Copyright (C) 2001, 2002, 2003, 2004, 2006 EPITA Research and Development Laboratory +// Copyright (C) 2001, 2002, 2003, 2004, 2006 EPITA Research and +// Development Laboratory // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -36,13 +37,22 @@ { + /// Specializations of functions point and dpoint : + /// \f$(n, coord) \rightarrow type\f$ for \f$n = 2\f$. /// \{ - /// Specializations of functions point and dpoint : (n,coord) -> type for n = 2. template <typename C> struct point_ <2, C> { typedef point2d_<C> ret; }; template <typename C> struct dpoint_ <2, C> { typedef dpoint2d_<C> ret; }; /// \} + /// Super type. + template<typename C> + struct set_super_type< point2d_<C> > + { + typedef internal::point_nd< point2d_<C> > ret; + }; + + /// Virtual types associated to oln::point2d_<C>. template <typename C> struct vtypes< point2d_<C> > @@ -56,18 +66,16 @@ /// General 2D point class. template <typename C> - class point2d_ : public internal::point_nd< point2d_<C> > // FIXME: stc_get_super_(point2d_<C>) + class point2d_ : public stc_get_supers(point2d_<C>) { typedef point2d_<C> self_t; - typedef internal::point_nd<self_t> super_t; + typedef stc_get_super(point2d_<C>) super_t; + typedef oln_type_of(self_t, coord) coord_t; using super_t::v_; public: - // Cf. BUG! typedef oln_type_of(self_t, grid) grid_t; - typedef oln_type_of(self_t, coord) coord_t; - /// Ctor. point2d_() { @@ -75,9 +83,8 @@ /// Ctor. point2d_(coord_t row, coord_t col) + : super_t (xtd::mk_vec(row, col)) { - v_[0] = row; - v_[1] = col; } /// Ctor. Index: oln/core/2d/dpoint2d.hh --- oln/core/2d/dpoint2d.hh (revision 597) +++ oln/core/2d/dpoint2d.hh (working copy) @@ -1,4 +1,5 @@ -// Copyright (C) 2001, 2002, 2003, 2004, 2006 EPITA Research and Development Laboratory +// Copyright (C) 2001, 2002, 2003, 2004, 2006 EPITA Research and +// Development Laboratory // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -37,12 +38,12 @@ { -// /// Super type. -// template<typename C> -// struct set_super_type< dpoint2d_<C> > -// { -// typedef abstract::dpoint< dpoint2d_<C> > ret; -// }; + /// Super type. + template<typename C> + struct set_super_type< dpoint2d_<C> > + { + typedef internal::dpoint_nd< dpoint2d_<C> > ret; + }; /// Virtual types associated to oln::dpoint2d_<C>. @@ -58,10 +59,11 @@ /// General 2D dpoint class. template <typename C> - class dpoint2d_ : public internal::dpoint_nd< dpoint2d_<C> > // FIXME: stc_get_super_(dpoint2d_<C>) + class dpoint2d_ + : public stc_get_supers(dpoint2d_<C>) { typedef dpoint2d_<C> self_t; - typedef internal::dpoint_nd<self_t> super_t; // FIXME: stc_get_super(self_t) + typedef stc_get_super(dpoint2d_<C>) super_t; typedef oln_type_of(self_t, coord) coord_t; using super_t::v_; @@ -74,8 +76,8 @@ } /// Ctor. - dpoint2d_(const xtd::vec<2,coord_t>& v) : - super_t(v) + dpoint2d_(const xtd::vec<2,coord_t>& v) + : super_t(v) { }

18 years, 3 months

597: Add isubset image morpher and subsequent tools.

by Thierry GERAUD

2006-10-02 Thierry GERAUD <theo(a)tegucigalpa.lrde.epita.fr> Add isubset image morpher and subsequent tools. * oln/core/gen/piter_isubset.hh: New. * oln/core/gen/topo_add_isubset.hh: New. * oln/morpher/add_isubset.hh: New. * oln/debug/print.hh (println): New. * oln/core/typedefs.hh (isubset): New. * oln/core/automatic/image_being_random_accessible.hh (set_impl): Remove; cause error-prone. * oln/core/abstract/image/type/hierarchy.hh (where_): Rely on xtd_is_binary instead of an hard-coded test. (include): Update. * oln/core/gen/fwd_piter_bbox.hh (topo_type): new. (topo_): Change ref into plain type so it is more secure. * oln/core/gen/bkd_piter_bbox.hh (topo_type): new. (topo_): Change ref into plain type so it is more secure. * oln/core/gen/topo_add_nbh.hh (operator topo_t): New. * oln/core/internal/topology_morpher.hh (delegated_type): New. Index: oln/debug/print.hh =================================================================== --- oln/debug/print.hh (revision 596) +++ oln/debug/print.hh (working copy) @@ -80,6 +80,7 @@ } // end of namespace oln::debug::impl + /// Facade. template <typename I> void print(const abstract::image<I>& input, std::ostream& ostr) @@ -88,6 +89,15 @@ } + /// Facade. + template <typename I> + void println(const abstract::image<I>& input, std::ostream& ostr) + { + print(input, ostr); + ostr << std::endl; + } + + } // end of namespace oln::debug } // end of namespace oln Index: oln/core/typedefs.hh =================================================================== --- oln/core/typedefs.hh (revision 596) +++ oln/core/typedefs.hh (working copy) @@ -134,6 +134,7 @@ mlc_decl_typedef(dpoint_type); mlc_decl_typedef(neighborhood_type); + mlc_decl_typedef(isubset); // -------------------------------------------------------------------- // FIXME: To be enabled later. @@ -152,6 +153,7 @@ // mlc_decl_typedef(window_type); // -------------------------------------------------------------------- + // ------------------------------ // // Extension in image_operators. // // ------------------------------ // Index: oln/core/automatic/image_being_random_accessible.hh =================================================================== --- oln/core/automatic/image_being_random_accessible.hh (revision 596) +++ oln/core/automatic/image_being_random_accessible.hh (working copy) @@ -72,33 +72,6 @@ }; - /// Implementation corresponding to the interface - /// oln::abstract::image_being_random_accessible for an identity morpher. - - template <typename E> - class set_impl< abstract::image_being_random_accessible, - morpher::tag::identity, - E > : - public virtual stc::any__simple<E> - { - private: - - typedef oln_type_of(E, point) point_t; - - public: - - bool impl_has(const point_t& p) const - { - return this->exact().delegate().has(p); - } - - bool impl_has_large(const point_t& p) const - { - return this->exact().delegate().has_large(p); - } - - }; - } // end of namespace oln::automatic } // end of namespace oln Index: oln/core/abstract/image/type/hierarchy.hh =================================================================== --- oln/core/abstract/image/type/hierarchy.hh (revision 596) +++ oln/core/abstract/image/type/hierarchy.hh (working copy) @@ -28,6 +28,7 @@ #ifndef OLN_CORE_ABSTRACT_IMAGE_TYPE_HIERARCHY_HH # define OLN_CORE_ABSTRACT_IMAGE_TYPE_HIERARCHY_HH +# include <xtd/valtraits.hh> # include <oln/core/abstract/image.hh> @@ -105,7 +106,7 @@ /// Binary case. template <typename E> struct case_< image_hierarchy_wrt_type, E, 1 > : - where_< mlc::eq_< oln_type_of(E, value), bool > > + where_< xtd_is_binary(oln_type_of(E, value)) > { // Definition of the super class corresponding to this case. typedef abstract::binary_image<E> ret; Index: oln/core/gen/piter_isubset.hh =================================================================== --- oln/core/gen/piter_isubset.hh (revision 0) +++ oln/core/gen/piter_isubset.hh (revision 0) @@ -0,0 +1,141 @@ +// Copyright (C) 2006 EPITA Research and Development Laboratory +// +// This file is part of the Olena Library. This library is free +// software; you can redistribute it and/or modify it under the terms +// of the GNU General Public License version 2 as published by the +// Free Software Foundation. +// +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this library; see the file COPYING. If not, write to +// the Free Software Foundation, 51 Franklin Street, Fifth Floor, +// Boston, MA 02111-1307, USA. +// +// As a special exception, you may use this file as part of a free +// software library without restriction. Specifically, if other files +// instantiate templates or use macros or inline functions from this +// file, or you compile this file and link it with other files to +// produce an executable, this file does not by itself cause the +// resulting executable to be covered by the GNU General Public +// License. This exception does not however invalidate any other +// reasons why the executable file might be covered by the GNU General +// Public License. + +#ifndef OLN_CORE_GEN_PITER_ISUBSET_HH +# define OLN_CORE_GEN_PITER_ISUBSET_HH + +# include <oln/core/abstract/topology.hh> +# include <oln/core/abstract/iterator_on_points.hh> + + +namespace oln +{ + + + // Forward declaration. + template <typename piter_t, typename isubset_t> class piter_isubset_; + + + // Super type declaration. + template <typename piter_t, typename isubset_t> + struct set_super_type< piter_isubset_<piter_t, isubset_t> > + { + typedef piter_isubset_<piter_t, isubset_t> self_t; + typedef abstract::iterator_on_points<self_t> ret; + }; + + + /// Virtual types associated to oln::piter_isubset_<piter_t, isubset_t>. + template <typename piter_t, typename isubset_t> + struct vtypes< piter_isubset_<piter_t, isubset_t> > + { + typedef oln_type_of(piter_t, point) point_type; + typedef oln_type_of(piter_t, grid) grid_type; + + typedef topo_add_isubset<oln_type_of(piter_t, topo), isubset_t> topo_type; + }; + + + + /// Abstract forward point iterator class. + template <typename piter_t, typename isubset_t> + class piter_isubset_ : public abstract::iterator_on_points< piter_isubset_<piter_t, isubset_t> > + { + typedef piter_isubset_<piter_t, isubset_t> self_t; + typedef abstract::iterator_on_points<self_t> super_t; + + typedef oln_type_of(self_t, point) topo_t; + typedef oln_type_of(piter_t, point) point_t; + + public: + + template <typename T> + piter_isubset_(const abstract::topology<T>& topo) + : p_(topo), + isubset_(topo.exact().isubset()) + { + } + + void impl_start() + { + p_.start(); + while (p_.is_valid() and isubset_(p_) == false) + p_.next(); + } + + void impl_next() + { + do + p_.next(); + while (p_.is_valid() and isubset_(p_) == false); + } + + void impl_invalidate() + { + p_.invalidate(); + } + + bool impl_is_valid() const + { + return p_.is_valid(); + } + + point_t impl_to_point() const + { + return p_.to_point(); + } + + const point_t* impl_point_adr() const + { + return p_.point_adr(); + } + + const topo_t& topo() const + { + topo_t tmp(p_.topo(), isubset_); + return tmp; + } + + template <typename new_topo_t> + struct change_topology_ + { + typedef typename piter_t::template change_topology_<new_topo_t>::ret new_piter_t; + typedef piter_isubset_<new_piter_t, isubset_t> ret; + }; + + protected: + + piter_t p_; + const isubset_t& isubset_; + + }; // end of class oln::piter_isubset_<point> + + +} // end of namespace oln + + +#endif // ! OLN_CORE_GEN_PITER_ISUBSET_HH Index: oln/core/gen/topo_add_isubset.hh =================================================================== --- oln/core/gen/topo_add_isubset.hh (revision 0) +++ oln/core/gen/topo_add_isubset.hh (revision 0) @@ -0,0 +1,115 @@ +// Copyright (C) 2006 EPITA Research and Development Laboratory +// +// This file is part of the Olena Library. This library is free +// software; you can redistribute it and/or modify it under the terms +// of the GNU General Public License version 2 as published by the +// Free Software Foundation. +// +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this library; see the file COPYING. If not, write to +// the Free Software Foundation, 51 Franklin Street, Fifth Floor, +// Boston, MA 02111-1307, USA. +// +// As a special exception, you may use this file as part of a free +// software library without restriction. Specifically, if other files +// instantiate templates or use macros or inline functions from this +// file, or you compile this file and link it with other files to +// produce an executable, this file does not by itself cause the +// resulting executable to be covered by the GNU General Public +// License. This exception does not however invalidate any other +// reasons why the executable file might be covered by the GNU General +// Public License. + +#ifndef OLN_CORE_GEN_TOPO_ADD_ISUBSET_HH +# define OLN_CORE_GEN_TOPO_ADD_ISUBSET_HH + +# include <oln/core/internal/topology_morpher.hh> + + + +namespace oln +{ + + + // Forward declarations. + template <typename topo, typename isubset> class topo_add_isubset; + + + // Super type declaration. + template <typename topo, typename isubset> + struct set_super_type< topo_add_isubset<topo, isubset> > + { + typedef topo_add_isubset<topo, isubset> self_t; + typedef internal::topology_morpher<topo, self_t> ret; + }; + + + /// Virtual types associated to oln::bbox_<point>. + template <typename topo, typename isubset> + struct vtypes< topo_add_isubset<topo, isubset> > + { + typedef isubset isubset_type; + }; + + + /// Bounding box topology based on a point class. + template <typename topo_t, typename isubset_t> + class topo_add_isubset + : public internal::topology_morpher<topo_t, topo_add_isubset<topo_t, isubset_t> > + { + typedef topo_add_isubset<topo_t, isubset_t> self_t; + typedef oln_type_of(self_t, point) point_t; + + public: + + topo_add_isubset() + { + } + + topo_add_isubset(const topo_t& topo, const isubset_t& isubset) + : topo_(topo), + isubset_(isubset) + { + } + + bool impl_has(const point_t& p) const + { + return topo_.has(p) and isubset_(p) == true; + } + + bool impl_has_large(const point_t& p) const + { + return topo_.has(p) and isubset_(p) == true; + } + + const topo_t& delegate() const + { + return topo_; + } + + const isubset_t& isubset() const + { + return isubset_; + } + + operator topo_t() const + { + return topo_; + } + + protected: + + topo_t topo_; + isubset_t isubset_; + }; + + +} // end of namespace oln + + +#endif // ! OLN_CORE_GEN_TOPO_ADD_ISUBSET_HH Index: oln/core/gen/fwd_piter_bbox.hh =================================================================== --- oln/core/gen/fwd_piter_bbox.hh (revision 596) +++ oln/core/gen/fwd_piter_bbox.hh (working copy) @@ -56,6 +56,7 @@ { typedef oln_type_of(topo, point) point_type; typedef oln_type_of(topo, grid) grid_type; + typedef topo topo_type; }; @@ -103,7 +104,7 @@ protected: - const topo_t& topo_; + const topo_t topo_; }; // end of class oln::fwd_piter_bbox_<point> Index: oln/core/gen/bkd_piter_bbox.hh =================================================================== --- oln/core/gen/bkd_piter_bbox.hh (revision 596) +++ oln/core/gen/bkd_piter_bbox.hh (working copy) @@ -56,6 +56,7 @@ { typedef oln_type_of(topo, point) point_type; typedef oln_type_of(topo, grid) grid_type; + typedef topo topo_type; }; @@ -103,7 +104,7 @@ protected: - const topo_t& topo_; + const topo_t topo_; }; // end of class oln::bkd_piter_bbox_<point> Index: oln/core/gen/topo_add_nbh.hh =================================================================== --- oln/core/gen/topo_add_nbh.hh (revision 596) +++ oln/core/gen/topo_add_nbh.hh (working copy) @@ -89,6 +89,11 @@ return topo_; } + operator topo_t() const + { + return topo_; + } + protected: topo_t topo_; Index: oln/core/internal/topology_morpher.hh =================================================================== --- oln/core/internal/topology_morpher.hh (revision 596) +++ oln/core/internal/topology_morpher.hh (working copy) @@ -54,7 +54,13 @@ typedef morpher::tag::identity ret; }; + template <typename Topo, typename E> + struct single_vtype< internal::topology_morpher<Topo, E>, typedef_::delegated_type > + { + typedef Topo ret; + }; + namespace internal { Index: oln/morpher/add_isubset.hh =================================================================== --- oln/morpher/add_isubset.hh (revision 0) +++ oln/morpher/add_isubset.hh (revision 0) @@ -0,0 +1,125 @@ +// Copyright (C) 2006 EPITA Research and Development Laboratory +// +// This file is part of the Olena Library. This library is free +// software; you can redistribute it and/or modify it under the terms +// of the GNU General Public License version 2 as published by the +// Free Software Foundation. +// +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this library; see the file COPYING. If not, write to +// the Free Software Foundation, 51 Franklin Street, Fifth Floor, +// Boston, MA 02111-1307, USA. +// +// As a special exception, you may use this file as part of a free +// software library without restriction. Specifically, if other files +// instantiate templates or use macros or inline functions from this +// file, or you compile this file and link it with other files to +// produce an executable, this file does not by itself cause the +// resulting executable to be covered by the GNU General Public +// License. This exception does not however invalidate any other +// reasons why the executable file might be covered by the GNU General +// Public License. + +#ifndef OLN_MORPHER_ADD_ISUBSET +# define OLN_MORPHER_ADD_ISUBSET + +# include <oln/morpher/internal/image_extension.hh> +# include <oln/morpher/tags.hh> +# include <oln/core/gen/topo_add_isubset.hh> +# include <oln/core/gen/piter_isubset.hh> + + +namespace oln +{ + + namespace morpher + { + // Forward declaration. + template <typename Image, typename Isubset> struct add_isubset; + + } // end of namespace oln::morpher + + + /// Super type. + template <typename Image, typename Isubset> + struct set_super_type< morpher::add_isubset<Image, Isubset> > + { + typedef morpher::add_isubset<Image, Isubset> self_t; + typedef morpher::internal::image_extension<Image, self_t> ret; + }; + + template <typename Image, typename Isubset> + struct vtypes< morpher::add_isubset<Image, Isubset> > + { + // Topology type. + typedef topo_add_isubset< oln_type_of(Image, topo), Isubset > topo_type; + + // Piter types. + typedef piter_isubset_<oln_type_of(Image, fwd_piter), Isubset> fwd_piter_type; + typedef piter_isubset_<oln_type_of(Image, bkd_piter), Isubset> bkd_piter_type; + + // Isubset type. + typedef Isubset subset_type; + }; + + + namespace morpher + { + /// Isubset addition morpher. + template <typename Image, typename Isubset> + class add_isubset : public stc_get_supers(mlc_comma_1(add_isubset<Image, Isubset>)) + { + private: + + typedef add_isubset<Image, Isubset> self_t; + typedef stc_get_nth_super(self_t, 1) super_t; + typedef oln_type_of(self_t, topo) topo_t; + + public: + + // FIXME: Handle the constness. + + add_isubset(const Image& image, const Isubset& isubset) : + super_t(image), + topo_(image.topo(), isubset) + { + mlc::assert_equal_<oln_type_of(Image, grid), oln_type_of(Isubset, grid)>::check(); + // FIXME: check that Image is without a isubset + } + + const topo_t& impl_topo() const + { + return topo_; + } + + protected: + topo_t topo_; + }; + + } // end of namespace oln::morpher + + + template <typename I, typename S> + morpher::add_isubset<I, S> + operator | (const abstract::image<I>& image, + const abstract::binary_image<S>& isubset) + { + mlc::assert_equal_<oln_type_of(I, grid), oln_type_of(S, grid)>::check(); + // FIXME: check that Image does not have yet a subset + morpher::add_isubset<I, S> tmp(image.exact(), isubset.exact()); + return tmp; + } + + // FIXME: Register this operator. + // FIXME: Add mutable version. + + +} // end of namespace oln + + +#endif // ! OLN_MORPHER_ADD_ISUBSET

18 years, 3 months

596: Use TESTS_CXXFLAGS in Olena.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk/olena Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Use TESTS_CXXFLAGS in Olena. * tests/Makefile.am (TESTS_CXXFLAGS): New. Append it to... (CXXFLAGS): ...this variable. * tests/fill.cc: Typo in comment. Makefile.am | 6 ++++-- fill.cc | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) Index: tests/Makefile.am --- tests/Makefile.am (revision 595) +++ tests/Makefile.am (working copy) @@ -9,8 +9,10 @@ # AM_CXXFLAGS = $(CXXFLAGS_STRICT) $(CXXFLAGS_DEBUG) # # when oln.m4 is available in the distribution. -# Meanwhile, alter CXXFLAGS to turn off any optimization. -CXXFLAGS = -O0 -ggdb +# Meanwhile, alter CXXFLAGS to turn off any optimization (Automake will +# warn against this, but that's OK). +TESTS_CXXFLAGS = @TESTS_CXXFLAGS@ +CXXFLAGS += $(TESTS_CXXFLAGS) check_PROGRAMS = \ Index: tests/fill.cc --- tests/fill.cc (revision 595) +++ tests/fill.cc (working copy) @@ -29,7 +29,7 @@ #include <cassert> // FIXME: We should not include oln/basics2d.hh, but -// oln/core/2d/image2d.hh (and oln/core/2d/neigh2d.hh ?). +// just oln/core/2d/image2d.hh. #include <oln/basics2d.hh> #include <oln/level/fill.hh>

18 years, 3 months

595: Use TESTS_CXXFLAGS in Static.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk/static Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Use TESTS_CXXFLAGS in Static. * tests/Makefile.am (TESTS_CXXFLAGS): New. Append it to... (CXXFLAGS): ...this variable. * tests/tour.cc (dynamic_hierarchy::A, dynamic_hierarchy::B) (dynamic_hierarchy::C): Add missing virtual destructors. Makefile.am | 3 ++- tour.cc | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) Index: tests/Makefile.am --- tests/Makefile.am (revision 594) +++ tests/Makefile.am (working copy) @@ -9,7 +9,8 @@ # when oln.m4 is available in the distribution. # Meanwhile, alter CXXFLAGS to turn off any optimization (Automake will # warn against this, but that's OK). -CXXFLAGS = -O0 -ggdb +TESTS_CXXFLAGS = @TESTS_CXXFLAGS@ +CXXFLAGS += $(TESTS_CXXFLAGS) check_PROGRAMS = \ Index: tests/tour.cc --- tests/tour.cc (revision 594) +++ tests/tour.cc (working copy) @@ -79,6 +79,8 @@ virtual int foo() { return 1; } // A virtual pure method. virtual int bar() = 0; + + virtual ~A() {} }; // `B' is a concrete class. @@ -88,6 +90,8 @@ virtual int foo() { return 2; } // `B::bar' is defined. virtual int bar() { return 3; } + + virtual ~B() {} }; // `C' is a concrete class. @@ -95,6 +99,8 @@ { // `B::foo' is redefined. virtual int foo() { return 4; } + + virtual ~C() {} }; } // end of namespace dynamic_hierarchy

18 years, 3 months

594: Use TESTS_CXXFLAGS in Extended.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk/extended Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Use TESTS_CXXFLAGS in Extended. * tests/Makefile.am (TESTS_CXXFLAGS): New. Append it to... (CXXFLAGS): ...this variable. * tests/optraits.cc (main): Make dummy use of all variables to avoid compiler warnings. Makefile.am | 8 ++++++-- optraits.cc | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) Index: tests/Makefile.am --- tests/Makefile.am (revision 593) +++ tests/Makefile.am (working copy) @@ -1,12 +1,16 @@ ## Process this file through Automake to create Makefile.in -*- Makefile -*- AM_CPPFLAGS = -I$(top_srcdir)/extended -I$(top_srcdir)/metalic + # FIXME: Add # -# AM_CXXFLAGS = $(CXXFLAGS_STRICT) -ggdb +# AM_CXXFLAGS = $(CXXFLAGS_STRICT) $(CXXFLAGS_DEBUG) # # when oln.m4 is available in the distribution. -AM_CXXFLAGS = -O0 -ggdb +# Meanwhile, alter CXXFLAGS to turn off any optimization (Automake will +# warn against this, but that's OK). +TESTS_CXXFLAGS = @TESTS_CXXFLAGS@ +CXXFLAGS += $(TESTS_CXXFLAGS) check_PROGRAMS = \ Index: tests/optraits.cc --- tests/optraits.cc (revision 593) +++ tests/optraits.cc (working copy) @@ -55,6 +55,8 @@ typeof(1+2u) tmp; // 2 * cos(_1); + // Dummy usage. + tmp = tmp; test_plus(2 * cos(_1), sin(_1)); }

18 years, 3 months

593: Use TESTS_CXXFLAGS in Metalic.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk/metalic Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Use TESTS_CXXFLAGS in Metalic. * tests/gcase.cc (print), tests/protected.cc (reveal), * tests/switch.cc (print): Make dummy use of all variables to void compiler warnings. * tests/Makefile.am (TESTS_CXXFLAGS): New. Append it to... (CXXFLAGS): ...this variable. Makefile.am | 8 ++++++-- gcase.cc | 2 ++ protected.cc | 2 ++ switch.cc | 2 ++ 4 files changed, 12 insertions(+), 2 deletions(-) Index: tests/switch.cc --- tests/switch.cc (revision 592) +++ tests/switch.cc (working copy) @@ -157,6 +157,8 @@ void print() { int tmp; + // Dummy usage. + tmp = tmp; } Index: tests/gcase.cc --- tests/gcase.cc (revision 592) +++ tests/gcase.cc (working copy) @@ -55,6 +55,8 @@ void print() { int tmp; + // Dummy usage. + tmp = tmp; } Index: tests/Makefile.am --- tests/Makefile.am (revision 592) +++ tests/Makefile.am (working copy) @@ -1,12 +1,16 @@ ## Process this file through Automake to create Makefile.in -*- Makefile -*- AM_CPPFLAGS = -I$(top_srcdir)/metalic + # FIXME: Add # -# AM_CXXFLAGS = $(CXXFLAGS_STRICT) -ggdb +# AM_CXXFLAGS = $(CXXFLAGS_STRICT) $(CXXFLAGS_DEBUG) # # when oln.m4 is available in the distribution. -AM_CXXFLAGS = -O0 -ggdb +# Meanwhile, alter CXXFLAGS to turn off any optimization (Automake will +# warn against this, but that's OK). +TESTS_CXXFLAGS = @TESTS_CXXFLAGS@ +CXXFLAGS += $(TESTS_CXXFLAGS) check_PROGRAMS = \ Index: tests/protected.cc --- tests/protected.cc (revision 592) +++ tests/protected.cc (working copy) @@ -39,6 +39,8 @@ void reveal() { T tmp; + // Dummy usage. + tmp = tmp; }

18 years, 3 months

592: Create a configure variable for C++ compiler flags used for the tests.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Create a configure variable for C++ compiler flags used for the tests. * configure.ac (TESTS_CXXFLAGS): New variable. configure.ac | 7 +++++++ 1 file changed, 7 insertions(+) Index: configure.ac --- configure.ac (revision 591) +++ configure.ac (working copy) @@ -32,6 +32,13 @@ CXXFLAGS="$CXXFLAGS -pipe" fi +# C++ compiler flags for tests. +AC_ARG_VAR([TESTS_CXXFLAGS]) +# We want no optimization for the tests (too slow), and a lot of debugging. +if test "$GXX" = yes && test -z "$TESTS_CXXFLAGS"; then + TESTS_CXXFLAGS="-O0 -ggdb -Wall -pipe" +fi + ## ------- ## ## Tests. ##

18 years, 3 months

591: Work around a bug in g++ 4.1 and 4.2 in tests/vtypes-and-exact.cc.

by Roland Levillain

https://svn.lrde.epita.fr/svn/oln/trunk/static Index: ChangeLog from Roland Levillain <roland(a)lrde.epita.fr> Work around a bug in g++ 4.1 and 4.2 in tests/vtypes-and-exact.cc. * tests/vtypes-and-exact.cc (my_direct_type_of), (my_direct_type_of_): New macros. (my::A::foo_type, my::A::bar_type, my::A::baz_type) (my::B::foo_type, my::B::bar_type, my::B::baz_type) (my::B::quux_type, my::B::yin_type) (my::C::foo_type, my::C::quux_type, my::C::zorg_type): Rename typedefs as... (my::A::foo_t, my::A::bar_t, my::A::baz_t) (my::B::foo_t, my::B::bar_t, my::B::baz_t) (my::B::quux_t, my::B::yin_t) (my::C::foo_t, my::C::quux_t, my::C::zorg_t): ...this. Use my_direct_type_of and my_direct_type_of_ (on the exact type) instead of my_type_of and my_type_of_ (on the ``self'', current type) to work around a bug in g++ 4.1 and 4.2. (main): Adjust. * tests/Makefile.am (AM_CXXFLAGS): Rename as... (CXXFLAGS): ...this. Makefile.am | 7 ++- vtypes-and-exact.cc | 103 ++++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 85 insertions(+), 25 deletions(-) Index: tests/vtypes-and-exact.cc --- tests/vtypes-and-exact.cc (revision 590) +++ tests/vtypes-and-exact.cc (working copy) @@ -44,6 +44,12 @@ #define my_type_of_(FromType, Typedef) \ stc_type_of_(my, my::category::my_cat, FromType, Typedef) +#define my_direct_type_of(FromExactType, Typedef) \ + typename my_direct_type_of_(FromExactType, Typedef) + +#define my_direct_type_of_(FromExactType, Typedef) \ + stc_direct_type_of_(my, my::category::my_cat, FromExactType, Typedef) + // Namespace equipment. stc_scoop_equipment_for_namespace(my); @@ -98,10 +104,33 @@ template <typename Exact> struct A : public stc::any<Exact> { + typedef A<Exact> self_t; + typedef Exact exact_t; + // Aliases. - typedef my_type_of(A, foo) foo_type; - typedef my_type_of(A, bar) bar_type; - typedef my_type_of(A, baz) baz_type; + + /* FIXME: Work around a bug that affects both g++ 4.1 and + gcc-snapshot (4.2) from Debian. The versions of the compiler + used at the moment this text was written were: + + g++ 4.1 : g++ (GCC) 4.1.2 20060920 (prerelease) (Debian 4.1.1-14) + gcc-snapshot : g++ (GCC) 4.2.0 20060922 (experimental) + + + Problem description: + + Using my_type_of (i.e., using stc_to_exact) breaks the + assertions ``Ensure stc::is_any_ works properly.'' below (in + main). Using my_direct_type_of (on the exact type) solves + this! */ +#if 0 + typedef my_type_of(self_t, foo) foo_t; + typedef my_type_of(self_t, bar) bar_t; + typedef my_type_of(self_t, baz) baz_t; +#endif + typedef my_direct_type_of(exact_t, foo) foo_t; + typedef my_direct_type_of(exact_t, bar) bar_t; + typedef my_direct_type_of(exact_t, baz) baz_t; }; @@ -144,12 +173,27 @@ template <typename Exact> struct B : public stc_get_supers(B<Exact>) { + typedef B<Exact> self_t; + typedef Exact exact_t; + // Aliases. - typedef my_type_of(B, foo) foo_type; - typedef my_type_of(B, bar) bar_type; - typedef my_type_of(B, baz) baz_type; - typedef my_type_of(B, quux) quux_type; - typedef my_type_of(B, yin) yin_type; + + /* FIXME: Same as above; using my_type_of (i.e., using + stc_to_exact) breaks the assertions ``Ensure stc::is_any_ works + properly.'' below (in main). Using my_direct_type_of (on the + exact type) solves this! */ +#if 0 + typedef my_type_of(self_t, foo) foo_t; + typedef my_type_of(self_t, bar) bar_t; + typedef my_type_of(self_t, baz) baz_t; + typedef my_type_of(self_t, quux) quux_t; + typedef my_type_of(self_t, yin) yin_t; +#endif + typedef my_direct_type_of(exact_t, foo) foo_t; + typedef my_direct_type_of(exact_t, bar) bar_t; + typedef my_direct_type_of(exact_t, baz) baz_t; + typedef my_direct_type_of(exact_t, quux) quux_t; + typedef my_direct_type_of(exact_t, yin) yin_t; }; @@ -173,10 +217,23 @@ struct C : public stc_get_supers(C) { + typedef C self_t; + typedef self_t exact_t; + // Aliases. - typedef my_type_of_(C, foo) foo_type; - typedef my_type_of_(C, quux) quux_type; - typedef my_type_of_(C, zorg) zorg_type; + + /* FIXME: Same as above; using my_type_of_ (i.e., using + stc_to_exact) breaks the assertions ``Ensure stc::is_any_ works + properly.'' below (in main). Using my_direct_type_of_ (on the + exact type) solves this! */ +#if 0 + typedef my_type_of_(self_t, foo) foo_t; + typedef my_type_of_(self_t, quux) quux_t; + typedef my_type_of_(self_t, zorg) zorg_t; +#endif + typedef my_direct_type_of_(exact_t, foo) foo_t; + typedef my_direct_type_of_(exact_t, quux) quux_t; + typedef my_direct_type_of_(exact_t, zorg) zorg_t; }; } // end of namespace my @@ -204,21 +261,21 @@ // Check types associated to A<C>. - mlc::assert_<mlc_eq(A<C>::foo_type, int)>::check(); - mlc::assert_<mlc_eq(A<C>::bar_type, double)>::check(); + mlc::assert_<mlc_eq(A<C>::foo_t, int)>::check(); + mlc::assert_<mlc_eq(A<C>::bar_t, double)>::check(); // Check types associated to B<C>. - mlc::assert_<mlc_eq(B<C>::baz_type, char)>::check(); - mlc::assert_<mlc_eq(B<C>::quux_type, long)>::check(); - mlc::assert_<mlc_eq(B<C>::yin_type, unsigned long)>::check(); + mlc::assert_<mlc_eq(B<C>::baz_t, char)>::check(); + mlc::assert_<mlc_eq(B<C>::quux_t, long)>::check(); + mlc::assert_<mlc_eq(B<C>::yin_t, unsigned long)>::check(); - mlc::assert_<mlc_eq(B<C>::bar_type, A<C>::bar_type)>::check(); + mlc::assert_<mlc_eq(B<C>::bar_t, A<C>::bar_t)>::check(); // Check types associated to C. - mlc::assert_<mlc_eq(C::foo_type, int)>::check(); - mlc::assert_<mlc_eq(C::bar_type, double)>::check(); - mlc::assert_<mlc_eq(C::baz_type, char)>::check(); - mlc::assert_<mlc_eq(C::quux_type, long)>::check(); - mlc::assert_<mlc_eq(C::yin_type, unsigned long)>::check(); - mlc::assert_<mlc_eq(C::zorg_type, double)>::check(); + mlc::assert_<mlc_eq(C::foo_t, int)>::check(); + mlc::assert_<mlc_eq(C::bar_t, double)>::check(); + mlc::assert_<mlc_eq(C::baz_t, char)>::check(); + mlc::assert_<mlc_eq(C::quux_t, long)>::check(); + mlc::assert_<mlc_eq(C::yin_t, unsigned long)>::check(); + mlc::assert_<mlc_eq(C::zorg_t, double)>::check(); } Index: tests/Makefile.am --- tests/Makefile.am (revision 590) +++ tests/Makefile.am (working copy) @@ -1,12 +1,15 @@ ## Process this file through Automake to create Makefile.in -*- Makefile -*- AM_CPPFLAGS = -I$(top_srcdir)/static -I$(top_srcdir)/metalic + # FIXME: Add # -# AM_CXXFLAGS = $(CXXFLAGS_STRICT) -ggdb +# AM_CXXFLAGS = $(CXXFLAGS_STRICT) $(CXXFLAGS_DEBUG) # # when oln.m4 is available in the distribution. -AM_CXXFLAGS = -O0 -ggdb +# Meanwhile, alter CXXFLAGS to turn off any optimization (Automake will +# warn against this, but that's OK). +CXXFLAGS = -O0 -ggdb check_PROGRAMS = \

18 years, 3 months

590: xtd_is_binary use bexpr_.

by Thierry GERAUD

2006-09-29 Thierry GERAUD <theo(a)tegucigalpa.lrde.epita.fr> * xtd/valtraits.hh: Use bexpr_. Index: xtd/valtraits.hh =================================================================== --- xtd/valtraits.hh (revision 589) +++ xtd/valtraits.hh (working copy) @@ -28,6 +28,7 @@ #ifndef XTD_VALTRAITS_HH # define XTD_VALTRAITS_HH +# include <mlc/bexpr.hh> // # include <xtd/traits.hh> // # include <xtd/builtin/traits.hh> @@ -37,16 +38,14 @@ { template <typename T> - struct is_binary + struct is_binary : public mlc::bexpr_<false> { - typedef mlc::false_ ret; }; template <> - struct is_binary <bool> + struct is_binary <bool> : public mlc::bexpr_<true> { - typedef mlc::true_ ret; }; @@ -54,7 +53,7 @@ -# define xtd_is_binary(T) typename xtd::is_binary<T>::ret +# define xtd_is_binary(T) xtd::is_binary<T>

18 years, 3 months

589: Add a temporary simple version of xtd_is_binary for use in oln.

by Thierry GERAUD

2006-09-29 Thierry GERAUD <theo(a)tegucigalpa.lrde.epita.fr> Add a temporary simple version of xtd_is_binary for use in oln. * xtd/valtraits.hh: New. * xtd/Makefile.am (nobase_xtd_HEADERS): Update. Index: xtd/valtraits.hh =================================================================== --- xtd/valtraits.hh (revision 0) +++ xtd/valtraits.hh (revision 0) @@ -0,0 +1,61 @@ +// Copyright (C) 2006 EPITA Research and Development Laboratory +// +// This file is part of the Olena Library. This library is free +// software; you can redistribute it and/or modify it under the terms +// of the GNU General Public License version 2 as published by the +// Free Software Foundation. +// +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this library; see the file COPYING. If not, write to +// the Free Software Foundation, 51 Franklin Street, Fifth Floor, +// Boston, MA 02111-1307, USA. +// +// As a special exception, you may use this file as part of a free +// software library without restriction. Specifically, if other files +// instantiate templates or use macros or inline functions from this +// file, or you compile this file and link it with other files to +// produce an executable, this file does not by itself cause the +// resulting executable to be covered by the GNU General Public +// License. This exception does not however invalidate any other +// reasons why the executable file might be covered by the GNU General +// Public License. + +#ifndef XTD_VALTRAITS_HH +# define XTD_VALTRAITS_HH + +// # include <xtd/traits.hh> +// # include <xtd/builtin/traits.hh> + + + +namespace xtd +{ + + template <typename T> + struct is_binary + { + typedef mlc::false_ ret; + }; + + + template <> + struct is_binary <bool> + { + typedef mlc::true_ ret; + }; + + +} // end of namespace xtd + + + +# define xtd_is_binary(T) typename xtd::is_binary<T>::ret + + + +#endif // ! XTD_VALTRAITS_HH Index: xtd/Makefile.am =================================================================== --- xtd/Makefile.am (revision 588) +++ xtd/Makefile.am (working copy) @@ -56,4 +56,5 @@ optraits.hh \ res.hh \ traits.hh \ + valtraits.hh \ vec.hh

18 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Olena-patches