- Olena-patches

olena-2.0-93-g146727e Backup
by Guillaume Lazzara 22 Jun '12

22 Jun '12

--- scribo/src/binarization/kim.cc | 347 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 347 insertions(+), 0 deletions(-) create mode 100644 scribo/src/binarization/kim.cc diff --git a/scribo/src/binarization/kim.cc b/scribo/src/binarization/kim.cc new file mode 100644 index 0000000..4596990 --- /dev/null +++ b/scribo/src/binarization/kim.cc @@ -0,0 +1,347 @@ +// Copyright (C) 2012 EPITA Research and Development Laboratory (LRDE) +// +// This file is part of Olena. +// +// Olena is free software: you can redistribute it and/or modify it under +// the terms of the GNU General Public License as published by the Free +// Software Foundation, version 2 of the License. +// +// Olena is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with Olena. If not, see <http://www.gnu.org/licenses/>. +// +// As a special exception, you may use this file as part of a free +// software project without restriction. Specifically, if other files +// instantiate templates or use macros or inline functions from this +// file, or you compile this file and link it with other files to produce +// an executable, this file does not by itself cause the resulting +// executable to be covered by the GNU General Public License. This +// exception does not however invalidate any other reasons why the +// executable file might be covered by the GNU General Public License. + +/// \file + +#include <cmath> +#include <mln/core/image/image2d.hh> +#include <mln/value/int_u8.hh> +#include <mln/io/magick/load.hh> +#include <mln/io/pbm/save.hh> +#include <mln/data/transform.hh> +#include <mln/fun/v2v/rgb_to_luma.hh> + +#include <scribo/binarization/sauvola_ms.hh> +#include <scribo/debug/option_parser.hh> +#include <scribo/debug/logger.hh> + +#include <scribo/util/integral_sum_sum2_functor.hh> + +#include <scribo/text/extract_lines.hh> +#include <scribo/debug/bboxes_enlarged_image.hh> +#include <algorithm> + + +static const scribo::debug::arg_data arg_desc[] = +{ + { "input.*", "An image." }, + { "output.pbm", "A binary image." }, + {0, 0} +}; + + +// --enable/disable-<name> +static const scribo::debug::toggle_data toggle_desc[] = +{ + // name, description, default value + {0, 0, false} +}; + + +// --<name> <args> +static const scribo::debug::opt_data opt_desc[] = +{ + // name, description, arguments, check args function, number of args, default arg + { "debug-prefix", "Enable debug image outputs. Prefix image name with that " + "given prefix.", "<prefix>", 0, 1, 0 }, + { "k", "Sauvola's formulae parameter", "<value>", 0, 1, "0.34" }, + { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", + scribo::debug::check_sauvola_first_subsampling, 1, "3" }, + { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, + {0, 0, 0, 0, 0, 0} +}; + + + + + + +int main(int argc, char *argv[]) +{ + using namespace mln; + using namespace scribo; + + scribo::debug::option_parser options(arg_desc, toggle_desc, opt_desc); + + if (!options.parse(argc, argv)) + return 1; + + // Enable debug output. + if (options.is_set("debug-prefix")) + { + scribo::debug::logger().set_filename_prefix(options.opt_value("debug-prefix").c_str()); + scribo::debug::logger().set_level(scribo::debug::All); + } + + Magick::InitializeMagick(*argv); + + trace::entering("main"); + + + bool verbose = options.is_set("verbose"); + // Window size + unsigned w_1 = atoi(options.opt_value("win-size").c_str()); + // First subsampling scale. + unsigned s = atoi(options.opt_value("s").c_str()); + double k = atof(options.opt_value("k").c_str()); + + if (verbose) + std::cout << "Using w_1=" << w_1 << " - s=" << s + << " - k=" << k << std::endl; + + // Load + image2d<value::rgb8> input_1; + io::magick::load(input_1, options.arg("input.*")); + + // Convert to Gray level image. + image2d<value::int_u8> + input_1_gl = data::transform(input_1, + mln::fun::v2v::rgb_to_luma<value::int_u8>()); + + // 1st simple binarization + image2d<bool> + output = scribo::binarization::sauvola_ms(input_1_gl, w_1, s, k); + + io::pbm::save(output, "debug_bin.pbm"); + + // Compute integral image + scribo::util::integral_sum_sum2_functor<value::int_u8,double> f_sum_sum2; + image2d<mln::util::couple<double,double> > + integral_sum_sum_2 = scribo::util::init_integral_image(input_1_gl, 1, f_sum_sum2); + + // Find text lines + line_set<image2d<scribo::def::lbl_type> > + lines = scribo::text::extract_lines(output, c8()); + + typedef scribo::def::lbl_type V; + typedef image2d<V> L; + mln::util::array<unsigned> thickness(lines.nelements() + 1, 0); + const component_set<L>& comp_set = lines.components(); + const L& lbl = comp_set.labeled_image(); + + // Compute run-lengths histogram in order to compute character + // thickness for each line. + for_all_lines(i, lines) + { + if (!lines(i).is_textline()) + continue; + + std::map<unsigned, unsigned> histo; + int count = 0; + for (int l = lines(i).bbox().pmin().row(); l <= lines(i).bbox().pmax().row(); ++l) + { + const V* end_ptr = &lbl.at_(l, lines(i).bbox().pmax().col() + 1); + for (const V* run_ptr = &lbl.at_(l, lines(i).bbox().pmin().col()); run_ptr != end_ptr; ++run_ptr) + if (*run_ptr) + ++count; + else + if (count) + { + if (histo.find(count) != histo.end()) + histo[count]++; + else + histo.insert(std::make_pair(count, 1)); + count = 0; + } + } + + unsigned max = 0; + unsigned thick = 0; + for (std::map<unsigned, unsigned>::const_iterator it = histo.begin(); it != histo.end(); ++it) + if (it->second > max) + { + max = it->second; + thick = it->first; + } + + thickness(lines(i).id()) = thick; + std::cout << "line " << i << " - thickness = " << thick << " - height = " << lines(i).x_height() << std::endl; + } + + // std::cout << "integral_sum_sum_2.domain() = " << integral_sum_sum_2.domain() << std::endl; + + // FIXME: To be removed. + extension::adjust_duplicate(integral_sum_sum_2, 50); + + for_all_lines(i, lines) + { + if (!lines(i).is_textline()) + continue; + + math::round<double> round; + double + win_min = round(std::max(thickness(lines(i).id()),2u) / 2.0), + win_max = round(std::max(lines(i).x_height(),2u) / 2.0), + card_min, + card_max; + + if (win_min == 0) + { + std::cout << "win_min == 0 - thickness = " << thickness(lines(i).id()) << std::endl; + abort(); + } + + if (win_max == 0) + { + std::cout << "win_max == 0 - x_height = " << lines(i).x_height() << std::endl; + abort(); + } + + + binarization::internal::sauvola_formula compute_thres; + + + // std::cout << "<<<<<<<<<<<<<< New line" << std::endl; + + mln_piter(L) p(lines(i).bbox()); + for_all(p) + { + accu::shape::bbox<point2d> accu; + point2d tl, br; + + // Min case + tl.row() = (p.row() - win_min - 1); + tl.col() = (p.col() - win_min - 1); + + br.row() = (p.row() + win_min); + br.col() = (p.col() + win_min); + + accu.take(tl); + accu.take(br); + box2d b = accu.to_result(); + b.crop_wrt(integral_sum_sum_2.domain()); + + point2d tr = b.pmax(); + tr.row() = b.pmin().row(); + point2d bl = b.pmin(); + bl.row() = b.pmax().row(); + + { + accu::shape::bbox<point2d> accu; + point2d tl, br; + + tl.row() = (p.row() - win_min); + tl.col() = (p.col() - win_min); + + br.row() = (p.row() + win_min); + br.col() = (p.col() + win_min); + + accu.take(tl); + accu.take(br); + box2d b = accu.to_result(); + b.crop_wrt(input_1_gl.domain()); + card_min = b.nsites(); + } + + // std::cout << "p = " << p << " - box = " << b << " - nsites = " << b.nsites() << " - card_min = " << card_min << std::endl; + + double sum = integral_sum_sum_2(b.pmax()).first() - integral_sum_sum_2(tr).first() - integral_sum_sum_2(bl).first() + integral_sum_sum_2(b.pmin()).first(); + double sum_2 = integral_sum_sum_2(b.pmax()).second() - integral_sum_sum_2(tr).second() - integral_sum_sum_2(bl).second() + integral_sum_sum_2(b.pmin()).second(); + double mean = sum / card_min; + + double num = (sum_2 - sum * sum / card_min); + double stddev = 0; + if (num > 0) + stddev = std::sqrt(num / (card_min - 1)); + else + stddev = 0; + + + double T_min = compute_thres(mean, stddev); + + // Max case + accu.init(); + tl.row() = (p.row() - win_max - 1); + tl.col() = (p.col() - win_max - 1); + + br.row() = (p.row() + win_max); + br.col() = (p.col() + win_max); + + accu.take(tl); + accu.take(br); + b = accu.to_result(); + b.crop_wrt(integral_sum_sum_2.domain()); + + tr = b.pmax(); + tr.row() = b.pmin().row(); + bl = b.pmin(); + bl.row() = b.pmax().row(); + + { + accu::shape::bbox<point2d> accu; + point2d tl, br; + + tl.row() = (p.row() - win_max); + tl.col() = (p.col() - win_max); + + br.row() = (p.row() + win_max); + br.col() = (p.col() + win_max); + + accu.take(tl); + accu.take(br); + box2d b = accu.to_result(); + b.crop_wrt(input_1_gl.domain()); + card_max = b.nsites(); + + // std::cout << "card_max = " << card_max << " - b = " << b << std::endl; + } + + sum = integral_sum_sum_2(b.pmax()).first() - integral_sum_sum_2(tr).first() - integral_sum_sum_2(bl).first() + integral_sum_sum_2(b.pmin()).first(); + sum_2 = integral_sum_sum_2(b.pmax()).second() - integral_sum_sum_2(tr).second() - integral_sum_sum_2(bl).second() + integral_sum_sum_2(b.pmin()).second(); + mean = sum / card_max; + + num = (sum_2 - sum * sum / card_max); + stddev = 0; + if (num > 0) + stddev = std::sqrt(num / (card_max - 1)); + else + stddev = 0; + + double T_max = compute_thres(mean, stddev); + + + // Final threshold + + double teta = 0.3; + double T = teta * T_max + (1 - teta) * T_min; + +// std::cout << "bbox = " << lines(i).bbox() << " - box = " << b << " - T_max = " << T_max << " - T_min = " << T_min << " - T = " << T << std::endl; + mln_assertion(T_min <= 255); + mln_assertion(T_max <= 255); + mln_assertion(T <= 255); + + output(p) = input_1_gl(p) <= T; + } + + } + + + image2d<value::rgb8> bbox = scribo::debug::bboxes_enlarged_image(output, lines); + io::ppm::save(bbox, "debug_bbox.ppm"); + + + io::pbm::save(output, options.arg("output.pbm")); +} -- 1.7.2.5

1 0

olena-2.0-94-g17a98b3 bACKUP
by Guillaume Lazzara 22 Jun '12

22 Jun '12

--- scribo/src/binarization/kim.cc | 102 ++++++++++++---------------------------- 1 files changed, 30 insertions(+), 72 deletions(-) diff --git a/scribo/src/binarization/kim.cc b/scribo/src/binarization/kim.cc index 4596990..7294a9c 100644 --- a/scribo/src/binarization/kim.cc +++ b/scribo/src/binarization/kim.cc @@ -116,6 +116,9 @@ int main(int argc, char *argv[]) image2d<value::rgb8> input_1; io::magick::load(input_1, options.arg("input.*")); + mln::util::timer t; + t.start(); + // Convert to Gray level image. image2d<value::int_u8> input_1_gl = data::transform(input_1, @@ -125,13 +128,18 @@ int main(int argc, char *argv[]) image2d<bool> output = scribo::binarization::sauvola_ms(input_1_gl, w_1, s, k); - io::pbm::save(output, "debug_bin.pbm"); + mln::util::timer lt; + lt.start(); // Compute integral image scribo::util::integral_sum_sum2_functor<value::int_u8,double> f_sum_sum2; image2d<mln::util::couple<double,double> > integral_sum_sum_2 = scribo::util::init_integral_image(input_1_gl, 1, f_sum_sum2); + lt.stop(); + std::cout << "integral image - " << lt << std::endl; + lt.start(); + // Find text lines line_set<image2d<scribo::def::lbl_type> > lines = scribo::text::extract_lines(output, c8()); @@ -142,6 +150,10 @@ int main(int argc, char *argv[]) const component_set<L>& comp_set = lines.components(); const L& lbl = comp_set.labeled_image(); + lt.stop(); + std::cout << "Text line finding - " << lt << std::endl; + lt.start(); + // Compute run-lengths histogram in order to compute character // thickness for each line. for_all_lines(i, lines) @@ -178,14 +190,13 @@ int main(int argc, char *argv[]) } thickness(lines(i).id()) = thick; - std::cout << "line " << i << " - thickness = " << thick << " - height = " << lines(i).x_height() << std::endl; } - // std::cout << "integral_sum_sum_2.domain() = " << integral_sum_sum_2.domain() << std::endl; - - // FIXME: To be removed. - extension::adjust_duplicate(integral_sum_sum_2, 50); + lt.stop(); + std::cout << "run-lengths histogram - " << lt << std::endl; + lt.start(); + // Compute thresholds for each pixel of each line and binarize again! for_all_lines(i, lines) { if (!lines(i).is_textline()) @@ -193,34 +204,20 @@ int main(int argc, char *argv[]) math::round<double> round; double - win_min = round(std::max(thickness(lines(i).id()),2u) / 2.0), - win_max = round(std::max(lines(i).x_height(),2u) / 2.0), + win_min = thickness(lines(i).id()), + win_max = lines(i).bbox().height(), card_min, card_max; - if (win_min == 0) - { - std::cout << "win_min == 0 - thickness = " << thickness(lines(i).id()) << std::endl; - abort(); - } - - if (win_max == 0) - { - std::cout << "win_max == 0 - x_height = " << lines(i).x_height() << std::endl; - abort(); - } - + mln_assertion(win_min != 0); + mln_assertion(win_max != 0); binarization::internal::sauvola_formula compute_thres; - - - // std::cout << "<<<<<<<<<<<<<< New line" << std::endl; + point2d tl, br; mln_piter(L) p(lines(i).bbox()); for_all(p) { - accu::shape::bbox<point2d> accu; - point2d tl, br; // Min case tl.row() = (p.row() - win_min - 1); @@ -229,9 +226,7 @@ int main(int argc, char *argv[]) br.row() = (p.row() + win_min); br.col() = (p.col() + win_min); - accu.take(tl); - accu.take(br); - box2d b = accu.to_result(); + box2d b(tl, br); b.crop_wrt(integral_sum_sum_2.domain()); point2d tr = b.pmax(); @@ -239,24 +234,7 @@ int main(int argc, char *argv[]) point2d bl = b.pmin(); bl.row() = b.pmax().row(); - { - accu::shape::bbox<point2d> accu; - point2d tl, br; - - tl.row() = (p.row() - win_min); - tl.col() = (p.col() - win_min); - - br.row() = (p.row() + win_min); - br.col() = (p.col() + win_min); - - accu.take(tl); - accu.take(br); - box2d b = accu.to_result(); - b.crop_wrt(input_1_gl.domain()); - card_min = b.nsites(); - } - - // std::cout << "p = " << p << " - box = " << b << " - nsites = " << b.nsites() << " - card_min = " << card_min << std::endl; + card_min = b.nsites() - b.height() - b.width() + 1; double sum = integral_sum_sum_2(b.pmax()).first() - integral_sum_sum_2(tr).first() - integral_sum_sum_2(bl).first() + integral_sum_sum_2(b.pmin()).first(); double sum_2 = integral_sum_sum_2(b.pmax()).second() - integral_sum_sum_2(tr).second() - integral_sum_sum_2(bl).second() + integral_sum_sum_2(b.pmin()).second(); @@ -273,16 +251,13 @@ int main(int argc, char *argv[]) double T_min = compute_thres(mean, stddev); // Max case - accu.init(); tl.row() = (p.row() - win_max - 1); tl.col() = (p.col() - win_max - 1); br.row() = (p.row() + win_max); br.col() = (p.col() + win_max); - accu.take(tl); - accu.take(br); - b = accu.to_result(); + b = box2d(tl, br); b.crop_wrt(integral_sum_sum_2.domain()); tr = b.pmax(); @@ -290,24 +265,7 @@ int main(int argc, char *argv[]) bl = b.pmin(); bl.row() = b.pmax().row(); - { - accu::shape::bbox<point2d> accu; - point2d tl, br; - - tl.row() = (p.row() - win_max); - tl.col() = (p.col() - win_max); - - br.row() = (p.row() + win_max); - br.col() = (p.col() + win_max); - - accu.take(tl); - accu.take(br); - box2d b = accu.to_result(); - b.crop_wrt(input_1_gl.domain()); - card_max = b.nsites(); - - // std::cout << "card_max = " << card_max << " - b = " << b << std::endl; - } + card_max = b.nsites() - b.height() - b.width() + 1; sum = integral_sum_sum_2(b.pmax()).first() - integral_sum_sum_2(tr).first() - integral_sum_sum_2(bl).first() + integral_sum_sum_2(b.pmin()).first(); sum_2 = integral_sum_sum_2(b.pmax()).second() - integral_sum_sum_2(tr).second() - integral_sum_sum_2(bl).second() + integral_sum_sum_2(b.pmin()).second(); @@ -328,7 +286,6 @@ int main(int argc, char *argv[]) double teta = 0.3; double T = teta * T_max + (1 - teta) * T_min; -// std::cout << "bbox = " << lines(i).bbox() << " - box = " << b << " - T_max = " << T_max << " - T_min = " << T_min << " - T = " << T << std::endl; mln_assertion(T_min <= 255); mln_assertion(T_max <= 255); mln_assertion(T <= 255); @@ -338,10 +295,11 @@ int main(int argc, char *argv[]) } + lt.stop(); + std::cout << "Last binarization - " << lt << std::endl; - image2d<value::rgb8> bbox = scribo::debug::bboxes_enlarged_image(output, lines); - io::ppm::save(bbox, "debug_bbox.ppm"); - + t.stop(); + std::cout << "Total time = " << t << std::endl; io::pbm::save(output, options.arg("output.pbm")); } -- 1.7.2.5

1 0

olena-2.0-95-g89004a2 Backup
by Guillaume Lazzara 22 Jun '12

22 Jun '12

--- milena/mln/core/internal/image_base.hh | 33 ++++--- scribo/scribo/binarization/sauvola_ms.hh | 43 ++++++++- scribo/scribo/canvas/integral_browsing.hh | 8 ++- scribo/scribo/estim/font_color.hh | 4 +- scribo/src/binarization/Makefile.am | 7 ++ scribo/src/binarization/kim.cc | 143 +++++++++++++---------------- scribo/src/binarization/niblack.cc | 5 +- scribo/src/binarization/sauvola_ms.cc | 17 +++- 8 files changed, 156 insertions(+), 104 deletions(-) diff --git a/milena/mln/core/internal/image_base.hh b/milena/mln/core/internal/image_base.hh index f1ba4f9..6b60121 100644 --- a/milena/mln/core/internal/image_base.hh +++ b/milena/mln/core/internal/image_base.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2007, 2008, 2009 EPITA Research and Development +// Copyright (C) 2007, 2008, 2009, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -43,18 +43,6 @@ # include <mln/value/set.hh> # include <mln/value/super_value.hh> -// image_base -// ^ -// | -// --------------------------- -// | | -// image_primary image_morpher -// ^ ^ -// | | -// | ----------------------------------------- -// | | | | -// pw_image_base image_domain_morpher image_value_morpher image_identity - namespace mln { @@ -73,10 +61,27 @@ namespace mln - /// A base class for images. + /// \brief A base class for images. /// /// Parameter \p T is the image value type. /// Parameter \p S is the image site set type. + /// + /// \internal + /// + /// \verbatim + /// image_base + /// ^ + /// | + /// --------------------------- + /// | | + /// image_primary image_morpher + /// ^ ^ + /// | | + /// | ----------------------------------------- + /// | | | | + /// pw_image_base image_domain_morpher image_value_morpher image_identity + /// + /// \endverbatim // template <typename T, typename S, typename E> struct image_base diff --git a/scribo/scribo/binarization/sauvola_ms.hh b/scribo/scribo/binarization/sauvola_ms.hh index 96064e9..ba58207 100644 --- a/scribo/scribo/binarization/sauvola_ms.hh +++ b/scribo/scribo/binarization/sauvola_ms.hh @@ -98,7 +98,8 @@ namespace scribo \param[in] s The scale factor used for the first subscaling. \param[in] lambda_min_1 Size of the objects kept at scale 1. \param[in] K Sauvola's formulae parameter. - + \param[out] integral_sum_sum_2 Integral image of sum and squared + sum. \p w_1 and \p lambda_min_1 are expressed according to the image at scale 0, i.e. the original size. @@ -107,6 +108,15 @@ namespace scribo */ template <typename I> mln_ch_value(I,bool) + sauvola_ms(const Image& input_1_, unsigned w_1, + unsigned s, double K, + image2d<mln::util::couple<double,double> >& integral_sum_sum_2); + + /// \overload + /// The integral image is not returned. + // + template <typename I> + mln_ch_value(I,bool) sauvola_ms(const Image& input_1_, unsigned w_1, unsigned s, double K); /// \overload @@ -802,7 +812,8 @@ namespace scribo template <typename I> mln_ch_value(I,bool) sauvola_ms(const Image& input_1_, unsigned w_1, - unsigned s, double K) + unsigned s, double K, + image2d<mln::util::couple<double,double> >& integral_sum_sum_2) { trace::entering("scribo::binarization::sauvola_ms"); @@ -853,7 +864,7 @@ namespace scribo // Resize input and compute integral images. typedef image2d<mln::util::couple<double,double> > integral_t; - integral_t integral_sum_sum_2; +// integral_t integral_sum_sum_2; mln::util::timer t; t.start(); @@ -1030,6 +1041,27 @@ namespace scribo template <typename I> mln_ch_value(I,bool) sauvola_ms(const Image& input_1_, unsigned w_1, + unsigned s, double K, + image2d<mln::util::couple<double,double> >& integral_sum_sum_2) + { + trace::entering("scribo::binarization::sauvola_ms"); + + mln_precondition(exact(input_1_).is_valid()); + // Gray level images ONLY. + mlc_is_not_a(mln_value(I), value::Vectorial)::check(); + mlc_is_not(mln_value(I), bool)::check(); + + mln_ch_value(I,bool) + output = impl::generic::sauvola_ms(exact(input_1_), w_1, s, K, + integral_sum_sum_2); + + trace::exiting("scribo::binarization::sauvola_ms"); + return output; + } + + template <typename I> + mln_ch_value(I,bool) + sauvola_ms(const Image& input_1_, unsigned w_1, unsigned s, double K) { trace::entering("scribo::binarization::sauvola_ms"); @@ -1039,8 +1071,11 @@ namespace scribo mlc_is_not_a(mln_value(I), value::Vectorial)::check(); mlc_is_not(mln_value(I), bool)::check(); + typedef image2d<mln::util::couple<double,double> > integral_t; + integral_t integral_sum_sum_2; + mln_ch_value(I,bool) - output = impl::generic::sauvola_ms(exact(input_1_), w_1, s, K); + output = sauvola_ms(exact(input_1_), w_1, s, K, integral_sum_sum_2); trace::exiting("scribo::binarization::sauvola_ms"); return output; diff --git a/scribo/scribo/canvas/integral_browsing.hh b/scribo/scribo/canvas/integral_browsing.hh index 89e0019..da13fe7 100644 --- a/scribo/scribo/canvas/integral_browsing.hh +++ b/scribo/scribo/canvas/integral_browsing.hh @@ -116,6 +116,12 @@ namespace scribo for (col = col_0; col <= max_col_mid; col += step) ; int w_right = ncols - col + w/2; + // tl: top left + // tr: top right + // ml: middle left + // mr: middle right + // bl: bottom left + // br: bottom right Ptr d_tl_start, d_tr_start, b_ml_start = 0, d_ml_start = 0, b_mr_start = 0, d_mr_start = 0, @@ -176,7 +182,7 @@ namespace scribo for (; col <= max_col_mid; col += step) { // D - C - internal::compute_stats(d_ima->first() - c_ima->first(), + internal::compute_stats(d_ima->first() - c_ima->first(), d_ima->second() - c_ima->second(), size_tc * s_2, mean, stddev); diff --git a/scribo/scribo/estim/font_color.hh b/scribo/scribo/estim/font_color.hh index 9a3c429..78e8c83 100644 --- a/scribo/scribo/estim/font_color.hh +++ b/scribo/scribo/estim/font_color.hh @@ -83,7 +83,7 @@ namespace scribo mln_ch_value(I,value::int_u8) lbl = labeling::blobs(skel, c8(), nlabels); - util::array<algebra::vec<3u, float> > res = + mln::util::array<algebra::vec<3u, float> > res = labeling::compute(accu::meta::stat::mean(), text_ima, lbl, nlabels); accu::stat::median_h<value::int_u12> m_red; @@ -131,7 +131,7 @@ namespace scribo value::int_u8 nlabels = 0; mln_ch_value(J,value::int_u8) lbl = labeling::blobs(skel, c8(), nlabels); - util::array<algebra::vec<3u, float> > res = + mln::util::array<algebra::vec<3u, float> > res = labeling::compute(accu::meta::stat::mean(), text_ima, lbl, nlabels); accu::stat::median_h<value::int_u12> m_val; diff --git a/scribo/src/binarization/Makefile.am b/scribo/src/binarization/Makefile.am index b29ac30..db168fa 100644 --- a/scribo/src/binarization/Makefile.am +++ b/scribo/src/binarization/Makefile.am @@ -30,6 +30,7 @@ if HAVE_MAGICKXX sauvola_ms_debug utilexec_PROGRAMS = \ + kim \ niblack \ otsu \ sauvola \ @@ -66,6 +67,12 @@ if HAVE_MAGICKXX sauvola_ms_fg_LDFLAGS = $(AM_LDFLAGS) \ $(MAGICKXX_LDFLAGS) + kim_SOURCES = kim.cc + kim_CPPFLAGS = $(AM_CPPFLAGS) \ + $(MAGICKXX_CPPFLAGS) + kim_LDFLAGS = $(AM_LDFLAGS) \ + $(MAGICKXX_LDFLAGS) + sauvola_SOURCES = sauvola.cc sauvola_CPPFLAGS = $(AM_CPPFLAGS) \ $(MAGICKXX_CPPFLAGS) diff --git a/scribo/src/binarization/kim.cc b/scribo/src/binarization/kim.cc index 7294a9c..aa81f50 100644 --- a/scribo/src/binarization/kim.cc +++ b/scribo/src/binarization/kim.cc @@ -77,6 +77,47 @@ static const scribo::debug::opt_data opt_desc[] = +double +compute_thres(const mln::image2d<mln::util::couple<double,double> >& integral_sum_sum_2, + int row, int col, unsigned win_size, + const scribo::binarization::internal::sauvola_formula& formula) +{ + point2d + tl(row - win_size - 1, + col - win_size - 1), + br(row + win_size, + col + win_size); + + box2d b(tl, br); + b.crop_wrt(integral_sum_sum_2.domain()); + + point2d tr = b.pmax(); + tr.row() = b.pmin().row(); + point2d bl = b.pmin(); + bl.row() = b.pmax().row(); + + unsigned card_min = b.nsites() - b.height() - b.width() + 1; + + const mln::util::couple<double,double>& + D = integral_sum_sum_2(b.pmax()), + B = integral_sum_sum_2(tr), + C = integral_sum_sum_2(bl), + A = integral_sum_sum_2(b.pmin()); + + double sum = D.first() - B.first() - C.first() + A.first(); + double sum_2 = D.second() - B.second() - C.second() + A.second(); + double mean = sum / card_min; + + double num = (sum_2 - sum * sum / card_min); + double stddev; + if (num > 0) + stddev = std::sqrt(num / (card_min - 1)); + else + stddev = 0; + + return formula(mean, stddev); +} + int main(int argc, char *argv[]) @@ -202,97 +243,43 @@ int main(int argc, char *argv[]) if (!lines(i).is_textline()) continue; - math::round<double> round; double win_min = thickness(lines(i).id()), - win_max = lines(i).bbox().height(), - card_min, - card_max; + win_max = lines(i).bbox().height();; mln_assertion(win_min != 0); mln_assertion(win_max != 0); - binarization::internal::sauvola_formula compute_thres; - point2d tl, br; + scribo::binarization::internal::sauvola_formula formula; - mln_piter(L) p(lines(i).bbox()); - for_all(p) + for (int row = lines(i).bbox().pmin().row(); + row <= lines(i).bbox().pmax().row(); + ++row) { + bool* out_ptr = &output.at_(row, lines(i).bbox().pmin().col()); + value::int_u8* in_ptr = &input_1_gl.at_(row, lines(i).bbox().pmin().col()); + for (int col = lines(i).bbox().pmin().col(); + col <= lines(i).bbox().pmax().col(); + ++col) + { + // Min case + double T_min = compute_thres(integral_sum_sum_2, row, col, win_min, formula); - // Min case - tl.row() = (p.row() - win_min - 1); - tl.col() = (p.col() - win_min - 1); - - br.row() = (p.row() + win_min); - br.col() = (p.col() + win_min); - - box2d b(tl, br); - b.crop_wrt(integral_sum_sum_2.domain()); - - point2d tr = b.pmax(); - tr.row() = b.pmin().row(); - point2d bl = b.pmin(); - bl.row() = b.pmax().row(); - - card_min = b.nsites() - b.height() - b.width() + 1; - - double sum = integral_sum_sum_2(b.pmax()).first() - integral_sum_sum_2(tr).first() - integral_sum_sum_2(bl).first() + integral_sum_sum_2(b.pmin()).first(); - double sum_2 = integral_sum_sum_2(b.pmax()).second() - integral_sum_sum_2(tr).second() - integral_sum_sum_2(bl).second() + integral_sum_sum_2(b.pmin()).second(); - double mean = sum / card_min; - - double num = (sum_2 - sum * sum / card_min); - double stddev = 0; - if (num > 0) - stddev = std::sqrt(num / (card_min - 1)); - else - stddev = 0; - - - double T_min = compute_thres(mean, stddev); - - // Max case - tl.row() = (p.row() - win_max - 1); - tl.col() = (p.col() - win_max - 1); - - br.row() = (p.row() + win_max); - br.col() = (p.col() + win_max); - - b = box2d(tl, br); - b.crop_wrt(integral_sum_sum_2.domain()); - - tr = b.pmax(); - tr.row() = b.pmin().row(); - bl = b.pmin(); - bl.row() = b.pmax().row(); - - card_max = b.nsites() - b.height() - b.width() + 1; - - sum = integral_sum_sum_2(b.pmax()).first() - integral_sum_sum_2(tr).first() - integral_sum_sum_2(bl).first() + integral_sum_sum_2(b.pmin()).first(); - sum_2 = integral_sum_sum_2(b.pmax()).second() - integral_sum_sum_2(tr).second() - integral_sum_sum_2(bl).second() + integral_sum_sum_2(b.pmin()).second(); - mean = sum / card_max; - - num = (sum_2 - sum * sum / card_max); - stddev = 0; - if (num > 0) - stddev = std::sqrt(num / (card_max - 1)); - else - stddev = 0; - - double T_max = compute_thres(mean, stddev); - - - // Final threshold + // Max case + double T_max = compute_thres(integral_sum_sum_2, row, col, win_max, formula); - double teta = 0.3; - double T = teta * T_max + (1 - teta) * T_min; + // Final threshold + double teta = 0.3; // Good results from 0.1 to 0.3 according + // to the paper. + double T = teta * T_max + (1 - teta) * T_min; - mln_assertion(T_min <= 255); - mln_assertion(T_max <= 255); - mln_assertion(T <= 255); + mln_assertion(T_min <= 255); + mln_assertion(T_max <= 255); + mln_assertion(T <= 255); - output(p) = input_1_gl(p) <= T; + *out_ptr++ = *in_ptr++ <= T; + } } - } lt.stop(); diff --git a/scribo/src/binarization/niblack.cc b/scribo/src/binarization/niblack.cc index 4b7ed91..58074fc 100644 --- a/scribo/src/binarization/niblack.cc +++ b/scribo/src/binarization/niblack.cc @@ -29,6 +29,8 @@ #include <mln/io/pbm/save.hh> #include <mln/data/transform.hh> #include <mln/fun/v2v/rgb_to_luma.hh> +#include <mln/arith/revert.hh> +#include <mln/logical/not.hh> #include <scribo/binarization/niblack.hh> #include <scribo/debug/option_parser.hh> @@ -98,8 +100,9 @@ int main(int argc, char *argv[]) image2d<value::int_u8> input_1_gl = data::transform(input, mln::fun::v2v::rgb_to_luma<value::int_u8>()); + arith::revert_inplace(input_1_gl); image2d<bool> out = scribo::binarization::niblack(input_1_gl, w, k); - + logical::not_inplace(out); io::pbm::save(out, options.arg("output.pbm")); trace::exiting("main"); diff --git a/scribo/src/binarization/sauvola_ms.cc b/scribo/src/binarization/sauvola_ms.cc index 483a35b..d07de72 100644 --- a/scribo/src/binarization/sauvola_ms.cc +++ b/scribo/src/binarization/sauvola_ms.cc @@ -109,15 +109,24 @@ int main(int argc, char *argv[]) unsigned s = atoi(options.opt_value("s").c_str()); double k = atof(options.opt_value("k").c_str()); + if (options.is_set("k")) + { + binarization::internal::k2 = k; + binarization::internal::k3 = k; + binarization::internal::k4 = k; + } + else + { + binarization::internal::k2 = atof(options.opt_value("k2").c_str()); + binarization::internal::k3 = atof(options.opt_value("k3").c_str()); + binarization::internal::k4 = atof(options.opt_value("k4").c_str()); + } + if (verbose) std::cout << "Using w_1=" << w_1 << " - s=" << s << " - k=" << k << std::endl; - binarization::internal::k2 = atof(options.opt_value("k2").c_str()); - binarization::internal::k3 = atof(options.opt_value("k3").c_str()); - binarization::internal::k4 = atof(options.opt_value("k4").c_str()); - // Load image2d<value::rgb8> input_1; -- 1.7.2.5

1 0

olena-2.0-96-g00db91c Make integral browsing canvas robust to large windows.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

* scribo/binarization/sauvola_ms.hh: remove tests on window size. * scribo/canvas/integral_browsing.hh: Check window size. --- scribo/scribo/binarization/sauvola_ms.hh | 28 ---------------------------- scribo/scribo/canvas/integral_browsing.hh | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 28 deletions(-) diff --git a/scribo/scribo/binarization/sauvola_ms.hh b/scribo/scribo/binarization/sauvola_ms.hh index ba58207..5f0f963 100644 --- a/scribo/scribo/binarization/sauvola_ms.hh +++ b/scribo/scribo/binarization/sauvola_ms.hh @@ -169,34 +169,6 @@ namespace scribo w_local_h = w_local, w_local_w = w_local; - //std::cout << "scale " <= static_cast<const unsigned>(integral_sum_sum_2.ncols())) - { - w_local_w = std::min(integral_sum_sum_2.ncols(), - integral_sum_sum_2.nrows()) - integral_sum_sum_2.border(); - w_local_h = w_local_w; - trace::warning("integral_browsing - Adjusting window width since it" - " was larger than image width."); - } - if (w_local_h >= static_cast<const unsigned>(integral_sum_sum_2.nrows())) - { - w_local_h = std::min(integral_sum_sum_2.nrows(), - integral_sum_sum_2.ncols()) - integral_sum_sum_2.border(); - w_local_w = w_local_h; - trace::warning("integral_browsing - Adjusting window height since it" - " was larger than image height."); - } - - if (! (w_local % 2)) - { - --w_local_w; - ++w_local_h; - } - - //std::cout << "Scale " < > f(sub, K, SCRIBO_DEFAULT_SAUVOLA_R, e_2, i, q); diff --git a/scribo/scribo/canvas/integral_browsing.hh b/scribo/scribo/canvas/integral_browsing.hh index da13fe7..5328a5a 100644 --- a/scribo/scribo/canvas/integral_browsing.hh +++ b/scribo/scribo/canvas/integral_browsing.hh @@ -88,6 +88,25 @@ namespace scribo // mln_precondition((h/2) < ima.nrows()); // mln_precondition((w/2) < ima.ncols()); + // Adjust window size to image. + if (w > (ima.domain().ncols() - ima.border())) + { + w = std::min(ima.domain().ncols(), ima.domain().nrows()) - ima.border(); + if (! (w % 2)) + --w; + trace::warning("integral_browsing - Adjusting window width since it" + " was larger than image height."); + } + if (h > (ima.domain().nrows() - ima.border())) + { + h = std::min(ima.domain().ncols(), ima.domain().nrows()) - ima.border(); + if (! (h % 2)) + --h; + trace::warning("integral_browsing - Adjusting window height since it" + " was larger than image width."); + } + + const int nrows = ima.nrows(), ncols = ima.ncols(), -- 1.7.2.5

1 0

olena-2.0-97-gf9ea569 Cleanup Kim's binarization.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

* src/binarization/kim.cc: Move code... * scribo/binarization/kim.hh: ... here. * tests/binarization/Makefile.am: Add new target. * tests/binarization/kim.cc, * tests/binarization/kim.ref.pbm, * tests/binarization/kim_weven_hodd.ref.pbm, * tests/binarization/kim_wodd_heven.ref.pbm, * tests/binarization/kim_wodd_hodd.ref.pbm: New. --- scribo/scribo/binarization/kim.hh | 262 ++++++++++++++++++++++ scribo/src/binarization/kim.cc | 199 +--------------- scribo/tests/binarization/Makefile.am | 6 + scribo/tests/binarization/{sauvola.cc => kim.cc} | 18 +- scribo/tests/binarization/kim.ref.pbm | Bin 0 -> 32884 bytes scribo/tests/binarization/kim_weven_hodd.ref.pbm | Bin 0 -> 32820 bytes scribo/tests/binarization/kim_wodd_heven.ref.pbm | Bin 0 -> 32884 bytes scribo/tests/binarization/kim_wodd_hodd.ref.pbm | Bin 0 -> 32820 bytes 8 files changed, 289 insertions(+), 196 deletions(-) create mode 100644 scribo/scribo/binarization/kim.hh copy scribo/tests/binarization/{sauvola.cc => kim.cc} (77%) create mode 100644 scribo/tests/binarization/kim.ref.pbm create mode 100644 scribo/tests/binarization/kim_weven_hodd.ref.pbm create mode 100644 scribo/tests/binarization/kim_wodd_heven.ref.pbm create mode 100644 scribo/tests/binarization/kim_wodd_hodd.ref.pbm diff --git a/scribo/scribo/binarization/kim.hh b/scribo/scribo/binarization/kim.hh new file mode 100644 index 0000000..0d31a1d --- /dev/null +++ b/scribo/scribo/binarization/kim.hh @@ -0,0 +1,262 @@ +// Copyright (C) 2012 EPITA Research and Development Laboratory (LRDE) +// +// This file is part of Olena. +// +// Olena is free software: you can redistribute it and/or modify it under +// the terms of the GNU General Public License as published by the Free +// Software Foundation, version 2 of the License. +// +// Olena is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with Olena. If not, see <http://www.gnu.org/licenses/>. +// +// As a special exception, you may use this file as part of a free +// software project without restriction. Specifically, if other files +// instantiate templates or use macros or inline functions from this +// file, or you compile this file and link it with other files to produce +// an executable, this file does not by itself cause the resulting +// executable to be covered by the GNU General Public License. This +// exception does not however invalidate any other reasons why the +// executable file might be covered by the GNU General Public License. + +#ifndef SCRIBO_BINARIZATION_KIM_HH +# define SCRIBO_BINARIZATION_KIM_HH + +/// \file +/// +/// + +#include <cmath> +#include <map> +#include <scribo/binarization/sauvola.hh> +#include <scribo/util/integral_sum_sum2_functor.hh> +#include <scribo/text/extract_lines.hh> + +namespace scribo +{ + + namespace binarization + { + + using namespace mln; + + /*! \brief Kim's binarization + + This algorithms performs a first rough binarization on the input + (here we use Sauvola's method). Then text lines are roughly + detected by grouping connected components. For each text lines, + character thickness and x height is computed. Finally, each + lines is binarized again, using text features as parameters for + adjusting the final threshold. + + This algorithms considers that global and local statistics + should be used to compute a threshold in text areas. + + This is an improvement of Sauvola's method. + + \param[in] input A gray-level image. + \param[in] window_size the window size to be used for the first + binarization. + \param[in] k Sauvola's formula parameter. + + This implementation is based on the paper "Multi-Window + Binarization of Camera Image for Document Recognition", In-Jung + Kim, Proceedings of the 9th International Workshop on Frontiers + in Handwriting Recognition (IWFHR-9 2004) + */ + template <typename I> + mln_ch_value(I, bool) + kim(const Image& input, unsigned window_size, double k); + + /*! \overload + k is set to SCRIBO_DEFAULT_SAUVOLA_K. + */ + template <typename I> + mln_ch_value(I, bool) + kim(const Image& input, unsigned window_size); + + +# ifndef MLN_INCLUDE_ONLY + + namespace internal + { + + double + compute_thres(const mln::image2d<mln::util::couple<double,double> >& integral_sum_sum_2, + int row, int col, unsigned win_size, + const scribo::binarization::internal::sauvola_formula& formula) + { + point2d + tl(row - win_size - 1, + col - win_size - 1), + br(row + win_size, + col + win_size); + + box2d b(tl, br); + b.crop_wrt(integral_sum_sum_2.domain()); + + point2d tr = b.pmax(); + tr.row() = b.pmin().row(); + point2d bl = b.pmin(); + bl.row() = b.pmax().row(); + + unsigned card_min = b.nsites() - b.height() - b.width() + 1; + + const mln::util::couple<double,double>& + D = integral_sum_sum_2(b.pmax()), + B = integral_sum_sum_2(tr), + C = integral_sum_sum_2(bl), + A = integral_sum_sum_2(b.pmin()); + + double sum = D.first() - B.first() - C.first() + A.first(); + double sum_2 = D.second() - B.second() - C.second() + A.second(); + double mean = sum / card_min; + + double num = (sum_2 - sum * sum / card_min); + double stddev; + if (num > 0) + stddev = std::sqrt(num / (card_min - 1)); + else + stddev = 0; + + return formula(mean, stddev); + } + + } // end of namespace scribo::binarization::internal + + + template <typename I> + mln_ch_value(I, bool) + kim(const Image& input_, unsigned window_size, double k) + { + trace::entering("scribo::binarization::kim"); + + const I& input = exact(input_); + + mln_precondition(input.is_valid()); + + // 1st simple binarization + image2d<bool> + output = scribo::binarization::sauvola(input, window_size, k); + + // Compute integral image + scribo::util::integral_sum_sum2_functor<mln_value(I),double> f_sum_sum2; + image2d<mln::util::couple<double,double> > + integral_sum_sum_2 = scribo::util::init_integral_image(input, 1, f_sum_sum2); + + // Find text lines + line_set<image2d<scribo::def::lbl_type> > + lines = scribo::text::extract_lines(output, c8()); + + typedef scribo::def::lbl_type V; + typedef image2d<V> L; + mln::util::array<unsigned> thickness(lines.nelements() + 1, 0); + const component_set<L>& comp_set = lines.components(); + const L& lbl = comp_set.labeled_image(); + + // Compute run-lengths histogram in order to compute character + // thickness for each line. + for_all_lines(i, lines) + { + if (!lines(i).is_textline()) + continue; + + std::map<unsigned, unsigned> histo; + int count = 0; + for (int l = lines(i).bbox().pmin().row(); l <= lines(i).bbox().pmax().row(); ++l) + { + const V* end_ptr = &lbl.at_(l, lines(i).bbox().pmax().col() + 1); + for (const V* run_ptr = &lbl.at_(l, lines(i).bbox().pmin().col()); run_ptr != end_ptr; ++run_ptr) + if (*run_ptr) + ++count; + else + if (count) + { + if (histo.find(count) != histo.end()) + histo[count]++; + else + histo.insert(std::make_pair(count, 1)); + count = 0; + } + } + + unsigned max = 0; + unsigned thick = 0; + for (std::map<unsigned, unsigned>::const_iterator it = histo.begin(); it != histo.end(); ++it) + if (it->second > max) + { + max = it->second; + thick = it->first; + } + + thickness(lines(i).id()) = thick; + } + + // Compute thresholds for each pixel of each line and binarize again! + for_all_lines(i, lines) + { + if (!lines(i).is_textline()) + continue; + + double + win_min = thickness(lines(i).id()), + win_max = lines(i).bbox().height();; + + mln_assertion(win_min != 0); + mln_assertion(win_max != 0); + + scribo::binarization::internal::sauvola_formula formula; + + double teta = 0.3; // Good results from 0.1 to 0.3 according + // to the paper. + for (int row = lines(i).bbox().pmin().row(); + row <= lines(i).bbox().pmax().row(); + ++row) + { + bool* out_ptr = &output.at_(row, lines(i).bbox().pmin().col()); + const mln_value(I)* in_ptr = &input.at_(row, lines(i).bbox().pmin().col()); + for (int col = lines(i).bbox().pmin().col(); + col <= lines(i).bbox().pmax().col(); + ++col) + { + // Min case + double T_min = compute_thres(integral_sum_sum_2, row, col, win_min, formula); + + // Max case + double T_max = compute_thres(integral_sum_sum_2, row, col, win_max, formula); + + // Final threshold + double T = teta * T_max + (1 - teta) * T_min; + + mln_assertion(T_min <= 255); + mln_assertion(T_max <= 255); + mln_assertion(T <= 255); + + *out_ptr++ = *in_ptr++ <= T; + } + } + } + + trace::exiting("scribo::binarization::kim"); + return output; + } + + + template <typename I> + mln_ch_value(I, bool) + kim(const Image& input, unsigned window_size) + { + return kim(input, window_size, SCRIBO_DEFAULT_SAUVOLA_K); + } + +# endif // ! MLN_INCLUDE_ONLY + + } // end of namespace scribo::binarization + +} // end of namespace scribo + +#endif // ! SCRIBO_BINARIZATION_KIM_HH diff --git a/scribo/src/binarization/kim.cc b/scribo/src/binarization/kim.cc index aa81f50..9f9c38f 100644 --- a/scribo/src/binarization/kim.cc +++ b/scribo/src/binarization/kim.cc @@ -28,26 +28,18 @@ #include <cmath> #include <mln/core/image/image2d.hh> #include <mln/value/int_u8.hh> -#include <mln/io/magick/load.hh> -#include <mln/io/pbm/save.hh> +#include <mln/io/magick/all.hh> #include <mln/data/transform.hh> #include <mln/fun/v2v/rgb_to_luma.hh> - -#include <scribo/binarization/sauvola_ms.hh> +#include <scribo/binarization/kim.hh> #include <scribo/debug/option_parser.hh> #include <scribo/debug/logger.hh> -#include <scribo/util/integral_sum_sum2_functor.hh> - -#include <scribo/text/extract_lines.hh> -#include <scribo/debug/bboxes_enlarged_image.hh> -#include <algorithm> - static const scribo::debug::arg_data arg_desc[] = { { "input.*", "An image." }, - { "output.pbm", "A binary image." }, + { "output.*", "A binary image." }, {0, 0} }; @@ -67,59 +59,11 @@ static const scribo::debug::opt_data opt_desc[] = { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, { "k", "Sauvola's formulae parameter", "<value>", 0, 1, "0.34" }, - { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", - scribo::debug::check_sauvola_first_subsampling, 1, "3" }, { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; - - - -double -compute_thres(const mln::image2d<mln::util::couple<double,double> >& integral_sum_sum_2, - int row, int col, unsigned win_size, - const scribo::binarization::internal::sauvola_formula& formula) -{ - point2d - tl(row - win_size - 1, - col - win_size - 1), - br(row + win_size, - col + win_size); - - box2d b(tl, br); - b.crop_wrt(integral_sum_sum_2.domain()); - - point2d tr = b.pmax(); - tr.row() = b.pmin().row(); - point2d bl = b.pmin(); - bl.row() = b.pmax().row(); - - unsigned card_min = b.nsites() - b.height() - b.width() + 1; - - const mln::util::couple<double,double>& - D = integral_sum_sum_2(b.pmax()), - B = integral_sum_sum_2(tr), - C = integral_sum_sum_2(bl), - A = integral_sum_sum_2(b.pmin()); - - double sum = D.first() - B.first() - C.first() + A.first(); - double sum_2 = D.second() - B.second() - C.second() + A.second(); - double mean = sum / card_min; - - double num = (sum_2 - sum * sum / card_min); - double stddev; - if (num > 0) - stddev = std::sqrt(num / (card_min - 1)); - else - stddev = 0; - - return formula(mean, stddev); -} - - - int main(int argc, char *argv[]) { using namespace mln; @@ -142,16 +86,17 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); // Window size unsigned w_1 = atoi(options.opt_value("win-size").c_str()); - // First subsampling scale. - unsigned s = atoi(options.opt_value("s").c_str()); double k = atof(options.opt_value("k").c_str()); - if (verbose) - std::cout << "Using w_1=" << w_1 << " - s=" << s - << " - k=" << k << std::endl; + if (options.is_set("verbose")) + { + scribo::debug::logger().set_verbose_mode( + scribo::debug::txt_to_verbose_mode(options.opt_value("verbose"))); + scribo::debug::logger().log(Low, std::string("Using w_1=") + w_1 + + std::string(" - k=") + k); + } // Load image2d<value::rgb8> input_1; @@ -165,128 +110,8 @@ int main(int argc, char *argv[]) input_1_gl = data::transform(input_1, mln::fun::v2v::rgb_to_luma<value::int_u8>()); - // 1st simple binarization image2d<bool> - output = scribo::binarization::sauvola_ms(input_1_gl, w_1, s, k); - - mln::util::timer lt; - lt.start(); - - // Compute integral image - scribo::util::integral_sum_sum2_functor<value::int_u8,double> f_sum_sum2; - image2d<mln::util::couple<double,double> > - integral_sum_sum_2 = scribo::util::init_integral_image(input_1_gl, 1, f_sum_sum2); - - lt.stop(); - std::cout << "integral image - " << lt << std::endl; - lt.start(); - - // Find text lines - line_set<image2d<scribo::def::lbl_type> > - lines = scribo::text::extract_lines(output, c8()); - - typedef scribo::def::lbl_type V; - typedef image2d<V> L; - mln::util::array<unsigned> thickness(lines.nelements() + 1, 0); - const component_set<L>& comp_set = lines.components(); - const L& lbl = comp_set.labeled_image(); - - lt.stop(); - std::cout << "Text line finding - " << lt << std::endl; - lt.start(); - - // Compute run-lengths histogram in order to compute character - // thickness for each line. - for_all_lines(i, lines) - { - if (!lines(i).is_textline()) - continue; - - std::map<unsigned, unsigned> histo; - int count = 0; - for (int l = lines(i).bbox().pmin().row(); l <= lines(i).bbox().pmax().row(); ++l) - { - const V* end_ptr = &lbl.at_(l, lines(i).bbox().pmax().col() + 1); - for (const V* run_ptr = &lbl.at_(l, lines(i).bbox().pmin().col()); run_ptr != end_ptr; ++run_ptr) - if (*run_ptr) - ++count; - else - if (count) - { - if (histo.find(count) != histo.end()) - histo[count]++; - else - histo.insert(std::make_pair(count, 1)); - count = 0; - } - } - - unsigned max = 0; - unsigned thick = 0; - for (std::map<unsigned, unsigned>::const_iterator it = histo.begin(); it != histo.end(); ++it) - if (it->second > max) - { - max = it->second; - thick = it->first; - } - - thickness(lines(i).id()) = thick; - } - - lt.stop(); - std::cout << "run-lengths histogram - " << lt << std::endl; - - lt.start(); - // Compute thresholds for each pixel of each line and binarize again! - for_all_lines(i, lines) - { - if (!lines(i).is_textline()) - continue; - - double - win_min = thickness(lines(i).id()), - win_max = lines(i).bbox().height();; - - mln_assertion(win_min != 0); - mln_assertion(win_max != 0); - - scribo::binarization::internal::sauvola_formula formula; - - for (int row = lines(i).bbox().pmin().row(); - row <= lines(i).bbox().pmax().row(); - ++row) - { - bool* out_ptr = &output.at_(row, lines(i).bbox().pmin().col()); - value::int_u8* in_ptr = &input_1_gl.at_(row, lines(i).bbox().pmin().col()); - for (int col = lines(i).bbox().pmin().col(); - col <= lines(i).bbox().pmax().col(); - ++col) - { - // Min case - double T_min = compute_thres(integral_sum_sum_2, row, col, win_min, formula); - - // Max case - double T_max = compute_thres(integral_sum_sum_2, row, col, win_max, formula); - - // Final threshold - double teta = 0.3; // Good results from 0.1 to 0.3 according - // to the paper. - double T = teta * T_max + (1 - teta) * T_min; - - mln_assertion(T_min <= 255); - mln_assertion(T_max <= 255); - mln_assertion(T <= 255); - - *out_ptr++ = *in_ptr++ <= T; - } - } - } - - lt.stop(); - std::cout << "Last binarization - " << lt << std::endl; - - t.stop(); - std::cout << "Total time = " << t << std::endl; + output = scribo::binarization::kim(input_1_gl, w_1, k); - io::pbm::save(output, options.arg("output.pbm")); + io::magick::save(output, options.arg("output.*")); } diff --git a/scribo/tests/binarization/Makefile.am b/scribo/tests/binarization/Makefile.am index bac5a24..714bf93 100644 --- a/scribo/tests/binarization/Makefile.am +++ b/scribo/tests/binarization/Makefile.am @@ -21,6 +21,10 @@ include $(top_srcdir)/scribo/tests/tests.mk EXTRA_DIST = \ + kim.res.pbm \ + kim_wodd_heven.ref.pbm \ + kim_weven_hodd.ref.pbm \ + kim_wodd_hodd.ref.pbm \ niblack.res.pbm \ niblack_wodd_heven.ref.pbm \ niblack_weven_hodd.ref.pbm \ @@ -41,6 +45,7 @@ EXTRA_DIST = \ check_PROGRAMS = \ global_threshold \ + kim \ local_threshold \ niblack \ otsu \ @@ -50,6 +55,7 @@ check_PROGRAMS = \ global_threshold_SOURCES = global_threshold.cc +kim_SOURCES = kim.cc local_threshold_SOURCES = local_threshold.cc niblack_SOURCES = niblack.cc otsu_SOURCES = otsu.cc diff --git a/scribo/tests/binarization/sauvola.cc b/scribo/tests/binarization/kim.cc similarity index 77% copy from scribo/tests/binarization/sauvola.cc copy to scribo/tests/binarization/kim.cc index 54e8bbd..74e0eef 100644 --- a/scribo/tests/binarization/sauvola.cc +++ b/scribo/tests/binarization/kim.cc @@ -31,7 +31,7 @@ #include <mln/io/pgm/load.hh> #include <mln/io/pbm/load.hh> -#include <scribo/binarization/sauvola.hh> +#include <scribo/binarization/kim.hh> #include "tests/data.hh" @@ -44,10 +44,10 @@ int main() image2d<value::int_u8> input; io::pgm::load(input, MILENA_IMG_DIR "/lena.pgm"); - image2d<bool> bin = scribo::binarization::sauvola(input, 101); + image2d<bool> bin = scribo::binarization::kim(input, 101); image2d<bool> ref; - io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/sauvola.ref.pbm"); + io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/kim.ref.pbm"); mln_assertion(bin == ref); } @@ -57,10 +57,10 @@ int main() image2d<value::int_u8> input; io::pgm::load(input, SCRIBO_IMG_DIR "/lena_wodd_heven.pgm"); - image2d<bool> bin = scribo::binarization::sauvola(input, 101); + image2d<bool> bin = scribo::binarization::kim(input, 101); image2d<bool> ref; - io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/sauvola_wodd_heven.ref.pbm"); + io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/kim_wodd_heven.ref.pbm"); mln_assertion(bin == ref); } @@ -70,10 +70,10 @@ int main() image2d<value::int_u8> input; io::pgm::load(input, SCRIBO_IMG_DIR "/lena_weven_hodd.pgm"); - image2d<bool> bin = scribo::binarization::sauvola(input, 101); + image2d<bool> bin = scribo::binarization::kim(input, 101); image2d<bool> ref; - io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/sauvola_weven_hodd.ref.pbm"); + io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/kim_weven_hodd.ref.pbm"); mln_assertion(bin == ref); } @@ -83,10 +83,10 @@ int main() image2d<value::int_u8> input; io::pgm::load(input, SCRIBO_IMG_DIR "/lena_wodd_hodd.pgm"); - image2d<bool> bin = scribo::binarization::sauvola(input, 101); + image2d<bool> bin = scribo::binarization::kim(input, 101); image2d<bool> ref; - io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/sauvola_wodd_hodd.ref.pbm"); + io::pbm::load(ref, SCRIBO_TESTS_DIR "binarization/kim_wodd_hodd.ref.pbm"); mln_assertion(bin == ref); } diff --git a/scribo/tests/binarization/kim.ref.pbm b/scribo/tests/binarization/kim.ref.pbm new file mode 100644 index 0000000..d792130 Binary files /dev/null and b/scribo/tests/binarization/kim.ref.pbm differ diff --git a/scribo/tests/binarization/kim_weven_hodd.ref.pbm b/scribo/tests/binarization/kim_weven_hodd.ref.pbm new file mode 100644 index 0000000..45eab1d Binary files /dev/null and b/scribo/tests/binarization/kim_weven_hodd.ref.pbm differ diff --git a/scribo/tests/binarization/kim_wodd_heven.ref.pbm b/scribo/tests/binarization/kim_wodd_heven.ref.pbm new file mode 100644 index 0000000..1dc805f Binary files /dev/null and b/scribo/tests/binarization/kim_wodd_heven.ref.pbm differ diff --git a/scribo/tests/binarization/kim_wodd_hodd.ref.pbm b/scribo/tests/binarization/kim_wodd_hodd.ref.pbm new file mode 100644 index 0000000..5598763 Binary files /dev/null and b/scribo/tests/binarization/kim_wodd_hodd.ref.pbm differ -- 1.7.2.5

1 0

olena-2.0-98-g948844a Make use of new logger features.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

* src/binarization/global_threshold.cc, * src/binarization/kim.cc, * src/binarization/niblack.cc, * src/binarization/otsu.cc, * src/binarization/sauvola.cc, * src/binarization/sauvola_ms.cc, * src/binarization/sauvola_ms_debug.cc, * src/binarization/sauvola_ms_fg.cc, * src/binarization/sauvola_ms_split.cc, * src/binarization/wolf.cc: Make use of operator<<. --- scribo/src/binarization/global_threshold.cc | 10 +++++----- scribo/src/binarization/kim.cc | 13 +++++-------- scribo/src/binarization/niblack.cc | 10 +++++----- scribo/src/binarization/otsu.cc | 9 ++++----- scribo/src/binarization/sauvola.cc | 18 ++++++------------ scribo/src/binarization/sauvola_ms.cc | 21 ++++++++------------- scribo/src/binarization/sauvola_ms_debug.cc | 20 +++++++------------- scribo/src/binarization/sauvola_ms_fg.cc | 11 +++++------ scribo/src/binarization/sauvola_ms_split.cc | 15 ++++++--------- scribo/src/binarization/wolf.cc | 9 ++++----- 10 files changed, 55 insertions(+), 81 deletions(-) diff --git a/scribo/src/binarization/global_threshold.cc b/scribo/src/binarization/global_threshold.cc index 276ec2e..eaf11c7 100644 --- a/scribo/src/binarization/global_threshold.cc +++ b/scribo/src/binarization/global_threshold.cc @@ -1,4 +1,5 @@ -// Copyright (C) 2011 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2011, 2012 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -57,7 +58,8 @@ static const scribo::debug::opt_data opt_desc[] = // name, description, arguments, check args function, number of args, default arg { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, {0, 0, 0, 0, 0, 0} }; @@ -83,11 +85,9 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); unsigned threshold = atoi(options.arg("threshold_value")); - if (verbose) - std::cout << "Using threshold=" << threshold << std::endl; + scribo::debug::logger() << "Using threshold=" << threshold << std::endl; image2d<value::rgb8> input; io::magick::load(input, options.arg("input.*")); diff --git a/scribo/src/binarization/kim.cc b/scribo/src/binarization/kim.cc index 9f9c38f..0a064d8 100644 --- a/scribo/src/binarization/kim.cc +++ b/scribo/src/binarization/kim.cc @@ -59,7 +59,8 @@ static const scribo::debug::opt_data opt_desc[] = { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, { "k", "Sauvola's formulae parameter", "<value>", 0, 1, "0.34" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -90,13 +91,9 @@ int main(int argc, char *argv[]) unsigned w_1 = atoi(options.opt_value("win-size").c_str()); double k = atof(options.opt_value("k").c_str()); - if (options.is_set("verbose")) - { - scribo::debug::logger().set_verbose_mode( - scribo::debug::txt_to_verbose_mode(options.opt_value("verbose"))); - scribo::debug::logger().log(Low, std::string("Using w_1=") + w_1 - + std::string(" - k=") + k); - } + scribo::debug::logger() << "Using w_1=" << w_1 + << " - k=" << k << std::endl; + // Load image2d<value::rgb8> input_1; diff --git a/scribo/src/binarization/niblack.cc b/scribo/src/binarization/niblack.cc index 58074fc..7c14c45 100644 --- a/scribo/src/binarization/niblack.cc +++ b/scribo/src/binarization/niblack.cc @@ -1,4 +1,5 @@ -// Copyright (C) 2011 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2011, 2012 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -59,7 +60,8 @@ static const scribo::debug::opt_data opt_desc[] = { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, { "k", "Niblack's formulae parameter", "<value>", 0, 1, "-0.2" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -86,12 +88,10 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); unsigned w = atoi(options.opt_value("win-size").c_str()); double k = atof(options.opt_value("k").c_str()); - if (verbose) - std::cout << "Using w=" << w << " and k=" << k << std::endl; + scribo::debug::logger() << "Using w=" << w << " and k=" << k << std::endl; image2d<value::rgb8> input; io::magick::load(input, options.arg("input.*")); diff --git a/scribo/src/binarization/otsu.cc b/scribo/src/binarization/otsu.cc index eb60973..dcdae1d 100644 --- a/scribo/src/binarization/otsu.cc +++ b/scribo/src/binarization/otsu.cc @@ -1,4 +1,5 @@ -// Copyright (C) 2011 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2011, 2012 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -60,7 +61,8 @@ static const scribo::debug::opt_data opt_desc[] = // name, description, arguments, check args function, number of args, default arg { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, {0, 0, 0, 0, 0, 0} }; @@ -86,9 +88,6 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); - (void) verbose; - image2d<value::rgb8> input; io::magick::load(input, options.arg("input.*")); diff --git a/scribo/src/binarization/sauvola.cc b/scribo/src/binarization/sauvola.cc index 6ea224c..3549585 100644 --- a/scribo/src/binarization/sauvola.cc +++ b/scribo/src/binarization/sauvola.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Copyright (C) 2009, 2010, 2011, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -58,7 +58,8 @@ static const scribo::debug::opt_data opt_desc[] = { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, { "k", "Sauvola's formulae parameter", "<value>", 0, 1, "0.34" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -85,12 +86,10 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); unsigned w = atoi(options.opt_value("win-size").c_str()); double k = atof(options.opt_value("k").c_str()); - if (verbose) - std::cout << "Using w=" << w << " and k=" << k << std::endl; + scribo::debug::logger() << "Using w=" << w << " and k=" << k << std::endl; image2d<value::rgb8> input; io::magick::load(input, options.arg("input.*")); @@ -99,17 +98,12 @@ int main(int argc, char *argv[]) image2d<value::int_u8> input_1_gl = data::transform(input, mln::fun::v2v::rgb_to_luma<value::int_u8>()); - mln::util::timer t; - t.start(); + scribo::debug::logger().start_local_time_logging(); // Binarize image2d<bool> out = scribo::binarization::sauvola(input_1_gl, w, k); - if (verbose) - { - t.stop(); - std::cout << "binarized in " << t << "s" << std::endl; - } + scribo::debug::logger().stop_local_time_logging("Binarized in"); io::pbm::save(out, options.arg("output.pbm")); diff --git a/scribo/src/binarization/sauvola_ms.cc b/scribo/src/binarization/sauvola_ms.cc index d07de72..c5ab3e4 100644 --- a/scribo/src/binarization/sauvola_ms.cc +++ b/scribo/src/binarization/sauvola_ms.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Copyright (C) 2009, 2010, 2011, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -70,7 +70,8 @@ static const scribo::debug::opt_data opt_desc[] = { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", scribo::debug::check_sauvola_first_subsampling, 1, "3" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -102,7 +103,6 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); // Window size unsigned w_1 = atoi(options.opt_value("win-size").c_str()); // First subsampling scale. @@ -122,9 +122,8 @@ int main(int argc, char *argv[]) binarization::internal::k4 = atof(options.opt_value("k4").c_str()); } - if (verbose) - std::cout << "Using w_1=" << w_1 << " - s=" << s - << " - k=" << k << std::endl; + scribo::debug::logger() << "Using w_1=" << w_1 << " - s=" << s + << " - k=" << k << std::endl; @@ -137,18 +136,14 @@ int main(int argc, char *argv[]) input_1_gl = data::transform(input_1, mln::fun::v2v::rgb_to_luma<value::int_u8>()); - mln::util::timer t; - t.start(); + + scribo::debug::logger().start_local_time_logging(); // Binarize image2d<bool> output = scribo::binarization::sauvola_ms(input_1_gl, w_1, s, k); - if (verbose) - { - t.stop(); - std::cout << "binarized in " << t << "s" << std::endl; - } + scribo::debug::logger().stop_local_time_logging("Binarized in"); io::pbm::save(output, options.arg("output.pbm")); } diff --git a/scribo/src/binarization/sauvola_ms_debug.cc b/scribo/src/binarization/sauvola_ms_debug.cc index d89e9f4..251f0e8 100644 --- a/scribo/src/binarization/sauvola_ms_debug.cc +++ b/scribo/src/binarization/sauvola_ms_debug.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Copyright (C) 2009, 2010, 2011, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -72,7 +72,8 @@ static const scribo::debug::opt_data opt_desc[] = { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", scribo::debug::check_sauvola_first_subsampling, 1, "3" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -131,7 +132,6 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); // Window size unsigned w_1 = atoi(options.opt_value("win-size").c_str()); // First subsampling scale. @@ -142,9 +142,8 @@ int main(int argc, char *argv[]) binarization::internal::k3 = atof(options.opt_value("k3").c_str()); binarization::internal::k4 = atof(options.opt_value("k4").c_str()); - if (verbose) - std::cout << "Using w_1=" << w_1 << " - s=" << s - << " - k=" << k << std::endl; + scribo::debug::logger() << "Using w_1=" << w_1 << " - s=" << s + << " - k=" << k << std::endl; scribo::binarization::internal::scale_image_output = "scale_image.pgm"; scribo::binarization::internal::threshold_image_output = "threshold_image.pbm"; @@ -162,18 +161,13 @@ int main(int argc, char *argv[]) input_1_gl = data::transform(input_1, mln::fun::v2v::rgb_to_luma<value::int_u8>()); - mln::util::timer t; - t.start(); + scribo::debug::logger().start_local_time_logging(); // Binarize. image2d<bool> output = scribo::binarization::sauvola_ms(input_1_gl, w_1, s, k); - if (verbose) - { - t.stop(); - std::cout << "binarized in " << t << "s" << std::endl; - } + scribo::debug::logger().stop_local_time_logging("Binarized in"); # ifdef SCRIBO_LOCAL_THRESHOLD_DEBUG { diff --git a/scribo/src/binarization/sauvola_ms_fg.cc b/scribo/src/binarization/sauvola_ms_fg.cc index 83a48af..98206a8 100644 --- a/scribo/src/binarization/sauvola_ms_fg.cc +++ b/scribo/src/binarization/sauvola_ms_fg.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Copyright (C) 2009, 2010, 2011, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -65,7 +65,8 @@ static const scribo::debug::opt_data opt_desc[] = "useful if fg-extraction is enabled.", "<size>", 0, 1, "1024" }, { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", scribo::debug::check_sauvola_first_subsampling, 1, "3" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -92,7 +93,6 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); unsigned lambda = atoi(options.opt_value("lambda").c_str()); // Window size @@ -102,9 +102,8 @@ int main(int argc, char *argv[]) unsigned s = atoi(options.opt_value("s").c_str()); double k = atof(options.opt_value("k").c_str()); - if (verbose) - std::cout << "Using w_1=" << w_1 << " - s=" << s << " - k=" - << k << " - lambda=" << lambda << std::endl; + scribo::debug::logger() << "Using w_1=" << w_1 << " - s=" << s << " - k=" + << k << " - lambda=" << lambda << std::endl; Magick::InitializeMagick(0); diff --git a/scribo/src/binarization/sauvola_ms_split.cc b/scribo/src/binarization/sauvola_ms_split.cc index f71f734..f1cc490 100644 --- a/scribo/src/binarization/sauvola_ms_split.cc +++ b/scribo/src/binarization/sauvola_ms_split.cc @@ -1,5 +1,5 @@ -// Copyright (C) 2009, 2010 EPITA Research and Development Laboratory -// (LRDE) +// Copyright (C) 2009, 2010, 2012 EPITA Research and Development +// Laboratory (LRDE) // // This file is part of Olena. // @@ -67,7 +67,8 @@ static const scribo::debug::opt_data opt_desc[] = "<num>", scribo::debug::check_sauvola_split_ntrue, 1, "2" }, { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", scribo::debug::check_sauvola_first_subsampling, 1, "3" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size at scale 1", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -92,7 +93,6 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); // Window size unsigned w_1 = atoi(options.opt_value("win-size").c_str()); // Scale 1 @@ -105,11 +105,8 @@ int main(int argc, char *argv[]) binarization::internal::k3 = atof(options.opt_value("k3").c_str()); binarization::internal::k4 = atof(options.opt_value("k4").c_str()); - - if (verbose) - std::cout << "Using w_1=" << w_1 << " - s=" << s << " - k=" - << k << " - min_ntrue=" << min_ntrue << std::endl; - + scribo::debug::logger() << "Using w_1=" << w_1 << " - s=" << s << " - k=" + << k << " - min_ntrue=" << min_ntrue << std::endl; Magick::InitializeMagick(0); diff --git a/scribo/src/binarization/wolf.cc b/scribo/src/binarization/wolf.cc index c481e09..4495f64 100644 --- a/scribo/src/binarization/wolf.cc +++ b/scribo/src/binarization/wolf.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Copyright (C) 2009, 2010, 2011, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -58,7 +58,8 @@ static const scribo::debug::opt_data opt_desc[] = { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, { "k", "Wolf's formulae parameter", "<value>", 0, 1, "0.34" }, - { "verbose", "Enable verbose mode", 0, 0, 0, 0 }, + { "verbose", "Enable verbose mode (mute, time, low, medium, full)", + "<mode>", scribo::debug::check_verbose_mode, 1, "mute" }, { "win-size", "Window size", "<size>", 0, 1, "101" }, {0, 0, 0, 0, 0, 0} }; @@ -85,12 +86,10 @@ int main(int argc, char *argv[]) trace::entering("main"); - bool verbose = options.is_set("verbose"); unsigned w = atoi(options.opt_value("win-size").c_str()); double k = atof(options.opt_value("k").c_str()); - if (verbose) - std::cout << "Using w=" << w << " and k=" << k << std::endl; + scribo::debug::logger() << "Using w=" << w << " and k=" << k << std::endl; image2d<value::rgb8> input; io::magick::load(input, options.arg("input.*")); -- 1.7.2.5

1 0

olena-2.0-99-gab0cdca Fix call to sauvola_ms.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

* scribo/binarization/sauvola_ms.hh, * scribo/binarization/sauvola_ms_split.hh: Here. --- scribo/scribo/binarization/sauvola_ms.hh | 4 ++-- scribo/scribo/binarization/sauvola_ms_split.hh | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scribo/scribo/binarization/sauvola_ms.hh b/scribo/scribo/binarization/sauvola_ms.hh index 5f0f963..3d04629 100644 --- a/scribo/scribo/binarization/sauvola_ms.hh +++ b/scribo/scribo/binarization/sauvola_ms.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Copyright (C) 2009, 2010, 2011, 2012 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -1047,7 +1047,7 @@ namespace scribo integral_t integral_sum_sum_2; mln_ch_value(I,bool) - output = sauvola_ms(exact(input_1_), w_1, s, K, integral_sum_sum_2); + output = sauvola_ms(input_1_, w_1, s, K, integral_sum_sum_2); trace::exiting("scribo::binarization::sauvola_ms"); return output; diff --git a/scribo/scribo/binarization/sauvola_ms_split.hh b/scribo/scribo/binarization/sauvola_ms_split.hh index cbef524..ff16a4e 100644 --- a/scribo/scribo/binarization/sauvola_ms_split.hh +++ b/scribo/scribo/binarization/sauvola_ms_split.hh @@ -107,9 +107,9 @@ namespace scribo bin_t r_b, g_b, b_b; - r_b = impl::generic::sauvola_ms(r_i, w_1, s, K); - g_b = impl::generic::sauvola_ms(g_i, w_1, s, K); - b_b = impl::generic::sauvola_ms(b_i, w_1, s, K); + r_b = sauvola_ms(r_i, w_1, s, K); + g_b = sauvola_ms(g_i, w_1, s, K); + b_b = sauvola_ms(b_i, w_1, s, K); border::resize(r_b, input_1.border()); border::resize(g_b, input_1.border()); -- 1.7.2.5

1 0

olena-2.0-100-g2f3154f Fix arguments.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

--- scribo/src/binarization/sauvola_ms.cc | 34 +++++++++++++++++--------------- 1 files changed, 18 insertions(+), 16 deletions(-) diff --git a/scribo/src/binarization/sauvola_ms.cc b/scribo/src/binarization/sauvola_ms.cc index c5ab3e4..685337c 100644 --- a/scribo/src/binarization/sauvola_ms.cc +++ b/scribo/src/binarization/sauvola_ms.cc @@ -60,12 +60,12 @@ static const scribo::debug::opt_data opt_desc[] = // name, description, arguments, check args function, number of args, default arg { "debug-prefix", "Enable debug image outputs. Prefix image name with that " "given prefix.", "<prefix>", 0, 1, 0 }, - { "k", "Sauvola's formulae parameter. Set it globally for all scales.", + { "all-k", "Sauvola's formulae parameter. Set it globally for all scales.", "<value>", 0, 1, "0.34" }, - { "k2", "Sauvola's formulae parameter", "<value>", 0, 1, "0.20" }, - { "k3", "Sauvola's formulae parameter", "<value>", 0, 1, "0.30" }, - { "k4", "Sauvola's formulae parameter", "<value>", 0, 1, "0.50" }, + { "k2", "Force Sauvola's formulae parameter value for scale 2", "<value>", 0, 1, 0 }, + { "k3", "Force Sauvola's formulae parameter value for scale 3", "<value>", 0, 1, 0 }, + { "k4", "Force Sauvola's formulae parameter value for scale 4", "<value>", 0, 1, 0 }, { "s", "First subsampling ratio. Possible values: 2 or 3.", "ratio", @@ -107,24 +107,26 @@ int main(int argc, char *argv[]) unsigned w_1 = atoi(options.opt_value("win-size").c_str()); // First subsampling scale. unsigned s = atoi(options.opt_value("s").c_str()); - double k = atof(options.opt_value("k").c_str()); - if (options.is_set("k")) - { - binarization::internal::k2 = k; - binarization::internal::k3 = k; - binarization::internal::k4 = k; - } - else - { + // Setting k parameter. + double k = atof(options.opt_value("all-k").c_str()); + binarization::internal::k2 = k; + binarization::internal::k3 = k; + binarization::internal::k4 = k; + + // Override k parameter for specific scales. + if (options.is_set("k2")) binarization::internal::k2 = atof(options.opt_value("k2").c_str()); + if (options.is_set("k3")) binarization::internal::k3 = atof(options.opt_value("k3").c_str()); + if (options.is_set("k4")) binarization::internal::k4 = atof(options.opt_value("k4").c_str()); - } scribo::debug::logger() << "Using w_1=" << w_1 << " - s=" << s - << " - k=" << k << std::endl; - + << " - k2=" << binarization::internal::k2 + << " - k3=" << binarization::internal::k3 + << " - k4=" << binarization::internal::k4 + << std::endl; // Load -- 1.7.2.5

1 0

olena-2.0-101-g73d0b5d Make use of logger features.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

* scribo/binarization/internal/local_threshold_core.hh, * scribo/binarization/internal/sauvola_formula.hh, * scribo/binarization/sauvola_ms.hh: Make use of operator<< with debug::logger. --- scribo/ChangeLog | 9 ++++ .../binarization/internal/local_threshold_core.hh | 16 +++---- .../binarization/internal/sauvola_formula.hh | 18 +-------- scribo/scribo/binarization/sauvola_ms.hh | 40 +++++++++----------- 4 files changed, 36 insertions(+), 47 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index f8d7491..b965146 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,3 +1,12 @@ +2012-05-11 Guillaume Lazzara <z(a)lrde.epita.fr> + + Make use of logger features. + + * scribo/binarization/internal/local_threshold_core.hh, + * scribo/binarization/internal/sauvola_formula.hh, + * scribo/binarization/sauvola_ms.hh: Make use of operator<< with + debug::logger. + 2012-05-10 Guillaume Lazzara <z(a)lrde.epita.fr> Improve option parser. diff --git a/scribo/scribo/binarization/internal/local_threshold_core.hh b/scribo/scribo/binarization/internal/local_threshold_core.hh index 7979da3..7589499 100644 --- a/scribo/scribo/binarization/internal/local_threshold_core.hh +++ b/scribo/scribo/binarization/internal/local_threshold_core.hh @@ -1,4 +1,5 @@ -// Copyright (C) 2011 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2011, 2012 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -51,7 +52,6 @@ # include <mln/debug/filename.hh> # endif // ! SCRIBO_LOCAL_THRESHOLD_DEBUG -# include <mln/util/timer.hh> namespace scribo { @@ -122,8 +122,7 @@ namespace scribo trace::entering("scribo::binarization::internal::impl::generic::local_threshold_core"); mln_precondition(exact(input).is_valid()); - mln::util::timer t; - t.start(); + scribo::debug::logger().start_local_time_logging(); // Make sure the image sizes are a multiple of 3 in each // dimension. (browsing while binarizing relies on that @@ -140,8 +139,7 @@ namespace scribo sub_domains[2].first(), sub_domains[2].second()); - t.stop(); - std::cout << "image integrale - " << t << std::endl; + scribo::debug::logger().stop_local_time_logging("image integrale -"); # ifdef SCRIBO_LOCAL_THRESHOLD_DEBUG initialize(internal::debug_mean, input); @@ -152,7 +150,7 @@ namespace scribo initialize(internal::debug_alphacond, input); # endif // ! SCRIBO_LOCAL_THRESHOLD_DEBUG - t.restart(); + scribo::debug::logger().start_local_time_logging(); window_size /= 3; if (window_size % 2) @@ -162,8 +160,8 @@ namespace scribo scribo::canvas::integral_browsing(integral, 1, window_size, window_size, 3, f); - t.stop(); - std::cout << "Binarization - " << t << std::endl; + + scribo::debug::logger().stop_local_time_logging("Binarization -"); trace::exiting("scribo::binarization::internal::impl::generic::local_threshold_core"); } diff --git a/scribo/scribo/binarization/internal/sauvola_formula.hh b/scribo/scribo/binarization/internal/sauvola_formula.hh index a06d6f9..005c034 100644 --- a/scribo/scribo/binarization/internal/sauvola_formula.hh +++ b/scribo/scribo/binarization/internal/sauvola_formula.hh @@ -1,4 +1,5 @@ -// Copyright (C) 2011 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2011, 2012 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -48,8 +49,6 @@ #include <mln/core/alias/point2d.hh> -// extern mln::image2d<bool> skewness_pbm; - namespace scribo { @@ -89,25 +88,12 @@ namespace scribo # ifndef MLN_INCLUDE_ONLY - // bool b; - // double skewness_; - inline double sauvola_formula::operator()(const double m_x_y, const double s_x_y, const double K, const double R) const { - // if (b) - // std::cout << skewness_ << " - " << (K * -1 * skewness_) << std::endl; - // volatile double new_t = ((skewness_ < 0) ? -skewness_ : 1 * m_x_y * (1.0 + K * ((s_x_y / R) - 1.0))); - // volatile double old_t = (m_x_y * (1.0 + K * ((s_x_y / R) - 1.0))); - // if (skewness_ > 0) - // if (new_t != old_t) - // std::cout << skewness_ << " - " << new_t << " vs " << old_t << std::endl; - // if (skewness_pbm(p)) return m_x_y * (1.0 + K * ((s_x_y / R) - 1.0)); - // else - // return (255 - m_x_y) * (1.0 + K * ((s_x_y / R) - 1.0)); } inline diff --git a/scribo/scribo/binarization/sauvola_ms.hh b/scribo/scribo/binarization/sauvola_ms.hh index 3d04629..b1e8144 100644 --- a/scribo/scribo/binarization/sauvola_ms.hh +++ b/scribo/scribo/binarization/sauvola_ms.hh @@ -78,7 +78,6 @@ # include <mln/accu/math/count.hh> # endif // ! SCRIBO_LOCAL_THRESHOLD_DEBUG -# include <mln/util/timer.hh> namespace scribo { @@ -838,8 +837,7 @@ namespace scribo typedef image2d<mln::util::couple<double,double> > integral_t; // integral_t integral_sum_sum_2; - mln::util::timer t; - t.start(); + scribo::debug::logger().start_local_time_logging(); // Subsampling from scale 1 to 2. { @@ -852,9 +850,8 @@ namespace scribo sub_ima.append(fi.sub); } - t.stop(); - std::cout << "1. subsampling and integral - " << t << std::endl; - t.restart(); + scribo::debug::logger().stop_local_time_logging("1. subsampling and integral -"); + scribo::debug::logger().start_local_time_logging(); // Subsampling to scale 3 and 4. // @@ -865,9 +862,8 @@ namespace scribo sub_domains[i].first(), sub_domains[i].second())); - t.stop(); - std::cout << "2. More subsampling - " << t << std::endl; - t.restart(); + scribo::debug::logger().stop_local_time_logging("2. More subsampling -"); + scribo::debug::logger().start_local_time_logging(); // Compute threshold images. image2d<int_u8> e_2; @@ -951,9 +947,8 @@ namespace scribo K); } - t.stop(); - std::cout << "3. Multi-scale processing - " << t << std::endl; - t.restart(); + scribo::debug::logger().stop_local_time_logging("3. Multi-scale processing -"); + scribo::debug::logger().start_local_time_logging(); # ifdef SCRIBO_LOCAL_THRESHOLD_DEBUG @@ -965,9 +960,8 @@ namespace scribo // Propagate scale values. e_2 = transform::influence_zone_geodesic(e_2, c8()); - t.stop(); - std::cout << "4. Influence Zone on Scale image - " << t << std::endl; - t.restart(); + scribo::debug::logger().stop_local_time_logging("4. Influence Zone on Scale image -"); + scribo::debug::logger().start_local_time_logging(); # ifdef SCRIBO_LOCAL_THRESHOLD_DEBUG @@ -980,10 +974,13 @@ namespace scribo mln::util::array<unsigned> count = labeling::compute(accu::meta::math::count(), e_2, 4); unsigned npixels = e_2.domain().nsites(); - std::cout << "Scale ratios: 2 (" << count[2] / (float)npixels * 100 - << ") - 3 (" << count[3] / (float)npixels * 100 - << ") - 4 (" << count[4] / (float)npixels * 100 << ")" - << std::endl; + scribo::debug::logger() << "Scale ratios: 2 (" + << count[2] / (float)npixels * 100 + << ") - 3 (" + << count[3] / (float)npixels * 100 + << ") - 4 (" + << count[4] / (float)npixels * 100 << ")" + << std::endl; if (internal::scale_proba_output) io::dump::save(internal::debug_scale_proba, @@ -994,9 +991,8 @@ namespace scribo image2d<bool> output = internal::multi_scale_binarization(input_1, e_2, t_ima, s); - t.stop(); - std::cout << "5. Final binarization - " << t << std::endl; - t.restart(); + scribo::debug::logger().stop_local_time_logging("5. Final binarization -"); + scribo::debug::logger().start_local_time_logging(); trace::exiting("scribo::binarization::sauvola_ms"); return output; -- 1.7.2.5

1 0

olena-2.0-102-g9bf1541 Add a default verbose mode in debug::logger.
by Guillaume Lazzara 22 Jun '12

22 Jun '12

* scribo/debug/logger.hh: Here. --- scribo/ChangeLog | 6 ++++++ scribo/scribo/debug/logger.hh | 34 ++++++++++++++++++++++++++++++++-- 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index b965146..cc3608f 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,11 @@ 2012-05-11 Guillaume Lazzara <z(a)lrde.epita.fr> + Add a default verbose mode in debug::logger. + + * scribo/debug/logger.hh: Here. + +2012-05-11 Guillaume Lazzara <z(a)lrde.epita.fr> + Make use of logger features. * scribo/binarization/internal/local_threshold_core.hh, diff --git a/scribo/scribo/debug/logger.hh b/scribo/scribo/debug/logger.hh index 5822cf3..cac2770 100644 --- a/scribo/scribo/debug/logger.hh +++ b/scribo/scribo/debug/logger.hh @@ -101,6 +101,13 @@ namespace scribo bool is_verbose() const; bool is_at_verbose_mode(VerboseMode mode) const; + /// The default verbose mode used while logging with + /// #operator<<. + bool set_default_verbose_mode(VerboseMode mode); + VerboseMode default_verbose_mode() const; + + /// Set the current verbose mode, filtering the debug output + /// logged through this object. bool set_verbose_mode(VerboseMode mode); VerboseMode verbose_mode() const; @@ -194,6 +201,7 @@ namespace scribo Level level_; VerboseMode verbose_mode_; + VerboseMode default_verbose_mode_; std::string verbose_prefix_; std::ostream& stream_; @@ -234,6 +242,7 @@ namespace scribo logger_::logger_() : level_(None), verbose_mode_(Mute), + default_verbose_mode_(Low), stream_(std::cerr), verbose_prefix_("LOG: ") { @@ -267,6 +276,27 @@ namespace scribo inline bool + logger_::set_default_verbose_mode(VerboseMode mode) + { + if (mode != Invalid) + { + default_verbose_mode_ = mode; + return true; + } + return false; + } + + + inline + VerboseMode + logger_::default_verbose_mode() const + { + return default_verbose_mode_; + } + + + inline + bool logger_::set_verbose_mode(VerboseMode mode) { if (mode != Invalid) @@ -475,7 +505,7 @@ namespace scribo logger_& logger_::operator<<(const V& v) { - if (verbose_mode_ >= Low) + if (verbose_mode_ >= default_verbose_mode_) stream_ << v; return *this; } @@ -484,7 +514,7 @@ namespace scribo logger_& logger_::operator<<(std::ostream& (*f)(std::ostream&)) { - if (verbose_mode_ >= Low) + if (verbose_mode_ >= default_verbose_mode_) f(stream_); return *this; } -- 1.7.2.5

1 0