May 2009 - Olena-patches

[PATCH 18/31] Adjust .gitignore files.
by Roland Levillain 15 May '09

15 May '09

* .gitignore: Ignore patterns *.pyc and *.stamp globally. * build-aux/.gitignore: Remove local pattern *.pyc. * milena/doc/.gitignore: Remove local pattern headers.stamp. --- .gitignore | 4 ++-- ChangeLog | 8 ++++++++ build-aux/.gitignore | 1 - milena/doc/.gitignore | 1 - 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index b130779..a7d574a 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,8 @@ # Global. *~ *.dSYM +*.pyc +*.stamp .deps Makefile.in Makefile @@ -8,8 +10,6 @@ Makefile # Local. /*-stamp /*.patch -/*.pyc -/*.stamp /*TAGS /*aclocal.m4 /*stamp-* diff --git a/ChangeLog b/ChangeLog index 494377a..64868be 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2009-05-14 Roland Levillain <roland(a)lrde.epita.fr> + + Adjust .gitignore files. + + * .gitignore: Ignore patterns *.pyc and *.stamp globally. + * build-aux/.gitignore: Remove local pattern *.pyc. + * milena/doc/.gitignore: Remove local pattern headers.stamp. + 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> Use more canonical names to handle the configuration of Swilena. diff --git a/build-aux/.gitignore b/build-aux/.gitignore index d96c228..fb342f9 100644 --- a/build-aux/.gitignore +++ b/build-aux/.gitignore @@ -13,7 +13,6 @@ /missing /*.patch /patches* -/*.pyc /py-compile /*.rej /*TAGS diff --git a/milena/doc/.gitignore b/milena/doc/.gitignore index f107fe3..642caef 100644 --- a/milena/doc/.gitignore +++ b/milena/doc/.gitignore @@ -1,3 +1,2 @@ /Doxyfile -/headers.stamp /html/ -- 1.6.1.2

1 0

[PATCH 17/31] Clean up Milena's top-level Makefile.am.
by Roland Levillain 15 May '09

15 May '09

* Makefile.am (EXTRA_DIST): Remove tools, tools/area_flooding.cc and tools/seed2tiling.cc. Reindent. --- milena/ChangeLog | 8 ++++++ milena/Makefile.am | 64 +++++++++++++++++++++++---------------------------- 2 files changed, 37 insertions(+), 35 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 51618ca..d5f79b1 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,13 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Clean up Milena's top-level Makefile.am. + + * Makefile.am (EXTRA_DIST): Remove tools, tools/area_flooding.cc and + tools/seed2tiling.cc. + Reindent. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Use conditional ENABLE_TRIMESH. * apps/statues/Makefile.am [ENABLE_TRIMESH]: Compile diff --git a/milena/Makefile.am b/milena/Makefile.am index a854381..e186158 100644 --- a/milena/Makefile.am +++ b/milena/Makefile.am @@ -30,44 +30,38 @@ regen-dist: $(srcdir)/headers.mk # # $< $@.tmp && mv -f $@.tmp $@ && chmod -w $@ # +EXTRA_DIST = generate_dist_headers.sh $(srcdir)/headers.mk: $(srcdir)/generate_dist_headers.sh cd $(srcdir) && ./generate_dist_headers.sh && chmod -w headers.mk include $(srcdir)/headers.mk -EXTRA_DIST = \ -img/README \ -img/fly.pbm \ -img/fly.pgm \ -img/fly.ppm \ -img/lena.pbm \ -img/lena.pgm \ -img/lena.ppm \ -img/lena_16.ppm \ -img/medium.pgm \ -img/medium.ppm \ -img/picasso.pbm \ -img/picasso.pgm \ -img/quite-small.pgm \ -img/small.pbm \ -img/small.pgm \ -img/small.ppm \ -img/squares-lc.pgm \ -img/squares.pgm \ -img/test.fits \ -img/tiny.pbm \ -img/tiny.pgm \ -img/tiny.ppm \ -img/toto.pbm - -EXTRA_DIST += \ -tests/img/test_rgb8.tif \ -tests/img/test_bw.tif \ -tests/img/test_gl.tif - -EXTRA_DIST += \ -generate_dist_headers.sh\ -tools \ -tools/area_flooding.cc \ -tools/seed2tiling.cc +EXTRA_DIST += \ + img/README \ + img/fly.pbm \ + img/fly.pgm \ + img/fly.ppm \ + img/lena.pbm \ + img/lena.pgm \ + img/lena.ppm \ + img/lena_16.ppm \ + img/medium.pgm \ + img/medium.ppm \ + img/picasso.pbm \ + img/picasso.pgm \ + img/quite-small.pgm \ + img/small.pbm \ + img/small.pgm \ + img/small.ppm \ + img/squares-lc.pgm \ + img/squares.pgm \ + img/test.fits \ + img/tiny.pbm \ + img/tiny.pgm \ + img/tiny.ppm \ + img/toto.pbm +EXTRA_DIST += \ + tests/img/test_rgb8.tif \ + tests/img/test_bw.tif \ + tests/img/test_gl.tif -- 1.6.1.2

1 0

[PATCH 16/31] Use conditional ENABLE_TRIMESH.
by Roland Levillain 15 May '09

15 May '09

* apps/statues/Makefile.am [ENABLE_TRIMESH]: Compile mesh-pinv-curv and mesh-max-curv. --- milena/ChangeLog | 7 +++++++ milena/apps/statues/Makefile.am | 35 ++++++++++++++++++++++------------- 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 5ed7f50..51618ca 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,12 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Use conditional ENABLE_TRIMESH. + + * apps/statues/Makefile.am [ENABLE_TRIMESH]: Compile + mesh-pinv-curv and mesh-max-curv. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Address comparisons of signed vs unsigned in apps/statues/. * apps/statues/io.hh: Use unsigned loop indices. diff --git a/milena/apps/statues/Makefile.am b/milena/apps/statues/Makefile.am index 3c04596..bf0aa4c 100644 --- a/milena/apps/statues/Makefile.am +++ b/milena/apps/statues/Makefile.am @@ -19,18 +19,21 @@ AM_CXXFLAGS = -Wall -Wextra -ggdb -O3 -DNDEBUG LDFLAGS_trimesh = $(GLFLAGS) LDADD_trimesh = -L$(top_builddir)/external/trimesh/libsrc -ltrimesh $(GLLIBS) -# FIXME: Have program names embed the type of structure used (either -# graph or complex). bin_PROGRAMS = TESTS = -## FIXME: Programs' names should reflect a dependency on Trimesh, if any. +# FIXME: Have program names embed the type of structure used (either +# graph or complex). + +## FIXME: Likewise, programs' names should reflect a dependency on +## Trimesh, if any. ## ------------------------------------------------ ## ## Graph-based applications, depending on Trimesh. ## ## ------------------------------------------------ ## +if ENABLE_TRIMESH # bin_PROGRAMS += mesh-segm mesh-skel # # mesh_segm_SOURCES = mesh-segm.cc io.hh @@ -47,28 +50,34 @@ TESTS = # mesh_skel_CPPFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS_trimesh) # mesh_skel_LDFLAGS = $(LDFLAGS_trimesh) # mesh_skel_LDADD = $(LDADD_trimesh) +endif ENABLE_TRIMESH ## -------------------------------------------------- ## ## Complex-based applications, depending on Trimesh. ## ## -------------------------------------------------- ## -bin_PROGRAMS += mesh-pinv-curv mesh-max-curv +if ENABLE_TRIMESH + bin_PROGRAMS += mesh-pinv-curv mesh-max-curv -mesh_pinv_curv_SOURCES = mesh-pinv-curv.cc io.hh -mesh_pinv_curv_CPPFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS_trimesh) -mesh_pinv_curv_LDFLAGS = $(LDFLAGS_trimesh) -mesh_pinv_curv_LDADD = $(LDADD_trimesh) + mesh_pinv_curv_SOURCES = mesh-pinv-curv.cc io.hh + mesh_pinv_curv_CPPFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS_trimesh) + mesh_pinv_curv_LDFLAGS = $(LDFLAGS_trimesh) + mesh_pinv_curv_LDADD = $(LDADD_trimesh) -mesh_max_curv_SOURCES = mesh-max-curv.cc io.hh -mesh_max_curv_CPPFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS_trimesh) -mesh_max_curv_LDFLAGS = $(LDFLAGS_trimesh) -mesh_max_curv_LDADD = $(LDADD_trimesh) -TESTS += test-mesh-max-curv + mesh_max_curv_SOURCES = mesh-max-curv.cc io.hh + mesh_max_curv_CPPFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS_trimesh) + mesh_max_curv_LDFLAGS = $(LDFLAGS_trimesh) + mesh_max_curv_LDADD = $(LDADD_trimesh) + TESTS += test-mesh-max-curv +endif ENABLE_TRIMESH ## ---------------------------------------------------- ## ## Complex-based applications, independent of Trimesh. ## ## ---------------------------------------------------- ## +# A Milena re-implementation of some features from Trimesh. This code +# is completely independent from the Trimesh library. +# FIXME: Change the name of this directory, as it is confusing. noinst_HEADERS = trimesh/misc.hh EXTRA_DIST = trimesh/README -- 1.6.1.2

1 0

[PATCH 15/31] Use more canonical names to handle the configuration of Swilena.
by Roland Levillain 15 May '09

15 May '09

* configure.ac: s/with_swilena/enable_swilena/. (ENABLE_SWILENA): Adjust conditional. --- ChangeLog | 7 +++++++ configure.ac | 6 ++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index d64a04d..494377a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Use more canonical names to handle the configuration of Swilena. + + * configure.ac: s/with_swilena/enable_swilena/. + (ENABLE_SWILENA): Adjust conditional. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Make Milena tools (milena/tools/) optional. * configure.ac: Add option `--enable-tools'. diff --git a/configure.ac b/configure.ac index 7b0aacb..48a849c 100644 --- a/configure.ac +++ b/configure.ac @@ -130,11 +130,9 @@ AC_CONFIG_SUBDIRS([external/trimesh]) ## Swilena. ## ## --------- ## -OLN_WITH_SWILENA([with_swilena=yes], [with_swilena=no]) -AM_CONDITIONAL([ENABLE_SWILENA], [test x$with_swilena = xyes]) +OLN_WITH_SWILENA([enable_swilena=yes], []) +AM_CONDITIONAL([ENABLE_SWILENA], [test x$enable_swilena = xyes]) -# FIXME: Should we still configure these files if ENABLE_SWILENA is -# false? AC_CONFIG_FILES([swilena/Makefile swilena/python/Makefile]) -- 1.6.1.2

1 0

[PATCH 14/31] Make Milena tools (milena/tools/) optional.
by Roland Levillain 15 May '09

15 May '09

* configure.ac: Add option `--enable-tools'. (ENABLE_TOOLS): New conditional. Gather lines related to tools. * milena/Makefile.am (SUBDIRS) [ENABLE_TOOLS]: Add tools. --- ChangeLog | 9 +++++++++ configure.ac | 30 ++++++++++++++++++++---------- milena/Makefile.am | 4 ++++ 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index ff0d142..d64a04d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Make Milena tools (milena/tools/) optional. + + * configure.ac: Add option `--enable-tools'. + (ENABLE_TOOLS): New conditional. + Gather lines related to tools. + * milena/Makefile.am (SUBDIRS) [ENABLE_TOOLS]: Add tools. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Make Milena applications (milena/apps/) optional. * configure.ac: Add option `--enable-apps'. diff --git a/configure.ac b/configure.ac index 5cb3f06..7b0aacb 100644 --- a/configure.ac +++ b/configure.ac @@ -87,15 +87,7 @@ if test "$GXX" = yes && test -z "$TESTS_CXXFLAGS_DEBUG"; then TESTS_CXXFLAGS_DEBUG="-O0 -ggdb -Wall -W -D_GLIBCXX_DEBUG -D_GLIBCXX_CONCEPT_CHECKS" fi -# ----------------- # -# Flags for tools. # -# ----------------- # -AC_ARG_VAR([TOOLS_CXXFLAGS]) -# We want fast binaries for tools. -if test "$GXX" = yes && test -z "$TOOLS_CXXFLAGS"; then - TOOLS_CXXFLAGS="-O3 -DNDEBUG -ggdb -Wall -W" -fi ## ------------------ ## @@ -176,10 +168,8 @@ AC_CONFIG_FILES([ milena/doc/tutorial/Makefile milena/doc/white_paper/Makefile milena/mesh/Makefile - milena/tools/Makefile ]) - ## ------- ## ## Tests. ## ## ------- ## @@ -333,4 +323,24 @@ if test "$GXX" = yes && test -z "$APPS_CXXFLAGS"; then APPS_CXXFLAGS="-O3 -DNDEBUG -ggdb -Wall -W" fi +## ------- ## +## Tools. ## +## ------- ## + +AC_ARG_ENABLE([tools], + [AS_HELP_STRING([--enable-tools], + [enable tools])]) +AM_CONDITIONAL([ENABLE_TOOLS], [test "x$enable_tools" = "xyes"]) + +# Ask for the creation of tools' Makefiles. +AC_CONFIG_FILES([milena/tools/Makefile]) + +# Flags for tools. +AC_ARG_VAR([TOOLS_CXXFLAGS]) +# We want fast binaries for tools. +if test "$GXX" = yes && test -z "$TOOLS_CXXFLAGS"; then + TOOLS_CXXFLAGS="-O3 -DNDEBUG -ggdb -Wall -W" +fi + + AC_OUTPUT diff --git a/milena/Makefile.am b/milena/Makefile.am index e267598..a854381 100644 --- a/milena/Makefile.am +++ b/milena/Makefile.am @@ -9,6 +9,10 @@ if ENABLE_APPS SUBDIRS += apps endif ENABLE_APPS +if ENABLE_TOOLS + SUBDIRS += tools +endif ENABLE_TOOLS + .PHONY: doc tutorial tools doc: -- 1.6.1.2

1 0

[PATCH 13/31] Make Milena applications (milena/apps/) optional.
by Roland Levillain 15 May '09

15 May '09

* configure.ac: Add option `--enable-apps'. (ENABLE_APPS): New conditional. Always configure milena/apps/Makefile and milena/apps/statues/Makefile. Populate APPS_CXXFLAGS with default flags. * milena/Makefile.am (SUBDIRS) [ENABLE_APPS]: Add apps. --- ChangeLog | 11 +++++++++++ configure.ac | 23 ++++++++++++++++------- milena/Makefile.am | 6 ++++-- 3 files changed, 31 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3f7ea4c..ff0d142 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,16 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Make Milena applications (milena/apps/) optional. + + * configure.ac: Add option `--enable-apps'. + (ENABLE_APPS): New conditional. + Always configure milena/apps/Makefile and + milena/apps/statues/Makefile. + Populate APPS_CXXFLAGS with default flags. + * milena/Makefile.am (SUBDIRS) [ENABLE_APPS]: Add apps. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Improve configure.ac w.r.t. Trimesh. * m4/trimesh.m4: Remove, and move relevant lines... diff --git a/configure.ac b/configure.ac index 6b46bc8..5cb3f06 100644 --- a/configure.ac +++ b/configure.ac @@ -298,14 +298,16 @@ AC_CONFIG_FILES([ ## Applications. ## ## -------------- ## -# FIXME: Don't build applications depending on Trimesh if Trimesh is not built. +AC_ARG_ENABLE([apps], + [AS_HELP_STRING([--enable-apps], + [enable application])]) +AM_CONDITIONAL([ENABLE_APPS], [test "x$enable_apps" = "xyes"]) + # Ask for the creation of applications' Makefiles. -# FIXME: Should it be achieved through oln.m4 macros, as we did in Olena 0.11? -# FIXME: ENABLE IT -#AC_CONFIG_FILES([ -# milena/apps/Makefile -# milena/apps/statues/Makefile -#]) +AC_CONFIG_FILES([ + milena/apps/Makefile + milena/apps/statues/Makefile +]) # Configure tests. # FIXME: Consider using `sed' instead of `configure' to create these @@ -324,4 +326,11 @@ AC_CONFIG_FILES([milena/apps/statues/test-mesh-complex-max-curv-segm], AC_CONFIG_FILES([milena/apps/statues/test-mesh-complex-skel], [chmod +x milena/apps/statues/test-mesh-complex-skel]) +# Flags for apps. +AC_ARG_VAR([APPS_CXXFLAGS]) +# We want fast binaries for apps. +if test "$GXX" = yes && test -z "$APPS_CXXFLAGS"; then + APPS_CXXFLAGS="-O3 -DNDEBUG -ggdb -Wall -W" +fi + AC_OUTPUT diff --git a/milena/Makefile.am b/milena/Makefile.am index 8ff2f4f..e267598 100644 --- a/milena/Makefile.am +++ b/milena/Makefile.am @@ -1,11 +1,13 @@ ## Process this file through Automake to create Makefile.in. -##FIXME SUBDIRS = \ doc \ mesh \ tests -# apps + +if ENABLE_APPS + SUBDIRS += apps +endif ENABLE_APPS .PHONY: doc tutorial tools -- 1.6.1.2

1 0

[PATCH 12/31] Address comparisons of signed vs unsigned in apps/statues/.
by Roland Levillain 15 May '09

15 May '09

* apps/statues/io.hh: Use unsigned loop indices. --- milena/ChangeLog | 6 ++++++ milena/apps/statues/io.hh | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 9bef11c..5ed7f50 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,11 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Address comparisons of signed vs unsigned in apps/statues/. + + * apps/statues/io.hh: Use unsigned loop indices. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + * mln/topo/skeleton/breadth_first_thinning.hh: Aesthetic changes. 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> diff --git a/milena/apps/statues/io.hh b/milena/apps/statues/io.hh index 04ce871..cbced91 100644 --- a/milena/apps/statues/io.hh +++ b/milena/apps/statues/io.hh @@ -55,7 +55,7 @@ inline void write_verts_asc(TriMesh *mesh, FILE *f, const char *before_conf, const char *after_line) { - for (int i = 0; i < mesh->vertices.size(); i++) { + for (unsigned i = 0; i < mesh->vertices.size(); i++) { fprintf(f, "%s%.7g %.7g %.7g", before_vert, mesh->vertices[i][0], mesh->vertices[i][1], @@ -98,7 +98,7 @@ inline void write_faces_asc_colored(TriMesh *mesh, const char *after_line) { mesh->need_faces(); - for (int i = 0; i < mesh->faces.size(); i++) + for (unsigned i = 0; i < mesh->faces.size(); i++) { fprintf(f, "%s%d %d %d %d %d %d%s\n", before_face, @@ -135,7 +135,7 @@ inline void write_faces_asc_float(TriMesh *mesh, const char *after_line) { mesh->need_faces(); - for (int i = 0; i < mesh->faces.size(); i++) + for (unsigned i = 0; i < mesh->faces.size(); i++) { // Vertices Color // -------- ------------ @@ -177,7 +177,7 @@ inline void write_faces_asc_binary(TriMesh *mesh, const char *after_line) { mesh->need_faces(); - for (int i = 0; i < mesh->faces.size(); i++) + for (unsigned i = 0; i < mesh->faces.size(); i++) if (face_value[i]) { fprintf(f, "%s%d %d %d%s\n", -- 1.6.1.2

1 0

[PATCH 11/31] mln/topo/skeleton/breadth_first_thinning.hh: Aesthetic changes.
by Roland Levillain 15 May '09

15 May '09

--- milena/ChangeLog | 4 ++++ milena/mln/topo/skeleton/breadth_first_thinning.hh | 6 ++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index f7d67b5..9bef11c 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,9 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + * mln/topo/skeleton/breadth_first_thinning.hh: Aesthetic changes. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Remove useless #include's. * mln/morpho/line_gradient.hh: diff --git a/milena/mln/topo/skeleton/breadth_first_thinning.hh b/milena/mln/topo/skeleton/breadth_first_thinning.hh index 6c28410..72f4d09 100644 --- a/milena/mln/topo/skeleton/breadth_first_thinning.hh +++ b/milena/mln/topo/skeleton/breadth_first_thinning.hh @@ -92,16 +92,14 @@ namespace mln F& is_simple = exact(is_simple_); const H& constraint = exact(constraint_); - typedef mln_psite(I) psite; - I output = duplicate(input); // Attach the work image to IS_SIMPLE. is_simple.set_image(output); + typedef mln_psite(I) psite; typedef p_set<psite> set_t; set_t set; - - // Populate the set with candiate simple points. + // Populate SET with candidate simple points. mln_piter(I) p_(output.domain()); for_all(p_) { -- 1.6.1.2

1 0

[PATCH 10/31] Remove useless #include's.
by Roland Levillain 15 May '09

15 May '09

* mln/morpho/line_gradient.hh: * apps/statues/mesh-complex-max-curv.cc: Here. --- milena/ChangeLog | 8 ++++++++ milena/apps/statues/mesh-complex-max-curv.cc | 3 --- milena/mln/morpho/line_gradient.hh | 2 -- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index e83522a..f7d67b5 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,13 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Remove useless #include's. + + * mln/morpho/line_gradient.hh: + * apps/statues/mesh-complex-max-curv.cc: + Here. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Have apps/statues/ catch up with Milena's current interface. * apps/statues/mesh-complex-max-curv-segm.cc, diff --git a/milena/apps/statues/mesh-complex-max-curv.cc b/milena/apps/statues/mesh-complex-max-curv.cc index 5c93d7d..5c095f8 100644 --- a/milena/apps/statues/mesh-complex-max-curv.cc +++ b/milena/apps/statues/mesh-complex-max-curv.cc @@ -39,9 +39,6 @@ #include <mln/core/image/complex_image.hh> #include <mln/core/image/complex_neighborhoods.hh> -#include <mln/morpho/closing_area.hh> -#include <mln/morpho/meyer_wst.hh> - #include <mln/data/fill.hh> #include <mln/literal/zero.hh> diff --git a/milena/mln/morpho/line_gradient.hh b/milena/mln/morpho/line_gradient.hh index 32b5975..c0c6018 100644 --- a/milena/mln/morpho/line_gradient.hh +++ b/milena/mln/morpho/line_gradient.hh @@ -40,8 +40,6 @@ # include <mln/math/abs.hh> -# include <mln/util/ord.hh> - # include <mln/core/image/image2d.hh> # include <mln/core/image/edge_image.hh> # include <mln/core/alias/window2d.hh> -- 1.6.1.2

1 0

[PATCH 09/31] Have apps/statues/ catch up with Milena's current interface.
by Roland Levillain 15 May '09

15 May '09

* apps/statues/mesh-complex-max-curv-segm.cc, * apps/statues/mesh-complex-segm.cc, * apps/statues/mesh-segm.cc, * apps/statues/mesh-skel.cc: Adjust to the current interface of mln::morpho::closing::area. --- milena/ChangeLog | 10 ++++++++++ milena/apps/statues/mesh-complex-max-curv-segm.cc | 4 ++-- milena/apps/statues/mesh-complex-segm.cc | 4 ++-- milena/apps/statues/mesh-segm.cc | 7 +++---- milena/apps/statues/mesh-skel.cc | 7 +++---- 5 files changed, 20 insertions(+), 12 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 3609d23..e83522a 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,15 @@ 2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + Have apps/statues/ catch up with Milena's current interface. + + * apps/statues/mesh-complex-max-curv-segm.cc, + * apps/statues/mesh-complex-segm.cc, + * apps/statues/mesh-segm.cc, + * apps/statues/mesh-skel.cc: + Adjust to the current interface of mln::morpho::closing::area. + +2009-05-11 Roland Levillain <roland(a)lrde.epita.fr> + * doc/.gitignore: Add headers.stamp. 2009-04-16 Roland Levillain <roland(a)lrde.epita.fr> diff --git a/milena/apps/statues/mesh-complex-max-curv-segm.cc b/milena/apps/statues/mesh-complex-max-curv-segm.cc index 37d4fbb..389f977 100644 --- a/milena/apps/statues/mesh-complex-max-curv-segm.cc +++ b/milena/apps/statues/mesh-complex-max-curv-segm.cc @@ -39,7 +39,7 @@ #include <mln/core/image/complex_image.hh> #include <mln/core/image/complex_neighborhoods.hh> -#include <mln/morpho/closing_area.hh> +#include <mln/morpho/closing/area.hh> #include <mln/morpho/meyer_wst.hh> #include <mln/math/max.hh> @@ -131,7 +131,7 @@ int main(int argc, char* argv[]) adj_edges_nbh_t; adj_edges_nbh_t adj_edges_nbh; - ima_t closed_input = mln::morpho::closing_area(input, adj_edges_nbh, lambda); + ima_t closed_input = mln::morpho::closing::area(input, adj_edges_nbh, lambda); /*------. | WST. | diff --git a/milena/apps/statues/mesh-complex-segm.cc b/milena/apps/statues/mesh-complex-segm.cc index ab049fc..c4a6dd0 100644 --- a/milena/apps/statues/mesh-complex-segm.cc +++ b/milena/apps/statues/mesh-complex-segm.cc @@ -39,7 +39,7 @@ #include <mln/core/image/complex_image.hh> #include <mln/core/image/complex_neighborhoods.hh> -#include <mln/morpho/closing_area.hh> +#include <mln/morpho/closing/area.hh> #include <mln/morpho/meyer_wst.hh> #include <mln/literal/white.hh> @@ -106,7 +106,7 @@ int main(int argc, char* argv[]) adj_edges_nbh_t; adj_edges_nbh_t adj_edges_nbh; - ima_t closed_input = mln::morpho::closing_area(input, adj_edges_nbh, lambda); + ima_t closed_input = mln::morpho::closing::area(input, adj_edges_nbh, lambda); /*------. | WST. | diff --git a/milena/apps/statues/mesh-segm.cc b/milena/apps/statues/mesh-segm.cc index 46391a1..e24fe6b 100644 --- a/milena/apps/statues/mesh-segm.cc +++ b/milena/apps/statues/mesh-segm.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2008 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2008, 2009 EPITA Research and Development Laboratory (LRDE) // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -46,7 +46,7 @@ #include <mln/core/image/line_graph_image.hh> #include <mln/core/image/line_graph_elt_neighborhood.hh> -#include <mln/morpho/closing_area.hh> +#include <mln/morpho/closing/area.hh> #include <mln/morpho/meyer_wst.hh> #include "io.hh" @@ -173,8 +173,7 @@ int main(int argc, char* argv[]) typedef mln::line_graph_elt_neighborhood<mln::point3d> nbh_t; nbh_t nbh; - ima_t closed_lg_ima (lg_ima.domain()); - mln::morpho::closing_area(lg_ima, nbh, lambda, closed_lg_ima); + ima_t closed_lg_ima = mln::morpho::closing::area(lg_ima, nbh, lambda); /*------. | WST. | diff --git a/milena/apps/statues/mesh-skel.cc b/milena/apps/statues/mesh-skel.cc index c4fd0f2..4b2d002 100644 --- a/milena/apps/statues/mesh-skel.cc +++ b/milena/apps/statues/mesh-skel.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2008 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2008, 2009 EPITA Research and Development Laboratory (LRDE) // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -46,7 +46,7 @@ #include <mln/core/image/graph_image.hh> #include <mln/core/image/graph_elt_neighborhood.hh> -#include <mln/morpho/closing_area.hh> +#include <mln/morpho/closing/area.hh> #include <mln/labeling/regional_minima.hh> #include "io.hh" @@ -155,8 +155,7 @@ int main(int argc, char* argv[]) typedef mln::graph_elt_neighborhood<mln::point3d> nbh_t; nbh_t nbh; - ima_t closed_g_ima (g_ima.domain()); - mln::morpho::closing_area(g_ima, nbh, lambda, closed_g_ima); + ima_t closed_g_ima = mln::morpho::closing::area(g_ima, nbh, lambda); /*------------------. | Regional minima. | -- 1.6.1.2

1 0