September 2008 - Olena-patches

Re: [Olena-patches] [Olena] #40: Review the trunk/milena/mln/io directory.
by Olena 12 Sep '08

12 Sep '08

#40: Review the trunk/milena/mln/io directory. ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: Olena Team Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/40#comment:3> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #41: Review the trunk/milena/mln/geom directory.
by Olena 12 Sep '08

12 Sep '08

#41: Review the trunk/milena/mln/geom directory. ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: Olena Team Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/41#comment:3> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #69: Review the trunk/milena/mln/fun/x2x directory.
by Olena 12 Sep '08

12 Sep '08

#69: Review the trunk/milena/mln/fun/x2x directory. ----------------------+----------------------------------------------------- Reporter: nivault | Owner: Olena Team Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ----------------------+----------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/69#comment:3> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #56: Review the trunk/milena/mln/estim directory.
by Olena 12 Sep '08

12 Sep '08

#56: Review the trunk/milena/mln/estim directory. ----------------------+----------------------------------------------------- Reporter: theo | Owner: theo Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ----------------------+----------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/56#comment:1> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #71: Review the trunk/milena/mln/fun directory
by Olena 12 Sep '08

12 Sep '08

#71: Review the trunk/milena/mln/fun directory -----------------------+---------------------------------------------------- Reporter: levill_r | Owner: levill_r Type: defect | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: -----------------------+---------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/71#comment:1> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #39: Review the trunk/milena/mln/debug directory.
by Olena 12 Sep '08

12 Sep '08

#39: Review the trunk/milena/mln/debug directory. ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: Olena Team Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/39#comment:2> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #64: Review the trunk/milena/mln/canvas directory.
by Olena 12 Sep '08

12 Sep '08

#64: Review the trunk/milena/mln/canvas directory. ----------------------+----------------------------------------------------- Reporter: nivault | Owner: Olena Team Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ----------------------+----------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/64#comment:3> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

Re: [Olena-patches] [Olena] #38: Review the trunk/milena/mln/accu directory.
by Olena 12 Sep '08

12 Sep '08

#38: Review the trunk/milena/mln/accu directory. ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: garrigues Type: task | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: wontfix | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * status: new => closed * resolution: => wontfix Comment: Closing, as the merging from source:trunk/cleanup-2008/ into source:trunk/ will require a new reviewing effort. -- Ticket URL: <https://trac.lrde.org/olena/ticket/38#comment:2> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0

cleanup-2008 r2228: Add at() and remove operator[] from image1d
by Guillaume Lazzara 12 Sep '08

12 Sep '08

URL: https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena ChangeLog: 2008-09-12 Guillaume Lazzara <z(a)lrde.epita.fr> Add at() and remove operator[] from image1d. * milena/mln/core/image/image1d.hh: add at() and remove operator[]. --- image1d.hh | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) Index: branches/cleanup-2008/milena/mln/core/image/image1d.hh =================================================================== --- branches/cleanup-2008/milena/mln/core/image/image1d.hh (revision 2227) +++ branches/cleanup-2008/milena/mln/core/image/image1d.hh (revision 2228) @@ -175,11 +175,15 @@ /// Read-write access to the image value located at point \p p. T& operator()(const point1d& p); - /// Read-only access to the image value located at offset \p o. - const T& operator[](unsigned i) const; - /// Read-write access to the image value located at offset \p o. - T& operator[](unsigned i); + // Specific methods: + // ----------------- + + /// Read-only access to the image value located at (\p index). + const T& at(int index) const; + + /// Read-write access to the image value located at (\p index). + T& at(int index); /// Fast Image method @@ -419,21 +423,22 @@ template <typename T> inline const T& - image1d<T>::operator[](unsigned o) const + image1d<T>::at(int index) const { - mln_precondition(o < nelements()); - return *(this->data_->buffer_ + o); + mln_precondition(this->has(make::point1d(index))); + return this->data_->array_[index]; } template <typename T> inline T& - image1d<T>::operator[](unsigned o) + image1d<T>::at(int index) { - mln_precondition(o < nelements()); - return *(this->data_->buffer_ + o); + mln_precondition(this->has(make::point1d(index))); + return this->data_->array_[index]; } + template <typename T> inline const T&

1 0

Re: [Olena-patches] [Olena] #133: Use consistent naming convention (w.r.t. underscores, abbreviations, etc.)
by Olena 12 Sep '08

12 Sep '08

#133: Use consistent naming convention (w.r.t. underscores, abbreviations, etc.) -----------------------+---------------------------------------------------- Reporter: levill_r | Owner: Olena Team Type: defect | Status: new Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: | Keywords: name coding style -----------------------+---------------------------------------------------- Old description: > We should write down __rules__ about names. For the moment, > wiki:Olena/Release1.0beta#NamingconventionsforOlena1.0 seems to be a good > place to write them. We might want to push them into the (developer) > documentation later. > > This ticket is a (relatively) unordered list of spotted issues. Decide, > reorder and fix. Don't close this ticket too soon, and use it a as memo. > > = Types (underscores, names) = > > We adopted many silent conventions while developing the project, and > inconsistencies arose. Here is a (non comprehensive) list of things to > fix: > * In source:trunk/mln/core/ `mln::window` vs `mln::neighb_` (full name > vs short name + no trailing underscore vs trailing underscore) > * Likewise, we have `mln::window` (without « `_` ») but `mln::point_`, > etc. > * In source:/trunk/milena/mln/accu/median.hh the class does not have any > trailing underscore, whereas other accumulators from > source:/trunk/milena/mln/accu/ have one. > * graph- and complex-related domain-iterators have trailing underscores, > whereas their vicinity counterparts does not. > > = Traits macros = > > * Should we use `mln_sum(V)` or `mln_trait_value_sum(V)` in the library > code? I (Roland) think so. > > = Neighborhoods = > > * The terms/prefixes `nbh`, `neighb` and `neighborhood` are used > inconsistently throughout the project. Here are the files that should be > checked (and possibly renamed), as of revision r1859: > * source:trunk/milena/mln/core/clock_neighb.hh > * source:trunk/milena/mln/core/clock_neighb2d.hh > * source:trunk/milena/mln/core/concept/doc/neighborhood.hh > * source:trunk/milena/mln/core/concept/neighborhood.hh > * source:trunk/milena/mln/core/graph_elt_neighborhood.hh > * source:trunk/milena/mln/core/graph_neighborhood_piter.hh > * source:trunk/milena/mln/core/line_graph_elt_neighborhood.hh > * source:trunk/milena/mln/core/line_graph_neighborhood_piter.hh > * source:trunk/milena/mln/core/neighb.hh > * source:trunk/milena/mln/core/neighb1d.hh > * source:trunk/milena/mln/core/neighb2d.hh > * source:trunk/milena/mln/core/neighb3d.hh > * source:trunk/milena/mln/metal/has_neighborhood.hh > * source:trunk/milena/mln/neighb/ > * source:trunk/milena/mln/trait/neighborhood.hh New description: We should write down __rules__ about names. For the moment, wiki:Olena/Release1.0#NamingconventionsforOlena1.0 seems to be a good place to write them. We might want to push them into the (developer) documentation later. This ticket is a (relatively) unordered list of spotted issues. Decide, reorder and fix. Don't close this ticket too soon, and use it a as memo. = Types (underscores, names) = We adopted many silent conventions while developing the project, and inconsistencies arose. Here is a (non comprehensive) list of things to fix: * In source:trunk/mln/core/ `mln::window` vs `mln::neighb_` (full name vs short name + no trailing underscore vs trailing underscore) * Likewise, we have `mln::window` (without « `_` ») but `mln::point_`, etc. * In source:/trunk/milena/mln/accu/median.hh the class does not have any trailing underscore, whereas other accumulators from source:/trunk/milena/mln/accu/ have one. * graph- and complex-related domain-iterators have trailing underscores, whereas their vicinity counterparts does not. = Traits macros = * Should we use `mln_sum(V)` or `mln_trait_value_sum(V)` in the library code? I (Roland) think so. = Neighborhoods = * The terms/prefixes `nbh`, `neighb` and `neighborhood` are used inconsistently throughout the project. Here are the files that should be checked (and possibly renamed), as of revision r1859: * source:trunk/milena/mln/core/clock_neighb.hh * source:trunk/milena/mln/core/clock_neighb2d.hh * source:trunk/milena/mln/core/concept/doc/neighborhood.hh * source:trunk/milena/mln/core/concept/neighborhood.hh * source:trunk/milena/mln/core/graph_elt_neighborhood.hh * source:trunk/milena/mln/core/graph_neighborhood_piter.hh * source:trunk/milena/mln/core/line_graph_elt_neighborhood.hh * source:trunk/milena/mln/core/line_graph_neighborhood_piter.hh * source:trunk/milena/mln/core/neighb.hh * source:trunk/milena/mln/core/neighb1d.hh * source:trunk/milena/mln/core/neighb2d.hh * source:trunk/milena/mln/core/neighb3d.hh * source:trunk/milena/mln/metal/has_neighborhood.hh * source:trunk/milena/mln/neighb/ * source:trunk/milena/mln/trait/neighborhood.hh Comment (by levill_r): s|Olena/Release1.0beta|Olena/Release1.0|. -- Ticket URL: <https://trac.lrde.org/olena/ticket/133#comment:2> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 0