September 2008 - Olena-patches

2302: Use util::ord in morpho::line_gradient instead of ad hoc code.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/morpho/line_gradient.hh (mln::morpho::internal::point2_lexicographical_less): Remove. (mln::morpho::line_gradient()::points): Use util::ord<point2d> instead of morpho::internal::point2d_lexicographical_less. --- milena/ChangeLog | 9 +++++++++ milena/mln/morpho/line_gradient.hh | 21 +++------------------ 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 2180a84..0b74ec4 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,14 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Use util::ord in morpho::line_gradient instead of ad hoc code. + + * mln/morpho/line_gradient.hh + (mln::morpho::internal::point2_lexicographical_less): Remove. + (mln::morpho::line_gradient()::points): Use util::ord<point2d> + instead of morpho::internal::point2d_lexicographical_less. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Have morpho::line_gradient compile again * mln/morpho/line_gradient.hh (mln::morpho::line_gradient): diff --git a/milena/mln/morpho/line_gradient.hh b/milena/mln/morpho/line_gradient.hh index 50c66dc..fb42d13 100644 --- a/milena/mln/morpho/line_gradient.hh +++ b/milena/mln/morpho/line_gradient.hh @@ -38,6 +38,8 @@ # include <mln/math/abs.hh> +# include <mln/util/ord.hh> + # include <mln/core/image/image2d.hh> # include <mln/core/alias/window2d.hh> # include <mln/core/image/line_graph_image.hh> @@ -62,22 +64,6 @@ namespace mln # ifndef MLN_INCLUDE_ONLY - // FIXME: We should have mixins to add such a comparison operator. - namespace internal - { - struct point2d_lexicographical_less - : std::binary_function<const point2d&, const point2d&, bool> - { - bool operator()(const point2d& lhs, const point2d& rhs) - { - return - lhs.row() < rhs.row() || - (lhs.row() == rhs.row() && lhs.col() < rhs.col()); - } - }; - } // end of namespace mln::morpho::internal - - template <typename T> mln::line_graph_image<mln::point2d, T> line_gradient(const mln::image2d<T>& ima) @@ -92,8 +78,7 @@ namespace mln exhibits the lack of a service from util::graph (or a another, missing tool) regarding the retrieval of vertices' ids from points. */ - std::map< mln::point2d, util::vertex_id, - morpho::internal::point2d_lexicographical_less > points; + std::map< mln::point2d, util::vertex_id, util::ord<point2d> > points; // Vertices. std::vector<value_t> vertex_values; -- 1.6.0.1

1 0

2301: Have morpho::line_gradient compile again
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/morpho/line_gradient.hh (mln::morpho::line_gradient): s/mln_max(util::edge_id))/mln_max(util::edge_id::equiv))/ --- milena/ChangeLog | 7 +++++++ milena/mln/morpho/line_gradient.hh | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index f8750e4..2180a84 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,12 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Have morpho::line_gradient compile again + + * mln/morpho/line_gradient.hh (mln::morpho::line_gradient): + s/mln_max(util::edge_id))/mln_max(util::edge_id::equiv))/ + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update the Doxygen documentation of iterator internal classes. * mln/core/internal/site_set_iterator_base.hh diff --git a/milena/mln/morpho/line_gradient.hh b/milena/mln/morpho/line_gradient.hh index cdd50b5..50c66dc 100644 --- a/milena/mln/morpho/line_gradient.hh +++ b/milena/mln/morpho/line_gradient.hh @@ -124,7 +124,7 @@ namespace mln #endif //!NDEBUG // The computed value is a norm of the gradient between P and Q. edge_values.push_back(math::abs(ima(p) - ima(q))); - mln_assertion(id != mln_max(util::edge_id)); + mln_assertion(id != mln_max(util::edge_id::equiv)); } // Line graph point set. -- 1.6.0.1

1 0

2300: Update the Doxygen documentation of iterator internal classes.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/internal/site_set_iterator_base.hh * mln/core/internal/site_relative_iterator_base.hh: Do it. --- milena/ChangeLog | 8 ++++++++ .../core/internal/site_relative_iterator_base.hh | 7 ++++--- milena/mln/core/internal/site_set_iterator_base.hh | 3 +++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 18f27e1..f8750e4 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,13 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update the Doxygen documentation of iterator internal classes. + + * mln/core/internal/site_set_iterator_base.hh + * mln/core/internal/site_relative_iterator_base.hh: + Do it. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update the Doxygen documentation of site set internal classes. * mln/core/internal/site_set_base.hh: Do it. diff --git a/milena/mln/core/internal/site_relative_iterator_base.hh b/milena/mln/core/internal/site_relative_iterator_base.hh index f9b582f..b488ee7 100644 --- a/milena/mln/core/internal/site_relative_iterator_base.hh +++ b/milena/mln/core/internal/site_relative_iterator_base.hh @@ -49,14 +49,15 @@ namespace mln namespace internal { - /*! \brief A generic forward iterator on points of windows and of + /*! \brief A generic iterator on points of windows and of * neighborhoods. * * Parameter \c S is the targeted "site set definition" type. It * can be either a Window, or a Neighborhood. * - * IMPORTANT: Sub-classes have to define do_start_, do_next_, and - * compute_p_. They shall define NEITHER start_ NOR next_. + * IMPORTANT: Sub-classes have to define do_start_, do_next_, + * is_valid_, invalidate_ and compute_p_. They shall define + * NEITHER start_ NOR next_. */ template <typename S, typename E> class site_relative_iterator_base : public site_iterator_base< S, E > diff --git a/milena/mln/core/internal/site_set_iterator_base.hh b/milena/mln/core/internal/site_set_iterator_base.hh index 376e5d6..6b76994 100644 --- a/milena/mln/core/internal/site_set_iterator_base.hh +++ b/milena/mln/core/internal/site_set_iterator_base.hh @@ -46,6 +46,9 @@ namespace mln /*! \internal A base class for site iterators. * * Parameter \c S is the targeted site set type. + * + * IMPORTANT: Sub-classes have to define start_, next_, + * is_valid_ and invalidate_. */ template <typename S, typename E> class site_set_iterator_base : public site_iterator_base<S, E> -- 1.6.0.1

1 0

2299: Update the Doxygen documentation of site set internal classes.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/internal/site_set_base.hh: Do it. --- milena/ChangeLog | 6 ++++++ milena/mln/core/internal/site_set_base.hh | 6 +++++- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index a98db9a..18f27e1 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,11 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update the Doxygen documentation of site set internal classes. + + * mln/core/internal/site_set_base.hh: Do it. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph image. * mln/core/image/line_graph_image.hh diff --git a/milena/mln/core/internal/site_set_base.hh b/milena/mln/core/internal/site_set_base.hh index 42c0199..de2eaeb 100644 --- a/milena/mln/core/internal/site_set_base.hh +++ b/milena/mln/core/internal/site_set_base.hh @@ -46,7 +46,11 @@ namespace mln /*! \internal A base class for site set classes. - * \p P is a psite type. + * + * \arg \p P The psite type of what is ``contained'' in the site + * set, not the psite of the site set (which is + * different, and defined by the site set itself). + * \arg \p E The exact type of the site set. */ template <typename P, typename E> struct site_set_base_ : public Site_Set<E> -- 1.6.0.1

1 0

2298: Update line graph image.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/image/line_graph_image.hh (mln::line_graph_image<P, V>::operator() const) (mln::line_graph_image<P, V>::operator()): Adjust to the new psite interface. s/id()/edge_id()/. Adjust preconditions. --- milena/ChangeLog | 11 +++++++++++ milena/mln/core/image/line_graph_image.hh | 12 ++++++------ 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index eaec49e..a98db9a 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,16 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph image. + + * mln/core/image/line_graph_image.hh + (mln::line_graph_image<P, V>::operator() const) + (mln::line_graph_image<P, V>::operator()): + Adjust to the new psite interface. + s/id()/edge_id()/. + Adjust preconditions. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph neighborhood & window piters. * mln/core/internal/line_graph_vicinity_piter.hh diff --git a/milena/mln/core/image/line_graph_image.hh b/milena/mln/core/image/line_graph_image.hh index 6770a08..69d9509 100644 --- a/milena/mln/core/image/line_graph_image.hh +++ b/milena/mln/core/image/line_graph_image.hh @@ -277,9 +277,9 @@ namespace mln typename line_graph_image<P, V>::rvalue line_graph_image<P, V>::operator()(const line_graph_psite& p) const { - mln_precondition(p.plg() == this->data_->plg_); - mln_precondition(p.id() < this->data_->edge_val_.size()); - return this->data_->edge_val_[p.id()]; + mln_precondition(p.is_valid()); + mln_precondition(p.site_set() == this->data_->plg_); + return this->data_->edge_val_[p.edge_id()]; } template <typename P, typename V> @@ -287,9 +287,9 @@ namespace mln typename line_graph_image<P, V>::lvalue line_graph_image<P, V>::operator()(const line_graph_psite& p) { - mln_precondition(p.plg() == this->data_->plg_); - mln_precondition(p.id() < this->data_->edge_val_.size()); - return this->data_->edge_val_[p.id()]; + mln_precondition(p.is_valid()); + mln_precondition(p.site_set() == this->data_->plg_); + return this->data_->edge_val_[p.edge_id()]; } template <typename P, typename V> -- 1.6.0.1

1 0

2297: Update line graph neighborhood & window piters.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/internal/line_graph_vicinity_piter.hh (mln::internal::line_graph_vicinity_piter_<P, S, E>): Inherit from internal::site_relative_iterator_base. (line_graph_vicinity_piter_<P, S, E>::line_graph_vicinity_piter_): New default ctor. Adjust other ctors. (mln::internal::line_graph_vicinity_piter_<P, S, E>::super_) (mln::internal::line_graph_vicinity_piter_<P, S, E>::psite) (mln::internal::line_graph_vicinity_piter_<P, S, E>::point) (mln::internal::line_graph_vicinity_piter_<P, S, E>::coord): Remove typedefs. (mln::internal::line_graph_vicinity_piter_<P, S, E>::to_point) (mln::internal::line_graph_vicinity_piter_<P, S, E>::to_psite) (mln::internal::line_graph_vicinity_piter_<P, S, E>::operator psite) (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_ref) (mln::internal::line_graph_vicinity_piter_<P, S, E>::plg) (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_hook_) (mln::internal::line_graph_vicinity_piter_<P, S, E>::operator[]): Remove methods. (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_ref_) (mln::internal::line_graph_vicinity_piter_<P, S, E>::saved_p_ref_) (mln::internal::line_graph_vicinity_piter_<P, S, E>::psite_) (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_): Remove attributes. * mln/core/image/line_graph_neighborhood_piter.hh * mln/core/image/line_graph_window_piter.hh (mln::line_graph_neighborhood_fwd_piter<P, N>::psite) (mln::line_graph_neighborhood_bkd_piter<P, N>::psite) (mln::line_graph_window_fwd_piter<P, W>::psite) (mln::line_graph_window_bkd_piter<P, W>::psite): New typdefs. (mln::line_graph_neighborhood_fwd_piter<P, N>) (mln::line_graph_neighborhood_bkd_piter<P, N>) (mln::line_graph_window_fwd_piter<P, W>) (mln::line_graph_window_bkd_piter<P, W>): New default ctors. Adjust other ctors to the new interface of mln::line_graph_vicinity_piter_. (mln::line_graph_neighborhood_fwd_piter<P, N>::is_valid_) (mln::line_graph_neighborhood_bkd_piter<P, N>::is_valid_) (mln::line_graph_window_fwd_piter<P, W>::is_valid_) (mln::line_graph_window_bkd_piter<P, W>::is_valid_): Adjust to the new interface of mln::line_graph_vicinity_piter_. (mln::line_graph_neighborhood_fwd_piter<P, N>::start) (mln::line_graph_neighborhood_bkd_piter<P, N>::start) (mln::line_graph_window_fwd_piter<P, W>::start) (mln::line_graph_window_bkd_piter<P, W>::start) (mln::line_graph_neighborhood_fwd_piter<P, N>::next) (mln::line_graph_neighborhood_bkd_piter<P, N>::next) (mln::line_graph_window_fwd_piter<P, W>::next) (mln::line_graph_window_bkd_piter<P, W>::next): Likewise. Rename as... (mln::line_graph_neighborhood_fwd_piter<P, N>::do_start_) (mln::line_graph_neighborhood_bkd_piter<P, N>::do_start_) (mln::line_graph_window_fwd_piter<P, W>::do_start_) (mln::line_graph_window_bkd_piter<P, W>::do_start_) (mln::line_graph_neighborhood_fwd_piter<P, N>::do_next_) (mln::line_graph_neighborhood_bkd_piter<P, N>::do_next_) (mln::line_graph_window_fwd_piter<P, W>::do_next_) (mln::line_graph_window_bkd_piter<P, W>::do_next_): ...these. (mln::line_graph_neighborhood_fwd_piter<P, N>::compute_p_) (mln::line_graph_neighborhood_bkd_piter<P, N>::compute_p_) (mln::line_graph_window_fwd_piter<P, W>::compute_p_) (mln::line_graph_window_bkd_piter<P, W>::compute_p_): New methods. (mln::line_graph_neighborhood_fwd_piter<P, N>::site) (mln::line_graph_neighborhood_bkd_piter<P, N>::site): Remove typedefs. (mln::line_graph_neighborhood_fwd_piter<P, N>::update_) (mln::line_graph_neighborhood_bkd_piter<P, N>::update_) (mln::line_graph_window_fwd_piter<P, W>::update_) (mln::line_graph_window_bkd_piter<P, W>::update_) (mln::line_graph_neighborhood_fwd_piter<P, N>::to_site) (mln::line_graph_neighborhood_bkd_piter<P, N>::to_site) (mln::line_graph_neighborhood_fwd_piter<P, N>::operator site) (mln::line_graph_neighborhood_bkd_piter<P, N>::operator site) (mln::line_graph_neighborhood_fwd_piter<P, N>::target_) (mln::line_graph_neighborhood_bkd_piter<P, N>::target_) (mln::line_graph_neighborhood_fwd_piter<P, N>::change_target) (mln::line_graph_neighborhood_bkd_piter<P, N>::change_target): Remove methods. (mln::line_graph_neighborhood_fwd_piter<P, N>::nbh_) (mln::line_graph_neighborhood_bkd_piter<P, N>::nbh_) (mln::line_graph_neighborhood_fwd_piter<P, N>::site_) (mln::line_graph_neighborhood_bkd_piter<P, N>::site_): --- milena/ChangeLog | 94 ++++++++ .../core/image/line_graph_neighborhood_piter.hh | 235 ++++---------------- milena/mln/core/image/line_graph_window_piter.hh | 140 +++++------- .../mln/core/internal/line_graph_vicinity_piter.hh | 119 ++--------- 4 files changed, 213 insertions(+), 375 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index f41074f..eaec49e 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,99 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph neighborhood & window piters. + + * mln/core/internal/line_graph_vicinity_piter.hh + (mln::internal::line_graph_vicinity_piter_<P, S, E>): + Inherit from internal::site_relative_iterator_base. + (line_graph_vicinity_piter_<P, S, E>::line_graph_vicinity_piter_): + New default ctor. + Adjust other ctors. + (mln::internal::line_graph_vicinity_piter_<P, S, E>::super_) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::psite) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::point) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::coord): + Remove typedefs. + (mln::internal::line_graph_vicinity_piter_<P, S, E>::to_point) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::to_psite) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::operator psite) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_ref) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::plg) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_hook_) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::operator[]): + Remove methods. + (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_ref_) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::saved_p_ref_) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::psite_) + (mln::internal::line_graph_vicinity_piter_<P, S, E>::p_): + Remove attributes. + + * mln/core/image/line_graph_neighborhood_piter.hh + * mln/core/image/line_graph_window_piter.hh + (mln::line_graph_neighborhood_fwd_piter<P, N>::psite) + (mln::line_graph_neighborhood_bkd_piter<P, N>::psite) + (mln::line_graph_window_fwd_piter<P, W>::psite) + (mln::line_graph_window_bkd_piter<P, W>::psite): + New typdefs. + (mln::line_graph_neighborhood_fwd_piter<P, N>) + (mln::line_graph_neighborhood_bkd_piter<P, N>) + (mln::line_graph_window_fwd_piter<P, W>) + (mln::line_graph_window_bkd_piter<P, W>): + New default ctors. + Adjust other ctors to the new interface of + mln::line_graph_vicinity_piter_. + (mln::line_graph_neighborhood_fwd_piter<P, N>::is_valid_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::is_valid_) + (mln::line_graph_window_fwd_piter<P, W>::is_valid_) + (mln::line_graph_window_bkd_piter<P, W>::is_valid_): + Adjust to the new interface of mln::line_graph_vicinity_piter_. + (mln::line_graph_neighborhood_fwd_piter<P, N>::start) + (mln::line_graph_neighborhood_bkd_piter<P, N>::start) + (mln::line_graph_window_fwd_piter<P, W>::start) + (mln::line_graph_window_bkd_piter<P, W>::start) + (mln::line_graph_neighborhood_fwd_piter<P, N>::next) + (mln::line_graph_neighborhood_bkd_piter<P, N>::next) + (mln::line_graph_window_fwd_piter<P, W>::next) + (mln::line_graph_window_bkd_piter<P, W>::next): + Likewise. + Rename as... + (mln::line_graph_neighborhood_fwd_piter<P, N>::do_start_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::do_start_) + (mln::line_graph_window_fwd_piter<P, W>::do_start_) + (mln::line_graph_window_bkd_piter<P, W>::do_start_) + (mln::line_graph_neighborhood_fwd_piter<P, N>::do_next_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::do_next_) + (mln::line_graph_window_fwd_piter<P, W>::do_next_) + (mln::line_graph_window_bkd_piter<P, W>::do_next_): + ...these. + (mln::line_graph_neighborhood_fwd_piter<P, N>::compute_p_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::compute_p_) + (mln::line_graph_window_fwd_piter<P, W>::compute_p_) + (mln::line_graph_window_bkd_piter<P, W>::compute_p_): + New methods. + (mln::line_graph_neighborhood_fwd_piter<P, N>::site) + (mln::line_graph_neighborhood_bkd_piter<P, N>::site): + Remove typedefs. + (mln::line_graph_neighborhood_fwd_piter<P, N>::update_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::update_) + (mln::line_graph_window_fwd_piter<P, W>::update_) + (mln::line_graph_window_bkd_piter<P, W>::update_) + (mln::line_graph_neighborhood_fwd_piter<P, N>::to_site) + (mln::line_graph_neighborhood_bkd_piter<P, N>::to_site) + (mln::line_graph_neighborhood_fwd_piter<P, N>::operator site) + (mln::line_graph_neighborhood_bkd_piter<P, N>::operator site) + (mln::line_graph_neighborhood_fwd_piter<P, N>::target_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::target_) + (mln::line_graph_neighborhood_fwd_piter<P, N>::change_target) + (mln::line_graph_neighborhood_bkd_piter<P, N>::change_target): + Remove methods. + (mln::line_graph_neighborhood_fwd_piter<P, N>::nbh_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::nbh_) + (mln::line_graph_neighborhood_fwd_piter<P, N>::site_) + (mln::line_graph_neighborhood_bkd_piter<P, N>::site_): + Remove attributes. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph elementary neighborhood and window. * mln/core/image/line_graph_elt_neighborhood.hh, diff --git a/milena/mln/core/image/line_graph_neighborhood_piter.hh b/milena/mln/core/image/line_graph_neighborhood_piter.hh index 69ad4db..c795783 100644 --- a/milena/mln/core/image/line_graph_neighborhood_piter.hh +++ b/milena/mln/core/image/line_graph_neighborhood_piter.hh @@ -54,8 +54,13 @@ namespace mln typedef internal::line_graph_vicinity_piter_<P, N, self_> super_; public: + /// The Point_Site type. + typedef mln_psite(N) psite; + + public: /// Construction. /// \{ + line_graph_neighborhood_fwd_piter(); template <typename Pref> line_graph_neighborhood_fwd_piter(const Neighborhood<N>& nbh, const Pref& p_ref); @@ -67,36 +72,17 @@ namespace mln bool is_valid_() const; /// Invalidate the iterator. void invalidate_(); - /// Start an iteration. - void start_(); + /// Start an iteration. + void do_start_(); /// Go to the next point. - void next_(); - /// Update the internal data of the iterator. - void update_(); - /// \} + void do_next_(); - /// Conversions. - /// \{ - /// The corresponding site type. - typedef P site; - // FIXME: Dummy. - site site_; - // FIXME: Dummy. - const site& to_site() const; - // FIXME: Dummy. - operator site() const; + /// Compute the current psite. + psite compute_p_() const; /// \} - /// Give the target neighborhood address. - const N*& target_(); - /// Change the target neighborhood. - void change_target(const N& nbh); - private: - /// The neighborhood. - const N* nbh_; - /// An iterator on the set of adjacent edges. typename super_::sites_t::const_iterator i_; }; @@ -116,8 +102,13 @@ namespace mln typedef internal::line_graph_vicinity_piter_<P, N, self_> super_; public: + /// The Point_Site type. + typedef mln_psite(N) psite; + + public: /// Construction. /// \{ + line_graph_neighborhood_bkd_piter(); template <typename Pref> line_graph_neighborhood_bkd_piter(const Neighborhood<N>& nbh, const Pref& p_ref); @@ -129,36 +120,17 @@ namespace mln bool is_valid_() const; /// Invalidate the iterator. void invalidate_(); - /// Start an iteration. - void start_(); + /// Start an iteration. + void do_start_(); /// Go to the next point. - void next_(); - /// Update the internal data of the iterator. - void update_(); - /// \} + void do_next_(); - /// Conversions. - /// \{ - /// The corresponding site type. - typedef P site; - // FIXME: Dummy. - site site_; - // FIXME: Dummy. - const site& to_site() const; - // FIXME: Dummy. - operator site() const; + /// Compute the current psite. + psite compute_p_() const; /// \} - /// Give the target neighborhood address. - const N*& target_(); - /// Change the target neighborhood. - void change_target(const N& nbh); - private: - /// The neighborhood. - const N* nbh_; - /// An iterator on the set of adjacent edges. typename super_::sites_t::const_reverse_iterator i_; }; @@ -172,15 +144,19 @@ namespace mln `------------------------------------------*/ template <typename P, typename N> + inline + line_graph_neighborhood_fwd_piter<P, N>::line_graph_neighborhood_fwd_piter() + { + } + + template <typename P, typename N> template <typename Pref> inline line_graph_neighborhood_fwd_piter<P, N>::line_graph_neighborhood_fwd_piter(const Neighborhood<N>& nbh, const Pref& p_ref) - : super_(p_ref), - nbh_(&exact(nbh)) + : super_(p_ref) { - // Invalidate i_. - this->invalidate(); + this->change_target(exact(nbh)); } template <typename P, typename N> @@ -188,14 +164,7 @@ namespace mln bool line_graph_neighborhood_fwd_piter<P, N>::is_valid_() const { - return - // The reference point must be valid... - this->p_ref_.is_valid() - // ...and must not have changed since the neighborhood has been - // computed... - && this->p_ref_ == this->saved_p_ref_ - // ...and the iterator i_ must point a valid value. - && i_ != this->sites_.end(); + return i_ != this->sites_.end(); } template <typename P, typename N> @@ -209,96 +178,47 @@ namespace mln template <typename P, typename N> inline void - line_graph_neighborhood_fwd_piter<P, N>::start_() + line_graph_neighborhood_fwd_piter<P, N>::do_start_() { - mln_precondition(this->p_ref_.is_valid()); - // Update the neighbors, if needed. - if (!this->saved_p_ref_.is_valid() || this->p_ref_ != this->saved_p_ref_) - { - this->saved_p_ref_ = this->p_ref_; - nbh_->compute_sites_(*this); - } + this->site_set().compute_sites_(*this); i_ = this->sites_.begin(); - // FIXME: We might move the is_valid_ condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename N> inline void - line_graph_neighborhood_fwd_piter<P, N>::next_() + line_graph_neighborhood_fwd_piter<P, N>::do_next_() { - // Ensure the p_ref_ has not changed. - mln_precondition(this->p_ref_ == this->saved_p_ref_); ++i_; - // FIXME: We might move the is_valid_ condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename N> inline - void - line_graph_neighborhood_fwd_piter<P, N>::update_() + mln_psite(N) + line_graph_neighborhood_fwd_piter<P, N>::compute_p_() const { - // Update psite_. - this->psite_ = line_graph_psite(this->plg(), *i_); + return line_graph_psite(this->center().site_set(), *i_); } - template <typename P, typename N> - inline - const P& - line_graph_neighborhood_fwd_piter<P, N>::to_site() const - { - // FIXME: Dummy. - abort(); - return site_; - } - - template <typename P, typename N> - inline - line_graph_neighborhood_fwd_piter<P, N>::operator P() const - { - // FIXME: Dummy. - abort(); - return site_; - } - - - template <typename P, typename N> - inline - const N*& - line_graph_neighborhood_fwd_piter<P, N>::target_() - { - return nbh_; - } + /*------------------------------------------. + | line_graph_neighborhood_bkd_piter<P, N>. | + `------------------------------------------*/ template <typename P, typename N> inline - void line_graph_neighborhood_fwd_piter<P, N>::change_target(const N& nbh) + line_graph_neighborhood_bkd_piter<P, N>::line_graph_neighborhood_bkd_piter() { - nbh_ = &nbh; - this->invalidate(); } - - - /*------------------------------------------. - | line_graph_neighborhood_bkd_piter<P, N>. | - `------------------------------------------*/ - template <typename P, typename N> template <typename Pref> inline line_graph_neighborhood_bkd_piter<P, N>::line_graph_neighborhood_bkd_piter(const Neighborhood<N>& nbh, const Pref& p_ref) - : super_(p_ref), - nbh_(&exact(nbh)) + : super_(p_ref) { - // Invalidate i_. - this->invalidate(); + this->change_target(exact(nbh)); } template <typename P, typename N> @@ -306,14 +226,7 @@ namespace mln bool line_graph_neighborhood_bkd_piter<P, N>::is_valid_() const { - return - // The reference point must be valid... - this->p_ref_.is_valid() - // ...and must not have changed since the neighborhood has been - // computed... - && this->p_ref_ == this->saved_p_ref_ - // ...and the iterator i_ must point a valid value. - && i_ != this->sites_.rend(); + return i_ != this->sites_.rend(); } template <typename P, typename N> @@ -327,78 +240,26 @@ namespace mln template <typename P, typename N> inline void - line_graph_neighborhood_bkd_piter<P, N>::start_() + line_graph_neighborhood_bkd_piter<P, N>::do_start_() { - mln_precondition(this->p_ref_.is_valid()); - // Update the neighbors, if needed. - if (!this->saved_p_ref_.is_valid() || this->p_ref_ != this->saved_p_ref_) - { - this->saved_p_ref_ = this->p_ref_; - nbh_->compute_sites_(*this); - } + this->site_set().compute_sites_(*this); i_ = this->sites_.rbegin(); - // FIXME: We might move the is_valid_ condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename N> inline void - line_graph_neighborhood_bkd_piter<P, N>::next_() + line_graph_neighborhood_bkd_piter<P, N>::do_next_() { - // Ensure the p_ref_ has not changed. - mln_precondition(this->p_ref_ == this->saved_p_ref_); ++i_; - // FIXME: We might move the is_valid_ condition within update_. - if (this->is_valid()) - update_(); - } - - template <typename P, typename N> - inline - void - line_graph_neighborhood_bkd_piter<P, N>::update_() - { - // Update psite_. - this->psite_ = line_graph_psite(this->plg(), *i_); - } - - - template <typename P, typename N> - inline - const P& - line_graph_neighborhood_bkd_piter<P, N>::to_site() const - { - // FIXME: Dummy. - abort(); - return site_; - } - - template <typename P, typename N> - inline - line_graph_neighborhood_bkd_piter<P, N>::operator P() const - { - // FIXME: Dummy. - abort(); - return site_; - } - - - template <typename P, typename N> - inline - const N*& - line_graph_neighborhood_bkd_piter<P, N>::target_() - { - return nbh_; } template <typename P, typename N> inline - void line_graph_neighborhood_bkd_piter<P, N>::change_target(const N& nbh) + mln_psite(N) + line_graph_neighborhood_bkd_piter<P, N>::compute_p_() const { - nbh_ = &nbh; - this->invalidate(); + return line_graph_psite(this->center().site_set(), *i_); } # endif // ! MLN_INCLUDE_ONLY diff --git a/milena/mln/core/image/line_graph_window_piter.hh b/milena/mln/core/image/line_graph_window_piter.hh index 2460f9a..085346c 100644 --- a/milena/mln/core/image/line_graph_window_piter.hh +++ b/milena/mln/core/image/line_graph_window_piter.hh @@ -54,11 +54,16 @@ namespace mln typedef internal::line_graph_vicinity_piter_<P, W, self_> super_; public: + /// The Point_Site type. + typedef mln_psite(W) psite; + + public: /// Construction. /// \{ + line_graph_window_fwd_piter(); template <typename Pref> line_graph_window_fwd_piter(const Window<W>& win, - const Point_Site<Pref>& p_ref); + const Pref& p_ref); /// \} /// Manipulation. @@ -67,19 +72,17 @@ namespace mln bool is_valid_() const; /// Invalidate the iterator. void invalidate_(); - /// Start an iteration. - void start_(); + /// Start an iteration. + void do_start_(); /// Go to the next point. - void next_(); - /// Update the internal data of the iterator. - void update_(); + void do_next_(); + + /// Compute the current psite. + psite compute_p_() const; /// \} private: - /// The window. - const W& win_; - /// An iterator on the set of adjacent edges. typename super_::sites_t::const_iterator i_; }; @@ -98,11 +101,16 @@ namespace mln typedef internal::line_graph_vicinity_piter_<P, W, self_> super_; public: + /// The Point_Site type. + typedef mln_psite(W) psite; + + public: /// Construction. /// \{ + line_graph_window_bkd_piter(); template <typename Pref> line_graph_window_bkd_piter(const Window<W>& win, - const Point_Site<Pref>& p_ref); + const Pref& p_ref); /// \} /// Manipulation. @@ -111,19 +119,17 @@ namespace mln bool is_valid_() const; /// Invalidate the iterator. void invalidate_(); - /// Start an iteration. - void start_(); + /// Start an iteration. + void do_start_(); /// Go to the next point. - void next_(); - /// Update the internal data of the iterator. - void update_(); + void do_next_(); + + /// Compute the current psite. + psite compute_p_() const; /// \} private: - /// The window. - const W& win_; - /// An iterator on the set of adjacent edges. typename super_::sites_t::const_reverse_iterator i_; }; @@ -137,15 +143,19 @@ namespace mln `------------------------------------*/ template <typename P, typename W> + inline + line_graph_window_fwd_piter<P, W>::line_graph_window_fwd_piter() + { + } + + template <typename P, typename W> template <typename Pref> inline line_graph_window_fwd_piter<P, W>::line_graph_window_fwd_piter(const Window<W>& win, - const Point_Site<Pref>& p_ref) - : super_(p_ref), - win_(exact(win)) + const Pref& p_ref) + : super_(p_ref) { - // Invalidate i_. - this->invalidate(); + this->change_target(exact(win)); } template <typename P, typename W> @@ -153,13 +163,7 @@ namespace mln bool line_graph_window_fwd_piter<P, W>::is_valid_() const { - return - // The reference point must be valid... - this->p_ref_.is_valid() - // ...and must not have changed since the window has been computed... - && this->p_ref_ == this->saved_p_ref_ - // ...and the iterator i_ must point a valid value. - && i_ != this->sites_.end(); + return i_ != this->sites_.end(); } template <typename P, typename W> @@ -173,41 +177,26 @@ namespace mln template <typename P, typename W> inline void - line_graph_window_fwd_piter<P, W>::start_() + line_graph_window_fwd_piter<P, W>::do_start_() { - mln_precondition(this->p_ref_.is_valid()); - // Update the sites, if needed. - if (!this->saved_p_ref_.is_valid() || this->p_ref_ != this->saved_p_ref_) - { - this->saved_p_ref_ = this->p_ref_; - win_.compute_sites_(*this); - } + this->site_set().compute_sites_(*this); i_ = this->sites_.begin(); - // FIXME: We might move the is_valid condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename W> inline void - line_graph_window_fwd_piter<P, W>::next_() + line_graph_window_fwd_piter<P, W>::do_next_() { - // Ensure the p_ref_ has not changed. - mln_precondition(this->p_ref_ == this->saved_p_ref_); ++i_; - // FIXME: We might move the is_valid condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename W> inline - void - line_graph_window_fwd_piter<P, W>::update_() + mln_psite(W) + line_graph_window_fwd_piter<P, W>::compute_p_() const { - // Update psite_. - this->psite_ = line_graph_psite(this->plg(), *i_); + return line_graph_psite(this->center().site_set(), *i_); } @@ -216,15 +205,19 @@ namespace mln `------------------------------------*/ template <typename P, typename W> + inline + line_graph_window_bkd_piter<P, W>::line_graph_window_bkd_piter() + { + } + + template <typename P, typename W> template <typename Pref> inline line_graph_window_bkd_piter<P, W>::line_graph_window_bkd_piter(const Window<W>& win, - const Point_Site<Pref>& p_ref) - : super_(p_ref), - win_(exact(win)) + const Pref& p_ref) + : super_(p_ref) { - // Invalidate i_. - this->invalidate(); + this->change_target(exact(win)); } template <typename P, typename W> @@ -232,13 +225,7 @@ namespace mln bool line_graph_window_bkd_piter<P, W>::is_valid_() const { - return - // The reference point must be valid... - this->p_ref_.is_valid() - // ...and must not have changed since the window has been computed... - && this->p_ref_ == this->saved_p_ref_ - // ...and the iterator i_ must point a valid value. - && i_ != this->sites_.rend(); + return i_ != this->sites_.rend(); } template <typename P, typename W> @@ -252,41 +239,26 @@ namespace mln template <typename P, typename W> inline void - line_graph_window_bkd_piter<P, W>::start_() + line_graph_window_bkd_piter<P, W>::do_start_() { - mln_precondition(this->p_ref_.is_valid()); - // Update the sites, if needed. - if (!this->saved_p_ref_.is_valid() || this->p_ref_ != this->saved_p_ref_) - { - this->saved_p_ref_ = this->p_ref_; - win_.compute_sites_(*this); - } + this->site_set().compute_sites_(*this); i_ = this->sites_.rbegin(); - // FIXME: We might move the is_valid condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename W> inline void - line_graph_window_bkd_piter<P, W>::next_() + line_graph_window_bkd_piter<P, W>::do_next_() { - // Ensure the p_ref_ has not changed. - mln_precondition(this->p_ref_ == this->saved_p_ref_); ++i_; - // FIXME: We might move the is_valid condition within update_. - if (this->is_valid()) - update_(); } template <typename P, typename W> inline - void - line_graph_window_bkd_piter<P, W>::update_() + mln_psite(W) + line_graph_window_bkd_piter<P, W>::compute_p_() const { - // Update psite_. - this->psite_ = line_graph_psite(this->plg(), *i_); + return line_graph_psite(this->center().site_set(), *i_); } # endif // ! MLN_INCLUDE_ONLY diff --git a/milena/mln/core/internal/line_graph_vicinity_piter.hh b/milena/mln/core/internal/line_graph_vicinity_piter.hh index 5a2f699..ffb7616 100644 --- a/milena/mln/core/internal/line_graph_vicinity_piter.hh +++ b/milena/mln/core/internal/line_graph_vicinity_piter.hh @@ -39,7 +39,7 @@ # include <set> -# include <mln/core/concept/site_iterator.hh> +# include <mln/core/internal/site_relative_iterator_base.hh> # include <mln/core/site_set/p_line_graph.hh> # include <mln/core/image/line_graph_psite.hh> @@ -49,25 +49,22 @@ namespace mln template <typename P> class p_line_graph; template <typename P> class line_graph_psite; + // FIXME: Consider renaming line_graph_vicinity_piter_ as + // line_graph_relative_piter_. + namespace internal { /// \brief Base for iterator on a line graph vicinity. template <typename P, typename S, typename E> class line_graph_vicinity_piter_ - /* FIXME: We should update the interface of this class and inherit - from internal::site_relative_iterator_base< S, E > instead. */ - : public internal::site_iterator_base< S, E > + : public internal::site_relative_iterator_base< S, E > { typedef line_graph_vicinity_piter_<P, S, E> self_; - typedef Site_Iterator< self_ > super_; public: enum { dim = P::dim }; - typedef line_graph_psite psite; - typedef P point; - typedef mln_coord(point) coord; // FIXME: Dummy typedef. typedef void dpoint; // FIXME: Dummy typedef. @@ -77,115 +74,46 @@ namespace mln typedef std::set<util::edge_id> sites_t; public: - /// Conversion and accessors. - /// \{ - /// Reference to the corresponding point. - const point& to_point() const; - /// Reference to the corresponding point site. - const psite& to_psite() const; - /// Convert the iterator into a line graph psite. - operator psite() const; - - /// Return the reference psite. - const psite& p_ref() const; - /// Return the mln::p_line_graph corresponding to this piter. - const p_line_graph& plg() const; /// Return the set of sites (adjacent edge ids). sites_t& sites(); - /* FIXME: Get rid of this as soon as this class inherits from - internal::site_relative_iterator_base< S, E >. */ - const psite& p_hook_() const; - - /// Read-only access to the \a i-th coordinate. - coord operator[](unsigned i) const; - /// \} - protected: /// Construction. /// \{ + line_graph_vicinity_piter_(); template <typename Pref> line_graph_vicinity_piter_(const Pref& p_ref); /// \} protected: - /// The ``central'' psite of the vicinity. - const psite& p_ref_; - - /// The last reference psite whose ajacent psites have been computed. - psite saved_p_ref_; /// The set of edge ids adjacent to the reference psite. sites_t sites_; - - /// The psite corresponding to this iterator. - psite psite_; - /// The point corresponding to this iterator. - /* FIXME: Dummy value. To be removed as soon as the conversion - from psite to point is no longer mandatory. */ - point p_; }; - /* FIXME: This hand-made delegation is painful. We should rely on - the general mechanism provided by Point_Site. But then again, we - need to refine/adjust the interface of Point_Site w.r.t. the - mandatory conversions to points. */ + + /// Print a mln::line_graph_vicinity_piter_<P, S, E>. template <typename P, typename S, typename E> inline std::ostream& - operator<<(std::ostream& ostr, const line_graph_vicinity_piter_<P, S, E>& p); + operator<<(std::ostream& ostr, + const line_graph_vicinity_piter_<P, S, E>& p); # ifndef MLN_INCLUDE_ONLY template <typename P, typename S, typename E> - template <typename Pref> - inline - line_graph_vicinity_piter_<P, S, E>::line_graph_vicinity_piter_(const Pref& p_ref) - : p_ref_(exact(p_ref)), - // Initialize psite_ to a dummy value. - psite_() - { - } - - template <typename P, typename S, typename E> - inline - const P& - line_graph_vicinity_piter_<P, S, E>::to_point() const - { - return p_; - } - - template <typename P, typename S, typename E> - inline - const line_graph_psite& - line_graph_vicinity_piter_<P, S, E>::to_psite() const - { - return psite_; - } - - template <typename P, typename S, typename E> inline - line_graph_vicinity_piter_<P, S, E>::operator line_graph_psite () const + line_graph_vicinity_piter_<P, S, E>::line_graph_vicinity_piter_() { - mln_precondition(exact(*this).is_valid()); - return psite_; - } - - template <typename P, typename S, typename E> - inline - const line_graph_psite& - line_graph_vicinity_piter_<P, S, E>::p_ref() const - { - return p_ref_; } template <typename P, typename S, typename E> + template <typename Pref> inline - const p_line_graph& - line_graph_vicinity_piter_<P, S, E>::plg() const + line_graph_vicinity_piter_<P, S, E>::line_graph_vicinity_piter_(const Pref& p_ref) { - return p_ref_.plg(); + center_at(p_ref); } template <typename P, typename S, typename E> @@ -196,30 +124,13 @@ namespace mln return sites_; } - template <typename P, typename S, typename E> - inline - const line_graph_psite& - line_graph_vicinity_piter_<P, S, E>::p_hook_() const - { - return psite_; - } - - template <typename P, typename S, typename E> - inline - mln_coord(P) - line_graph_vicinity_piter_<P, S, E>::operator[](unsigned i) const - { - assert(i < dim); - return p_[i]; - } - template <typename P, typename S, typename E> inline std::ostream& operator<<(std::ostream& ostr, const line_graph_vicinity_piter_<P, S, E>& p) { - return ostr << p.to_psite(); + return ostr << p.unproxy_(); } # endif // ! MLN_INCLUDE_ONLY -- 1.6.0.1

1 0

2296: Update line graph elementary neighborhood and window.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/image/line_graph_elt_neighborhood.hh, * mln/core/image/line_graph_elt_window.hh (mln::line_graph_elt_neighborhood::site) (mln::line_graph_elt_window::site): Deduce these typedefs from their respective psites. (mln::line_graph_elt_neighborhood::compute_sites_) (mln::line_graph_elt_window::compute_sites_): Adjust to the new psite interface. s/pref()/center()/. s/plg()/center().site_set()/. --- milena/ChangeLog | 15 +++++++++++++++ .../mln/core/image/line_graph_elt_neighborhood.hh | 19 ++++++++++--------- milena/mln/core/image/line_graph_elt_window.hh | 16 +++++++++------- 3 files changed, 34 insertions(+), 16 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 763076d..f41074f 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,20 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph elementary neighborhood and window. + + * mln/core/image/line_graph_elt_neighborhood.hh, + * mln/core/image/line_graph_elt_window.hh + (mln::line_graph_elt_neighborhood::site) + (mln::line_graph_elt_window::site): + Deduce these typedefs from their respective psites. + (mln::line_graph_elt_neighborhood::compute_sites_) + (mln::line_graph_elt_window::compute_sites_): + Adjust to the new psite interface. + s/pref()/center()/. + s/plg()/center().site_set()/. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Add a site_set accessor on site_relative_iterator_base. * mln/core/internal/site_relative_iterator_base.hh diff --git a/milena/mln/core/image/line_graph_elt_neighborhood.hh b/milena/mln/core/image/line_graph_elt_neighborhood.hh index 80dc0f3..38b7d8f 100644 --- a/milena/mln/core/image/line_graph_elt_neighborhood.hh +++ b/milena/mln/core/image/line_graph_elt_neighborhood.hh @@ -38,7 +38,9 @@ - mln::graph_elt_window - mln::graph_elt_neighborhood - mln::line_graph_elt_window - - mln::line_graph_elt_neighborhood. */ + - mln::line_graph_elt_neighborhood. + + See https://trac.lrde.org/olena/ticket/139. */ /* FIXME: Due to the poor interface of mln::p_line_graph and mln::util::graph, we show to much implementation details here. @@ -70,10 +72,10 @@ namespace mln public: /// Associated types. /// \{ - /// The type of site corresponding to the neighborhood. - typedef P site; /// The type of psite corresponding to the neighborhood. typedef line_graph_psite psite; + /// The type of site corresponding to the neighborhood. + typedef mln_site(psite) site; // The type of the set of neighbors (edge ids adjacent to the // reference psite). typedef std::set<util::edge_id> sites_t; @@ -98,7 +100,6 @@ namespace mln window to_window() const; /// \} - /// Services for iterators. /// \{ /// Compute the set of sites for this neighborhood around \a piter. @@ -126,15 +127,15 @@ namespace mln line_graph_elt_neighborhood::compute_sites_(Site_Iterator<Piter>& piter_) const { Piter& piter = exact(piter_); - util::edge_id ref_edge_id = piter.p_ref().id(); + util::edge_id ref_edge_id = piter.center().edge_id(); sites_t& sites = piter.sites(); sites.clear(); /* FIXME: Move this computation out of the neighborhood. In fact, this should be a service of the graph, also proposed by the p_line_graph. */ // Ajacent edges connected through vertex 1. - util::vertex_id id1 = piter.p_ref().first_id(); - const util::vertex& vertex1 = piter.plg().gr_->vertex(id1); + util::vertex_id id1 = piter.center().first_id(); + const util::vertex& vertex1 = piter.center().site_set().gr_->vertex(id1); for (std::vector<util::edge_id>::const_iterator e = vertex1.edges.begin(); e != vertex1.edges.end(); ++e) // We explicitly enforce that the reference piter edge id is @@ -142,8 +143,8 @@ namespace mln if (*e != ref_edge_id) sites.insert(*e); // Ajacent edges connected through vertex 2. - util::vertex_id id2 = piter.p_ref().second_id(); - const util::vertex& vertex2 = piter.plg().gr_->vertex(id2); + util::vertex_id id2 = piter.center().second_id(); + const util::vertex& vertex2 = piter.center().site_set().gr_->vertex(id2); for (std::vector<util::edge_id>::const_iterator e = vertex2.edges.begin(); e != vertex2.edges.end(); ++e) // Same remark as above. diff --git a/milena/mln/core/image/line_graph_elt_window.hh b/milena/mln/core/image/line_graph_elt_window.hh index 04bc542..8649372 100644 --- a/milena/mln/core/image/line_graph_elt_window.hh +++ b/milena/mln/core/image/line_graph_elt_window.hh @@ -38,7 +38,9 @@ - mln::graph_elt_window - mln::graph_elt_neighborhood - mln::line_graph_elt_window - - mln::line_graph_elt_neighborhood. */ + - mln::line_graph_elt_neighborhood. + + See https://trac.lrde.org/olena/ticket/139. */ /* FIXME: Due to the poor interface of mln::p_line_graph and mln::util::graph, we show to much implementation details here. @@ -65,10 +67,10 @@ namespace mln public: /// Associated types. /// \{ - /// The type of site corresponding to the window. - typedef P site; /// The type of psite corresponding to the window. typedef line_graph_psite psite; + /// The type of site corresponding to the window. + typedef mln_site(psite) site; // The type of the set of window sites (edge ids adjacent to the // reference psite). typedef std::set<util::edge_id> sites_t; @@ -142,14 +144,14 @@ namespace mln id) itself into SITES, since it is part of the set of edges adjacent to VERTEX1 and VERTEX2, and will therefore be automatically added. */ - util::vertex_id id1 = piter.p_ref().first_id(); - const util::vertex& vertex1 = piter.plg().gr_->vertex(id1); + util::vertex_id id1 = piter.center().first_id(); + const util::vertex& vertex1 = piter.center().site_set().gr_->vertex(id1); for (std::vector<util::edge_id>::const_iterator e = vertex1.edges.begin(); e != vertex1.edges.end(); ++e) sites.insert(*e); // Ajacent edges connected through vertex 2. - util::vertex_id id2 = piter.p_ref().second_id(); - const util::vertex& vertex2 = piter.plg().gr_->vertex(id2); + util::vertex_id id2 = piter.center().second_id(); + const util::vertex& vertex2 = piter.center().site_set().gr_->vertex(id2); for (std::vector<util::edge_id>::const_iterator e = vertex2.edges.begin(); e != vertex2.edges.end(); ++e) sites.insert(*e); -- 1.6.0.1

1 0

2295: Add a site_set accessor on site_relative_iterator_base.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/internal/site_relative_iterator_base.hh (mln::internal::site_relative_iterator_base<S, E>::site_set): New method. --- milena/ChangeLog | 8 ++++++++ .../core/internal/site_relative_iterator_base.hh | 15 ++++++++++++++- 2 files changed, 22 insertions(+), 1 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 75826ef..763076d 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,13 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Add a site_set accessor on site_relative_iterator_base. + + * mln/core/internal/site_relative_iterator_base.hh + (mln::internal::site_relative_iterator_base<S, E>::site_set): + New method. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph psite set iterators. * mln/core/site_set/p_line_graph_piter.hh diff --git a/milena/mln/core/internal/site_relative_iterator_base.hh b/milena/mln/core/internal/site_relative_iterator_base.hh index ea30c22..f9b582f 100644 --- a/milena/mln/core/internal/site_relative_iterator_base.hh +++ b/milena/mln/core/internal/site_relative_iterator_base.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2008 EPITA Research and Development Laboratory +// Copyright (C) 2008 EPITA Research and Development Laboratory (LRDE) // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -75,6 +75,10 @@ namespace mln /// Go to the next point. void next_(); + /// Give the site set (neighborhood or window) that this + /// iterator browses. + const S& site_set() const; + /// The psite around which this iterator moves. const mln_psite(S)& center() const; @@ -172,6 +176,15 @@ namespace mln template <typename S, typename E> inline + const S& + site_relative_iterator_base<S, E>::site_set() const + { + mln_precondition(this->s_ != 0); + return *this->s_; + } + + template <typename S, typename E> + inline const mln_psite(S)& site_relative_iterator_base<S,E>::subj_() { -- 1.6.0.1

1 0

2294: Update line graph psite set iterators.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/site_set/p_line_graph_piter.hh (mln::p_line_graph_fwd_piter_::super) (mln::p_line_graph_bkd_piter_::super): Adjust. (mln::p_line_graph_fwd_piter_::dim) (mln::p_line_graph_bkd_piter_::dim) (mln::p_line_graph_fwd_piter_::point) (mln::p_line_graph_bkd_piter_::point) (mln::p_line_graph_fwd_piter_::site) (mln::p_line_graph_bkd_piter_::psite) (mln::p_line_graph_fwd_piter_::psite) (mln::p_line_graph_bkd_piter_::coord) (mln::p_line_graph_fwd_piter_::coord): Remove typedefs. (mln::p_line_graph_fwd_piter::p_line_graph_fwd_piter) (mln::p_line_graph_bkd_piter::p_line_graph_bkd_piter): New default ctors. Remove copy ctors. (mln::p_line_graph_fwd_piter::is_valid_) (mln::p_line_graph_bkd_piter::is_valid_) (mln::p_line_graph_fwd_piter::invalidate_) (mln::p_line_graph_bkd_piter::invalidate_) (mln::p_line_graph_fwd_piter::start_) (mln::p_line_graph_bkd_piter::start_) (mln::p_line_graph_fwd_piter::next_) (mln::p_line_graph_bkd_piter::next_): Adjust w.r.t. the new interface of line_graph_psite. (operator<<(std::ostream&, const p_line_graph_fwd_piter_&)) (operator<<(std::ostream&, const p_line_graph_bkd_piter_&)): Likewise. (mln::p_line_graph_fwd_piter::operator=) (mln::p_line_graph_bkd_piter::operator=) (mln::p_line_graph_fwd_piter::update) (mln::p_line_graph_bkd_piter::update_) (mln::p_line_graph_fwd_piter::to_point) (mln::p_line_graph_bkd_piter::to_point) (mln::p_line_graph_fwd_piter::to_psite) (mln::p_line_graph_bkd_piter::to_psite) (mln::p_line_graph_fwd_piter::operator psite) (mln::p_line_graph_bkd_piter::operator psite) (mln::p_line_graph_fwd_piter::operator[]): (mln::p_line_graph_bkd_piter::operator[]): Remove methods. (mln::p_line_graph_fwd_piter::plg_) (mln::p_line_graph_bkd_piter::plg_) (mln::p_line_graph_fwd_piter::id_) (mln::p_line_graph_bkd_piter::id_) (mln::p_line_graph_fwd_piter::psite_): (mln::p_line_graph_bkd_piter::psite_): Remove attributes. (mln::p_line_graph_fwd_piter::p_) (mln::p_line_graph_bkd_piter::p_): Get it from super_. --- milena/ChangeLog | 58 +++++ milena/mln/core/site_set/p_line_graph_piter.hh | 286 +++--------------------- 2 files changed, 85 insertions(+), 259 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 856b341..75826ef 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,63 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph psite set iterators. + + * mln/core/site_set/p_line_graph_piter.hh + (mln::p_line_graph_fwd_piter_::super) + (mln::p_line_graph_bkd_piter_::super): + Adjust. + (mln::p_line_graph_fwd_piter_::dim) + (mln::p_line_graph_bkd_piter_::dim) + (mln::p_line_graph_fwd_piter_::point) + (mln::p_line_graph_bkd_piter_::point) + (mln::p_line_graph_fwd_piter_::site) + (mln::p_line_graph_bkd_piter_::psite) + (mln::p_line_graph_fwd_piter_::psite) + (mln::p_line_graph_bkd_piter_::coord) + (mln::p_line_graph_fwd_piter_::coord): + Remove typedefs. + (mln::p_line_graph_fwd_piter::p_line_graph_fwd_piter) + (mln::p_line_graph_bkd_piter::p_line_graph_bkd_piter): + New default ctors. + Remove copy ctors. + (mln::p_line_graph_fwd_piter::is_valid_) + (mln::p_line_graph_bkd_piter::is_valid_) + (mln::p_line_graph_fwd_piter::invalidate_) + (mln::p_line_graph_bkd_piter::invalidate_) + (mln::p_line_graph_fwd_piter::start_) + (mln::p_line_graph_bkd_piter::start_) + (mln::p_line_graph_fwd_piter::next_) + (mln::p_line_graph_bkd_piter::next_): + Adjust w.r.t. the new interface of line_graph_psite. + (operator<<(std::ostream&, const p_line_graph_fwd_piter_&)) + (operator<<(std::ostream&, const p_line_graph_bkd_piter_&)): + Likewise. + (mln::p_line_graph_fwd_piter::operator=) + (mln::p_line_graph_bkd_piter::operator=) + (mln::p_line_graph_fwd_piter::update) + (mln::p_line_graph_bkd_piter::update_) + (mln::p_line_graph_fwd_piter::to_point) + (mln::p_line_graph_bkd_piter::to_point) + (mln::p_line_graph_fwd_piter::to_psite) + (mln::p_line_graph_bkd_piter::to_psite) + (mln::p_line_graph_fwd_piter::operator psite) + (mln::p_line_graph_bkd_piter::operator psite) + (mln::p_line_graph_fwd_piter::operator[]): + (mln::p_line_graph_bkd_piter::operator[]): + Remove methods. + (mln::p_line_graph_fwd_piter::plg_) + (mln::p_line_graph_bkd_piter::plg_) + (mln::p_line_graph_fwd_piter::id_) + (mln::p_line_graph_bkd_piter::id_) + (mln::p_line_graph_fwd_piter::psite_): + (mln::p_line_graph_bkd_piter::psite_): + Remove attributes. + (mln::p_line_graph_fwd_piter::p_) + (mln::p_line_graph_bkd_piter::p_): + Get it from super_. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph psite set. * mln/core/site_set/p_line_graph.hh (mln::p_line_graph): diff --git a/milena/mln/core/site_set/p_line_graph_piter.hh b/milena/mln/core/site_set/p_line_graph_piter.hh index 23518d6..4971075 100644 --- a/milena/mln/core/site_set/p_line_graph_piter.hh +++ b/milena/mln/core/site_set/p_line_graph_piter.hh @@ -53,21 +53,13 @@ namespace mln p_line_graph_fwd_piter_ > { typedef p_line_graph_fwd_piter_ self_; - typedef internal::site_iterator_base< P, self_ > super_; + typedef internal::site_set_iterator_base< p_line_graph, self_ > super_; public: - // Make definitions from super class available. - enum { dim = super_::dim }; - - typedef line_graph_psite psite; - typedef P point; - typedef mln_coord(point) coord; - /// Construction and assignment. /// \{ + p_line_graph_fwd_piter_(); p_line_graph_fwd_piter_(const p_line_graph& plg); - p_line_graph_fwd_piter_(const self_& rhs); - self_& operator= (const self_& rhs); /// \} /// Manipulation. @@ -76,47 +68,19 @@ namespace mln bool is_valid_() const; /// Invalidate the iterator. void invalidate_(); + /// Start an iteration. void start_(); - /// Go to the next point. void next_(); - /// Update the internal data of the iterator. - void update_(); /// \} - /// Conversion and accessors. - /// \{ - /// Reference to the corresponding point. - // FIXME: Dummy. - const point& to_point () const; - /// Reference to the corresponding point site. - const psite& to_psite () const; - /// Convert the iterator into a line graph psite. - operator psite() const; - - /// Read-only access to the \a i-th coordinate. - coord operator[](unsigned i) const; - /// \} - - private: - /// The p_line_graph this point site belongs to. - const p_line_graph* plg_; - /// The id of the edge this psite is pointing towards. - util::edge_id id_; - /// The psite corresponding to this iterator. - psite psite_; - /// The point corresponding to this iterator. - /* FIXME: Dummy value. To be removed as soon as the conversion - from psite to point is no longer mandatory. */ - point p_; + protected: + using super_::p_; }; - /* FIXME: This hand-made delegation is painful. We should rely on - the general mechanism provided by Point_Site. But then again, we - need to refine/adjust the interface of Point_Site w.r.t. the - mandatory conversions to points. */ + /// Print a mln::p_line_graph_fwd_piter_. template <typename P> inline std::ostream& @@ -134,21 +98,13 @@ namespace mln p_line_graph_bkd_piter_ > { typedef p_line_graph_bkd_piter_ self_; - typedef internal::site_iterator_base< P, self_ > super_; + typedef internal::site_set_iterator_base< p_line_graph, self_ > super_; public: - // Make definitions from super class available. - enum { dim = super_::dim }; - - typedef line_graph_psite psite; - typedef P point; - typedef mln_coord(point) coord; - /// Construction and assignment. /// \{ + p_line_graph_bkd_piter_(); p_line_graph_bkd_piter_(const p_line_graph& plg); - p_line_graph_bkd_piter_(const self_& rhs); - self_& operator= (const self_& rhs); /// \} /// Manipulation. @@ -157,47 +113,19 @@ namespace mln bool is_valid_() const; /// Invalidate the iterator. void invalidate_(); + /// Start an iteration. void start_(); - /// Go to the next point. void next_(); - /// Update the internal data of the iterator. - void update_(); - /// \} - - /// Conversion and accessors. - /// \{ - /// Reference to the corresponding point. - // FIXME: Dummy. - const point& to_point () const; - /// Reference to the corresponding point site. - const psite& to_psite () const; - /// Convert the iterator into a line graph psite. - operator psite() const; - - /// Read-only access to the \a i-th coordinate. - mln_coord(point) operator[](unsigned i) const; /// \} protected: - /// The p_line_graph this point site belongs to. - const p_line_graph* plg_; - /// The id of the edge this psite is pointing towards. - util::edge_id id_; - /// The psite corresponding to this iterator. - psite psite_; - /// The point corresponding to this iterator. - /* FIXME: Dummy value. To be removed as soon as the conversion - from psite to point is no longer mandatory. */ - point p_; + using super_::p_; }; - /* FIXME: This hand-made delegation is painful. We should rely on - the general mechanism provided by Point_Site. But then again, we - need to refine/adjust the interface of Point_Site w.r.t. the - mandatory conversions to points. */ + /// Print a mln::p_line_graph_bkd_piter_. template <typename P> inline std::ostream& @@ -212,44 +140,15 @@ namespace mln template <typename P> inline - p_line_graph_fwd_piter_::p_line_graph_fwd_piter_(const p_line_graph& plg) - : plg_(&plg), - // Initialize psite_ to a dummy value. - psite_(plg, -1) - { - // Invalidate id_. - this->invalidate(); - } - - template <typename P> - inline - p_line_graph_fwd_piter_::p_line_graph_fwd_piter_(const p_line_graph_fwd_piter_& rhs) - : plg_(rhs.plg_), - id_(rhs.id_), - psite_(rhs.psite_) + p_line_graph_fwd_piter_::p_line_graph_fwd_piter_() { } template <typename P> inline - p_line_graph_fwd_piter_& - p_line_graph_fwd_piter_::operator=(const p_line_graph_fwd_piter_& rhs) - { - if (&rhs == this) - return *this; - plg_ = rhs.plg_; - id_ = rhs.id_; - psite_ = rhs.psite_; - return *this; - } - - template <typename P> - inline - mln_coord(P) - p_line_graph_fwd_piter_::operator[](unsigned i) const + p_line_graph_fwd_piter_::p_line_graph_fwd_piter_(const p_line_graph& plg) { - // Dummy value. - return p_[i]; + this->change_target(plg); } template <typename P> @@ -257,7 +156,7 @@ namespace mln bool p_line_graph_fwd_piter_::is_valid_() const { - return plg_ && id_ < plg_->nedges(); + return p_.is_valid(); } template <typename P> @@ -265,7 +164,7 @@ namespace mln void p_line_graph_fwd_piter_::invalidate_() { - id_ = -1; + p_.invalidate(); } template <typename P> @@ -273,9 +172,7 @@ namespace mln void p_line_graph_fwd_piter_::start_() { - id_ = 0; - if (this->is_valid()) - update_(); + p_.change_edge_id(0); } template <typename P> @@ -283,54 +180,7 @@ namespace mln void p_line_graph_fwd_piter_::next_() { - ++id_.to_equiv(); - if (this->is_valid()) - update_(); - } - - template <typename P> - inline - void - p_line_graph_fwd_piter_::update_() - { - // Update psite_. - psite_ = line_graph_psite(*plg_, id_); - } - - template <typename P> - inline - const P& - p_line_graph_fwd_piter_::to_point() const - { - // Dummy value. - return p_; - } - - template <typename P> - inline - const line_graph_psite& - p_line_graph_fwd_piter_::to_psite() const - { - /* We don't check whether the iterator is valid before returning - the value using - - mln_precondition(this->is_valid()); - - since this method may be called *before* the iterator is - actually initialized. This is the case for instance when this - point iterator (say, P) is used to initialize another iterator - on window or neighborhood (say, Q); most of the time, for_all() - is responsible for the initialization of P, but it takes place - *after* the creation of Q. */ - return psite_; - } - - template <typename P> - inline - p_line_graph_fwd_piter_::operator line_graph_psite() const - { - mln_precondition(this->is_valid()); - return psite_; + p_.inc_edge_id(); } @@ -339,9 +189,7 @@ namespace mln std::ostream& operator<<(std::ostream& ostr, const p_line_graph_fwd_piter_& p) { - // FIXME: We should use p.to_psite() here, but as it lacks the - // precondition the conversion operator has, we use the latter. - return ostr << static_cast< line_graph_psite >(p); + return ostr << p.unproxy_(); } @@ -351,46 +199,15 @@ namespace mln template <typename P> inline - p_line_graph_bkd_piter_::p_line_graph_bkd_piter_(const p_line_graph& plg) - : plg_(&plg), - // Initialize psite_ to a dummy value. - psite_(plg, -1) - { - // Invalidate id_. - this->invalidate(); - } - - template <typename P> - inline - p_line_graph_bkd_piter_::p_line_graph_bkd_piter_(const p_line_graph_bkd_piter_& rhs) - : plg_(rhs.plg_), - id_(rhs.id_), - psite_(rhs.psite_) - { - } - - template <typename P> - inline - p_line_graph_bkd_piter_& - p_line_graph_bkd_piter_::operator=(const p_line_graph_bkd_piter_& rhs) + p_line_graph_bkd_piter_::p_line_graph_bkd_piter_() { - if (&rhs == this) - return *this; - plg_ = rhs.plg_; - id_ = rhs.id_; - psite_ = rhs.psite_; - // FIXME: Probably superfluous. -// update_(); - return *this; } template <typename P> inline - mln_coord(P) - p_line_graph_bkd_piter_::operator[](unsigned i) const + p_line_graph_bkd_piter_::p_line_graph_bkd_piter_(const p_line_graph& plg) { - // Dummy value. - return p_[i]; + this->change_target(plg); } template <typename P> @@ -398,7 +215,7 @@ namespace mln bool p_line_graph_bkd_piter_::is_valid_() const { - return plg_ && id_ < plg_->nedges(); + return p_.is_valid(); } template <typename P> @@ -406,7 +223,7 @@ namespace mln void p_line_graph_bkd_piter_::invalidate_() { - id_ = -1; + p_.set_id(this->site_set().nedges()); } template <typename P> @@ -414,9 +231,7 @@ namespace mln void p_line_graph_bkd_piter_::start_() { - id_ = plg_->nedges() - 1; - if (this->is_valid()) - update_(); + p_.set_id(this->site_set().nedges() - 1); } template <typename P> @@ -424,54 +239,7 @@ namespace mln void p_line_graph_bkd_piter_::next_() { - --id_.to_equiv(); - if (this->is_valid()) - update_(); - } - - template <typename P> - inline - void - p_line_graph_bkd_piter_::update_() - { - // Update psite_. - psite_ = line_graph_psite(*plg_, id_); - } - - template <typename P> - inline - const P& - p_line_graph_bkd_piter_::to_point() const - { - // Dummy value. - return p_; - } - - template <typename P> - inline - const line_graph_psite& - p_line_graph_bkd_piter_::to_psite() const - { - /* We don't check whether the iterator is valid before returning - the value using - - mln_precondition(this->is_valid()); - - since this method may be called *before* the iterator is - actually initialized. This is the case for instance when this - point iterator (say, P) is used to initialize another iterator - on window or neighborhood (say, Q); most of the time, for_all() - is responsible for the initialization of P, but it takes place - *after* the creation of Q. */ - return psite_; - } - - template <typename P> - inline - p_line_graph_bkd_piter_::operator line_graph_psite() const - { - mln_precondition(this->is_valid()); - return psite_; + p_.dec_edge_id(); } @@ -480,7 +248,7 @@ namespace mln std::ostream& operator<<(std::ostream& ostr, const p_line_graph_bkd_piter_& p) { - return ostr << static_cast< line_graph_psite >(p); + return ostr << p.unproxy_(); } # endif // ! MLN_INCLUDE_ONLY -- 1.6.0.1

1 0

2293: Update line graph psite set.
by Roland Levillain 17 Sep '08

17 Sep '08

* mln/core/site_set/p_line_graph.hh (mln::p_line_graph): Inherit from internal::site_set_base_< site_pair, p_line_graph >. (mln::p_line_graph::self_) (mln::p_line_graph::super_): New typedefs. (mln::p_line_graph::site): Remove typedef. (mln::p_line_graph::element): Define as mln_site(super_). (mln::p_line_graph::nsites): Set return type to unsigned. (mln::p_line_graph::has): Update w.r.t. the new interface of mln::line_graph_psite. * mln/core/concept/site_set.hh (site_set_nsites_check<mln::trait::site_set::nsites::known, E>::run): Add a FIXME. --- milena/ChangeLog | 19 ++++++++++++++++++ milena/mln/core/concept/site_set.hh | 1 + milena/mln/core/site_set/p_line_graph.hh | 31 +++++++++++++++++++++-------- 3 files changed, 42 insertions(+), 9 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index ae13b3c..856b341 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,24 @@ 2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph psite set. + + * mln/core/site_set/p_line_graph.hh (mln::p_line_graph): + Inherit from + internal::site_set_base_< site_pair, p_line_graph >. + (mln::p_line_graph::self_) + (mln::p_line_graph::super_): + New typedefs. + (mln::p_line_graph::site): Remove typedef. + (mln::p_line_graph::element): Define as mln_site(super_). + (mln::p_line_graph::nsites): Set return type to unsigned. + (mln::p_line_graph::has): Update w.r.t. the new interface of + mln::line_graph_psite. + * mln/core/concept/site_set.hh + (site_set_nsites_check<mln::trait::site_set::nsites::known, E>::run): + Add a FIXME. + +2008-09-17 Roland Levillain <roland(a)lrde.epita.fr> + Update line graph psite. * mln/core/image/line_graph_psite.hh diff --git a/milena/mln/core/concept/site_set.hh b/milena/mln/core/concept/site_set.hh index 2e9d4b7..40b288e 100644 --- a/milena/mln/core/concept/site_set.hh +++ b/milena/mln/core/concept/site_set.hh @@ -186,6 +186,7 @@ namespace mln { static void run() { + // FIXME: Return type should be std::size_t. unsigned (E::*m)() const = & E::nsites; m = 0; } diff --git a/milena/mln/core/site_set/p_line_graph.hh b/milena/mln/core/site_set/p_line_graph.hh index 036cfef..548b9e2 100644 --- a/milena/mln/core/site_set/p_line_graph.hh +++ b/milena/mln/core/site_set/p_line_graph.hh @@ -28,6 +28,8 @@ #ifndef MLN_CORE_SITE_SET_P_LINE_GRAPH_HH # define MLN_CORE_SITE_SET_P_LINE_GRAPH_HH +# include <mln/util/site_pair.hh> + # include <mln/core/concept/point_site.hh> # include <mln/core/internal/site_set_base.hh> # include <mln/accu/bbox.hh> @@ -47,6 +49,7 @@ namespace mln { + // Forward declaration. template<typename P> struct p_line_graph; @@ -69,8 +72,11 @@ namespace mln template<typename P> struct p_line_graph - : public internal::site_set_base_< line_graph_psite, p_line_graph > + : public internal::site_set_base_< site_pair, p_line_graph > { + typedef p_line_graph self_; + typedef internal::site_set_base_< site_pair, self_ > super_; + typedef util::graph graph; /// \brief Construct a line graph psite set from a graph of points. @@ -84,10 +90,7 @@ namespace mln /// Associated types. /// \{ /// Element associated type. - typedef P element; - - /// Site associated type. - typedef P site; + typedef mln_site(super_) element; /// Point_Site associated type. typedef line_graph_psite psite; @@ -107,7 +110,9 @@ namespace mln /// line graph. /// /// Required by the mln::Point_Set concept. - std::size_t nsites() const; + /* FIXME: Return type should be std::size_t (see + mln/core/concept/site_set.hh). */ + unsigned nsites() const; /// Return The number of vertices in the graph. std::size_t nvertices() const; @@ -160,6 +165,10 @@ namespace mln bool operator==(const p_line_graph& lhs, const p_line_graph& rhs); + + /* FIXME: Extend the `ord' mechanism instead of this ill-defined + pseudo-order. */ + /// \brief Inclusion of a mln::p_line_graph in another one. /// /// This inclusion relation is very strict for the moment, since our @@ -189,7 +198,7 @@ namespace mln template <typename P> inline - std::size_t + unsigned p_line_graph::nsites() const { return nedges(); @@ -235,9 +244,9 @@ namespace mln { return // Check whether P is compatible with this psite set. - (&p.plg() == this) && + (p.target_() == this) && // Check that the edge id of P belongs to the range of valid edge ids. - (p.id() < gr_->nedges()); + (p.is_valid()); } template <typename P> @@ -317,6 +326,10 @@ namespace mln bool operator==(const p_line_graph& lhs, const p_line_graph& rhs) { + /* FIXME: We should not rely on pointer equality here, as graph + will soon become shells using (shared) tracked pointers to + actual data. So, delegate the equality test to the graphs + themselves. */ return lhs.gr_.ptr_ == rhs.gr_.ptr_; } -- 1.6.0.1

1 0