Olena-patches April 2011

olena-patches@lrde.epita.fr

4 participants
107 discussions

last-svn-commit-220-gfc56934 Make the interface of thinning algorithms uniform w.r.t. functors.

by Roland Levillain

* mln/topo/skeleton/priority_driven_thinning.hh (mln::topo::skeleton::priority_driven_thinning): Catch up with mln::topo::skeleton::breadth_first_thinning. * mln/topo/detach_point.hh: Turn into a functor to match the new interface of thinning algorithms. * tests/topo/skeleton/breadth_first_thinning.cc * tests/topo/skeleton/breadth_first_thinning_constrained.cc * tests/topo/skeleton/priority_driven_thinning.cc * tests/topo/skeleton/priority_driven_thinning_constrained.cc: Adjust. --- milena/ChangeLog | 15 +++++ milena/mln/topo/detach_point.hh | 66 +++++++++++++++++--- .../mln/topo/skeleton/priority_driven_thinning.hh | 23 +++++-- .../tests/topo/skeleton/breadth_first_thinning.cc | 6 +- .../skeleton/breadth_first_thinning_constrained.cc | 6 +- .../topo/skeleton/priority_driven_thinning.cc | 6 +- .../priority_driven_thinning_constrained.cc | 6 +- 7 files changed, 104 insertions(+), 24 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index d4d9a23..a4a1345 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,20 @@ 2011-02-24 Roland Levillain <roland(a)lrde.epita.fr> + Make the interface of thinning algorithms uniform w.r.t. functors. + + * mln/topo/skeleton/priority_driven_thinning.hh + (mln::topo::skeleton::priority_driven_thinning): Catch up + with mln::topo::skeleton::breadth_first_thinning. + * mln/topo/detach_point.hh: Turn into a functor to match the new + interface of thinning algorithms. + * tests/topo/skeleton/breadth_first_thinning.cc + * tests/topo/skeleton/breadth_first_thinning_constrained.cc + * tests/topo/skeleton/priority_driven_thinning.cc + * tests/topo/skeleton/priority_driven_thinning_constrained.cc: + Adjust. + +2011-02-24 Roland Levillain <roland(a)lrde.epita.fr> + State a cell is not simple if it does not correspond to a facet. * mln/topo/is_simple_cell.hh diff --git a/milena/mln/topo/detach_point.hh b/milena/mln/topo/detach_point.hh index 818f7cd..6e4d22d 100644 --- a/milena/mln/topo/detach_point.hh +++ b/milena/mln/topo/detach_point.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2010 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2010, 2011 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -29,8 +29,7 @@ /// \file /// \brief Detaching a point from a binary image. -// FIXME: Not generic. Swap arguments and use Image and -// mln_psite(I) as types. +# include <mln/metal/equal.hh> # include <mln/core/image/image2d.hh> # include <mln/core/alias/point2d.hh> @@ -41,19 +40,68 @@ namespace mln namespace topo { - /// \brief Detach a point from a binary image. - inline - void - detach_point(const mln::point2d& p, mln::image2d<bool>& ima); + /// \brief Functor detaching a point from a binary image. + template <typename I> + class detach_point + { + public: + /// Build a functor. + detach_point(); + + /// Build a functor, and assign an image to it. + /// + /// \param ima The image. + detach_point(Image& ima); + + /// Set the underlying image. + void set_image(Image& ima); + + /// \brief Detach point \a p from the image. + void operator()(const mln_psite(I)& p) const; + + private: + /// The image. + I* ima_; + }; + # ifndef MLN_INCLUDE_ONLY + template <typename I> + inline + detach_point::detach_point() + : ima_(0) + { + // Ensure I is a binary image type. + /* FIXME: Not compatible with proxy/morphers on values. */ + mlc_equal(mln_value(I), bool)::check(); + } + + template <typename I> + inline + detach_point::detach_point(Image& ima) + : ima_(exact(&ima)) + { + // Ensure I is a binary image type. + /* FIXME: Not compatible with proxy/morphers on values. */ + mlc_equal(mln_value(I), bool)::check(); + } + + template <typename I> + inline + void + detach_point::set_image(Image& ima) + { + ima_ = exact(&ima); + } + + template <typename I> inline void - detach_point(const mln::point2d& p, mln::image2d<bool>& ima) + detach_point::operator()(const mln_psite(I)& p) const { - ima(p) = false; + (*ima_)(p) = false; } # endif // MLN_INCLUDE_ONLY diff --git a/milena/mln/topo/skeleton/priority_driven_thinning.hh b/milena/mln/topo/skeleton/priority_driven_thinning.hh index e29062f..ad8e63d 100644 --- a/milena/mln/topo/skeleton/priority_driven_thinning.hh +++ b/milena/mln/topo/skeleton/priority_driven_thinning.hh @@ -1,4 +1,5 @@ -// Copyright (C) 2009, 2010 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2009, 2010, 2011 EPITA Research and Development +// Laboratory (LRDE) // // This file is part of Olena. // @@ -62,10 +63,14 @@ namespace mln (sites). This functor must provide a method <tt>void set_image(const Image&)</tt>. \param detach A function used to detach a cell from \a input. + This functor must provide a method + <tt>void set_image(const Image&)</tt>. \param priority A priority function expressed as an image. \param constraint A constraint on point (site); if it returns \c false for a point, this point - will not be removed. */ + will not be removed. + + Keywords: skeletons, simple points. */ template <typename I, typename N, typename F, typename G, typename J, typename H> mln_concrete(I) @@ -87,9 +92,12 @@ namespace mln \param is_simple The predicate on the simplicity of points (sites). This functor must provide a method <tt>void set_image(const Image&)</tt>. - \param detach A function used to detach a cell from - \a input. - \param priority A priority function expressed as an image. */ + \param detach A function used to detach a cell from \a input. + This functor must provide a method + <tt>void set_image(const Image&)</tt>. + \param priority A priority function expressed as an image. + + Keywords: skeletons, simple points. */ template <typename I, typename N, typename F, typename G, typename J> mln_concrete(I) priority_driven_thinning(const Image& input, @@ -121,8 +129,9 @@ namespace mln const H& constraint = exact(constraint_); mln_concrete(I) output = duplicate(input); - // Attach the work image to IS_SIMPLE. + // Attach the work image to IS_SIMPLE and DETACH. is_simple.set_image(output); + detach.set_image(output); typedef mln_psite(I) psite; typedef p_queue_fast<psite> queue_t; @@ -141,7 +150,7 @@ namespace mln psite p = queue.pop_front(); if (output(p) && constraint(p) && is_simple(p)) { - detach(p, output); + detach(p); mln_niter(N) n(nbh, p); for_all(n) { diff --git a/milena/tests/topo/skeleton/breadth_first_thinning.cc b/milena/tests/topo/skeleton/breadth_first_thinning.cc index e77421a..1ed7260 100644 --- a/milena/tests/topo/skeleton/breadth_first_thinning.cc +++ b/milena/tests/topo/skeleton/breadth_first_thinning.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2010 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2010, 2011 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -64,9 +64,11 @@ int main() // Simplicity criterion functor. topo::is_simple_point2d<I, N> is_simple(nbh_fg, nbh_bg); + // Simple point detach procedure. + topo::detach_point detach; I output = topo::skeleton::breadth_first_thinning(input, nbh_fg, is_simple, - topo::detach_point); + detach); io::pbm::save(output, "breadth_first_thinning-small.pbm"); } diff --git a/milena/tests/topo/skeleton/breadth_first_thinning_constrained.cc b/milena/tests/topo/skeleton/breadth_first_thinning_constrained.cc index 8ec213a..c8fbe52 100644 --- a/milena/tests/topo/skeleton/breadth_first_thinning_constrained.cc +++ b/milena/tests/topo/skeleton/breadth_first_thinning_constrained.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2010 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2010, 2011 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -65,12 +65,14 @@ int main() // Simplicity criterion functor. topo::is_simple_point2d<I, N> is_simple(nbh_fg, nbh_bg); + // Simple point detach procedure. + topo::detach_point detach; // Constraint: do not collapse end points. topo::is_not_end_point<I, N> constraint(nbh_fg, input); I output = topo::skeleton::breadth_first_thinning(input, nbh_fg, is_simple, - topo::detach_point, + detach, constraint); io::pbm::save(output, "breadth_first_thinning_constrained-small.pbm"); } diff --git a/milena/tests/topo/skeleton/priority_driven_thinning.cc b/milena/tests/topo/skeleton/priority_driven_thinning.cc index 36470d1..6cfacae 100644 --- a/milena/tests/topo/skeleton/priority_driven_thinning.cc +++ b/milena/tests/topo/skeleton/priority_driven_thinning.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2010 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2010, 2011 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -68,6 +68,8 @@ int main() // Simplicity criterion functor. topo::is_simple_point2d<I, N> is_simple(nbh_fg, nbh_bg); + // Simple point detach procedure. + topo::detach_point detach; // Distance type. typedef value::int_u8 D; @@ -84,7 +86,7 @@ int main() I output = topo::skeleton::priority_driven_thinning(input, nbh_fg, is_simple, - topo::detach_point, + detach, priority); io::pbm::save(output, "priority_driven_thinning-small.pbm"); } diff --git a/milena/tests/topo/skeleton/priority_driven_thinning_constrained.cc b/milena/tests/topo/skeleton/priority_driven_thinning_constrained.cc index 822d5cd..32e17a1 100644 --- a/milena/tests/topo/skeleton/priority_driven_thinning_constrained.cc +++ b/milena/tests/topo/skeleton/priority_driven_thinning_constrained.cc @@ -1,4 +1,4 @@ -// Copyright (C) 2010 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2010, 2011 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -69,6 +69,8 @@ int main() // Simplicity criterion functor. topo::is_simple_point2d<I, N> is_simple(nbh_fg, nbh_bg); + // Simple point detach procedure. + topo::detach_point detach; // Constraint: do not collapse end points. topo::is_not_end_point<I, N> constraint(nbh_fg, input); @@ -87,7 +89,7 @@ int main() I output = topo::skeleton::priority_driven_thinning(input, nbh_fg, is_simple, - topo::detach_point, + detach, priority, constraint); io::pbm::save(output, "priority_driven_thinning_constrained-small.pbm"); -- 1.5.6.5

13 years, 8 months

last-svn-commit-219-g5326c7c State a cell is not simple if it does not correspond to a facet.

by Roland Levillain

* mln/topo/is_simple_cell.hh (mln::topo::is_simple_cell<I, N, NL, NH>::operator()): Here. --- milena/ChangeLog | 7 +++++++ milena/mln/make/attachment.hh | 2 ++ milena/mln/make/detachment.hh | 2 ++ milena/mln/topo/detach_cell.hh | 2 ++ milena/mln/topo/is_facet.hh | 2 ++ milena/mln/topo/is_simple_cell.hh | 26 +++++++++++++++++++++++++- 6 files changed, 40 insertions(+), 1 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 279f0a6..d4d9a23 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,3 +1,10 @@ +2011-02-24 Roland Levillain <roland(a)lrde.epita.fr> + + State a cell is not simple if it does not correspond to a facet. + + * mln/topo/is_simple_cell.hh + (mln::topo::is_simple_cell<I, N, NL, NH>::operator()): Here. + 2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> Use mln::data::paste to simplify mesh skeleton applications. diff --git a/milena/mln/make/attachment.hh b/milena/mln/make/attachment.hh index 3af5332..63eca65 100644 --- a/milena/mln/make/attachment.hh +++ b/milena/mln/make/attachment.hh @@ -74,6 +74,8 @@ namespace mln attachment(const Image& ima_, const mln_psite(I)& f, const Neighborhood<N>& nbh_) { + // FIXME: The current implementation of topo::is_facet is too + // naive: it does not take the values of the image into account. mln_precondition(topo::is_facet(f)); mlc_equal(mln_value(I), bool)::check(); diff --git a/milena/mln/make/detachment.hh b/milena/mln/make/detachment.hh index 6cd01ba..88b70a0 100644 --- a/milena/mln/make/detachment.hh +++ b/milena/mln/make/detachment.hh @@ -81,6 +81,8 @@ namespace mln detachment(const Image& ima_, const mln_psite(I)& f, const Neighborhood<N>& nbh_) { + // FIXME: The current implementation of topo::is_facet is too + // naive: it does not take the values of the image into account. mln_precondition(topo::is_facet(f)); mlc_equal(mln_value(I), bool)::check(); diff --git a/milena/mln/topo/detach_cell.hh b/milena/mln/topo/detach_cell.hh index 9e2a489..250babf 100644 --- a/milena/mln/topo/detach_cell.hh +++ b/milena/mln/topo/detach_cell.hh @@ -131,6 +131,8 @@ namespace mln detach_cell<I, N>::operator()(const mln_psite(I)& f) { mln_precondition(ima_); + // FIXME: The current implementation of topo::is_facet is too + // naive: it does not take the values of the image into account. mln_precondition(topo::is_facet(f)); typedef p_set<mln_psite(I)> faces_t; diff --git a/milena/mln/topo/is_facet.hh b/milena/mln/topo/is_facet.hh index 0b10040..675126c 100644 --- a/milena/mln/topo/is_facet.hh +++ b/milena/mln/topo/is_facet.hh @@ -52,6 +52,8 @@ namespace mln # ifndef MLN_INCLUDE_ONLY + // FIXME: Too naive: this code does not take the values of the + // image into account. template <unsigned D, typename G> inline bool diff --git a/milena/mln/topo/is_simple_cell.hh b/milena/mln/topo/is_simple_cell.hh index bf60c3d..0cf50fb 100644 --- a/milena/mln/topo/is_simple_cell.hh +++ b/milena/mln/topo/is_simple_cell.hh @@ -81,7 +81,12 @@ namespace mln /// Set the underlying image. void set_image(const mln::Image& ima); - /// Based on the algorithm A2 from couprie.08.pami. + /** \brief Test whether a face (expected to be facet) is a + simple cell. + + If \a p is not a facet, return false. + + Based on the algorithm A2 from couprie.08.pami. */ /* FIXME: We probably broke the compatiblity with g++ 3.3, as it seems this compiler does not like an indirect type like the one of the following operator's argument. Check and possibly @@ -124,6 +129,25 @@ namespace mln is_simple_cell<I, N, NL, NH>::operator()(const mln_psite(I)& p) const { mln_precondition(ima_); + // FIXME: Introduce `const I& ima = *ima_;' and use it instead of + // `ima_'. Or introduce an `ima()' accessor? + + // FIXME: We should be using topo::is_facet, but this routine is + // too naive, and does not take the values of the image into + // account. + { + // This (part of) ``algorithm'' considers that looking for + // faces of dimension n+1 is enough (which is the case + // if the image is a complex). + NH higher_adj_nbh; + mln_niter(NH) n(higher_adj_nbh, p); + for_all(n) + // If the higher-dim-faces neighborhood is not empty, then P + // is included in a face of higher dimension. + if (ima_->has(n) && (*ima_)(n)) + return false; + // Otherwise, F is a facet; continue. + } typedef p_set<mln_psite(I)> faces_t; -- 1.5.6.5

13 years, 8 months

last-svn-commit-218-gd298681 Use mln::data::paste to simplify mesh skeleton applications.

by Roland Levillain

* apps/mesh-segm-skel/mesh-complex-skel.cc, * apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc, * apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc: Here. --- milena/ChangeLog | 9 ++++++++ .../mesh-segm-skel/mesh-complex-max-curv-skel.cc | 22 ++++++++++---------- .../mesh-segm-skel/mesh-complex-pinv-curv-skel.cc | 22 ++++++++++---------- milena/apps/mesh-segm-skel/mesh-complex-skel.cc | 22 ++++++++++---------- 4 files changed, 42 insertions(+), 33 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 40e876c..279f0a6 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,14 @@ 2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + Use mln::data::paste to simplify mesh skeleton applications. + + * apps/mesh-segm-skel/mesh-complex-skel.cc, + * apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc, + * apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc: + Here. + +2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + Update mesh skeleton applications. * apps/mesh-segm-skel/mesh-complex-skel.cc, diff --git a/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc index 641b0b4..2d55ff2 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc @@ -42,6 +42,7 @@ #include <mln/core/image/dmorph/image_if.hh> #include <mln/core/image/dmorph/mutable_extension_ima.hh> #include <mln/core/routine/mutable_extend.hh> +#include <mln/data/paste.hh> #include <mln/value/label_16.hh> @@ -267,9 +268,6 @@ main(int argc, char* argv[]) // to triangles. typedef mln::mutable_extension_ima<bin_triangle_only_ima_t, bin_ima_t> bin_triangle_ima_t; - // FIXME: Find a shorter name (skel_ima ? Careful, there is already a `skel' image below). - bin_triangle_ima_t bin_triangle_ima = - mln::mutable_extend((surface | is_a_triangle).rw(), surface); // ------------------------ // // Simple point predicate. // @@ -302,11 +300,15 @@ main(int argc, char* argv[]) // Functor detaching a cell. mln::topo::detach_cell<bin_triangle_ima_t, adj_nbh_t> detach(adj_nbh); - mln_concrete_(bin_triangle_ima_t) skel = - mln::topo::skeleton::breadth_first_thinning(bin_triangle_ima, - nbh, - is_simple_triangle, - detach); + mln_concrete_(bin_ima_t) skel; + mln::initialize(skel, surface); + mln::data::paste + (mln::topo::skeleton::breadth_first_thinning + (mln::mutable_extend((surface | is_a_triangle).rw(), surface), + nbh, + is_simple_triangle, + detach), + skel); /*---------. @@ -324,7 +326,5 @@ main(int argc, char* argv[]) mln::io::off::save(skel | mln::pw::value(skel) == mln::pw::cst(true), output_filename); #endif - // FIXME: We have to ``unmorph'' (twice!) SKEL first, since save_bin_alt only - // handles complex_image's. - mln::io::off::save_bin_alt(skel.unmorph_().unmorph_(), output_filename); + mln::io::off::save_bin_alt(skel, output_filename); } diff --git a/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc index 5096efa..bf92305 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc @@ -42,6 +42,7 @@ #include <mln/core/image/dmorph/image_if.hh> #include <mln/core/image/dmorph/mutable_extension_ima.hh> #include <mln/core/routine/mutable_extend.hh> +#include <mln/data/paste.hh> #include <mln/value/label_16.hh> @@ -272,9 +273,6 @@ main(int argc, char* argv[]) // to triangles. typedef mln::mutable_extension_ima<bin_triangle_only_ima_t, bin_ima_t> bin_triangle_ima_t; - // FIXME: Find a shorter name (skel_ima ? Careful, there is already a `skel' image below). - bin_triangle_ima_t bin_triangle_ima = - mln::mutable_extend((surface | is_a_triangle).rw(), surface); // ------------------------ // // Simple point predicate. // @@ -307,11 +305,15 @@ main(int argc, char* argv[]) // Functor detaching a cell. mln::topo::detach_cell<bin_triangle_ima_t, adj_nbh_t> detach(adj_nbh); - mln_concrete_(bin_triangle_ima_t) skel = - mln::topo::skeleton::breadth_first_thinning(bin_triangle_ima, - nbh, - is_simple_triangle, - detach); + mln_concrete_(bin_ima_t) skel; + mln::initialize(skel, surface); + mln::data::paste + (mln::topo::skeleton::breadth_first_thinning + (mln::mutable_extend((surface | is_a_triangle).rw(), surface), + nbh, + is_simple_triangle, + detach), + skel); /*---------. @@ -329,7 +331,5 @@ main(int argc, char* argv[]) mln::io::off::save(skel | mln::pw::value(skel) == mln::pw::cst(true), output_filename); #endif - // FIXME: We have to ``unmorph'' (twice!) SKEL first, since save_bin_alt only - // handles complex_image's. - mln::io::off::save_bin_alt(skel.unmorph_().unmorph_(), output_filename); + mln::io::off::save_bin_alt(skel, output_filename); } diff --git a/milena/apps/mesh-segm-skel/mesh-complex-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-skel.cc index 4f5ca78..fcd37e5 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-skel.cc @@ -39,6 +39,7 @@ #include <mln/core/image/dmorph/image_if.hh> #include <mln/core/image/dmorph/mutable_extension_ima.hh> #include <mln/core/routine/mutable_extend.hh> +#include <mln/data/paste.hh> #include <mln/value/label_16.hh> @@ -225,9 +226,6 @@ main(int argc, char* argv[]) // to triangles. typedef mln::mutable_extension_ima<bin_triangle_only_ima_t, bin_ima_t> bin_triangle_ima_t; - // FIXME: Find a shorter name (skel_ima ? Careful, there is already a `skel' image below). - bin_triangle_ima_t bin_triangle_ima = - mln::mutable_extend((surface | is_a_triangle).rw(), surface); // ------------------------ // // Simple point predicate. // @@ -260,11 +258,15 @@ main(int argc, char* argv[]) // Functor detaching a cell. mln::topo::detach_cell<bin_triangle_ima_t, adj_nbh_t> detach(adj_nbh); - mln_concrete_(bin_triangle_ima_t) skel = - mln::topo::skeleton::breadth_first_thinning(bin_triangle_ima, - nbh, - is_simple_triangle, - detach); + mln_concrete_(bin_ima_t) skel; + mln::initialize(skel, surface); + mln::data::paste + (mln::topo::skeleton::breadth_first_thinning + (mln::mutable_extend((surface | is_a_triangle).rw(), surface), + nbh, + is_simple_triangle, + detach), + skel); /*---------. @@ -282,7 +284,5 @@ main(int argc, char* argv[]) mln::io::off::save(skel | mln::pw::value(skel) == mln::pw::cst(true), output_filename); #endif - // FIXME: We have to ``unmorph'' (twice!) SKEL first, since save_bin_alt only - // handles complex_image's. - mln::io::off::save_bin_alt(skel.unmorph_().unmorph_(), output_filename); + mln::io::off::save_bin_alt(skel, output_filename); } -- 1.5.6.5

13 years, 8 months

last-svn-commit-217-g65616e2 Update mesh skeleton applications.

by Roland Levillain

* apps/mesh-segm-skel/mesh-complex-skel.cc, * apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc, * apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc: Catch up with the new interface of breadth-first thinning and auxiliary routines. --- milena/ChangeLog | 10 +++ .../mesh-segm-skel/mesh-complex-max-curv-skel.cc | 82 ++++++++++++++++---- .../mesh-segm-skel/mesh-complex-pinv-curv-skel.cc | 82 ++++++++++++++++---- milena/apps/mesh-segm-skel/mesh-complex-skel.cc | 82 ++++++++++++++++---- 4 files changed, 205 insertions(+), 51 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index bff25d3..40e876c 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,15 @@ 2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + Update mesh skeleton applications. + + * apps/mesh-segm-skel/mesh-complex-skel.cc, + * apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc, + * apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc: + Catch up with the new interface of breadth-first thinning and + auxiliary routines. + +2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + More generic breadth-first-thinning-based skeleton transformations. * mln/topo/is_simple_cell.hh: Make this functor more generic. diff --git a/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc index edb943e..641b0b4 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc @@ -39,7 +39,9 @@ #include <mln/core/image/complex_image.hh> #include <mln/core/image/complex_neighborhoods.hh> -#include <mln/core/site_set/p_set.hh> +#include <mln/core/image/dmorph/image_if.hh> +#include <mln/core/image/dmorph/mutable_extension_ima.hh> +#include <mln/core/routine/mutable_extend.hh> #include <mln/value/label_16.hh> @@ -252,31 +254,77 @@ main(int argc, char* argv[]) | Skeleton. | `-----------*/ - mln::topo::is_simple_cell<bin_ima_t> is_simple_p; - /* FIXME: Cheat! We'd like to iterate on cells of highest - dimension (2-cells) only, but we cannot constrain the domain of - the input using image_if (yet) like this + // ---------------- // + // Skeleton image. // + // ---------------- // + + // Predicate type: is a face a triangle (2-face)? + typedef mln::topo::is_n_face<mln_psite_(bin_ima_t), D> is_a_triangle_t; + is_a_triangle_t is_a_triangle; + // Surface image type, of which domain is restricted to triangles. + typedef mln::image_if<bin_ima_t, is_a_triangle_t> bin_triangle_only_ima_t; + // Surface image type, of which iteration (not domain) is restricted + // to triangles. + typedef mln::mutable_extension_ima<bin_triangle_only_ima_t, bin_ima_t> + bin_triangle_ima_t; + // FIXME: Find a shorter name (skel_ima ? Careful, there is already a `skel' image below). + bin_triangle_ima_t bin_triangle_ima = + mln::mutable_extend((surface | is_a_triangle).rw(), surface); + + // ------------------------ // + // Simple point predicate. // + // ------------------------ // + + // Neighborhood type returning the set of (n-1)- and (n+1)-faces + // adjacent to a an n-face. + typedef mln::complex_lower_higher_neighborhood<D, G> adj_nbh_t; + // Neighborhood type returning the set of (n-1)-faces adjacent to a + // an n-face. + typedef mln::complex_lower_neighborhood<D, G> lower_adj_nbh_t; + // Neighborhood type returning the set of (n+1)-faces adjacent to a + // an n-face. + typedef mln::complex_higher_neighborhood<D, G> higher_adj_nbh_t; + // Predicate type: is a triangle (2-face) simple? + typedef mln::topo::is_simple_cell< bin_triangle_ima_t, + adj_nbh_t, + lower_adj_nbh_t, + higher_adj_nbh_t > + is_simple_triangle_t; + is_simple_triangle_t is_simple_triangle; + + // ------------------------------- // + // Simple point detach procedure. // + // ------------------------------- // + + // Type of adjacency relationships between faces of immediately + // lower and higher dimensions. + adj_nbh_t adj_nbh; + // Functor detaching a cell. + mln::topo::detach_cell<bin_triangle_ima_t, adj_nbh_t> detach(adj_nbh); + + mln_concrete_(bin_triangle_ima_t) skel = + mln::topo::skeleton::breadth_first_thinning(bin_triangle_ima, + nbh, + is_simple_triangle, + detach); - breadth_first_thinning(surface | is_n_face<2>, nbh, is_simple_p); - - As a workaround, we use the constraint predicate of the - skeleton routine to restrict the iteration to 2-cells. */ - mln::topo::is_n_face<mln_psite_(bin_ima_t), bin_ima_t::dim> constraint_p; - bin_ima_t skel = - mln::topo::skeleton::breadth_first_thinning(surface, nbh, - is_simple_p, - mln::topo::detach_cell<D, G>, - constraint_p); /*---------. | Output. | `---------*/ /* FIXME: This does not work (yet). - Use workaround mln::io::off::save_bin_alt instead (bad!) */ + Use workaround mln::io::off::save_bin_alt instead (bad!) + + Moreover, even if it worked, it would not have the same meaning + as mln::io::off::save_bin_alt. Maybe the latter is useful, after + all. But we need to factor it with the code of + mln::io::off::save, anyway. */ #if 0 mln::io::off::save(skel | mln::pw::value(skel) == mln::pw::cst(true), output_filename); #endif - mln::io::off::save_bin_alt(skel, output_filename); + // FIXME: We have to ``unmorph'' (twice!) SKEL first, since save_bin_alt only + // handles complex_image's. + mln::io::off::save_bin_alt(skel.unmorph_().unmorph_(), output_filename); } diff --git a/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc index e2bdf45..5096efa 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc @@ -39,7 +39,9 @@ #include <mln/core/image/complex_image.hh> #include <mln/core/image/complex_neighborhoods.hh> -#include <mln/core/site_set/p_set.hh> +#include <mln/core/image/dmorph/image_if.hh> +#include <mln/core/image/dmorph/mutable_extension_ima.hh> +#include <mln/core/routine/mutable_extend.hh> #include <mln/value/label_16.hh> @@ -257,31 +259,77 @@ main(int argc, char* argv[]) | Skeleton. | `-----------*/ - mln::topo::is_simple_cell<bin_ima_t> is_simple_p; - /* FIXME: Cheat! We'd like to iterate on cells of highest - dimension (2-cells) only, but we cannot constrain the domain of - the input using image_if (yet) like this + // ---------------- // + // Skeleton image. // + // ---------------- // + + // Predicate type: is a face a triangle (2-face)? + typedef mln::topo::is_n_face<mln_psite_(bin_ima_t), D> is_a_triangle_t; + is_a_triangle_t is_a_triangle; + // Surface image type, of which domain is restricted to triangles. + typedef mln::image_if<bin_ima_t, is_a_triangle_t> bin_triangle_only_ima_t; + // Surface image type, of which iteration (not domain) is restricted + // to triangles. + typedef mln::mutable_extension_ima<bin_triangle_only_ima_t, bin_ima_t> + bin_triangle_ima_t; + // FIXME: Find a shorter name (skel_ima ? Careful, there is already a `skel' image below). + bin_triangle_ima_t bin_triangle_ima = + mln::mutable_extend((surface | is_a_triangle).rw(), surface); + + // ------------------------ // + // Simple point predicate. // + // ------------------------ // + + // Neighborhood type returning the set of (n-1)- and (n+1)-faces + // adjacent to a an n-face. + typedef mln::complex_lower_higher_neighborhood<D, G> adj_nbh_t; + // Neighborhood type returning the set of (n-1)-faces adjacent to a + // an n-face. + typedef mln::complex_lower_neighborhood<D, G> lower_adj_nbh_t; + // Neighborhood type returning the set of (n+1)-faces adjacent to a + // an n-face. + typedef mln::complex_higher_neighborhood<D, G> higher_adj_nbh_t; + // Predicate type: is a triangle (2-face) simple? + typedef mln::topo::is_simple_cell< bin_triangle_ima_t, + adj_nbh_t, + lower_adj_nbh_t, + higher_adj_nbh_t > + is_simple_triangle_t; + is_simple_triangle_t is_simple_triangle; + + // ------------------------------- // + // Simple point detach procedure. // + // ------------------------------- // + + // Type of adjacency relationships between faces of immediately + // lower and higher dimensions. + adj_nbh_t adj_nbh; + // Functor detaching a cell. + mln::topo::detach_cell<bin_triangle_ima_t, adj_nbh_t> detach(adj_nbh); + + mln_concrete_(bin_triangle_ima_t) skel = + mln::topo::skeleton::breadth_first_thinning(bin_triangle_ima, + nbh, + is_simple_triangle, + detach); - breadth_first_thinning(surface | is_n_face<2>, nbh, is_simple_p); - - As a workaround, we use the constraint predicate of the - skeleton routine to restrict the iteration to 2-cells. */ - mln::topo::is_n_face<mln_psite_(bin_ima_t), bin_ima_t::dim> constraint_p; - bin_ima_t skel = - mln::topo::skeleton::breadth_first_thinning(surface, nbh, - is_simple_p, - mln::topo::detach_cell<D, G>, - constraint_p); /*---------. | Output. | `---------*/ /* FIXME: This does not work (yet). - Use workaround mln::io::off::save_bin_alt instead (bad!) */ + Use workaround mln::io::off::save_bin_alt instead (bad!) + + Moreover, even if it worked, it would not have the same meaning + as mln::io::off::save_bin_alt. Maybe the latter is useful, after + all. But we need to factor it with the code of + mln::io::off::save, anyway. */ #if 0 mln::io::off::save(skel | mln::pw::value(skel) == mln::pw::cst(true), output_filename); #endif - mln::io::off::save_bin_alt(skel, output_filename); + // FIXME: We have to ``unmorph'' (twice!) SKEL first, since save_bin_alt only + // handles complex_image's. + mln::io::off::save_bin_alt(skel.unmorph_().unmorph_(), output_filename); } diff --git a/milena/apps/mesh-segm-skel/mesh-complex-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-skel.cc index b8b7da8..4f5ca78 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-skel.cc @@ -36,7 +36,9 @@ #include <mln/core/image/complex_image.hh> #include <mln/core/image/complex_neighborhoods.hh> -#include <mln/core/site_set/p_set.hh> +#include <mln/core/image/dmorph/image_if.hh> +#include <mln/core/image/dmorph/mutable_extension_ima.hh> +#include <mln/core/routine/mutable_extend.hh> #include <mln/value/label_16.hh> @@ -210,31 +212,77 @@ main(int argc, char* argv[]) | Skeleton. | `-----------*/ - mln::topo::is_simple_cell<bin_ima_t> is_simple_p; - /* FIXME: Cheat! We'd like to iterate on cells of highest - dimension (2-cells) only, but we cannot constrain the domain of - the input using image_if (yet) like this + // ---------------- // + // Skeleton image. // + // ---------------- // + + // Predicate type: is a face a triangle (2-face)? + typedef mln::topo::is_n_face<mln_psite_(bin_ima_t), D> is_a_triangle_t; + is_a_triangle_t is_a_triangle; + // Surface image type, of which domain is restricted to triangles. + typedef mln::image_if<bin_ima_t, is_a_triangle_t> bin_triangle_only_ima_t; + // Surface image type, of which iteration (not domain) is restricted + // to triangles. + typedef mln::mutable_extension_ima<bin_triangle_only_ima_t, bin_ima_t> + bin_triangle_ima_t; + // FIXME: Find a shorter name (skel_ima ? Careful, there is already a `skel' image below). + bin_triangle_ima_t bin_triangle_ima = + mln::mutable_extend((surface | is_a_triangle).rw(), surface); + + // ------------------------ // + // Simple point predicate. // + // ------------------------ // + + // Neighborhood type returning the set of (n-1)- and (n+1)-faces + // adjacent to a an n-face. + typedef mln::complex_lower_higher_neighborhood<D, G> adj_nbh_t; + // Neighborhood type returning the set of (n-1)-faces adjacent to a + // an n-face. + typedef mln::complex_lower_neighborhood<D, G> lower_adj_nbh_t; + // Neighborhood type returning the set of (n+1)-faces adjacent to a + // an n-face. + typedef mln::complex_higher_neighborhood<D, G> higher_adj_nbh_t; + // Predicate type: is a triangle (2-face) simple? + typedef mln::topo::is_simple_cell< bin_triangle_ima_t, + adj_nbh_t, + lower_adj_nbh_t, + higher_adj_nbh_t > + is_simple_triangle_t; + is_simple_triangle_t is_simple_triangle; + + // ------------------------------- // + // Simple point detach procedure. // + // ------------------------------- // + + // Type of adjacency relationships between faces of immediately + // lower and higher dimensions. + adj_nbh_t adj_nbh; + // Functor detaching a cell. + mln::topo::detach_cell<bin_triangle_ima_t, adj_nbh_t> detach(adj_nbh); + + mln_concrete_(bin_triangle_ima_t) skel = + mln::topo::skeleton::breadth_first_thinning(bin_triangle_ima, + nbh, + is_simple_triangle, + detach); - breadth_first_thinning(surface | is_n_face<2>, nbh, is_simple_p); - - As a workaround, we use the constraint predicate of the - skeleton routine to restrict the iteration to 2-cells. */ - mln::topo::is_n_face<mln_psite_(bin_ima_t), bin_ima_t::dim> constraint_p; - bin_ima_t skel = - mln::topo::skeleton::breadth_first_thinning(surface, nbh, - is_simple_p, - mln::topo::detach_cell<D, G>, - constraint_p); /*---------. | Output. | `---------*/ /* FIXME: This does not work (yet). - Use workaround mln::io::off::save_bin_alt instead (bad!) */ + Use workaround mln::io::off::save_bin_alt instead (bad!) + + Moreover, even if it worked, it would not have the same meaning + as mln::io::off::save_bin_alt. Maybe the latter is useful, after + all. But we need to factor it with the code of + mln::io::off::save, anyway. */ #if 0 mln::io::off::save(skel | mln::pw::value(skel) == mln::pw::cst(true), output_filename); #endif - mln::io::off::save_bin_alt(skel, output_filename); + // FIXME: We have to ``unmorph'' (twice!) SKEL first, since save_bin_alt only + // handles complex_image's. + mln::io::off::save_bin_alt(skel.unmorph_().unmorph_(), output_filename); } -- 1.5.6.5

13 years, 8 months

last-svn-commit-216-g7a48c8c More generic breadth-first-thinning-based skeleton transformations.

by Roland Levillain

* mln/topo/is_simple_cell.hh: Make this functor more generic. * mln/topo/detach_cell.hh (detach): Turn this function into a more generic functor. * mln/make/attachment.hh (mln::make::attachment) * mln/make/detachment.hh (mln::make::detachment): Make these routines more generic. * mln/topo/skeleton/breadth_first_thinning.hh (mln::topo::skeleton::breadth_first_thinning): Adjust. * headers.mk: Regen. --- milena/ChangeLog | 15 +++ milena/mln/make/attachment.hh | 48 +++++---- milena/mln/make/detachment.hh | 41 +++++--- milena/mln/topo/detach_cell.hh | 107 ++++++++++++++++--- milena/mln/topo/is_simple_cell.hh | 81 ++++++++------- milena/mln/topo/skeleton/breadth_first_thinning.hh | 18 +++- 6 files changed, 213 insertions(+), 97 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index c0a7088..bff25d3 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,20 @@ 2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + More generic breadth-first-thinning-based skeleton transformations. + + * mln/topo/is_simple_cell.hh: Make this functor more generic. + * mln/topo/detach_cell.hh (detach): Turn this function into a + more generic functor. + * mln/make/attachment.hh (mln::make::attachment) + * mln/make/detachment.hh (mln::make::detachment): + Make these routines more generic. + * mln/topo/skeleton/breadth_first_thinning.hh + (mln::topo::skeleton::breadth_first_thinning): + Adjust. + * headers.mk: Regen. + +2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + Introduce a helper to build an mln::mutable_extension_ima. * mln/core/routine/mutable_extend.hh: New. diff --git a/milena/mln/make/attachment.hh b/milena/mln/make/attachment.hh index 088f9df..3af5332 100644 --- a/milena/mln/make/attachment.hh +++ b/milena/mln/make/attachment.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2009 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2009, 2010 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -43,52 +43,58 @@ namespace mln /** \brief Compute the attachment of the cell corresponding to the facet \a f to the image \a ima. + \param ima The input image to which the facet is attached. + \param f The psite corresponding to the attached facet. + \param nbh An adjacency relationship between faces + (should return the set of (n-1)- and (n+1)-faces + adjacent to an n-face). + + \return A set of faces containing the attachment. + + \pre ima is an image of Boolean values. \pre \a f is a facet (it does not belong to any face of higher dimension). - \pre ima is an image of Boolean values. - - \return a set of faces containing the attachment. We do not use the fomal definition of the attachment here (see couprie.08.pami). We use the following (equivalent) definition: an N-face F in CELL is in the attachment of CELL to IMA if it is adjacent to at least an (N-1)-face or an (N+1)-face that does not belong to CELL. */ - template <unsigned D, typename G, typename V> - p_set< complex_psite<D, G> > - attachment(const complex_psite<D, G>& f, - const complex_image<D, G, V>& ima); + template <typename I, typename N> + p_set<mln_psite(I)> + attachment(const Image& ima, const mln_psite(I)& f, + const Neighborhood<N>& nbh); # ifndef MLN_INCLUDE_ONLY - template <unsigned D, typename G, typename V> + template <typename I, typename N> inline - p_set< complex_psite<D, G> > - attachment(const complex_psite<D, G>& f, - const complex_image<D, G, V>& ima) + p_set<mln_psite(I)> + attachment(const Image& ima_, const mln_psite(I)& f, + const Neighborhood<N>& nbh_) { mln_precondition(topo::is_facet(f)); - mlc_equal(V, bool)::check(); + mlc_equal(mln_value(I), bool)::check(); + + I ima = exact(ima_); + N nbh = exact(nbh_); - typedef complex_psite<D, G> psite; - typedef p_set<psite> faces_t; + typedef p_set<mln_psite(I)> faces_t; faces_t f_hat = make::cell(f); - faces_t att_f; + faces_t attach_f; - typedef complex_lower_higher_neighborhood<D, G> adj_nbh_t; - adj_nbh_t adj_nbh; mln_piter(faces_t) g(f_hat); - mln_niter(adj_nbh_t) n(adj_nbh, g); + mln_niter(N) n(nbh, g); for_all(g) for_all(n) if (ima(n) && !f_hat.has(n)) { - att_f.insert(g); + attach_f.insert(g); break; } - return att_f; + return attach_f; } # endif // MLN_INCLUDE_ONLY diff --git a/milena/mln/make/detachment.hh b/milena/mln/make/detachment.hh index 16a8c92..6cd01ba 100644 --- a/milena/mln/make/detachment.hh +++ b/milena/mln/make/detachment.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2009 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2009, 2010 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -43,12 +43,19 @@ namespace mln /** \brief Compute the detachment of the cell corresponding to the facet \a f from the image \a ima. + \param ima The input image from which the facet is to be + detached. + \param f The psite corresponding to the facet to detach. + \param nbh An adjacency relationship between faces + (should return the set of (n-1)- and (n+1)-faces + adjacent to an n-face). + + \return A set of faces containing the detachment. + \pre \a f is a facet (it does not belong to any face of higher dimension). \pre \a ima is an image of Boolean values. - \return a set of faces containing the detachment. - We do not use the fomal definition of the detachment here (see couprie.08.pami). We use the following (equivalent) definition: an N-face F in CELL is not in the detachment of CELL from IMA if @@ -60,34 +67,34 @@ namespace mln the part that is removed, i.e., the detached part CELL - ATTACHMENT. It would be wise to rename this routine to something else. */ - template <unsigned D, typename G, typename V> - p_set< complex_psite<D, G> > - detachment(const complex_psite<D, G>& f, - const complex_image<D, G, V>& ima); + template <typename I, typename N> + p_set<mln_psite(I)> + detachment(const Image& ima, const mln_psite(I)& f, + const Neighborhood<N>& nbh); # ifndef MLN_INCLUDE_ONLY - template <unsigned D, typename G, typename V> + template <typename I, typename N> inline - p_set< complex_psite<D, G> > - detachment(const complex_psite<D, G>& f, - const complex_image<D, G, V>& ima) + p_set<mln_psite(I)> + detachment(const Image& ima_, const mln_psite(I)& f, + const Neighborhood<N>& nbh_) { mln_precondition(topo::is_facet(f)); - mlc_equal(V, bool)::check(); + mlc_equal(mln_value(I), bool)::check(); + + I ima = exact(ima_); + N nbh = exact(nbh_); - typedef complex_psite<D, G> psite; - typedef p_set<psite> faces_t; + typedef p_set<mln_psite(I)> faces_t; faces_t f_hat = make::cell(f); // Initialize DETACH_F to F_HAT. faces_t detach_f = f_hat; - typedef complex_lower_higher_neighborhood<D, G> adj_nbh_t; - adj_nbh_t adj_nbh; mln_piter(faces_t) g(f_hat); - mln_niter(adj_nbh_t) n(adj_nbh, g); + mln_niter(N) n(nbh, g); for_all(g) for_all(n) if (ima(n) && !f_hat.has(n)) diff --git a/milena/mln/topo/detach_cell.hh b/milena/mln/topo/detach_cell.hh index dfc4fb5..9e2a489 100644 --- a/milena/mln/topo/detach_cell.hh +++ b/milena/mln/topo/detach_cell.hh @@ -27,7 +27,7 @@ # define MLN_TOPO_DETACH_CELL_HH /// \file -/// \brief Detaching a cell from a binary complex-based image. +/// \brief Detaching a cell from a binary (probably complex-based) image. # include <mln/core/site_set/p_set.hh> # include <mln/core/image/complex_image.hh> @@ -40,38 +40,111 @@ namespace mln namespace topo { - /** Detach the cell corresponding to \a f from \a ima. + /** A functor detaching a cell from a binary (probably + complex-based) image. - \pre \a f is a facet (it does not belong to any face of higher - dimension). - \pre \a ima is an image of Boolean values. */ - template <unsigned D, typename G> - void - detach_cell(const complex_psite<D, G>& f, complex_image<D, G, bool>& ima); + \tparam I The type of the image. + \tparam N An neighborhood type corresponding to (directly) + adjacent faces (should return the set of (n-1)- and + (n+1)-faces adjacent to an n-face). */ + template <typename I, typename N> + class detach_cell + { + public: + /// Constructors. + /// \{ + /** Construct an mln::topo::detach_cell from a neighborhood. + + \param nbh An adjacency relationship between faces + (should return the set of (n-1)- and (n+1)-faces + adjacent to an n-face). */ + detach_cell(const Neighborhood<N>& nbh); + + /** Construct an mln::topo::detach_cell from an image and a + neighborhood. + + \pre \a ima is an image of Boolean values. + + \param ima The input image from which the facet is to be + detached. + \param nbh An adjacency relationship between faces + (should return the set of (n-1)- and (n+1)-faces + adjacent to an n-face). */ + detach_cell(mln::Image& ima, const Neighborhood<N>& nbh); + /// \} + + /* FIXME: Rename as init() or something like this? See how other + functors are written. */ + /** Set the underlying image. + + \pre \a ima is an image of Boolean values. */ + void set_image(mln::Image& ima); + + /** Detach the cell corresponding to \a f from \a ima. + + \pre \a f is a facet (it does not belong to any face of + higher dimension). + + \param f The psite corresponding to the facet to detach. + \param nbh An adjacency relationship between faces + (should return the set of (n-1)- and (n+1)-faces + adjacent to an n-face). */ + void + operator()(const mln_psite(I)& f); + + private: + I* ima_; + const N& nbh_; + }; # ifndef MLN_INCLUDE_ONLY - template <unsigned D, typename G> + template <typename I, typename N> + inline + detach_cell<I, N>::detach_cell(const Neighborhood<N>& nbh) + : ima_(0), nbh_(exact(nbh)) + { + } + + template <typename I, typename N> + inline + detach_cell<I, N>::detach_cell(mln::Image& ima, + const Neighborhood<N>& nbh) + : ima_(exact(&ima)), nbh_(exact(nbh)) + { + mlc_equal(mln_value(I), bool)::check(); + } + + template <typename I, typename N> + inline + void + detach_cell<I, N>::set_image(mln::Image& ima) + { + mlc_equal(mln_value(I), bool)::check(); + ima_ = exact(&ima); + } + + template <typename I, typename N> inline void - detach_cell(const complex_psite<D, G>& f, complex_image<D, G, bool>& ima) + detach_cell<I, N>::operator()(const mln_psite(I)& f) { + mln_precondition(ima_); mln_precondition(topo::is_facet(f)); - typedef complex_psite<D, G> psite; - typedef p_set<psite> faces_t; + typedef p_set<mln_psite(I)> faces_t; - // Compute the detachment of P from IMA. - faces_t detach = make::detachment(f, ima); - // Detach all its faces from IMA. + // Compute the detachment of P from *IMA_. + faces_t detach = make::detachment(*ima_, f, nbh_); + // Detach all its faces from *IMA_. # if 0 // FIXME: Does not work yet? Check again. - data::fill(ima | detach, false); + data::fill(*ima_ | detach, false); # endif mln_piter(faces_t) p(detach); for_all(p) - ima(p) = false; + (*ima_)(p) = false; } # endif // MLN_INCLUDE_ONLY diff --git a/milena/mln/topo/is_simple_cell.hh b/milena/mln/topo/is_simple_cell.hh index a86a8fa..bf60c3d 100644 --- a/milena/mln/topo/is_simple_cell.hh +++ b/milena/mln/topo/is_simple_cell.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2009 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2009, 2010 EPITA Research and Development Laboratory (LRDE) // // This file is part of Olena. // @@ -27,7 +27,6 @@ # define MLN_TOPO_IS_SIMPLE_CELL_HH /// \file -/// /// \brief Testing whether a facet is a simple cell. # include <mln/core/concept/function.hh> @@ -48,22 +47,29 @@ namespace mln namespace topo { + /* FIXME: Maybe we could add traits to deduce N from NL and NH (or + the converse). Anyway, the part of the code where neighborhood + are used should be moved into another functor + (`is_collapsible', see below), thus pushing away this + issue. */ + /** \brief A predicate for the simplicity of a point based on the collapse property of the attachment. The functor does not actually take a cell as input, but a face - that is expected to be a D-facet. */ - template <typename I> - class is_simple_cell : public mln::Function_v2b< is_simple_cell > + that is expected to be a D-facet. + + \tparam I The type of the image. + \tparam N The neighborhood type returning the set of + (n-1)- and (n+1)-faces adjacent to a an n-face. + \tparam NL The neighborhood type returning the set of + (n-1)-faces adjacent to a an n-face. + \tparam NH The neighborhood type returning the set of + (n+1)-faces adjacent to a an n-face. */ + template <typename I, typename N, typename NL, typename NH> + class is_simple_cell : public mln::Function_v2b< is_simple_cell<I, N, NL, NH> > { public: - /// Dimension of the image (and therefore of the complex). - static const unsigned D = I::dim; - /// Geometry of the image. - typedef mln_geom(I) G; - /// Psite type. - typedef mln::complex_psite<D, G> psite; - /// Result type of the functor. typedef bool result; @@ -76,8 +82,11 @@ namespace mln void set_image(const mln::Image& ima); /// Based on the algorithm A2 from couprie.08.pami. - bool operator()(const mln::complex_psite<I::dim,mln_geom(I)>& p) const; - // Tech note: The argument type above is explicit to help g++-3.3. + /* FIXME: We probably broke the compatiblity with g++ 3.3, as it + seems this compiler does not like an indirect type like the + one of the following operator's argument. Check and possibly + improve this. */ + bool operator()(const mln_psite(I)& p) const; private: const I* ima_; @@ -87,44 +96,44 @@ namespace mln # ifndef MLN_INCLUDE_ONLY - template <typename I> + template <typename I, typename N, typename NL, typename NH> inline - is_simple_cell::is_simple_cell() + is_simple_cell<I, N, NL, NH>::is_simple_cell() : ima_(0) { } - template <typename I> + template <typename I, typename N, typename NL, typename NH> inline - is_simple_cell::is_simple_cell(const mln::Image& ima) - : ima_(mln::exact(&ima)) + is_simple_cell<I, N, NL, NH>::is_simple_cell(const mln::Image& ima) + : ima_(exact(&ima)) { } - template <typename I> + template <typename I, typename N, typename NL, typename NH> inline void - is_simple_cell::set_image(const mln::Image& ima) + is_simple_cell<I, N, NL, NH>::set_image(const mln::Image& ima) { - ima_ = mln::exact(&ima); + ima_ = exact(&ima); } - template <typename I> + template <typename I, typename N, typename NL, typename NH> inline bool - is_simple_cell::operator()(const mln::complex_psite<I::dim,mln_geom(I)>& p) const - // Tech note: The argument type above is explicit to help g++-3.3. + is_simple_cell<I, N, NL, NH>::operator()(const mln_psite(I)& p) const { mln_precondition(ima_); - typedef p_set<psite> faces_t; + typedef p_set<mln_psite(I)> faces_t; - // Compute the attachment of the cell corresponding to P to he + // Compute the attachment of the cell corresponding to P to the // domain of *IMA_. - faces_t att = make::attachment(p, *ima_); + N adj_nbh; + faces_t att = make::attachment(*ima_, p, adj_nbh); // A cell with an empty attachment is not simple. - /* FIXME: Why does p_set not provide an empty() predicate? */ + /* FIXME: Why p_set does not provide an empty() predicate? */ if (att.nsites() == 0) return false; @@ -134,10 +143,8 @@ namespace mln routine. */ // Try to collapse the attachment (to a single point). { - typedef complex_lower_neighborhood<D, G> lower_adj_nbh_t; - typedef complex_higher_neighborhood<D, G> higher_adj_nbh_t; - lower_adj_nbh_t lower_adj_nbh; - higher_adj_nbh_t higher_adj_nbh; + NL lower_adj_nbh; + NH higher_adj_nbh; while (att.nsites() > 1) { @@ -149,11 +156,11 @@ namespace mln for_all(g) /* G cannot have dimension 0, since we later look for an adjacent face H of lower dimension. */ - if (static_cast<psite>(g).n() > 0) + if (static_cast<mln_psite(I)>(g).n() > 0) { // Check whether G is a facet within ATT. bool g_is_facet = true; - mln_niter(higher_adj_nbh_t) f(higher_adj_nbh, g); + mln_niter(NH) f(higher_adj_nbh, g); for_all(f) if (att.has(f)) { @@ -165,13 +172,13 @@ namespace mln // Look for a face H stricly included in G. bool gh_is_simple_pair = false; - mln_niter(lower_adj_nbh_t) h(lower_adj_nbh, g); + mln_niter(NL) h(lower_adj_nbh, g); for_all(h) { bool h_strictly_in_g = true; if (att.has(h)) { - mln_niter(higher_adj_nbh_t) i(higher_adj_nbh, h); + mln_niter(NH) i(higher_adj_nbh, h); for_all(i) if (i != g && att.has(i)) { diff --git a/milena/mln/topo/skeleton/breadth_first_thinning.hh b/milena/mln/topo/skeleton/breadth_first_thinning.hh index 7401bae..121c159 100644 --- a/milena/mln/topo/skeleton/breadth_first_thinning.hh +++ b/milena/mln/topo/skeleton/breadth_first_thinning.hh @@ -61,9 +61,13 @@ namespace mln (sites). This functor must provide a method <tt>void set_image(const Image&)</tt>. \param detach A function used to detach a cell from \a input. + This functor must provide a method + <tt>void set_image(const Image&)</tt>. \param constraint A constraint on point (site); if it returns \c false for a point, this point - will not be removed. */ + will not be removed. + + Keywords: skeletons, simple points. */ template <typename I, typename N, typename F, typename G, typename H> mln_concrete(I) breadth_first_thinning(const Image& input, @@ -83,8 +87,11 @@ namespace mln \param is_simple The predicate on the simplicity of points (sites). This functor must provide a method <tt>void set_image(const Image&)</tt>. - \param detach A function used to detach a cell from - \a input. */ + \param detach A function used to detach a cell from \a input. + This functor must provide a method + <tt>void set_image(const Image&)</tt>. + + Keywords: skeletons, simple points. */ template <typename I, typename N, typename F, typename G> mln_concrete(I) breadth_first_thinning(const Image& input, @@ -112,8 +119,9 @@ namespace mln const H& constraint = exact(constraint_); mln_concrete(I) output = duplicate(input); - // Attach the work image to IS_SIMPLE. + // Attach the work image to IS_SIMPLE and DETACH. is_simple.set_image(output); + detach.set_image(output); typedef mln_psite(I) psite; typedef p_queue_fast<psite> queue_t; @@ -131,7 +139,7 @@ namespace mln psite p = queue.pop_front(); if (output(p) && constraint(p) && is_simple(p)) { - detach(p, output); + detach(p); mln_niter(N) n(nbh, p); for_all(n) { -- 1.5.6.5

13 years, 8 months

last-svn-commit-215-g5c73804 Introduce a helper to build an mln::mutable_extension_ima.

by Roland Levillain

* mln/core/routine/mutable_extend.hh: New. * headers.mk: Regen. --- milena/ChangeLog | 7 +++ milena/headers.mk | 1 + .../max_sli.hh => core/routine/mutable_extend.hh} | 47 ++++++++++---------- 3 files changed, 31 insertions(+), 24 deletions(-) copy milena/mln/{geom/max_sli.hh => core/routine/mutable_extend.hh} (59%) diff --git a/milena/ChangeLog b/milena/ChangeLog index c6f99c1..c0a7088 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,12 @@ 2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + Introduce a helper to build an mln::mutable_extension_ima. + + * mln/core/routine/mutable_extend.hh: New. + * headers.mk: Regen. + +2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + Introduce an extension-by-mutable-image morpher. * mln/core/image/dmorph/mutable_extension_ima.hh: New. diff --git a/milena/headers.mk b/milena/headers.mk index a08fbfa..6794868 100644 --- a/milena/headers.mk +++ b/milena/headers.mk @@ -371,6 +371,7 @@ mln/core/routine/extend.hh \ mln/core/routine/init.hh \ mln/core/routine/init.hxx \ mln/core/routine/initialize.hh \ +mln/core/routine/mutable_extend.hh \ mln/core/routine/ops.hh \ mln/core/routine/primary.hh \ mln/core/site_set/all.hh \ diff --git a/milena/mln/geom/max_sli.hh b/milena/mln/core/routine/mutable_extend.hh similarity index 59% copy from milena/mln/geom/max_sli.hh copy to milena/mln/core/routine/mutable_extend.hh index cf4fc51..73f2672 100644 --- a/milena/mln/geom/max_sli.hh +++ b/milena/mln/core/routine/mutable_extend.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2007, 2008, 2009 EPITA Research and Development +// Copyright (C) 2008, 2009, 2010 EPITA Research and Development // Laboratory (LRDE) // // This file is part of Olena. @@ -24,45 +24,44 @@ // exception does not however invalidate any other reasons why the // executable file might be covered by the GNU General Public License. -#ifndef MLN_GEOM_MAX_SLI_HH -# define MLN_GEOM_MAX_SLI_HH +#ifndef MLN_CORE_ROUTINE_MUTABLE_EXTEND_HH +# define MLN_CORE_ROUTINE_MUTABLE_EXTEND_HH /// \file /// -/// Give the maximum sli of an image. +/// Routine to extend a mutable image with a mutable extension. +/// +/// \todo Use the 'instant' mechanism. +/// \todo Deal with ambiguities. +/// \todo Check that there is no extension yet (except "mutable_extendable"). + +# include <mln/core/image/dmorph/mutable_extension_ima.hh> -# include <mln/core/concept/image.hh> -# include <mln/geom/bbox.hh> namespace mln { - namespace geom - { - - /// Give the maximum sli of an image. - template <typename I> - mln_deduce(I, site, coord) max_sli(const Image& ima); + /// Extend a mutable image with a mutable image. + template <typename I, typename J> + mutable_extension_ima<I, J> + mutable_extend(Image& ima, Image<J>& ext); # ifndef MLN_INCLUDE_ONLY - template <typename I> - inline - mln_deduce(I, site, coord) max_sli(const Image& ima) - { - mln_precondition(exact(ima).is_valid()); - mln_deduce(I, site, coord) maxsli = geom::bbox(ima).pmax().sli(); - - return maxsli; - } + template <typename I, typename J> + mutable_extension_ima<I, J> + mutable_extend(Image& ima, Image<J>& ext) + { + mlc_converts_to(mln_value(J), mln_value(I))::check(); + mutable_extension_ima<I, J> tmp(exact(ima), exact(ext)); + return tmp; + } # endif // ! MLN_INCLUDE_ONLY - } // end of namespace mln::geom - } // end of namespace mln -#endif // ! MLN_GEOM_MAX_SLI_HH +#endif // ! MLN_CORE_ROUTINE_MUTABLE_EXTEND_HH -- 1.5.6.5

13 years, 8 months

last-svn-commit-214-g3076fae Introduce an extension-by-mutable-image morpher.

by Roland Levillain

* mln/core/image/dmorph/mutable_extension_ima.hh: New. * headers.mk: Regen. --- milena/ChangeLog | 7 ++ milena/headers.mk | 1 + .../{extension_ima.hh => mutable_extension_ima.hh} | 92 +++++++++----------- 3 files changed, 51 insertions(+), 49 deletions(-) copy milena/mln/core/image/dmorph/{extension_ima.hh => mutable_extension_ima.hh} (68%) diff --git a/milena/ChangeLog b/milena/ChangeLog index 373d9fa..c6f99c1 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,3 +1,10 @@ +2010-09-09 Roland Levillain <roland(a)lrde.epita.fr> + + Introduce an extension-by-mutable-image morpher. + + * mln/core/image/dmorph/mutable_extension_ima.hh: New. + * headers.mk: Regen. + 2010-09-20 Roland Levillain <roland(a)lrde.epita.fr> Get the `detach' argument of thinning algorithms by reference. diff --git a/milena/headers.mk b/milena/headers.mk index 90dd918..a08fbfa 100644 --- a/milena/headers.mk +++ b/milena/headers.mk @@ -277,6 +277,7 @@ mln/core/image/dmorph/hexa.hh \ mln/core/image/dmorph/hexa_piter.hh \ mln/core/image/dmorph/image2d_h.hh \ mln/core/image/dmorph/image_if.hh \ +mln/core/image/dmorph/mutable_extension_ima.hh \ mln/core/image/dmorph/p2p_image.hh \ mln/core/image/dmorph/slice_image.hh \ mln/core/image/dmorph/sub_image.hh \ diff --git a/milena/mln/core/image/dmorph/extension_ima.hh b/milena/mln/core/image/dmorph/mutable_extension_ima.hh similarity index 68% copy from milena/mln/core/image/dmorph/extension_ima.hh copy to milena/mln/core/image/dmorph/mutable_extension_ima.hh index a0bc9ca..f208581 100644 --- a/milena/mln/core/image/dmorph/extension_ima.hh +++ b/milena/mln/core/image/dmorph/mutable_extension_ima.hh @@ -1,4 +1,4 @@ -// Copyright (C) 2008, 2009 EPITA Research and Development Laboratory +// Copyright (C) 2008, 2009, 2010 EPITA Research and Development Laboratory // (LRDE) // // This file is part of Olena. @@ -24,13 +24,13 @@ // exception does not however invalidate any other reasons why the // executable file might be covered by the GNU General Public License. -#ifndef MLN_CORE_IMAGE_DMORPH_EXTENSION_IMA_HH -# define MLN_CORE_IMAGE_DMORPH_EXTENSION_IMA_HH +#ifndef MLN_CORE_IMAGE_DMORPH_MUTABLE_EXTENSION_IMA_HH +# define MLN_CORE_IMAGE_DMORPH_MUTABLE_EXTENSION_IMA_HH /// \file /// /// Definition of a morpher that extends the domain of an image -/// with an image. +/// with a readable and writable (rw) image. # include <mln/core/internal/image_identity.hh> @@ -40,17 +40,17 @@ namespace mln { // Forward declaration. - template <typename I, typename J> struct extension_ima; + template <typename I, typename J> struct mutable_extension_ima; namespace internal { - /// Data structure for \c mln::extension_ima<I, J>. + /// Data structure for \c mln::mutable_extension_ima<I, J>. template <typename I, typename J> - struct data< extension_ima<I, J> > + struct data< mutable_extension_ima<I, J> > { - data(I& ima, const J& ext); + data(I& ima, J& ext); I ima_; J ext_; @@ -63,7 +63,7 @@ namespace mln { template <typename I, typename J> - struct image_< extension_ima<I, J> > : image_ // Same as I except... + struct image_< mutable_extension_ima<I, J> > : image_ // Same as I except... { // ...these changes. typedef trait::image::category::identity_morpher category; @@ -77,11 +77,11 @@ namespace mln }; template <typename I, typename J, typename V> - struct ch_value< extension_ima<I, J>, V > + struct ch_value< mutable_extension_ima<I, J>, V > { typedef mlc_converts_to(mln_value(J), V) keep_ext; typedef mln_ch_value(I, V) Iv; - typedef extension_ima<Iv, J> Iv_ext; + typedef mutable_extension_ima<Iv, J> Iv_ext; typedef mlc_if(keep_ext, Iv_ext, Iv) ret; }; @@ -94,15 +94,15 @@ namespace mln /// \ingroup modimagedomainmorpher // template <typename I, typename J> - class extension_ima + class mutable_extension_ima - : public internal::image_identity< I, mln_domain(I), extension_ima<I, J> >, + : public internal::image_identity< I, mln_domain(I), mutable_extension_ima<I, J> >, private mlc_converts_to(mln_value(J), mln_value(I))::check_t { public: /// Skeleton. - typedef extension_ima< tag::image_, tag::ext_<J> > skeleton; + typedef mutable_extension_ima< tag::image_, tag::ext_<J> > skeleton; /// Image value type. typedef mln_value(I) value; @@ -111,14 +111,14 @@ namespace mln typedef mln_value(I) rvalue; /// Constructor without argument. - extension_ima(); + mutable_extension_ima(); /// Constructor from an image \p ima and a function \p ext. - extension_ima(I& ima, const J& ext); + mutable_extension_ima(I& ima, J& ext); /// Deferred initialization from an image \p ima and a function \p /// ext. - void init_(I& ima, const J& ext); + void init_(I& ima, J& ext); /// Test if \p p is valid. @@ -131,52 +131,52 @@ namespace mln mln_value(I) operator()(const mln_psite(I)& p) const; /// Read-write access to the image value located at site \p p. - mln_morpher_lvalue(I) operator()(const mln_psite(I)& p); + mln_lvalue(I) operator()(const mln_psite(I)& p); - /// Read-only access to the extension domain (image). - const J& extension() const; + /// Access to the extension domain (image). + J& extension() ; }; // init_ template <typename I, typename J, typename M> - void init_(tag::image_t, extension_ima<I,J>& target, const M& model); + void init_(tag::image_t, mutable_extension_ima<I,J>& target, const M& model); template <typename J, typename I> - void init_(tag::extension_t, J& target, const extension_ima<I,J>& model); + void init_(tag::extension_t, J& target, const mutable_extension_ima<I,J>& model); # ifndef MLN_INCLUDE_ONLY - // internal::data< extension_ima<I,S> > + // internal::data< mutable_extension_ima<I,S> > namespace internal { template <typename I, typename J> inline - data< extension_ima<I, J> >::data(I& ima, const J& ext) + data< mutable_extension_ima<I, J> >::data(I& ima, J& ext) : ima_(ima), - ext_(const_cast<J&>(ext)) + ext_(ext) { } } // end of namespace mln::internal - // extension_ima<I, J> + // mutable_extension_ima<I, J> template <typename I, typename J> inline - extension_ima<I, J>::extension_ima() + mutable_extension_ima<I, J>::mutable_extension_ima() { } template <typename I, typename J> inline - extension_ima<I, J>::extension_ima(I& ima, const J& ext) + mutable_extension_ima<I, J>::mutable_extension_ima(I& ima, J& ext) { init_(ima, ext); } @@ -184,16 +184,16 @@ namespace mln template <typename I, typename J> inline void - extension_ima<I, J>::init_(I& ima, const J& ext) + mutable_extension_ima<I, J>::init_(I& ima, J& ext) { - this->data_ = new internal::data< extension_ima<I, J> >(ima, ext); + this->data_ = new internal::data< mutable_extension_ima<I, J> >(ima, ext); } template <typename I, typename J> template <typename P> inline bool - extension_ima<I, J>::has(const P& p) const + mutable_extension_ima<I, J>::has(const P& p) const { mln_precondition(this->is_valid()); mln_precondition(this->data_->ext_.is_valid()); @@ -205,7 +205,7 @@ namespace mln template <typename I, typename J> inline mln_value(I) - extension_ima<I, J>::operator()(const mln_psite(I)& p) const + mutable_extension_ima<I, J>::operator()(const mln_psite(I)& p) const { mln_precondition(this->is_valid()); mln_precondition(has(p)); @@ -219,29 +219,23 @@ namespace mln template <typename I, typename J> inline - mln_morpher_lvalue(I) - extension_ima<I, J>::operator()(const mln_psite(I)& p) + mln_lvalue(I) + mutable_extension_ima<I, J>::operator()(const mln_psite(I)& p) { - static mln_value(I) cpy; mln_precondition(this->is_valid()); mln_precondition(has(p)); - // See the above comment about if-else v. ternary. + // if-else is preferred to the ternary op to allow for the + // function result to convert towards the expected return type. if (this->data_->ima_.domain().has(p)) return this->data_->ima_(p); else - { - // This hack makes this signature valid both in the image - // domain and in its extension. It works even if - // mln_morpher_lvalue(I) is a mutable reference. - cpy = this->data_->ext_(p); - return cpy; - } + return this->data_->ext_(p); } template <typename I, typename J> inline - const J& - extension_ima<I, J>::extension() const + J& + mutable_extension_ima<I, J>::extension() { mln_precondition(this->is_valid()); return this->data_->ext_; @@ -251,7 +245,7 @@ namespace mln template <typename I, typename J, typename M> inline - void init_(tag::image_t, extension_ima<I,J>& target, const M& model) + void init_(tag::image_t, mutable_extension_ima<I,J>& target, const M& model) { I ima; init_(tag::image, ima, model); @@ -262,10 +256,10 @@ namespace mln template <typename J, typename I> inline - void init_(tag::extension_t, J& target, const extension_ima<I,J>& model) + void init_(tag::extension_t, J& target, const mutable_extension_ima<I,J>& model) { typedef mlc_unconst(J) J_; - J_& ext_ = const_cast<J_&>(model.extension()); + J_& ext_ = const_cast< mutable_extension_ima<I,J>& >(model).extension(); J_& target_ = const_cast<J_&>(target); target_ = ext_; } @@ -275,4 +269,4 @@ namespace mln } // end of namespace mln -#endif // ! MLN_CORE_IMAGE_DMORPH_EXTENSION_IMA_HH +#endif // ! MLN_CORE_IMAGE_DMORPH_MUTABLE_EXTENSION_IMA_HH -- 1.5.6.5

13 years, 8 months

last-svn-commit-213-ga6b48d3 Get the `detach' argument of thinning algorithms by reference.

by Roland Levillain

* mln/topo/skeleton/breadth_first_thinning.hh (topo::skeleton::breadth_first_thinning) * mln/topo/skeleton/priority_driven_thinning.hh (topo::skeleton::priority_driven_thinning): Here. --- milena/ChangeLog | 10 ++++++++++ milena/mln/topo/skeleton/breadth_first_thinning.hh | 8 ++++---- .../mln/topo/skeleton/priority_driven_thinning.hh | 8 ++++---- 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 9a2bbcc..373d9fa 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,3 +1,13 @@ +2010-09-20 Roland Levillain <roland(a)lrde.epita.fr> + + Get the `detach' argument of thinning algorithms by reference. + + * mln/topo/skeleton/breadth_first_thinning.hh + (topo::skeleton::breadth_first_thinning) + * mln/topo/skeleton/priority_driven_thinning.hh + (topo::skeleton::priority_driven_thinning): + Here. + 2010-09-19 Roland Levillain <roland(a)lrde.epita.fr> Get rid of intermediate psites in thinning algorithms. diff --git a/milena/mln/topo/skeleton/breadth_first_thinning.hh b/milena/mln/topo/skeleton/breadth_first_thinning.hh index 286e3e0..7401bae 100644 --- a/milena/mln/topo/skeleton/breadth_first_thinning.hh +++ b/milena/mln/topo/skeleton/breadth_first_thinning.hh @@ -69,7 +69,7 @@ namespace mln breadth_first_thinning(const Image& input, const Neighborhood<N>& nbh, Function_v2b<F>& is_simple, - G detach, + G& detach, const Function_v2b<H>& constraint); @@ -90,7 +90,7 @@ namespace mln breadth_first_thinning(const Image& input, const Neighborhood<N>& nbh, Function_v2b<F>& is_simple, - G detach); + G& detach); # ifndef MLN_INCLUDE_ONLY @@ -101,7 +101,7 @@ namespace mln breadth_first_thinning(const Image& input_, const Neighborhood<N>& nbh_, Function_v2b<F>& is_simple_, - G detach, + G& detach, const Function_v2b<H>& constraint_) { trace::entering("topo::skeleton::breadth_first_thinning"); @@ -153,7 +153,7 @@ namespace mln breadth_first_thinning(const Image& input, const Neighborhood<N>& nbh, Function_v2b<F>& is_simple, - G detach) + G& detach) { return breadth_first_thinning(input, nbh, is_simple, detach, fun::p2b::tautology()); diff --git a/milena/mln/topo/skeleton/priority_driven_thinning.hh b/milena/mln/topo/skeleton/priority_driven_thinning.hh index cacc575..e29062f 100644 --- a/milena/mln/topo/skeleton/priority_driven_thinning.hh +++ b/milena/mln/topo/skeleton/priority_driven_thinning.hh @@ -72,7 +72,7 @@ namespace mln priority_driven_thinning(const Image& input, const Neighborhood<N>& nbh, Function_v2b<F>& is_simple, - G detach, + G& detach, const Image<J>& priority, const Function_v2b<H>& constraint); @@ -95,7 +95,7 @@ namespace mln priority_driven_thinning(const Image& input, const Neighborhood<N>& nbh, Function_v2b<F>& is_simple, - G detach, + G& detach, const Image<J>& priority); @@ -108,7 +108,7 @@ namespace mln priority_driven_thinning(const Image& input_, const Neighborhood<N>& nbh_, Function_v2b<F>& is_simple_, - G detach, + G& detach, const Image<J>& priority_, const Function_v2b<H>& constraint_) { @@ -163,7 +163,7 @@ namespace mln priority_driven_thinning(const Image& input, const Neighborhood<N>& nbh, Function_v2b<F>& is_simple, - G detach, + G& detach, const Image<J>& priority) { return priority_driven_thinning(input, nbh, is_simple, detach, -- 1.5.6.5

13 years, 8 months

last-svn-commit-212-g004dc21 Get rid of intermediate psites in thinning algorithms.

by Roland Levillain

* mln/topo/skeleton/breadth_first_thinning.hh, * mln/topo/skeleton/priority_driven_thinning.hh: Here. --- milena/ChangeLog | 8 ++++++++ milena/mln/topo/skeleton/breadth_first_thinning.hh | 16 ++++------------ .../mln/topo/skeleton/priority_driven_thinning.hh | 16 ++++------------ 3 files changed, 16 insertions(+), 24 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index e0532ab..9a2bbcc 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,13 @@ 2010-09-19 Roland Levillain <roland(a)lrde.epita.fr> + Get rid of intermediate psites in thinning algorithms. + + * mln/topo/skeleton/breadth_first_thinning.hh, + * mln/topo/skeleton/priority_driven_thinning.hh: + Here. + +2010-09-19 Roland Levillain <roland(a)lrde.epita.fr> + Have topo::is_n_face take a psite type as class parameter. * mln/topo/is_n_face.hh: Here, so that the argument of this diff --git a/milena/mln/topo/skeleton/breadth_first_thinning.hh b/milena/mln/topo/skeleton/breadth_first_thinning.hh index d2f33b5..286e3e0 100644 --- a/milena/mln/topo/skeleton/breadth_first_thinning.hh +++ b/milena/mln/topo/skeleton/breadth_first_thinning.hh @@ -119,15 +119,9 @@ namespace mln typedef p_queue_fast<psite> queue_t; queue_t queue; // Populate QUEUE with candidate simple points. - mln_piter(I) p_(output.domain()); - for_all(p_) + mln_piter(I) p(output.domain()); + for_all(p) { - /* CONSTRAINTS and IS_SIMPLE are site-to-boolean (p2b) - predicate functors; passing an iterator as argument might - not be possible (C++ cannot resolve template routines if - an implicit conversion of the argument is needed). Help - the compiler and pass an actual, explicit psite. */ - psite p = p_; if (output(p) && constraint(p) && is_simple(p)) queue.push(p); } @@ -138,11 +132,9 @@ namespace mln if (output(p) && constraint(p) && is_simple(p)) { detach(p, output); - mln_niter(N) n_(nbh, p); - for_all(n_) + mln_niter(N) n(nbh, p); + for_all(n) { - // Same remark as above regarding P and P_. - psite n = n_; if (output.domain().has(n) && output(n) && constraint(n) && is_simple(n)) queue.push(n); diff --git a/milena/mln/topo/skeleton/priority_driven_thinning.hh b/milena/mln/topo/skeleton/priority_driven_thinning.hh index 42e1b13..cacc575 100644 --- a/milena/mln/topo/skeleton/priority_driven_thinning.hh +++ b/milena/mln/topo/skeleton/priority_driven_thinning.hh @@ -129,15 +129,9 @@ namespace mln typedef p_priority<mln_value(J), queue_t> priority_queue_t; priority_queue_t queue; // Populate QUEUE with candidate simple points. - mln_piter(I) p_(output.domain()); - for_all(p_) + mln_piter(I) p(output.domain()); + for_all(p) { - /* CONSTRAINTS and IS_SIMPLE are site-to-boolean (p2b) - predicate functors; passing an iterator as argument might - not be possible (C++ cannot resolve template routines if - an implicit conversion of the argument is needed). Help - the compiler and pass an actual, explicit psite. */ - psite p = p_; if (output(p) && constraint(p) && is_simple(p)) queue.push(priority(p), p); } @@ -148,11 +142,9 @@ namespace mln if (output(p) && constraint(p) && is_simple(p)) { detach(p, output); - mln_niter(N) n_(nbh, p); - for_all(n_) + mln_niter(N) n(nbh, p); + for_all(n) { - // Same remark as above regarding P and P_. - psite n = n_; if (output.domain().has(n) && output(n) && constraint(n) && is_simple(n)) queue.push(priority(n), n); -- 1.5.6.5

13 years, 8 months

last-svn-commit-211-ga47828e Have topo::is_n_face take a psite type as class parameter.

by Roland Levillain

* mln/topo/is_n_face.hh: Here, so that the argument of this functor (e.g., an iterator) is always converted to the psite type. * apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc, * apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc, * apps/mesh-segm-skel/mesh-complex-skel.cc: Adjust. --- milena/ChangeLog | 12 ++++++++++++ .../mesh-segm-skel/mesh-complex-max-curv-skel.cc | 2 +- .../mesh-segm-skel/mesh-complex-pinv-curv-skel.cc | 2 +- milena/apps/mesh-segm-skel/mesh-complex-skel.cc | 2 +- milena/mln/topo/is_n_face.hh | 16 ++++++++-------- 5 files changed, 23 insertions(+), 11 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 11924f1..e0532ab 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,3 +1,15 @@ +2010-09-19 Roland Levillain <roland(a)lrde.epita.fr> + + Have topo::is_n_face take a psite type as class parameter. + + * mln/topo/is_n_face.hh: Here, so that the argument of this + functor (e.g., an iterator) is always converted to the psite + type. + * apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc, + * apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc, + * apps/mesh-segm-skel/mesh-complex-skel.cc: + Adjust. + 2010-09-17 Roland Levillain <roland(a)lrde.epita.fr> Aesthetic changes in thinning algorithms. diff --git a/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc index 5c17726..edb943e 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-max-curv-skel.cc @@ -261,7 +261,7 @@ main(int argc, char* argv[]) As a workaround, we use the constraint predicate of the skeleton routine to restrict the iteration to 2-cells. */ - mln::topo::is_n_face<bin_ima_t::dim> constraint_p; + mln::topo::is_n_face<mln_psite_(bin_ima_t), bin_ima_t::dim> constraint_p; bin_ima_t skel = mln::topo::skeleton::breadth_first_thinning(surface, nbh, is_simple_p, diff --git a/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc index 7092b18..e2bdf45 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-pinv-curv-skel.cc @@ -266,7 +266,7 @@ main(int argc, char* argv[]) As a workaround, we use the constraint predicate of the skeleton routine to restrict the iteration to 2-cells. */ - mln::topo::is_n_face<bin_ima_t::dim> constraint_p; + mln::topo::is_n_face<mln_psite_(bin_ima_t), bin_ima_t::dim> constraint_p; bin_ima_t skel = mln::topo::skeleton::breadth_first_thinning(surface, nbh, is_simple_p, diff --git a/milena/apps/mesh-segm-skel/mesh-complex-skel.cc b/milena/apps/mesh-segm-skel/mesh-complex-skel.cc index f5a7f11..b8b7da8 100644 --- a/milena/apps/mesh-segm-skel/mesh-complex-skel.cc +++ b/milena/apps/mesh-segm-skel/mesh-complex-skel.cc @@ -219,7 +219,7 @@ main(int argc, char* argv[]) As a workaround, we use the constraint predicate of the skeleton routine to restrict the iteration to 2-cells. */ - mln::topo::is_n_face<bin_ima_t::dim> constraint_p; + mln::topo::is_n_face<mln_psite_(bin_ima_t), bin_ima_t::dim> constraint_p; bin_ima_t skel = mln::topo::skeleton::breadth_first_thinning(surface, nbh, is_simple_p, diff --git a/milena/mln/topo/is_n_face.hh b/milena/mln/topo/is_n_face.hh index bc9aa71..ab696c1 100644 --- a/milena/mln/topo/is_n_face.hh +++ b/milena/mln/topo/is_n_face.hh @@ -41,26 +41,26 @@ namespace mln { // Forward declaration. - template <unsigned N> struct is_n_face; + template <typename P, unsigned N> + struct is_n_face; - /// A functor testing wheter a mln::complex_psite is an \p N -face. - template <unsigned N> - struct is_n_face : public mln::Function_v2b< is_n_face<N> > + /// A functor testing wheter a psite (presumably an + /// mln::complex_psite) is an \p N -face. + template <typename P, unsigned N> + struct is_n_face : public mln::Function_v2b< is_n_face<P, N> > { typedef bool result; - template <typename P> bool operator()(const P& p) const; }; # ifndef MLN_INCLUDE_ONLY - template <unsigned N> - template <typename P> + template <typename P, unsigned N> inline bool - is_n_face<N>::operator()(const P& p) const + is_n_face<P, N>::operator()(const P& p) const { return p.n() == N; } -- 1.5.6.5

13 years, 8 months

← Newer
1
...
4
5
6
7
8
9
10
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Olena-patches April 2011