Re: [Olena-bugs] [Olena] #116: Move the definitions of the vset property higher in the image hierarchy - Olena-bugs

19 Jun 2014

#116: Move the definitions of the vset property higher in the image hierarchy
--------------------------+------------------------
  Reporter:  levill_r     |      Owner:  Olena Team
      Type:  enhancement  |     Status:  closed
  Priority:  minor        |  Milestone:  Olena 2.1
 Component:  Milena       |    Version:  2.0
Resolution:  invalid      |   Keywords:  factor
--------------------------+------------------------
Changes (by levill_r):

 * status:  new => closed
 * version:  1.0 => 2.0
 * resolution:   => invalid

Old description:

...
  Milena is full of redundant definitions of `vset`,
like this one:

 {{{
 #!cpp
 typedef mln::value::set<value> vset;
 }}}

 For instance, see
  * source:trunk/milena/mln/core/image2d.hh
  * source:trunk/milena/mln/core/internal/t_image.hh

 Factor them in higher super classes.

 {{{
 #!html
 <br/>
 }}}

 Likewise, factor definitions of method `values()`, in particular in
 morphers :
 {{{
 #!cpp
 const vset& values() const;
 }}}
 {{{
 #!cpp
 template <typename I>
 const mln_vset(I)&
 t_image<I>::values() const
 {
   mln_precondition(this->delegatee_() != 0);
   return this->delegatee_()->values();
 }
 }}} 
New description:

 Milena is full of redundant definitions of `vset`, like this one:

 {{{
 #!cpp
 typedef mln::value::set<value> vset;
 }}}

 For instance, see
  * source:milena/mln/core/image/image2d.hh
  * source:milena/trash/t_image.hh

 Factor them in higher super classes.

 {{{
 #!html
 <br/>
 }}}

 Likewise, factor definitions of method `values()`, in particular in
 morphers :
 {{{
 #!cpp
 const vset& values() const;
 }}}
 {{{
 #!cpp
 template <typename I>
 const mln_vset(I)&
 t_image<I>::values() const
 {
   mln_precondition(this->delegatee_() != 0);
   return this->delegatee_()->values();
 }
 }}}

--

Comment:

 This ticket seems irrelevant now, as `values_eligible_values()` seems to
 have replaced `values()`; closing.

-- 
Ticket URL: <https://trac.lrde.epita.fr/olena/ticket/116#comment:4>
Olena <http://olena.lrde.epita.fr>
Olena, a generic and efficient image processing platform