1822: Clean up some ChangeLog entries.
https://svn.lrde.epita.fr/svn/oln/trunk/milena Index: ChangeLog =================================================================== --- ChangeLog (revision 1821) +++ ChangeLog (revision 1822) @@ -6,20 +6,24 @@ * sandbox/jardonnet/test/bin: New Bin directory. * sandbox/jardonnet/test/Makefile: Update for testes. - * sandbox/jardonnet/test/icp_lazy.cc: New dedicated to lazy_map. - * sandbox/jardonnet/registration/icp_lazy.hh: New dedicated to lazy map. + * sandbox/jardonnet/test/icp_lazy.cc: New dedicated to lazy_map. + * sandbox/jardonnet/registration/icp_lazy.hh: New dedicated to + lazy map. * sandbox/jardonnet/registration/quat7.hh: Update. * sandbox/jardonnet/registration/chamfer.hh: Update. - * sandbox/jardonnet/registration/icp.hh: Update (dedicated to distance_map). + * sandbox/jardonnet/registration/icp.hh: Update (dedicated to + distance_map). - * sandbox/jardonnet/registration/misc.hh: Move outside quat/ (removed). - * sandbox/jardonnet/registration/rotation.hh: Move outside quat/ (removed). + * sandbox/jardonnet/registration/misc.hh: Move outside quat/ + (removed). + * sandbox/jardonnet/registration/rotation.hh: Move outside quat/ + (removed). * sandbox/jardonnet/test/check: Remove old test script. 2008-04-02 Caroline Vigouroux <vigour_c@epita.fr> - change RGB encoding from int_u to float01_. + Change RGB encoding from int_u to float01_. * sandbox/vigouroux/color/my_hsi.hh: plug HSI on value. * sandbox/vigouroux/color/rgb_to_hsi.hh: . * sandbox/vigouroux/moyenne.cc: test new HSI and RGB. @@ -30,7 +34,9 @@ * mln/algebra/vec.hh: Add check for dimension in to_point(). * sandbox/jardonnet/test/plotscript: Add gnuplot script. - * sandbox/jardonnet/test/Makefile: Add g++ flags: Unexpected behavior disappear with -ffloat-store (float are not stored in register). + * sandbox/jardonnet/test/Makefile: Add g++ flags: Unexpected + behavior disappear with -ffloat-store (float are not stored in + register). * sandbox/jardonnet/test/check: Update test script. * sandbox/jardonnet/registration/quat7.hh: . * sandbox/jardonnet/registration/icp.hh: . @@ -43,11 +49,13 @@ * sandbox/abraham: New. * sandbox/abraham/morpho: New. - * sandbox/abraham/morpho/basic_najman.hh: New, contains Najman component tree. + * sandbox/abraham/morpho/basic_najman.hh: New, contains Najman + component tree. * sandbox/abraham/morpho/test.cc: New. * sandbox/abraham/morpho/images: New. * sandbox/abraham/morpho/images/test_component_tree.pgm: New. - * sandbox/abraham/morpho/topo_wst.hh: New, draft of topological watershed. + * sandbox/abraham/morpho/topo_wst.hh: New, draft of topological + watershed. * sandbox/abraham/morpho/Makefile: New. 2008-03-31 Nicolas Ballas <ballas@lrde.epita.fr> @@ -65,9 +73,11 @@ * sandbox/jardonnet/test/reduce.cc: New: image scaling. * sandbox/jardonnet/test/01.pbm, * sandbox/jardonnet/test/02.pbm: New: test images. - * sandbox/jardonnet/registration/icp.hh: Use type lazy_map instead of std::pair, in order to use spécific constructors. + * sandbox/jardonnet/registration/icp.hh: Use type lazy_map instead + of std::pair, in order to use spécific constructors. * sandbox/jardonnet/registration/projection.hh: update. - * sandbox/jardonnet/registration/tools.hh: Add tools for boxes (to include in Milena?). + * sandbox/jardonnet/registration/tools.hh: Add tools for boxes (to + include in Milena?). 2008-03-29 Ugo Jardonnet <jardonnet@lrde.epita.fr> @@ -80,8 +90,10 @@ * sandbox/jardonnet/registration/cloud.hh: Correction. * sandbox/jardonnet/registration/jacobi.hh: Add FIXME (nD). * sandbox/jardonnet/registration/icp.hh: Improvment. - * sandbox/jardonnet/registration/projection.hh: Add a projection technique "memo" computing closest point only if needed. - * sandbox/jardonnet/registration/tools.hh: Gather together tools to add to milena. + * sandbox/jardonnet/registration/projection.hh: Add a projection + technique "memo" computing closest point only if needed. + * sandbox/jardonnet/registration/tools.hh: Gather together tools + to add to milena. 2008-03-28 Roland Levillain <roland@lrde.epita.fr> @@ -500,10 +512,11 @@ * sandbox/jardonnet/registration/icp.hh, * sandbox/jardonnet/registration/projection.hh, * sandbox/jardonnet/registration/quat/all.hh, - * sandbox/jardonnet/registration/quat/rotation.hh: Update for p_array and n dim (not ready yet). + * sandbox/jardonnet/registration/quat/rotation.hh: Update for + p_array and n dim (not ready yet). + * sandbox/jardonnet/registration/quat/interpol.hh: Remove. + Provided by qut.hh - * sandbox/jardonnet/registration/quat/interpol.hh: Remove. Provided by qut.hh - 2008-03-19 Michel Pellegrin <pellegrin@lrde.epita.fr> Fix some mistakes, Add. @@ -590,7 +603,8 @@ * mln/value/internal/gray_f.hh, * mln/value/int_u.hh, * mln/value/int_u_sat.hh, - * mln/value/label.hh: metal/math had been wrongly substitute by algebra/math. + * mln/value/label.hh: metal/math had been wrongly substitute by + algebra/math. * mln/trait/ch_value.hh, * mln/core/h_vec.hh: wrong namespace for vec. @@ -1087,7 +1101,7 @@ (mln::line_graph_image<P, V>::init_): Ensure there are no data before initializing new ones. * mln/core/internal/image_morpher.hh: Remove spurious FIXMEs. - * mln/core/line_graph_psite.hh + * mln/core/line_graph_psite.hh (mln::line_graph_psite<P>::point): Set typedef to P. (mln::line_graph_psite<P>::operator[]): Adjust return type. (mln::line_graph_psite<P>::line_graph_psite): New ctor. @@ -1260,9 +1274,11 @@ Split fllt.hh in my sanbox. - * sandbox/garrigues/fllt/compute_level_set.hh: New, compute the level sets. + * sandbox/garrigues/fllt/compute_level_set.hh: New, compute the + level sets. * sandbox/garrigues/fllt/debug.hh: New, debug routines for FLLT. - * sandbox/garrigues/fllt/doc.hh: New, some comments from the monasse's paper. + * sandbox/garrigues/fllt/doc.hh: New, some comments from + Monasse's paper. * sandbox/garrigues/fllt/lower.hh: New, the struct used to compute the lower level set. * sandbox/garrigues/fllt/upper.hh: New, the struct used to compute the @@ -1277,7 +1293,7 @@ Chamfer DT visual tests (beautiful images inside !). * sandbox/folio/chamfer_dt.cc: New visual tests inside - (Beware! There's a picasso painting here !). + (Beware! There's a picasso painting here !). 2008-02-26 Matthieu Garrigues <garrigues@lrde.epita.fr> @@ -1492,7 +1508,8 @@ * mln/binarization/includes.hh: include for binarization. * mln/binarization/binarization.hh: generic binarization (v2b for now). * mln/binarization/thresholding.hh: thresholding. - * mln/io/pnm/save.hh: Comments for dummy (me) users who try to save binary as pgm. + * mln/io/pnm/save.hh: Comments for dummy (me) users who try to + save binary as pgm. * tests/binarization: New test directory. * tests/binarization/thresholding.cc: New test file. @@ -1573,7 +1590,7 @@ Ressurect and adjust those files from a revision 1700, since mln::labeling::regional_minima (needed by Meyer's WST) doesn't work (yet) on image which are not point-wise accessible. - * mln/util/greater_psite.hh: New. + * mln/util/greater_psite.hh: New. Clone and modified from mln/util/greater_point.hh. * mln/morpho/meyer_wst.hh (morpho::meyer_wst): s/point/psite/. Use morpho::minima_components instead of level::regional_minima, @@ -3171,7 +3188,7 @@ Add `has' and `point_at' method for all run based image. * mln/core/internal/run_image.hh: Add `has' and `point_at' - method. + method. * mln/core/mono_obased_rle_image.hh, * mln/core/mono_rle_image.hh, * mln/core/obased_rle_image.hh, @@ -3198,10 +3215,13 @@ Update creation of documentation. * doc/Doxyfile.in, - * doc/Makefile.am: Update for generation of internal or user documentation. - * doc/Doxyfile_user.in: New template file for generate the user documentation. - - Update source for distinction between the user and developper documentation. + * doc/Makefile.am: Update for generation of internal or user + documentation. + * doc/Doxyfile_user.in: New template file for generate the user + documentation. + Update source for distinction between the user and developper + documentation. + * mln/accu/all.hh, * mln/accu/internal/base.hh, * mln/arith/all.hh, @@ -3518,7 +3538,7 @@ * mln/core/mono_rle_encode.hh: Fix. * mln/core/mono_rle_image.hh: Add get_value() method. * mln/core/obased_rle_image.hh: Add vector of value for easier - acces to the image. + acces to the image. * tests/core/Makefile.am: Add test. * tests/core/mono_obased_rle_image.cc: New. @@ -3645,14 +3665,14 @@ Complete the macros in Meta Accumlator. * mln/core/concept/meta_accumulator.hh: (mln_accu_with_, - mln_accu_result_) New. + mln_accu_result_) New. 2007-12-03 Matthieu Garrigues <garrigues@lrde.epita.fr> Complete the macros in Meta Accumlator. * mln/core/concept/meta_accumulator.hh: (mln_accu_with_, - mln_accu_result_) New. + mln_accu_result_) New. 2007-12-03 Matthieu Garrigues <garrigues@lrde.epita.fr> @@ -4199,8 +4219,8 @@ * mln/io/ppm/load.hh, * mln/io/ppm/save.hh, * tests/io/ppm/ppm.cc: Add documentation, review the code, put - MLN_INCLUDE_ONLY gards, add missing function declaration (outside - MLN_INCLUDE_ONLY). + MLN_INCLUDE_ONLY gards, add missing function declaration (outside + MLN_INCLUDE_ONLY). 2007-11-28 Guillaume Duhamel <guillaume.duhamel@lrde.epita.fr> @@ -4251,7 +4271,7 @@ Review debug directory. * mln/debug/iota.hh: Resolve a fixme due to a resolved bug (in - operator %) + operator %) * mln/debug/iota.spe.hh: likewise * tests/Makefile.am: Move debug tests... * tests/debug/Makefile.am: ...here @@ -4268,7 +4288,7 @@ make save pgm work on graylevels. document pnm::save. * mln/io/pgm/save.hh: Disable type checking in pgm::save to allow to - save graylevel images. + save graylevel images. * mln/io/pnm/save.hh: Documentation. * mln/io/pnm/save_header.hh: graylevel compatibility. @@ -5193,7 +5213,8 @@ 2007-11-16 Guillaume Duhamel <guillaume.duhamel@lrde.epita.fr> - Add tracing for level algorithm and split specialization of level::transform. + Add tracing for level algorithm and split specialization of + level::transform. * mln/level/compute.hh, * mln/level/fill.hh, @@ -10817,7 +10838,6 @@ * mln/core/image1d_b.hh: re-add array_ attribute in the image1d_b class we actually need it to handle the border offset => array_ = buffer_ - vb_.pmin().ind(); -) * mln/debug/println.hh: update * tests/debug_println_with_border.cc: add 1d test. @@ -10993,11 +11013,11 @@ 2007-09-06 Matthieu Garrigues <garrigues.matthieu@lrde.epita.fr> add println_with_border - * mln/debug/println.hh: - add 3 function : - println_with_border(const box2d& b, const Fast_Image<I>& input_) - impl::println_with_border(const S&, const Fast_Image<I>& input_) - impl::println_with_border(const box2d& b, const Fast_Image<I>& input_) + * mln/debug/println.hh + (println_with_border(const box2d&, const Fast_Image<I>&)) + (impl::println_with_border(const S&, const Fast_Image<I>&)) + (impl::println_with_border(const box2d&, const Fast_Image<I>&)): + New functions. * tests/println_with_border.cc: New. 2007-09-06 Thierry Geraud <thierry.geraud@lrde.epita.fr> @@ -12280,9 +12300,11 @@ Repair lineary pixel iterator. - * mln/core/pixter2d_b.hh: Adapt pixter2d_b to the new pixel iterator hierachy. + * mln/core/pixter2d_b.hh: Adapt pixter2d_b to the new pixel + iterator hierachy. * mln/core/internal/pixel_iterator_base.hh: Fix dead code. - * mln/core/internal/lineary_pixel_iterator_base.hh: New factorization class. + * mln/core/internal/lineary_pixel_iterator_base.hh: New + factorization class. 2007-07-19 Thierry Geraud <thierry.geraud@lrde.epita.fr> @@ -12312,13 +12334,16 @@ * tests/pixter_point2d.cc: Update test. * mln/core/pixel.hh: Add typedefs in the class pixel_. * mln/core/macros.hh: Add new macros. - * mln/core/concept/pixel_iterator.hh: New, rename Fast_Iterator concep as Pixel Iterator. + * mln/core/concept/pixel_iterator.hh: New, rename Fast_Iterator + concep as Pixel Iterator. * mln/core/concept/fast_iterator.hh: Remove. * mln/core/concept/genpixel.hh: Constructor fixed. * mln/core/pixter2d_b.hh: Broken!. * mln/core/image2d_b.hh: Add new method point_at_offset. - * mln/core/dpoints_pixter.hh: Adapt dpoint_pixter to the new hierarchy. - * mln/core/internal/pixel_iterator_base.hh: New, rename fast_iterator_base_ as pixel_iterator_base_. + * mln/core/dpoints_pixter.hh: Adapt dpoint_pixter to the new + hierarchy. + * mln/core/internal/pixel_iterator_base.hh: New, rename + fast_iterator_base_ as pixel_iterator_base_. * mln/core/internal/fast_iterator_base.hh: Remove. * mln/level/fast_median.hh: New median using qixter. @@ -12896,12 +12921,13 @@ * sandbox: New. * sandbox/cxxcompilation: New. - * sandbox/cxxcompilation/compilation_unit.rb: Tools used to create compilation unit file - for benchmark. + * sandbox/cxxcompilation/compilation_unit.rb: Tools used to create + compilation unit file for benchmark. * sandbox/cxxcompilation/test.cc: Test file used in benchmark. - * sandbox/cxxcompilation/methods: Describes some existing method which improve compilation - time. - * sandbox/cxxcompilation/vaucanson_bench: Benchmark on Vaucanson method. + * sandbox/cxxcompilation/methods: Describes some existing method + which improve compilation time. + * sandbox/cxxcompilation/vaucanson_bench: Benchmark on Vaucanson + method. 2007-07-03 Thierry Geraud <thierry.geraud@lrde.epita.fr>
En relisant certaines entrées de ChangeLog, je m'aperçois qu'il y a du relâchement ! Certaines entrées sont bâclées, voire non remplies ! Ce n'est pas admissible. Olena n'est pas un projet kleenex, on a besoin que vous remplissiez les ChangeLog correctement et précisément pour 1. suivre l'activité du projet en général ; 2. suivre votre travail en particulier ; 3. retrouver l'information plus tard (typiquement, dans plusieurs semaines/mois/années), ce qui est capital (et beaucoup plus courant que vous ne le pensez). Merci de lire attentivement ce qui suit, et de mettre en pratique ! * La première chose à faire est de revoir les fondamentaux. Relisez donc : - https://www.lrde.epita.fr/dload/guide/guide.html#htoc66 - http://www.gnu.org/prep/standards/html_node/Change-Logs.html * Ensuite, regardez comment les autres entrées de ChangeLog sont écrites. Vous pouvez prendre exemple sur Akim, Alexandre, Théo et moi-même, qui avons l'habitude de cet exercice. * Les outils sont là pour vous aider. En particulier, Emacs peut vous aider à pré-remplir un ChangeLog plus facilement avec le mode ad hoc : M-x change-log-mode Pour éviter les lignes-qui-dépasse-les-80-colonnes, utilisez M-x auto-fill-mode Quant aux problèmes d'espace (à traiter directement sur le fichier ChangeLog dans un patch à part, le cas échéant), utilisez M-x whitespace-cleanup * Corrigez vos erreurs de ChangeLog au plus vite (i.e., pas trop lomgtemps après le patch contenant ces erreurs), *dans un patch séparé* et *ne faites pas mention de ces changements dans le ChangeLog lui-même* ! Pour cela, il vaut mieux éviter d'utiliser Vcs ou svn-wrapper : utilisez « \svn » au lieu de « svn » pour déconnecter temporairement votre alias « svn » : \svn commit -m "Clean up ChangeLog" ChangeLog Puis n'oubliez pas de poster les changements ; par ex. : svn diff -r PREV >diffs.patch et postez diffs.patch dans olena-patches@lrde.epita.fr dans un message qqch qui ressemble à ce que génerent Vcs et svn-wrapper. * Enfin, voici quelques erreurs classiques, qu'il ne *faut pas* repoduire. Merci d'avance !
Index: ChangeLog =================================================================== --- ChangeLog (revision 1821) +++ ChangeLog (revision 1822) @@ -6,20 +6,24 @@ * sandbox/jardonnet/test/bin: New Bin directory. * sandbox/jardonnet/test/Makefile: Update for testes.
- * sandbox/jardonnet/test/icp_lazy.cc: New dedicated to lazy_map. - * sandbox/jardonnet/registration/icp_lazy.hh: New dedicated to lazy map. + * sandbox/jardonnet/test/icp_lazy.cc: New dedicated to lazy_map. + * sandbox/jardonnet/registration/icp_lazy.hh: New dedicated to + lazy map.
Attention à l'indentation: dans ChangeLog, les lignes correspondant aux fichiers démarrent par une tabulation (C-i), puis par une étoile (*) et une espace, et enfin le nom du fichier.
* sandbox/jardonnet/registration/quat7.hh: Update. * sandbox/jardonnet/registration/chamfer.hh: Update. - * sandbox/jardonnet/registration/icp.hh: Update (dedicated to distance_map). + * sandbox/jardonnet/registration/icp.hh: Update (dedicated to + distance_map).
- * sandbox/jardonnet/registration/misc.hh: Move outside quat/ (removed). - * sandbox/jardonnet/registration/rotation.hh: Move outside quat/ (removed). + * sandbox/jardonnet/registration/misc.hh: Move outside quat/ + (removed). + * sandbox/jardonnet/registration/rotation.hh: Move outside quat/ + (removed).
Prière de ne pas faire du cinémascope (plus de 80 colonnes), tant dans le code que dans les ChangeLogs. [...]
2008-04-02 Caroline Vigouroux <vigour_c@epita.fr>
- change RGB encoding from int_u to float01_. + Change RGB encoding from int_u to float01_.
Attention aux majuscules, et à la ponctuation en général. [...]
* sandbox/vigouroux/color/rgb_to_hsi.hh: .
Remplir *toutes* les lignes! Laisser des ligne vides est inadmissible.
@@ -1277,7 +1293,7 @@
Chamfer DT visual tests (beautiful images inside !). * sandbox/folio/chamfer_dt.cc: New visual tests inside - (Beware! There's a picasso painting here !). + (Beware! There's a picasso painting here !).
Attention aux espaces.
@@ -10993,11 +11013,11 @@ 2007-09-06 Matthieu Garrigues <garrigues.matthieu@lrde.epita.fr>
add println_with_border - * mln/debug/println.hh: - add 3 function : - println_with_border(const box2d& b, const Fast_Image<I>& input_) - impl::println_with_border(const S&, const Fast_Image<I>& input_) - impl::println_with_border(const box2d& b, const Fast_Image<I>& input_) + * mln/debug/println.hh + (println_with_border(const box2d&, const Fast_Image<I>&)) + (impl::println_with_border(const S&, const Fast_Image<I>&)) + (impl::println_with_border(const box2d&, const Fast_Image<I>&)): + New functions. * tests/println_with_border.cc: New.
Utiliser les idiomes des ChangeLogs. Lorsque vous voulez parler d'un individu `bar' (une fonction, par ex.) dans un fichier `foo.cc' par exemple, ne faites pas ça : * foo.cc: Add a new function `bar'. Mais faites ceci : * foo.cc (bar): New function.
participants (1)
-
Roland Levillain