* scribo/binarization/global_threshold_auto.hh, * scribo/binarization/internal/niblack_formula.hh, * scribo/binarization/niblack_threshold.hh, * scribo/binarization/sauvola_ms.hh, * scribo/binarization/sauvola_threshold.hh, * scribo/core/component_set.hh, * scribo/core/line_info.hh, * scribo/filter/images_in_paragraph.hh, * scribo/postprocessing/fill_object_holes.hh, * scribo/preprocessing/deskew.hh, * scribo/primitive/extract/internal/union.hh, * scribo/primitive/extract/non_text.hh, * scribo/primitive/extract/non_text_hdoc.hh, * scribo/primitive/extract/non_text_kmean.hh, * scribo/primitive/link/internal/find_several_links.hh, * scribo/primitive/link/internal/link_functor_base.hh, * scribo/primitive/link/merge_double_link_closest_aligned.hh: Here. --- scribo/ChangeLog | 22 ++++++++++++++++++++ .../scribo/binarization/global_threshold_auto.hh | 2 +- .../binarization/internal/niblack_formula.hh | 2 +- scribo/scribo/binarization/niblack_threshold.hh | 2 +- scribo/scribo/binarization/sauvola_ms.hh | 2 +- scribo/scribo/binarization/sauvola_threshold.hh | 2 +- scribo/scribo/core/component_set.hh | 3 +- scribo/scribo/core/line_info.hh | 4 +- scribo/scribo/filter/images_in_paragraph.hh | 2 +- scribo/scribo/postprocessing/fill_object_holes.hh | 6 ++-- scribo/scribo/preprocessing/deskew.hh | 2 +- scribo/scribo/primitive/extract/internal/union.hh | 2 +- scribo/scribo/primitive/extract/non_text.hh | 2 +- scribo/scribo/primitive/extract/non_text_hdoc.hh | 2 +- scribo/scribo/primitive/extract/non_text_kmean.hh | 2 +- .../primitive/link/internal/find_several_links.hh | 4 +- .../primitive/link/internal/link_functor_base.hh | 2 +- .../link/merge_double_link_closest_aligned.hh | 2 +- 18 files changed, 43 insertions(+), 22 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index b1e4665..954af2c 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,27 @@ 2013-03-20 Guillaume Lazzara <z@lrde.epita.fr> + Replace \fixme with FIXME. + + * scribo/binarization/global_threshold_auto.hh, + * scribo/binarization/internal/niblack_formula.hh, + * scribo/binarization/niblack_threshold.hh, + * scribo/binarization/sauvola_ms.hh, + * scribo/binarization/sauvola_threshold.hh, + * scribo/core/component_set.hh, + * scribo/core/line_info.hh, + * scribo/filter/images_in_paragraph.hh, + * scribo/postprocessing/fill_object_holes.hh, + * scribo/preprocessing/deskew.hh, + * scribo/primitive/extract/internal/union.hh, + * scribo/primitive/extract/non_text.hh, + * scribo/primitive/extract/non_text_hdoc.hh, + * scribo/primitive/extract/non_text_kmean.hh, + * scribo/primitive/link/internal/find_several_links.hh, + * scribo/primitive/link/internal/link_functor_base.hh, + * scribo/primitive/link/merge_double_link_closest_aligned.hh: Here. + +2013-03-20 Guillaume Lazzara <z@lrde.epita.fr> + Fix an invalid initialization in several binarization algorithms. * scribo/binarization/internal/local_threshold_core.hh: Fix doc. diff --git a/scribo/scribo/binarization/global_threshold_auto.hh b/scribo/scribo/binarization/global_threshold_auto.hh index 196ca3a..01dc8c5 100644 --- a/scribo/scribo/binarization/global_threshold_auto.hh +++ b/scribo/scribo/binarization/global_threshold_auto.hh @@ -31,7 +31,7 @@ /// /// Binarize a graylevel image using an automatic global threshold. /// -/// \fixme: Adapt the filtering if no threshold is found. +/// FIXME: Adapt the filtering if no threshold is found. # include <mln/core/image/image1d.hh> # include <mln/core/alias/neighb1d.hh> diff --git a/scribo/scribo/binarization/internal/niblack_formula.hh b/scribo/scribo/binarization/internal/niblack_formula.hh index eb57103..437950a 100644 --- a/scribo/scribo/binarization/internal/niblack_formula.hh +++ b/scribo/scribo/binarization/internal/niblack_formula.hh @@ -32,7 +32,7 @@ /// \brief Routines computing a threshold using Niblack's binarization /// formula. -// \fixme Having an unused parameter to fulfill the required interface +// FIXME: Having an unused parameter to fulfill the required interface // may not be the best solution... // Setup default Niblack's formula parameters values. diff --git a/scribo/scribo/binarization/niblack_threshold.hh b/scribo/scribo/binarization/niblack_threshold.hh index 1bd074b..ceb9415 100644 --- a/scribo/scribo/binarization/niblack_threshold.hh +++ b/scribo/scribo/binarization/niblack_threshold.hh @@ -31,7 +31,7 @@ /// /// Compute an image of local threshold using Niblack algorithm. -/// \fixme return type too restrictive! +/// FIXME: return type too restrictive! # include <algorithm> # include <cmath> diff --git a/scribo/scribo/binarization/sauvola_ms.hh b/scribo/scribo/binarization/sauvola_ms.hh index e5a46cb..0bfd5a4 100644 --- a/scribo/scribo/binarization/sauvola_ms.hh +++ b/scribo/scribo/binarization/sauvola_ms.hh @@ -33,7 +33,7 @@ /// \brief Binarize an image using a multi-scale implementation of /// Sauvola's algoritm. /// -/// \fixme Use the integral image for successive subsampling. +/// FIXME: Use the integral image for successive subsampling. # include <mln/core/alias/neighb2d.hh> diff --git a/scribo/scribo/binarization/sauvola_threshold.hh b/scribo/scribo/binarization/sauvola_threshold.hh index ad6a5a9..c9ea3f3 100644 --- a/scribo/scribo/binarization/sauvola_threshold.hh +++ b/scribo/scribo/binarization/sauvola_threshold.hh @@ -31,7 +31,7 @@ /// /// Compute an image of local threshold using Sauvola algorithm. -/// \fixme return type too restrictive! +/// FIXME: return type too restrictive! # include <algorithm> # include <cmath> diff --git a/scribo/scribo/core/component_set.hh b/scribo/scribo/core/component_set.hh index 8c3e83f..32eb636 100644 --- a/scribo/scribo/core/component_set.hh +++ b/scribo/scribo/core/component_set.hh @@ -31,10 +31,9 @@ /// /// \brief Definition of a component set. /// -/// \fixme component_set should always set a component type in order +/// FIXME: component_set should always set a component type in order /// to be fully supported by visitors. - # include <mln/core/concept/site_set.hh> # include <mln/core/concept/function.hh> diff --git a/scribo/scribo/core/line_info.hh b/scribo/scribo/core/line_info.hh index 59ce1d3..bdbc18b 100644 --- a/scribo/scribo/core/line_info.hh +++ b/scribo/scribo/core/line_info.hh @@ -31,10 +31,10 @@ /// /// \brief Line information data structure. /// -/// \fixme The meanline should not be stored! The user can deduce it +/// FIXME: The meanline should not be stored! The user can deduce it /// from the x_height and the baseline. /// -/// \fixme The way the meanline and the baseline are computed is not +/// FIXME: The way the meanline and the baseline are computed is not /// optimal and does not work if the components are too high (because /// of the median accumulator and int_u12 overflows). diff --git a/scribo/scribo/filter/images_in_paragraph.hh b/scribo/scribo/filter/images_in_paragraph.hh index 5fc340b..45e5fc4 100644 --- a/scribo/scribo/filter/images_in_paragraph.hh +++ b/scribo/scribo/filter/images_in_paragraph.hh @@ -29,7 +29,7 @@ /// \file /// /// Invalidate false positive images. -/// \fixme Share same test canvas as text::merging. +/// FIXME: Share same test canvas as text::merging. # include <mln/core/concept/image.hh> diff --git a/scribo/scribo/postprocessing/fill_object_holes.hh b/scribo/scribo/postprocessing/fill_object_holes.hh index 037874d..636b929 100644 --- a/scribo/scribo/postprocessing/fill_object_holes.hh +++ b/scribo/scribo/postprocessing/fill_object_holes.hh @@ -30,9 +30,9 @@ /// /// \brief Fill-in object small holes. -/// \FIXME share code with filter/object_groups_with_holes.hh -/// \FIXME Merge the two following routines. -/// \FIXME Use a size ratio in both overloads. +/// FIXME: share code with filter/object_groups_with_holes.hh +/// FIXME: Merge the two following routines. +/// FIXME: Use a size ratio in both overloads. # include <sstream> diff --git a/scribo/scribo/preprocessing/deskew.hh b/scribo/scribo/preprocessing/deskew.hh index 284bd0e..555bad7 100644 --- a/scribo/scribo/preprocessing/deskew.hh +++ b/scribo/scribo/preprocessing/deskew.hh @@ -30,7 +30,7 @@ /// /// Deskew an image. -/// \FIXME: provide a version for binary images. +/// FIXME: provide a version for binary images. # include <queue> diff --git a/scribo/scribo/primitive/extract/internal/union.hh b/scribo/scribo/primitive/extract/internal/union.hh index 89687d6..660652f 100644 --- a/scribo/scribo/primitive/extract/internal/union.hh +++ b/scribo/scribo/primitive/extract/internal/union.hh @@ -27,7 +27,7 @@ /// /// \brief Various utilities for image extraction /// -/// \fixme To be cleanup +/// FIXME: To be cleanup #ifndef SCRIBO_PRIMITIVE_EXTRACT_INTERNAL_UNION_HH # define SCRIBO_PRIMITIVE_EXTRACT_INTERNAL_UNION_HH diff --git a/scribo/scribo/primitive/extract/non_text.hh b/scribo/scribo/primitive/extract/non_text.hh index fe81a46..e2ebbd7 100644 --- a/scribo/scribo/primitive/extract/non_text.hh +++ b/scribo/scribo/primitive/extract/non_text.hh @@ -28,7 +28,7 @@ /// /// \brief Find in a document non text which are not text. /// -/// \fixme To be optimized! +/// FIXME: To be optimized! #ifndef SCRIBO_PRIMITIVE_EXTRACT_NON_TEXT_HH # define SCRIBO_PRIMITIVE_EXTRACT_NON_TEXT_HH diff --git a/scribo/scribo/primitive/extract/non_text_hdoc.hh b/scribo/scribo/primitive/extract/non_text_hdoc.hh index e506b4b..9de95d3 100644 --- a/scribo/scribo/primitive/extract/non_text_hdoc.hh +++ b/scribo/scribo/primitive/extract/non_text_hdoc.hh @@ -28,7 +28,7 @@ /// /// \brief Find in a document non text which are not text. /// -/// \fixme To be optimized! +/// FIXME: To be optimized! #ifndef SCRIBO_PRIMITIVE_EXTRACT_NON_TEXT_HDOC_HH # define SCRIBO_PRIMITIVE_EXTRACT_NON_TEXT_HDOC_HH diff --git a/scribo/scribo/primitive/extract/non_text_kmean.hh b/scribo/scribo/primitive/extract/non_text_kmean.hh index 716e772..55b9a7b 100644 --- a/scribo/scribo/primitive/extract/non_text_kmean.hh +++ b/scribo/scribo/primitive/extract/non_text_kmean.hh @@ -28,7 +28,7 @@ /// /// \brief Find in a document non text which are not text. /// -/// \fixme To be optimized! +/// FIXME: To be optimized! #ifndef SCRIBO_PRIMITIVE_EXTRACT_NON_TEXT_KMEAN_HH # define SCRIBO_PRIMITIVE_EXTRACT_NON_TEXT_KMEAN_HH diff --git a/scribo/scribo/primitive/link/internal/find_several_links.hh b/scribo/scribo/primitive/link/internal/find_several_links.hh index 2d4a663..74d3b18 100644 --- a/scribo/scribo/primitive/link/internal/find_several_links.hh +++ b/scribo/scribo/primitive/link/internal/find_several_links.hh @@ -31,7 +31,7 @@ /// /// Find the neighbor of a line of text if exists. /// -/// \fixme do not iterate over the number of anchor types but use a +/// FIXME: do not iterate over the number of anchor types but use a /// set of anchors specified in the functor. # include <mln/core/concept/image.hh> @@ -93,7 +93,7 @@ namespace scribo for_all_anchors(a, functor.anchors()) // <-- nanchor && anchors { - // FIXME : See fixme at the beginning of this file. + // FIXME:: See fixme at the beginning of this file. anchor::Type anchor = functor.anchors()[a]; mln_site(scribo_support_(F)) diff --git a/scribo/scribo/primitive/link/internal/link_functor_base.hh b/scribo/scribo/primitive/link/internal/link_functor_base.hh index a509126..e63096f 100644 --- a/scribo/scribo/primitive/link/internal/link_functor_base.hh +++ b/scribo/scribo/primitive/link/internal/link_functor_base.hh @@ -31,7 +31,7 @@ /// /// Base class for link functors. /// -/// \fixme type used for 'current_object' argument should be of type +/// FIXME: type used for 'current_object' argument should be of type /// mln_value(L) # include <mln/core/concept/image.hh> diff --git a/scribo/scribo/primitive/link/merge_double_link_closest_aligned.hh b/scribo/scribo/primitive/link/merge_double_link_closest_aligned.hh index e3221c1..d981672 100644 --- a/scribo/scribo/primitive/link/merge_double_link_closest_aligned.hh +++ b/scribo/scribo/primitive/link/merge_double_link_closest_aligned.hh @@ -91,7 +91,7 @@ namespace scribo for_all_links(l, output) if (right(l) != l) { - //FIXME Handle the case when a component is included in another one ? + //FIXME: Handle the case when a component is included in another one ? // Update distance align_data(l).first() -- 1.7.2.5