[Olena] #135: Name Confilts between util::node and util::node.
#135: Name Confilts between util::node and util::node. -----------------------+---------------------------------------------------- Reporter: garrigues | Owner: Olena Team Type: defect | Status: new Priority: major | Milestone: Olena 1.0ß Component: Milena | Version: 1.0 Keywords: | -----------------------+---------------------------------------------------- We have two util::node : one for the graph implementation and also one for the tree. see source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh -- Ticket URL: <https://trac.lrde.org/olena/ticket/135> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.
#135: Name clash between (graph-related) util::node and (tree-related) util::node ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: levill_r Type: defect | Status: assigned Priority: critical | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * priority: major => critical * status: new => assigned * owner: Olena Team => levill_r * summary: Name Confilts between util::node and util::node. => Name clash between (graph-related) util::node and (tree-related) util::node Old description:
We have two util::node : one for the graph implementation and also one for the tree. see source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh
New description: We have two `util::node` types : one for the graph implementation and also one for the tree. see source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh Comment: I'll try to address this one ASAP. Thanks for reporting this problem Matthieu! I think I'll probably rename the graph-related `util::node` as `util::vertex`, since it should have been named like this in the first place anyway. This change will be part of the graph overhauling I'm currently working on. -- Ticket URL: <https://trac.lrde.org/olena/ticket/135#comment:1> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.
#135: Rename (graph-related) util::node as util::vertex ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: levill_r Type: defect | Status: assigned Priority: critical | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * summary: Name clash between (graph-related) util::node and (tree- related) util::node => Rename (graph-related) util::node as util::vertex Old description:
We have two `util::node` types : one for the graph implementation and also one for the tree. see source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh
New description: * ~~We have two `mln::util::node` types : one for the graph implementation and also one for the tree. See source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh. Remove this name clash.~~ (Fixed; Matthieu Garrigues renamed the tree-related `mln::util::node` in r1749.) * Anyway, the graph-related `mln::util::node` should be renamed as `mln::util::vertex`. * Even better: `mln::util::vertex` and `mln::util::edge` should be given two distinct, incompatible types, like Vaucanson's graph item handlers (ask Roland for more details). Comment: * Mention Matthieu solved the name clash in r1749. * Add the renaming of `util::node` to `util::vertex` as a to-do. -- Ticket URL: <https://trac.lrde.org/olena/ticket/135#comment:2> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.
#135: Have util::vertex and util::edge be distinct types ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: levill_r Type: defect | Status: assigned Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * priority: critical => major * summary: Rename (graph-related) util::node as util::vertex => Have util::vertex and util::edge be distinct types Old description:
* ~~We have two `mln::util::node` types : one for the graph implementation and also one for the tree. See source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh. Remove this name clash.~~ (Fixed; Matthieu Garrigues renamed the tree-related `mln::util::node` in r1749.) * Anyway, the graph-related `mln::util::node` should be renamed as `mln::util::vertex`. * Even better: `mln::util::vertex` and `mln::util::edge` should be given two distinct, incompatible types, like Vaucanson's graph item handlers (ask Roland for more details).
New description: * ~~We have two `mln::util::node` types : one for the graph implementation and also one for the tree. See source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh. Remove this name clash.~~ (Fixed; Matthieu Garrigues renamed the tree-related `mln::util::node` in r1749.) * ~~Anyway, the graph-related `mln::util::node` should be renamed as `mln::util::vertex`~~ (done in r1993). * Even better: `mln::util::vertex` and `mln::util::edge` should be given two distinct, incompatible types, like Vaucanson's graph item handlers (ask Roland for more details). Comment: s/`util::node`/`util::vertex`/ (r1993). -- Ticket URL: <https://trac.lrde.org/olena/ticket/135#comment:3> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.
#135: Have util::vertex_id and util::edge_id be distinct types ------------------------+--------------------------------------------------- Reporter: garrigues | Owner: levill_r Type: defect | Status: closed Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Changes (by levill_r): * status: assigned => closed * resolution: => fixed * summary: Have util::vertex and util::edge be distinct types => Have util::vertex_id and util::edge_id be distinct types Old description:
* ~~We have two `mln::util::node` types : one for the graph implementation and also one for the tree. See source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh. Remove this name clash.~~ (Fixed; Matthieu Garrigues renamed the tree-related `mln::util::node` in r1749.) * ~~Anyway, the graph-related `mln::util::node` should be renamed as `mln::util::vertex`~~ (done in r1993). * Even better: `mln::util::vertex` and `mln::util::edge` should be given two distinct, incompatible types, like Vaucanson's graph item handlers (ask Roland for more details).
New description: * ~~We have two `mln::util::node` types : one for the graph implementation and also one for the tree. See source:/trunk/milena/mln/util/tree.hh and source:/trunk/milena/mln/util/internal/graph_base.hh. Remove this name clash.~~ (Fixed; Matthieu Garrigues renamed the tree-related `mln::util::node` in r1749.) * ~~Anyway, the graph-related `mln::util::node` should be renamed as `mln::util::vertex`~~ (done in r1993). * ~~Even better: `mln::util::vertex` and `mln::util::edge` should be given two distinct, incompatible types, like Vaucanson's graph item handlers~~ (done in r2003). -- Ticket URL: <https://trac.lrde.org/olena/ticket/135#comment:4> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.
participants (1)
-
Olena