
Edwin Carlinet <carlinet@lrde.epita.fr> writes:
URL: https://svn.lrde.epita.fr/svn/oln/trunk/milena
ChangeLog: 2009-06-04 Edwin Carlinet <carlinet@lrde.epita.fr>
Rename predorder iterator by depth1st iterator. * mln/morpho/tree/data.hh, * mln/morpho/tree/propagate_node.hh, * sandbox/edwin/tests/sharpness_attribute.cc: Rename predorder iterator by depth1st iterator.
[...]
Index: trunk/milena/headers.mk ===================================================================
[...]
Index: trunk/milena/tests/unit_test/unit-tests.mk ===================================================================
[...] These files were modified but you did not mention them in your ChangeLog. You must mention every change! Use `svn diff' or `git diff' to ensure you do not forget anything. Moreover, these files are generated, and deserve their own commit: their regeneration has nothing to do with the rest of the changes.
Index: trunk/milena/mln/morpho/tree/data.hh =================================================================== --- trunk/milena/mln/morpho/tree/data.hh (revision 3986) +++ trunk/milena/mln/morpho/tree/data.hh (revision 3987)
[...]
@@ -370,6 +370,10 @@ /// Skip current point children. Next call to next() goes to the brother point. void skip_children();
+ unsigned get_depth() { + return stack_.size() - 1; + }
This is not the canonical Olena style: place the opening brace its own line: unsigned get_depth() { return stack_.size() - 1; } BTW, you did not mention this addition in your ChangeLog.