April 2013 - Olena-patches

olena-2.0-543-gce97be8 scribo/core/object_links.hh: Always initialize links in non-default constructors.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- scribo/ChangeLog | 5 +++++ scribo/scribo/core/object_links.hh | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index 6a7d44a..14a2e51 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,10 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * scribo/core/object_links.hh: Always initialize links in + non-default constructors. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * scribo/core/component_set.hh: Adjust memory pre-allocation size. 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> diff --git a/scribo/scribo/core/object_links.hh b/scribo/scribo/core/object_links.hh index ef1d3ab..9aa4db0 100644 --- a/scribo/scribo/core/object_links.hh +++ b/scribo/scribo/core/object_links.hh @@ -207,6 +207,9 @@ namespace scribo object_links<L>::object_links(const component_set<L>& components) { data_ = new data_t(components, value::next(components.nelements())); + + // Initialize with no link. + init(); } -- 1.7.2.5

1 0

olena-2.0-542-g289bcac scribo/core/component_set.hh: Adjust memory pre-allocation size.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- scribo/ChangeLog | 4 ++++ scribo/scribo/core/component_set.hh | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index 9f4ac2a..6a7d44a 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,9 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * scribo/core/component_set.hh: Adjust memory pre-allocation size. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + Enhance documentation in scribo. * scribo/core/component_set.hh, diff --git a/scribo/scribo/core/component_set.hh b/scribo/scribo/core/component_set.hh index 30769d4..135580f 100644 --- a/scribo/scribo/core/component_set.hh +++ b/scribo/scribo/core/component_set.hh @@ -405,7 +405,7 @@ namespace scribo mln_precondition(infos_.nelements() == 0); ncomps_ = ncomps; - infos_.reserve(ncomps_); + infos_.reserve(mln::value::next(ncomps_)); infos_.append(component_info<L>()); // Component 0, i.e. the background. } -- 1.7.2.5

1 0

olena-2.0-541-g83d9bff Enhance documentation in scribo.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

* scribo/core/component_set.hh, * scribo/core/object_links.hh: Add missing member documentation. * scribo/debug/logger.hh: Fix an invalid object reference. --- scribo/ChangeLog | 9 ++++++ scribo/scribo/core/component_set.hh | 5 ++- scribo/scribo/core/object_links.hh | 50 ++++++++++++++++++++++++++++------- scribo/scribo/debug/logger.hh | 2 +- 4 files changed, 53 insertions(+), 13 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index cf030cb..9f4ac2a 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,14 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + Enhance documentation in scribo. + + * scribo/core/component_set.hh, + * scribo/core/object_links.hh: Add missing member documentation. + + * scribo/debug/logger.hh: Fix an invalid object reference. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * scribo/core/component_set.hh: Hide internal API. 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> diff --git a/scribo/scribo/core/component_set.hh b/scribo/scribo/core/component_set.hh index 259a508..30769d4 100644 --- a/scribo/scribo/core/component_set.hh +++ b/scribo/scribo/core/component_set.hh @@ -256,7 +256,7 @@ namespace scribo // Misc Members - /// Return the component count. + /// Return the number of components, background excluded. mln_value(L) nelements() const; /// Return component information for a given component id \p id. @@ -357,11 +357,12 @@ namespace scribo }; + /// \relates component_set template <typename L> bool operator==(const component_set<L>& lhs, const component_set<L>& rhs); - + /// \relates component_set template <typename L> std::ostream& operator<<(std::ostream& ostr, const component_set<L>& info); diff --git a/scribo/scribo/core/object_links.hh b/scribo/scribo/core/object_links.hh index 0515d84..ef1d3ab 100644 --- a/scribo/scribo/core/object_links.hh +++ b/scribo/scribo/core/object_links.hh @@ -58,7 +58,7 @@ namespace scribo object_links_data(); object_links_data(const component_set<L>& components, unsigned size); object_links_data(const component_set<L>& components, - unsigned size, unsigned value); + unsigned size, unsigned default_link_id); mln::util::array<unsigned> comp_to_link_; component_set<L> components_; @@ -69,20 +69,41 @@ namespace scribo - /// \brief Object links representation. - /// - /// \ingroup grpstruct - // + /*! \brief Object links representation. + + This structure is meant to store link information between + components. Linking components can be considered as a first step + towards component grouping. + + It requires a component_set to be constructed. Each component + existing in the component_set may have link in an object_link + structure. If no component_set is used for construction, this + object is invalid (\sa is_valid()). + + + + \ingroup grpstruct + */ template <typename L> class object_links : public Serializable<object_links<L> > { typedef internal::object_links_data<L> data_t; public: + /// Default constructor. It produces an invalid structure. object_links(); + + /// Construct a valid object_links. Links is enabled for each + /// valid component but no link is set. Invalid components links + /// are disabled. object_links(const component_set<L>& components); - object_links(const component_set<L>& components, unsigned value); + /// Construct a valid object_links. Links is enabled for each + /// valid component and set by default towards component with id + /// \p default_link_id. Invalid components links are disabled. + object_links(const component_set<L>& components, unsigned default_link_id); + + /// Return the underlying component_set. const component_set<L>& components() const; /// Return True if this object_links structure is correctly @@ -97,6 +118,8 @@ namespace scribo /// itself to another component. bool is_linked(unsigned comp_id) const; + /// Return the number of links. This is equivalent to the number + /// of components + the background. unsigned nelements() const; /// Link related methods. @@ -116,10 +139,16 @@ namespace scribo const unsigned& operator()(unsigned comp_id) const; /// \} + /// Returns the underlying array encoding the component + /// links. Indexes in array correspond to component ids and the + /// corresponding value is the component id involved in the link. const mln::util::array<unsigned>& comp_to_link() const; + /// Initialize links. Each component is linked to itself (i.e. has + /// no link). Invalid components have linking disabled. void init(); + /// Make a deep copy of this structure. object_links<L> duplicate() const; private: @@ -127,6 +156,7 @@ namespace scribo }; + /// \relates object_links template <typename L> std::ostream& operator<<(std::ostream& ostr, const object_links<L>& links); @@ -156,8 +186,8 @@ namespace scribo template <typename L> object_links_data<L>::object_links_data(const component_set<L>& components, - unsigned size, unsigned value) - : comp_to_link_(size, value), components_(components) + unsigned size, unsigned default_link_id) + : comp_to_link_(size, default_link_id), components_(components) { }; @@ -182,10 +212,10 @@ namespace scribo template <typename L> object_links<L>::object_links(const component_set<L>& components, - unsigned value) + unsigned default_link_id) { data_ = new data_t(components, value::next(components.nelements()), - value); + default_link_id); } diff --git a/scribo/scribo/debug/logger.hh b/scribo/scribo/debug/logger.hh index 0b29aaf..ab283c3 100644 --- a/scribo/scribo/debug/logger.hh +++ b/scribo/scribo/debug/logger.hh @@ -144,7 +144,7 @@ namespace scribo inside a program. Stopping time logging will output the computed time if - Verbose mode is higher or equal to #Time. + Verbose mode is higher or equal to scribo::debug::Time. */ /// @{ void start_time_logging(); -- 1.7.2.5

1 0

olena-2.0-540-gaa8db8d scribo/core/component_set.hh: Hide internal API.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- scribo/ChangeLog | 4 ++++ scribo/scribo/core/component_set.hh | 5 +++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index 39b46c5..cf030cb 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,9 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * scribo/core/component_set.hh: Hide internal API. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + Move documentation of component_set in its corresponding header. * doc/scribo/core/component_set.dox: Remove and move documentation... diff --git a/scribo/scribo/core/component_set.hh b/scribo/scribo/core/component_set.hh index 72bdbcd..259a508 100644 --- a/scribo/scribo/core/component_set.hh +++ b/scribo/scribo/core/component_set.hh @@ -307,6 +307,8 @@ namespace scribo // Internal methods + /// \cond INTERNAL_API + /// \internal /// Return all the component infos. // @@ -343,10 +345,13 @@ namespace scribo // mln_concrete(L) valid_comps_image_() const; + /// \endcond protected: + /// \cond INTERNAL_API /// Duplicate the underlying image and create a new component_set. void init_(const component_set<L>& model); + /// \endcond mln::util::tracked_ptr<data_t> data_; }; -- 1.7.2.5

1 0

olena-2.0-539-ge2f4e92 Move documentation of component_set in its corresponding header.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

* doc/scribo/core/component_set.dox: Remove and move documentation... * scribo/core/component_set.hh: ... here. --- scribo/ChangeLog | 8 +++ scribo/doc/scribo/core/component_set.dox | 90 ------------------------------ scribo/scribo/core/component_set.hh | 88 +++++++++++++++++++++++++++++ 3 files changed, 96 insertions(+), 90 deletions(-) delete mode 100644 scribo/doc/scribo/core/component_set.dox diff --git a/scribo/ChangeLog b/scribo/ChangeLog index 3d971b9..39b46c5 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,13 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + Move documentation of component_set in its corresponding header. + + * doc/scribo/core/component_set.dox: Remove and move documentation... + + * scribo/core/component_set.hh: ... here. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * doc/Doxyfile.in: Expand more macros. 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> diff --git a/scribo/doc/scribo/core/component_set.dox b/scribo/doc/scribo/core/component_set.dox deleted file mode 100644 index ccde17c..0000000 --- a/scribo/doc/scribo/core/component_set.dox +++ /dev/null @@ -1,90 +0,0 @@ -/*! - \class scribo::component_set - - This structure is used to store rich information related to - components in an image. - - It can be constructed directly from a labeled image and the number - of components, or using primitive::extract::components (easier and - recommanded) with a binary image. - - \code - mln::image2d<bool> ima; - mln::io::pbm::load(ima, "document.pbm"); - - typedef scribo::def::lbl_type V; - typedef mln::image2d<V> L; - V ncomps; - component_set<L> comps = primitive::extract::components(ima, c4(), ncomps); - \endcode - - Each component is associated to an id, \ref component_id_t. This - id is equivalent to the component label in the label image (\ref - labeled_image()). - - A component_set is considered as valid if it has been initialized - (i.e. not instantiated with the default constructor). - - On construction, information is automatically computed for each - components. To iterate over all the components and get that - information, use operator()() or info(): - - \code - for_all_comps(c,comps) - { - const scribo::component_info<L>& comp_info = comps.info(c); - - // Some code here... - } - \endcode - - Among component information, a component::Tag tag is stored and - used to mark specific components. This tag can be massively - updated for all components using update_tags(). The function - passed to this method must implement the following interface: - - \code - template <typename L> - struct my_function - : mln::Function_v2b< my_function<L> > - { - // Constructor - my_function(const scribo::component_set<L>& components) - : components_(components) - { - } - - // Core function - bool operator()(const mln_value(L)& l) const - { - if (l == mln::literal::zero) - return false; - return true;// your test here - } - - /// Component set. - scribo::component_set<L> components_; - }; - \endcode - - Tags can be used to filter/make a selection of - components. Routines performing this selection/filtering - automatically are listed in \ref grpalgofiltercomp section. - - Components considered as separators in the input image (lines, - blocks, ...) may be processed separately and are useful of the - rest of the layout analysis. This structure allows you to store a - binary image of separators which will be used in some routines to - prevent wrong regrouping. Note that no component information will - be computed for separators. The separator image can be managed - with has_separators(), add_separators(), separators(), and - clear_separators(). - - scribo::component_set is the first data structure in the - hierarchical representation of a document as explained in \ref - grpstruct. - - \sa component_info, component::Tag, component::Type, grpstruct, - grpalgofiltercomp. - -*/ \ No newline at end of file diff --git a/scribo/scribo/core/component_set.hh b/scribo/scribo/core/component_set.hh index eea385b..72bdbcd 100644 --- a/scribo/scribo/core/component_set.hh +++ b/scribo/scribo/core/component_set.hh @@ -123,6 +123,94 @@ namespace scribo /*! \brief Represents all the components in a document image. + This structure is used to store rich information related to + components in an image. + + It can be constructed directly from a labeled image and the number + of components, or using primitive::extract::components (easier and + recommanded) with a binary image. + + \code + mln::image2d<bool> ima; + mln::io::pbm::load(ima, "document.pbm"); + + typedef scribo::def::lbl_type V; + typedef mln::image2d<V> L; + V ncomps; + component_set<L> comps = primitive::extract::components(ima, c4(), ncomps); + \endcode + + Each component is associated to an id, \ref component_id_t. This + id is equivalent to the component label in the label image (\ref + labeled_image()). They are labeled from 1 to nelements() + included. Id 0 is reserved for the background which is not + considered as an actual component. + + A component_set is considered as valid if it has been initialized + (i.e. not instantiated with the default constructor). + + On construction, information is automatically computed for each + components. To iterate over all the components and get that + information, use operator()() or info(): + + \code + for_all_comps(c,comps) + { + const scribo::component_info<L>& comp_info = comps.info(c); + + // Some code here... + } + \endcode + + Among component information, a component::Tag tag is stored and + used to mark specific components. This tag can be massively + updated for all components using update_tags(). The function + passed to this method must implement the following interface: + + \code + template <typename L> + struct my_function + : mln::Function_v2b< my_function<L> > + { + // Constructor + my_function(const scribo::component_set<L>& components) + : components_(components) + { + } + + // Core function + bool operator()(const mln_value(L)& l) const + { + if (l == mln::literal::zero) + return false; + return true;// your test here + } + + /// Component set. + scribo::component_set<L> components_; + }; + \endcode + + Tags can be used to filter/make a selection of + components. Routines performing this selection/filtering + automatically are listed in \ref grpalgofiltercomp section. + + Components considered as separators in the input image (lines, + blocks, ...) may be processed separately and are useful of the + rest of the layout analysis. This structure allows you to store a + binary image of separators which will be used in some routines to + prevent wrong regrouping. Note that no component information will + be computed for separators. The separator image can be managed + with has_separators(), add_separators(), separators(), and + clear_separators(). + + scribo::component_set is the first data structure in the + hierarchical representation of a document as explained in \ref + grpstruct. + + \sa component_info, component::Tag, component::Type, grpstruct, + grpalgofiltercomp. + \ingroup grpstruct */ template <typename L> -- 1.7.2.5

1 0

olena-2.0-538-g07333d2 doc/Doxyfile.in: Expand more macros.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- scribo/ChangeLog | 4 ++++ scribo/doc/Doxyfile.in | 11 +++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index dd9004e..3d971b9 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,9 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * doc/Doxyfile.in: Expand more macros. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * doc/Doxyfile.in: Exclude internal symbols from documentation. 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> diff --git a/scribo/doc/Doxyfile.in b/scribo/doc/Doxyfile.in index f9d930c..904121c 100644 --- a/scribo/doc/Doxyfile.in +++ b/scribo/doc/Doxyfile.in @@ -227,7 +227,8 @@ EXPAND_ONLY_PREDEF = YES SEARCH_INCLUDES = YES INCLUDE_PATH = INCLUDE_FILE_PATTERNS = -PREDEFINED = "for_all(x)=for(x.start(); x.is_valid(); x.next())" \ +PREDEFINED = MLN_INCLUDE_ONLY \ + "for_all(x)=for(x.start(); x.is_valid(); x.next())" \ "for_all_2(x1, x2)=for(x1.start(), x2.start(); x1.is_valid(); x1.next(), x2.next())" \ "for_all_3(x1, x2, x3)=for(x1.start(), x2.start(), x3.start(); x1.is_valid(); x1.next(), x2.next(), x3.next())" \ "for_all_remaining(x)=if (! x.is_valid()) {} else while (x.next(), x.is_valid())" \ @@ -325,9 +326,11 @@ PREDEFINED = "for_all(x)=for(x.start(); x.is_valid(); x.next())" \ "mln_graph_element_(T)=T::graph_element" \ "mln_fun_vv2v(F, L, R)=mln::fun::vv2v::F< mln_value(L), mln_value(R) >" \ "mln_fun_vv2v_result(F, L, R)=typename mln_fun_vv2v(F, L, R)::result" \ - "mln_ch_fun_vv2v(F, L, R)=typename mln::trait::ch_value< L, typename mln_fun_vv2v(F, L, R)::result >::ret" - - + "mln_ch_fun_vv2v(F, L, R)=typename mln::trait::ch_value< L, typename mln_fun_vv2v(F, L, R)::result >::ret" \ + "mln_ch_convolve(I, W)=typename mln::linear::ch_convolve<I, W>::ret" \ + "mln_ch_convolve_(I, W)=mln::linear::ch_convolve<I, W>::ret" \ + "mln_ch_convolve_grad(I, W)=typename mln::trait::ch_value< I, algebra::vec< I::site::dim, typename mln::linear::ch_convolve<I,W>::ret::value > >::ret" \ + "mln_ch_convolve_grad_(I, W)=mln::trait::ch_value< I, algebra::vec< I::site::dim, mln::linear::ch_convolve<I,W>::ret::value > >::ret" EXPAND_AS_DEFINED = -- 1.7.2.5

1 0

olena-2.0-537-g1a302ad doc/Doxyfile.in: Exclude internal symbols from documentation.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- scribo/ChangeLog | 4 ++++ scribo/doc/Doxyfile.in | 3 ++- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index 869db05..dd9004e 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,9 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * doc/Doxyfile.in: Exclude internal symbols from documentation. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * doc/Doxyflile.in: Fix include paths in documentation. 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> diff --git a/scribo/doc/Doxyfile.in b/scribo/doc/Doxyfile.in index 0c30c9c..f9d930c 100644 --- a/scribo/doc/Doxyfile.in +++ b/scribo/doc/Doxyfile.in @@ -110,7 +110,8 @@ EXCLUDE = @top_srcdir@/scribo/demo \ @top_srcdir@/scribo/+* EXCLUDE_SYMLINKS = YES EXCLUDE_PATTERNS = *.spe.hh *.moc.cc -EXCLUDE_SYMBOLS = *_ mln::trait::* +EXCLUDE_SYMBOLS = mln::trait::* \ + scribo::*::internal::*_data EXAMPLE_PATH = @top_srcdir@/scribo/doc/examples \ @top_srcdir@/scribo/doc/outputs \ @top_srcdir@/scribo/doc/examples/split \ -- 1.7.2.5

1 0

olena-2.0-536-gb0051dc doc/Doxyflile.in: Fix include paths in documentation.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- scribo/ChangeLog | 4 ++++ scribo/doc/Doxyfile.in | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/scribo/ChangeLog b/scribo/ChangeLog index 216f480..869db05 100644 --- a/scribo/ChangeLog +++ b/scribo/ChangeLog @@ -1,5 +1,9 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * doc/Doxyflile.in: Fix include paths in documentation. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * scribo/util/component_precise_outline.hh: Check if sites are part of the image. diff --git a/scribo/doc/Doxyfile.in b/scribo/doc/Doxyfile.in index 28371aa..0c30c9c 100644 --- a/scribo/doc/Doxyfile.in +++ b/scribo/doc/Doxyfile.in @@ -33,7 +33,7 @@ ABBREVIATE_BRIEF = ALWAYS_DETAILED_SEC = YES INLINE_INHERITED_MEMB = YES FULL_PATH_NAMES = YES -STRIP_FROM_PATH = @top_srcdir@/scribo +STRIP_FROM_PATH = STRIP_FROM_INC_PATH = @top_srcdir@/scribo SHORT_NAMES = NO JAVADOC_AUTOBRIEF = YES -- 1.7.2.5

1 0

olena-2.0-535-g13b6149 Move internal code to namespace internal.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

* mln/labeling/n_max.hh: Move internal function to namespace internal. * tests/labeling/n_max.cc: Update function namespaces. --- milena/ChangeLog | 9 +++++ milena/mln/labeling/n_max.hh | 77 +++++++++++++++++++++------------------ milena/tests/labeling/n_max.cc | 5 ++- 3 files changed, 53 insertions(+), 38 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index a45676f..91b8ec9 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,14 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + Move internal code to namespace internal. + + * mln/labeling/n_max.hh: Move internal function to namespace + internal. + + * tests/labeling/n_max.cc: Update function namespaces. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * mln/win/rectangle2d.hh: Hide internal API. 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> diff --git a/milena/mln/labeling/n_max.hh b/milena/mln/labeling/n_max.hh index c53949e..dbd2cf7 100644 --- a/milena/mln/labeling/n_max.hh +++ b/milena/mln/labeling/n_max.hh @@ -1,4 +1,5 @@ -// Copyright (C) 2009 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2009, 2013 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -35,13 +36,6 @@ /// /// Construct from a count accumulator of a labeled image an array with /// the ordered n biggest labels. -/// -/// \return an array starting at index 1 -/// -/// \warning The biggest value is stocked at index 0. It generally represents -/// the background and should be ignored. However, it is still accessible -/// if necessary. - namespace mln { @@ -49,11 +43,17 @@ namespace mln namespace labeling { - template <typename L, typename V> - util::array<L> - n_max(const util::array<V>& in_arr, unsigned n); + /*! \brief Construct from a count accumulator of a labeled image an array with + the ordered n biggest labels. + \return an array starting at index 1 + \warning The biggest value is stored at index 0. It usually + represents the background and should be ignored. However, it + is still accessible if necessary. + + \ingroup labeling + */ template <typename L> util::array<mln_value(L)> n_max(const Image<L>& lbl, const mln_value(L)& nlabels, unsigned n); @@ -61,44 +61,49 @@ namespace mln # ifndef MLN_INCLUDE_ONLY - template <typename L, typename V> - util::array<L> - n_max(const util::array<V>& in_arr, unsigned n) + namespace internal { - mln_trace("mln::labeling::n_max"); - - mln_precondition(n < in_arr.nelements()); - util::array<L> output(n + 1, 0); - for (unsigned i = 0; i < n + 1; ++i) - output[i] = i; - int swap = 0; - for (int j = n - 1; j > 0; --j) + template <typename L, typename V> + util::array<L> + n_max(const util::array<V>& in_arr, unsigned n) { - if (in_arr[output[j]] < in_arr[output[j + 1]]) - { - swap = output[j]; - output[j] = output[j + 1]; - output[j + 1] = swap; - } - } + mln_trace("mln::labeling::n_max"); - for (unsigned i = n; i < in_arr.nelements(); ++i) - { - if (in_arr[i] > in_arr[output[n]]) + mln_precondition(n < in_arr.nelements()); + + util::array<L> output(n + 1, 0); + for (unsigned i = 0; i < n + 1; ++i) + output[i] = i; + int swap = 0; + for (int j = n - 1; j > 0; --j) { - output[n] = i; - for (unsigned j = n - 1; j > 0 && in_arr[output[j]] < in_arr[output[j + 1]]; --j) + if (in_arr[output[j]] < in_arr[output[j + 1]]) { swap = output[j]; output[j] = output[j + 1]; output[j + 1] = swap; } } + + for (unsigned i = n; i < in_arr.nelements(); ++i) + { + if (in_arr[i] > in_arr[output[n]]) + { + output[n] = i; + for (unsigned j = n - 1; j > 0 && in_arr[output[j]] < in_arr[output[j + 1]]; --j) + { + swap = output[j]; + output[j] = output[j + 1]; + output[j + 1] = swap; + } + } + } + + return output; } - return output; - } + } // end of namespace mln::labeling::internal template <typename L> diff --git a/milena/tests/labeling/n_max.cc b/milena/tests/labeling/n_max.cc index 1b70a7e..001ed8b 100644 --- a/milena/tests/labeling/n_max.cc +++ b/milena/tests/labeling/n_max.cc @@ -1,4 +1,5 @@ -// Copyright (C) 2009 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2009, 2013 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of Olena. // @@ -55,7 +56,7 @@ int main() accu::math::count<int_u8> a_; util::array<unsigned> a = labeling::compute(a_, threshold, labels, nlabels); - util::array<label_8> arr_big = labeling::n_max<label_8>(a, 3); + util::array<label_8> arr_big = labeling::internal::n_max<label_8>(a, 3); mln_assertion(arr_big[1] == 1u); mln_assertion(arr_big[2] == 4u); -- 1.7.2.5

1 0

olena-2.0-534-g77d7b3a mln/win/rectangle2d.hh: Hide internal API.
by Guillaume Lazzara 17 Apr '13

17 Apr '13

--- milena/ChangeLog | 4 ++++ milena/mln/win/rectangle2d.hh | 13 ++++++++----- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/milena/ChangeLog b/milena/ChangeLog index 3275cd1..a45676f 100644 --- a/milena/ChangeLog +++ b/milena/ChangeLog @@ -1,5 +1,9 @@ 2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + * mln/win/rectangle2d.hh: Hide internal API. + +2013-04-17 Guillaume Lazzara <z(a)lrde.epita.fr> + Add labeling module in documentation. * doc/mln/labeling/labeling.dox: New. Introduce labeling module. diff --git a/milena/mln/win/rectangle2d.hh b/milena/mln/win/rectangle2d.hh index 6764755..fb6f734 100644 --- a/milena/mln/win/rectangle2d.hh +++ b/milena/mln/win/rectangle2d.hh @@ -1,4 +1,5 @@ -// Copyright (C) 2007, 2008, 2009 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2007, 2008, 2009, 2013 EPITA Research and Development +// Laboratory (LRDE) // // This file is part of Olena. // @@ -82,16 +83,18 @@ namespace mln /// Give the rectangle area. unsigned area() const; + /// Give the std vector of delta-points. + const std::vector<dpoint2d>& std_vector() const; + + + /// \cond INTERNAL_API /*! \brief Give the maximum coordinate gap between the window * center and a window point. */ unsigned delta_() const; - - /// Give the std vector of delta-points. - const std::vector<dpoint2d>& std_vector() const; - void print_(std::ostream& ostr) const; + /// \endcond protected: -- 1.7.2.5

1 0