May 2009 - Olena-patches

[Olena] #156: Kill a maximum of warnings in Swilena
by Olena 10 Jun '09

10 Jun '09

#156: Kill a maximum of warnings in Swilena -------------------------+-------------------------------------------------- Reporter: levill_r | Owner: levill_r Type: enhancement | Status: new Priority: minor | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Keywords: | -------------------------+-------------------------------------------------- The Python wrappers have been written quickly, and they lack some information (base classes, etc.), making `swig` emit a lot of warnings. Most of them are harmless, however they clutter the output of the build. Get rid of them. -- Ticket URL: <https://trac.lrde.org/olena/ticket/156> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

2 2

[Olena] #189: Factor Makefile helpers generators
by Olena Trac 10 Jun '09

10 Jun '09

#189: Factor Makefile helpers generators ---------------------------+------------------------------------------------ Reporter: levill_r | Owner: Olena Team Type: enhancement | Status: new Priority: minor | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Keywords: Make Automake | ---------------------------+------------------------------------------------ Generators * source:trunk/milena/tests/unit_test/build_unit_test.sh and * source:trunk/scribo/tests/unit_test/build_unit_test.sh share most of their code; factor them. Moreover, we should make some effort to factor all generators and move them to a common location (we use `dev/` in Tiger, but `build-aux/` is also acceptable). -- Ticket URL: <https://trac.lrde.org/olena/ticket/189> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 1

[Olena] #128: Handle carefully tests using X11
by Olena 10 Jun '09

10 Jun '09

#128: Handle carefully tests using X11 ----------------------+----------------------------------------------------- Reporter: levill_r | Owner: Olena Team Type: defect | Status: new Priority: major | Milestone: Olena 1.0ß Component: Milena | Version: 1.0 Keywords: test | ----------------------+----------------------------------------------------- Some tests require X11 visualization programs such as `display` (from !ImageMagick) or `xv`. This is an issue since * the they might not be installed on the machine; * the host/session on which tests are executed might not run a X11 display. IMHO, we could either 1. move them out of the `check` target (and have them launched by the `check-all`/`check-full` target, or a check-x11 target); or 2. have `configure` check whether the required programs are present, as well as a (usable) X11 session. (Maybe the Vaucanson Team ran into such questions; ask them.) -- Ticket URL: <https://trac.lrde.org/olena/ticket/128> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image library.

2 2

[Olena] #125: Ambiguity in comparaison with literals
by Olena 09 Jun '09

09 Jun '09

#125: Ambiguity in comparaison with literals --------------------------------+------------------------------------------- Reporter: garrigues | Owner: theo Type: defect | Status: new Priority: major | Milestone: Olena 1.0ß Component: Milena | Version: 1.0 Keywords: literals operators | --------------------------------+------------------------------------------- This test shows the problem : {{{ #!cpp # include <mln/value/gl8.hh> # include <mln/literal/all.hh> int main() { using mln::value::gl8; using mln::literal::white; gl8 b; b == white; } }}} The compiler can't find the right operator== to compate graylevel with literals. Here is the error output : {{{ test.cc: In function 'int main()': test.cc:11: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: ../../mln/literal/ops.hh:252: note: candidate 1: typename mln::trait::op::eq<O, O>::ret mln::operator==(const mln::Object<E>&, const mln::Literal<L>&) [with O = mln::value::graylevel<8u>, L = mln::literal::white_t] ../../mln/value/internal/gray_f.hh:317: note: candidate 2: bool mln::value::operator==(const mln::value::Integer<I>&, const mln::value::graylevel_f&) [with I = mln::value::graylevel<8u>] }}} -- Ticket URL: <https://trac.lrde.epita.fr/olena/ticket/125> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image library.

2 1

[Olena] #183: Have mln::complex_image be more flexible w.r.t. its domain
by Olena Trac 09 Jun '09

09 Jun '09

#183: Have mln::complex_image be more flexible w.r.t. its domain -------------------------+-------------------------------------------------- Reporter: levill_r | Owner: levill_r Type: enhancement | Status: new Priority: critical | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Keywords: site set | -------------------------+-------------------------------------------------- `mln::complex_image` makes it mandatory us to assign values to ''each'' face of a complex. But sometimes, we are only interested by a subset of a complex (e.g., its edges). We should have the choice of the domain of a `mln::complex_image`. Hint: see how Guillaume revamped the graph-based images, using functions (i.e. domain + value -> image). I (Roland) still consider actual images types are desirable, but we could implement them as wrappers of function- based images. I have set the priority of this ticket to 2 (« critical ») because we really need this feature for the examples of the ISMM'09 and DGCI'09 submissions. -- Ticket URL: <https://trac.lrde.org/olena/ticket/183> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

1 1

[Olena] #163: Decide into what mln_?iter(T) should expand
by Olena 09 Jun '09

09 Jun '09

#163: Decide into what mln_?iter(T) should expand ---------------------------------+------------------------------------------ Reporter: levill_r | Owner: Olena Team Type: proposal | Status: new Priority: minor | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Keywords: convention shortcut | ---------------------------------+------------------------------------------ In source:trunk/milena/mln/core/macros.hh, the macros {{{ #!cpp mln_?iter(T) mln_?iter_(T) }}} expand as {{{ #!cpp typename T::fwd_?iter T::fwd_?iter }}} Shouldn't they expand as {{{ #!cpp typename T::?iter T::?iter }}} ? -- Ticket URL: <https://trac.lrde.org/olena/ticket/163> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

2 3

[Olena] #157: Improve depency tracking in Swilena
by Olena 09 Jun '09

09 Jun '09

#157: Improve depency tracking in Swilena -------------------------+-------------------------------------------------- Reporter: levill_r | Owner: Olena Team Type: enhancement | Status: new Priority: minor | Milestone: Olena 1.0 Component: Swilena | Version: 1.0 Keywords: | -------------------------+-------------------------------------------------- Our hand-made build system does not seem to track dependencies very well in Swilena/Python. Improve this. -- Ticket URL: <https://trac.lrde.org/olena/ticket/157> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

2 2

[Olena] #180: algebra::vec's != operators cannot be used.
by Olena 08 Jun '09

08 Jun '09

#180: algebra::vec's != operators cannot be used. ---------------------+------------------------------------------------------ Reporter: lazzara | Owner: Olena Team Type: defect | Status: new Priority: major | Milestone: Olena 1.0 Component: Milena | Version: 1.0 Keywords: | ---------------------+------------------------------------------------------ The following example does not compile. test.cc: {{{ # include <mln/algebra/vec.hh> int main() { using namespace mln::algebra; vec<3, float> a, b; bool c = (a != b); } }}} g++ -I. test.cc {{{ test.cc: In function 'int main()': test.cc:6: error: cannot convert 'mln::algebra::vec<3u, bool>' to 'bool' in initialization ./mln/core/routine/ops.hh: In function 'typename mln::trait::op::neq<L, R>::ret mln::operator!=(const mln::Object<E>&, const mln::Object<O2>&) [with O1 = mln::algebra::vec<3u, float>, O2 = mln::algebra::vec<3u, float>]': test.cc:6: instantiated from here ./mln/core/routine/ops.hh:528: error: conversion from 'bool' to non-scalar type 'mln::algebra::vec<3u, bool>' requested }}} Note that if '(a != b)' is replaced by '(a == b)' or '!(a == b)', this example compiles. -- Ticket URL: <https://trac.lrde.org/olena/ticket/180> Olena <http://olena.lrde.epita.fr> Olena, a generic and efficient C++ image processing library.

2 1

3937: Update makefile list.
by Thierry Geraud 29 May '09

29 May '09

https://svn.lrde.epita.fr/svn/oln/trunk Index: ChangeLog from Thierry Geraud <thierry.geraud(a)lrde.epita.fr> Update makefile list. * configure.ac: Update makefile list. configure.ac | 1 - 1 file changed, 1 deletion(-) Index: configure.ac --- configure.ac (revision 3936) +++ configure.ac (working copy) @@ -247,7 +247,6 @@ milena/tests/core/Makefile milena/tests/core/alias/Makefile milena/tests/core/image/Makefile - milena/tests/core/image/morph/Makefile milena/tests/core/image/dmorph/Makefile milena/tests/core/image/imorph/Makefile milena/tests/core/image/vmorph/Makefile

1 0

3936: Move obsolete image types and clock_nbh2d into trash.
by Thierry Geraud 29 May '09

29 May '09

https://svn.lrde.epita.fr/svn/oln/trunk/milena Index: ChangeLog from Thierry Geraud <thierry.geraud(a)lrde.epita.fr> Move obsolete image types and clock_nbh2d into trash. * mln/core/image/morph/t_image.hh, * tests/core/image/morph/t_image.cc: Move to... * trash/t_image.hh, * trash/t_image.cc: ...these new trash files. * mln/core/clock_neighb.hh, * mln/core/clock_neighb2d.hh, * tests/core/other/clock_neighb2d.cc: Move to... * trash/clock_neighb.hh, * trash/clock_neighb2d.hh, * trash/clock_neighb2d.cc: ...trash. * tests/core/other/clock_test.cc: Rename and move to... * trash/clock_neighb2d_bis.cc: ...trash. * mln/core/image/tr_mesh.hh: Remove; empty class. * mln/core/image/morph/all.hh: Remove. * mln/core/image/morph: Remove directory. * tests/core/image/morph/Makefile.am: Remove. * tests/core/image/morph: Remove. * mln/core/image/all.hh: Update. * mln/trait/images.hh: Update. * mln/core/all.hh: Update. * tests/core/other/Makefile.am: Update. * tests/core/image/Makefile.am: Update. mln/core/all.hh | 5 ++--- mln/core/image/all.hh | 4 ---- mln/trait/images.hh | 9 ++++----- tests/core/image/Makefile.am | 1 - tests/core/other/Makefile.am | 5 ----- 5 files changed, 6 insertions(+), 18 deletions(-) Index: mln/trait/images.hh --- mln/trait/images.hh (revision 3935) +++ mln/trait/images.hh (working copy) @@ -1,5 +1,5 @@ -// Copyright (C) 2007, 2008 EPITA Research and Development Laboratory -// (LRDE) +// Copyright (C) 2007, 2008, 2009 EPITA Research and Development +// Laboratory (LRDE) // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -36,6 +36,8 @@ /// \todo Split this file into many. /// /// \todo the 'nature' prop is not set yet in image types. +/// +/// \todo The image list is not up-to-date (and move it elsewhere !) # include <iostream> # include <string> @@ -114,14 +116,11 @@ template <typename T> struct image2d; template <typename T> struct image3d; namespace pw { template <typename F, typename S> class image; } - template <typename P, typename T> class rle_image; - template <typename P, typename T> class sparse_image; // Morphers. template <typename I, typename F> struct image_if_base; template <typename I, typename D> class decorated_image; template <typename I, typename S> class sub_image; - template <typename I> struct t_image; template <typename I> class safe_image; template <typename T, typename I> class cast_image_; namespace value { template <unsigned n, typename I> struct stack_image; } Index: mln/core/image/all.hh --- mln/core/image/all.hh (revision 3935) +++ mln/core/image/all.hh (working copy) @@ -36,7 +36,6 @@ // Sub-directories. -# include <mln/core/image/morph/all.hh> # include <mln/core/image/dmorph/all.hh> # include <mln/core/image/imorph/all.hh> # include <mln/core/image/vmorph/all.hh> @@ -61,9 +60,6 @@ # include <mln/core/image/image1d.hh> # include <mln/core/image/image2d.hh> # include <mln/core/image/image3d.hh> -# include <mln/core/image/sparse_encode.hh> -# include <mln/core/image/sparse_image.hh> -# include <mln/core/image/tr_mesh.hh> # include <mln/core/image/vertex_image.hh> Index: mln/core/all.hh --- mln/core/all.hh (revision 3935) +++ mln/core/all.hh (working copy) @@ -1,4 +1,5 @@ -// Copyright (C) 2008 EPITA Research and Development Laboratory (LRDE) +// Copyright (C) 2008, 2009 EPITA Research and Development Laboratory +// (LRDE) // // This file is part of the Olena Library. This library is free // software; you can redistribute it and/or modify it under the terms @@ -45,8 +46,6 @@ // Local directory. # include <mln/core/a_point_of.hh> # include <mln/core/category.hh> -# include <mln/core/clock_neighb.hh> -# include <mln/core/clock_neighb2d.hh> # include <mln/core/dpoints_pixter.hh> # include <mln/core/contract.hh> # include <mln/core/dpoint.hh> Index: tests/core/other/Makefile.am --- tests/core/other/Makefile.am (revision 3935) +++ tests/core/other/Makefile.am (working copy) @@ -2,12 +2,9 @@ include $(top_srcdir)/milena/tests/tests.mk -##FIXME: re-enable tests check_PROGRAMS = \ box_runstart_piter \ category \ -## clock_neighb2d \ -## clock_test \ dpoints_pixter \ graph_elt_neighborhood \ graph_elt_neighborhood_if \ @@ -27,8 +24,6 @@ box_runstart_piter_SOURCES = box_runstart_piter.cc category_SOURCES = category.cc -##clock_neighb2d_SOURCES = clock_neighb2d.cc -##clock_test_SOURCES = clock_test.cc dpoints_pixter_SOURCES = dpoints_pixter.cc graph_elt_neighborhood_SOURCES = graph_elt_neighborhood.cc graph_elt_neighborhood_if_SOURCES = graph_elt_neighborhood_if.cc Index: tests/core/image/Makefile.am --- tests/core/image/Makefile.am (revision 3935) +++ tests/core/image/Makefile.am (working copy) @@ -3,7 +3,6 @@ include $(top_srcdir)/milena/tests/tests.mk SUBDIRS = \ - morph \ dmorph \ imorph \ vmorph

1 0