November 2008 - Olena-patches

milena r2759: Fix the gaussian_2nd_derivative coef normalisation
by Florian Lesaint 02 Nov '08

02 Nov '08

URL: https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena ChangeLog: 2008-11-02 Florian Lesaint <florian.lesaint(a)lrde.epita.fr> Fix the gaussian_2nd_derivative coef normalisation. and remove stretch since it can be a problem with float images. * linear/gaussian.hh: Here. --- gaussian.hh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Index: branches/cleanup-2008/milena/mln/linear/gaussian.hh =================================================================== --- branches/cleanup-2008/milena/mln/linear/gaussian.hh (revision 2758) +++ branches/cleanup-2008/milena/mln/linear/gaussian.hh (revision 2759) @@ -329,6 +329,7 @@ float exp2b0 = exp(2.0 * b0); float scale0 = 1 + exp2b0 - 2 * cos0 * expb0; + scale0 *= scale0 * scale0; float scaleA = a1 * sin0 * expb0 * (1 + expb0 * (2 * cos0 * (1 + exp2b0) + exp2b0 - 6)) + a0 * expb0 * (2 * expb0 * (2 - cos0 * cos0) * (1 - exp2b0) - cos0 * (1 - exp2b0 * exp2b0)); @@ -337,6 +338,7 @@ float exp2b1 = exp(2.0 * b1); float scale1 = 1 + exp2b1 - 2 * cos1 * expb1; + scale1 *= scale1 * scale1; float scaleC = c1 * sin1 * expb1 * (1 + expb1 * (2 * cos1 * (1 + exp2b1) + exp2b1 - 6)) + c0 * expb1 * (2 * expb1 * (2 - cos1 * cos1) * (1 - exp2b1) - cos1 * (1 - exp2b1 * exp2b1)); @@ -393,8 +395,8 @@ /* Convert the result image to the user-requested datatype. FIXME: We are making an unnecessary copy in case the user expects a ntg::float_s image. */ - level::stretch(work_img, out); - //level::paste(work_img, out); + //level::stretch(work_img, out); + level::paste(work_img, out); }

1 0

r2758: Big cleanup
by Maxime van Noppen 01 Nov '08

01 Nov '08

From: Maxime van Noppen <yabo(a)lrde.epita.fr> To: olena-patches(a)lrde.epita.fr Subject: r2758: Big cleanup URL: https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena/sandbox ChangeLog: 2008-11-01 Maxime van Noppen <yabo(a)lrde.epita.fr> Big cleanup. * max_tree.hh: Factorize code in generic methods. * v2.cc: Comment and clean code. --- max_tree.hh | 218 +++++++++++++++++++++++++----------------------------------- v2.cc | 111 +++++++++++++++++++++++------- 2 files changed, 177 insertions(+), 152 deletions(-) Index: branches/cleanup-2008/milena/sandbox/classif/max_tree.hh =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2757) +++ branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2758) @@ -37,21 +37,16 @@ mln_ch_value(I, point) new_parent; mln_ch_value(I, point) zpar; - // image of volumes - image3d<unsigned> vol; - image3d<unsigned> nb_represent; - image3d<double> density; - //tags image3d<bool> is_active; - image3d< algebra::vec<3, double> > mean_color; max_tree_(const I& f, const N& nbh) - : f(f), nbh(nbh), vol(f.domain()), nb_represent(f.domain()), density(f.domain()), - is_active(f.domain()), mean_color(f.domain()), new_parent(f.domain()) + : f(f), nbh(nbh), is_active(f.domain()), new_parent(f.domain()) { run(); level::fill(is_active, true); + + new_parent = parent; } void run() @@ -94,11 +89,11 @@ point active_parent(const point& p) { - if(is_root(p)) - return p; - point node = parent(p); - while (not is_active(node)) - node = parent(node); + point node = new_parent(p); + + while (not is_active(node) && not is_root(node)) + node = new_parent(node); + return node; } @@ -108,163 +103,169 @@ zpar(p) = p; } - void area() + image3d<unsigned> compute_nb_represent() { - image2d<value::int_u16> area(f.domain()); - level::fill(area, 1); - mln_fwd_piter(S) p(s); - for_all(p) - { - if (parent(p) == p) - continue; - area(parent(p)) += area(p); - } - debug::println(area); - } + image3d<unsigned> nb_represent(f.domain()); - void volume() - { - level::fill(vol, 0); level::fill(nb_represent, 0); - - { mln_fwd_piter(S) p(s); for_all(p) { - vol(p) += 1; nb_represent(p) += f(p); - if (not is_root(p)) - { nb_represent(parent(p)) += nb_represent(p); - vol(parent(p)) += vol(p); } - density(parent(p)) = (nb_represent(parent(p)) - nb_represent(p)) / (double) (vol(parent(p)) - vol(p)); - } - } - - { - mln_fwd_piter(S) p(s); - for_all(p) - { - std::cerr << " Color " << p << std::endl - << " vol = " << vol(p) << " vertices" << std::endl - << " nb_represent = " << nb_represent(p) << std::endl - << " f = " << f(p) << std::endl - << " density = " << density(p) << " representant / vertices " << std::endl << std::endl; - } - } + return nb_represent; } - void density_fusion(float ratio) + image3d<unsigned> compute_volume() { - assert(ratio < 1); + image3d<unsigned> volume(f.domain()); + level::fill(volume, 0); mln_fwd_piter(S) p(s); - for_all(p) - { - if (density(active_parent(p)) > (1 - ratio) * density(p) && - density(active_parent(p)) < (1 + ratio) * density(p)) - is_active(p) = false; - } - } - - void density_closing(float lambda) - { - assert(ratio < 1); - mln_fwd_piter(S) p(s); for_all(p) { - if (density(p) < lambda) - is_active(p) = false; + volume(p) += 1; + if (not is_root(p)) + volume(parent(p)) += volume(p); } + + return volume; } - void compute_mean_color() + image3d< algebra::vec<3, double> > compute_mean_color() { - level::fill(mean_color, make::vec(0, 0, 0)); + image3d< algebra::vec<3, double> > mean_color(f.domain()); + + update_parents(); mln_fwd_piter(S) p(s); for_all(p) mean_color(p) = make::vec(p[0], p[1], p[2]); for_all(p) - mean_color(parent(p)) = (mean_color(parent(p)) + mean_color(p)) / 2.; + mean_color(new_parent(p)) = (mean_color(new_parent(p)) + mean_color(p)) / 2.; - for_all(p) - if (mean_color(p)[0] < 10 && mean_color(p)[1] < 10 && mean_color(p)[2] < 10) - std::cerr << "Warning " << p << " == " << mean_color(p) << std::endl; + return mean_color; } - // Cut components with less represents than lambda - void volume_fusion(int lambda) + template<typename X> + void lumberjack(const X& ima, const mln_value(X)& lambda) { + unsigned progress = 0; + unsigned step = s.nsites() / 100; + mln_fwd_piter(S) p(s); + for_all(p) { - if (vol(p) < lambda) + if (ima(p) < lambda) is_active(p) = false; + + ++progress; + if (progress % step == 0) + { + std::cout << "." << std::flush; + progress = 0; } } - void nb_represent_fusion(int lambda) + std::cout << std::endl; + } + + template<typename X> + void nuclear_fusion(const X& ima, const mln_value(X)& lambda) { + unsigned progress = 0; + unsigned step = s.nsites() / 100; + + update_parents(); + mln_fwd_piter(S) p(s); for_all(p) { - if (nb_represent(p) < lambda) + if (fabs(1 - ima(new_parent(p)) / ima(p)) < lambda) is_active(p) = false; + + ++progress; + if (progress % step == 0) + { + std::cout << "." << std::flush; + progress = 0; } } + std::cout << std::endl; + } + void color_fusion(int lambda) { + unsigned progress = 0; + unsigned step = s.nsites() / 100; + + update_parents(); + mln_fwd_piter(S) p(s); for_all(p) { - if (parent(p)[0] - p[0] < lambda && - parent(p)[1] - p[1] < lambda && - parent(p)[2] - p[2] < lambda) + if (new_parent(p)[0] - p[0] < lambda && + new_parent(p)[1] - p[1] < lambda && + new_parent(p)[2] - p[2] < lambda) is_active(p) = false; - } - } - point active_parent(const point& p) + ++progress; + if (progress % step == 0) { - point node = parent(p); - - while (not is_active(node) && not is_root(node)) - node = parent(node); - - return node; + std::cout << "." << std::flush; + progress = 0; + } + } + std::cout << std::endl; } void update_parents() { + unsigned progress = 0; + unsigned step = s.nsites() / 100; + + std::cout << "Update parents"; + mln_fwd_piter(S) p(s); for_all(p) + { new_parent(p) = active_parent(p); + + ++progress; + if (progress % step == 0) + { + std::cout << "." << std::flush; + progress = 0; + } + } + std::cout << std::endl; } template < typename J > - void to_ppm(const J& ima, const std::string& file, unsigned f) + void to_ppm(const J& ima, const std::string& file, unsigned f, + const image3d< algebra::vec<3, double> >& mean_color) { + update_parents(); + J out(ima.domain()); level::fill(out, value::rgb8(0, 0, 0)); mln_piter(J) p(ima.domain()); for_all(p) { - point3d p3 = point3d(ima(p).red() / f, ima(p).green() / f, ima(p).blue() / f); - point3d node = new_parent(p3); + point3d node = new_parent(point3d(ima(p).red() / f, ima(p).green() / f, ima(p).blue() / f)); out(p) = value::rgb8(static_cast<unsigned char>(mean_color(node)[0] * f), static_cast<unsigned char>(mean_color(node)[1] * f), static_cast<unsigned char>(mean_color(node)[2] * f)); - //out(p) = value::rgb8(mean_color(node)[0] * f, mean_color(node)[1] * f, mean_color(node)[2] * f); } io::ppm::save(out, file); @@ -272,41 +273,9 @@ unsigned number_of_nodes() { - p_array<point> node; - - mln_fwd_piter(S) p(s); - for_all(p) - if (is_node(p)) - node.insert(p); - - std::cout << s.nsites() << std::endl; - std::cout << parent.domain().nsites() << std::endl; - std::cout << node.nsites() << std::endl; - return s.nsites(); } - void print_class_info() - { - int nb_class = 0; - - mln_fwd_piter(S) p(s); - - //std::cout.width(5); - std::cout.precision(2); - - std::cout << "Color\t\tId\t\tdensity\t\tvolume\t\tnb_represent" << std::endl; - - for_all(p) - { - if (is_active(p)) - { - std::cout << mean_color(p) << "\t\t" << nb_class << "\t\t" << density(p) << "\t\t" << vol(p) << "\t\t" << nb_represent(p) << std::endl; - ++nb_class; - } - } - } - bool is_root(const point& p) const { return parent(p) == p; @@ -334,7 +303,6 @@ zpar(r) = p; } } - }; Index: branches/cleanup-2008/milena/sandbox/classif/v2.cc =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2757) +++ branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2758) @@ -38,45 +38,100 @@ return histo; } +template <typename I> +image3d< double > +compute_density(const I& weight, const I& volume) +{ + image3d< double > density(volume.domain()); + + mln_piter(I) p(volume.domain()); + for_all(p) + density(p) = weight(p) / volume(p); + + return density; +} + template <typename I, typename J, typename N> unsigned -compute_max_tree(const I& ima, const J& histo, const N& nbh, - const unsigned f, float lambda, float ratio) +process_max_tree(const I& ima, const J& histo, const N& nbh, + double density_lambda, unsigned volume_lambda, + unsigned nb_represent_lambda, unsigned color_lambda, + unsigned div_factor) { max_tree_<J,N> run(histo, nbh); - run.volume(); + // FIXME: write a compute() method with functor argument + image3d<unsigned> nb_represent = run.compute_nb_represent(); + image3d<unsigned> volume = run.compute_volume(); + image3d< algebra::vec<3, double> > mean_color = run.compute_mean_color(); + image3d<double> density = compute_density(nb_represent, volume); - std::cout << "step 1 - nb_represent fusion" << std::endl; - //run.nb_represent_fusion(lambda); - std::cout << "step 2 - volume fusion" << std::endl; - //run.volume_fusion(lambda); - std::cout << "step 3 - color fusion" << std::endl; - //run.color_fusion(lambda); - std::cout << "step 3 - density fusion" << std::endl; - //run.density_fusion(ratio); + // Density closing + if (density_lambda > 0.00001) + { + std::cout << "Density cutting" << std::endl; + run.nuclear_fusion(density, density_lambda); + } - std::cout << "step Update parents" << std::endl; - run.update_parents(); + // Volume cutting + if (volume_lambda != 0) + { + std::cout << "Volume cutting" << std::endl; + run.lumberjack(volume, volume_lambda); + } + + // Represent cutting + if (nb_represent_lambda != 0) + { + std::cout << "nb_represent cutting" << std::endl; + run.lumberjack(nb_represent, nb_represent_lambda); + } + + // Color fusion + if (color_lambda != 0) + { + std::cout << "Color fusion" << std::endl; + run.color_fusion(color_lambda); // FIXME: factorize the code with a functor + } - std::cout << "step Compute mean color" << std::endl; + // Compute mean color of active nodes + std::cout << "Compute mean color" << std::endl; run.compute_mean_color(); - std::cout << "step Print class info" << std::endl; - run.print_class_info(); + // Print informations on the filtered max tree + { + int nb_class = 0; + + mln_piter(image3d<unsigned>) p(nb_represent.domain()); + + std::cerr.precision(2); + + std::cerr << "Color\t\tId\t\tdensity\t\tvolume\t\tnb_represent" << std::endl; + + for_all(p) + if (run.is_active(p)) + { + std::cerr << mean_color(p) << "\t\t" << nb_class << "\t\t" << density(p) << "\t\t" << volume(p) << "\t\t" << nb_represent(p) << std::endl; + ++nb_class; + } - std::cout << "step Output image" << std::endl; - run.to_ppm(ima, "out.ppm", f); + std::cout << "Number of classes : " << nb_class << std::endl; + } + + + // Write the image w.r.t. the max tree + run.to_ppm(ima, "out.ppm", div_factor, mean_color); } bool usage(int argc, char ** argv) { - if (argc != 5) + if (argc != 7) { - std::cout << "usage: " << argv[0] << " image div_factor lambda ratio" << std::endl; + std::cout << "usage: " << argv[0] << " image div_factor density_lambda volume_lambda nb_represent_lambda color_lambda" << std::endl; return false; } + return true; } @@ -86,10 +141,14 @@ return 1; image2d<value::rgb8> ima; + ima = io::ppm::load<value::rgb8>(argv[1]); - const int div_factor = atoi(argv[2]); - const float lambda = atof(argv[3]); - const float ratio = atof(argv[4]); + + int div_factor = atoi(argv[2]); + float density_lambda = atof(argv[3]); + unsigned volume_lambda = atoi(argv[4]); + unsigned nb_represent_lambda = atoi(argv[5]); + unsigned color_lambda = atoi(argv[6]); //make histo image3d<unsigned> histo = fill_histo(ima, div_factor); @@ -98,8 +157,6 @@ accu::mean<unsigned, unsigned, unsigned> mean; image2d<unsigned> phisto = proj(histo, mean); - //debug::println(phisto); - - // Compute max_tree - compute_max_tree(ima, histo, c6(), div_factor, lambda, ratio); + // Process max_tree + process_max_tree(ima, histo, c6(), density_lambda, volume_lambda, nb_represent_lambda, color_lambda, div_factor); }

1 0

r2757: Merge the filter chain
by Maxime van Noppen 01 Nov '08

01 Nov '08

From: Maxime van Noppen <yabo(a)lrde.epita.fr> To: olena-patches(a)lrde.epita.fr Subject: r2757: Merge the filter chain URL: https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena/sandbox ChangeLog: 2008-11-01 Maxime van Noppen <yabo(a)lrde.epita.fr> Merge the filter chain. * max_tree.hh: Add a new_parent image to avoid computing them all * the time. * v2.cc: Define a filter chain order. --- max_tree.hh | 28 ++++++++++++++++++++-------- v2.cc | 21 ++++++++++++++++----- 2 files changed, 36 insertions(+), 13 deletions(-) Index: branches/cleanup-2008/milena/sandbox/classif/max_tree.hh =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2756) +++ branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2757) @@ -34,6 +34,7 @@ S s; mln_ch_value(I, bool) deja_vu; mln_ch_value(I, point) parent; + mln_ch_value(I, point) new_parent; mln_ch_value(I, point) zpar; // image of volumes @@ -47,7 +48,7 @@ max_tree_(const I& f, const N& nbh) : f(f), nbh(nbh), vol(f.domain()), nb_represent(f.domain()), density(f.domain()), - is_active(f.domain()), mean_color(f.domain()) + is_active(f.domain()), mean_color(f.domain()), new_parent(f.domain()) { run(); level::fill(is_active, true); @@ -231,6 +232,23 @@ } } + point active_parent(const point& p) + { + point node = parent(p); + + while (not is_active(node) && not is_root(node)) + node = parent(node); + + return node; + } + + void update_parents() + { + mln_fwd_piter(S) p(s); + for_all(p) + new_parent(p) = active_parent(p); + } + template < typename J > void to_ppm(const J& ima, const std::string& file, unsigned f) { @@ -241,13 +259,7 @@ for_all(p) { point3d p3 = point3d(ima(p).red() / f, ima(p).green() / f, ima(p).blue() / f); - - point3d node = p3; - if (not is_node(p3)) - node = parent(p3); - - while (not is_active(node)) - node = parent(node); + point3d node = new_parent(p3); out(p) = value::rgb8(static_cast<unsigned char>(mean_color(node)[0] * f), static_cast<unsigned char>(mean_color(node)[1] * f), Index: branches/cleanup-2008/milena/sandbox/classif/v2.cc =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2756) +++ branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2757) @@ -45,18 +45,29 @@ { max_tree_<J,N> run(histo, nbh); - //run.number_of_nodes(); run.volume(); - run.volume_fusion(lambda); - run.density_fusion(ratio); + std::cout << "step 1 - nb_represent fusion" << std::endl; + //run.nb_represent_fusion(lambda); + std::cout << "step 2 - volume fusion" << std::endl; + //run.volume_fusion(lambda); + std::cout << "step 3 - color fusion" << std::endl; + //run.color_fusion(lambda); + std::cout << "step 3 - density fusion" << std::endl; + //run.density_fusion(ratio); + + std::cout << "step Update parents" << std::endl; + run.update_parents(); + + std::cout << "step Compute mean color" << std::endl; run.compute_mean_color(); - run.to_ppm(ima, "out.ppm", f); + std::cout << "step Print class info" << std::endl; run.print_class_info(); - //std::cout << " Number of nodes : " << run.number_of_nodes() << std::endl; + std::cout << "step Output image" << std::endl; + run.to_ppm(ima, "out.ppm", f); } bool usage(int argc, char ** argv)

1 0

cleanup-2008 2756: INIM: Classif: Work on density.
by Ugo Jardonnet 01 Nov '08

01 Nov '08

https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena/sandbox Index: ChangeLog from Ugo Jardonnet <ugo.jardonnet(a)lrde.epita.fr> INIM: Classif: Work on density. * classif/max_tree.hh (density closing|fusion): Add. * classif/v2.cc: Add parameter. max_tree.hh | 40 +++++++++++++++++++++++++++++++++++++--- v2.cc | 36 +++++++++++------------------------- 2 files changed, 48 insertions(+), 28 deletions(-) Index: classif/max_tree.hh --- classif/max_tree.hh (revision 2755) +++ classif/max_tree.hh (working copy) @@ -91,6 +91,16 @@ } // end of run() + point active_parent(const point& p) + { + if(is_root(p)) + return p; + point node = parent(p); + while (not is_active(node)) + node = parent(node); + return node; + } + void make_set(const point& p) { parent(p) = p; @@ -124,13 +134,13 @@ vol(p) += 1; nb_represent(p) += f(p); - if (parent(p) != p) + if (not is_root(p)) { nb_represent(parent(p)) += nb_represent(p); vol(parent(p)) += vol(p); } - density(p) = nb_represent(p) / (double) vol(p); + density(parent(p)) = (nb_represent(parent(p)) - nb_represent(p)) / (double) (vol(parent(p)) - vol(p)); } } @@ -147,6 +157,31 @@ } } + void density_fusion(float ratio) + { + assert(ratio < 1); + + mln_fwd_piter(S) p(s); + for_all(p) + { + if (density(active_parent(p)) > (1 - ratio) * density(p) && + density(active_parent(p)) < (1 + ratio) * density(p)) + is_active(p) = false; + } + } + + void density_closing(float lambda) + { + assert(ratio < 1); + + mln_fwd_piter(S) p(s); + for_all(p) + { + if (density(p) < lambda) + is_active(p) = false; + } + } + void compute_mean_color() { level::fill(mean_color, make::vec(0, 0, 0)); @@ -214,7 +249,6 @@ while (not is_active(node)) node = parent(node); -write: out(p) = value::rgb8(static_cast<unsigned char>(mean_color(node)[0] * f), static_cast<unsigned char>(mean_color(node)[1] * f), static_cast<unsigned char>(mean_color(node)[2] * f)); Index: classif/v2.cc --- classif/v2.cc (revision 2755) +++ classif/v2.cc (working copy) @@ -40,45 +40,30 @@ template <typename I, typename J, typename N> unsigned -compute_max_tree(const I& ima, const J& histo, const N& nbh, const unsigned f, int lambda) +compute_max_tree(const I& ima, const J& histo, const N& nbh, + const unsigned f, float lambda, float ratio) { max_tree_<J,N> run(histo, nbh); -#if 0 - I out(ima.domain()); - mln_piter(I) p(ima.domain()); - for_all(p) - { - //color at ima(p) - point3d v = point3d(ima(p).red() / f, - ima(p).green() / f, - ima(p).blue() / f); - //node the class of color with same density as v - point3d pn = run.parent(v); - //out(p) = color pn - out(p) = value::rgb8(pn[0] * f, pn[1] * f, pn[2] * f); - } - io::ppm::save(out, "tmp.ppm"); -#endif //run.number_of_nodes(); - run.volume(); - run.nb_represent_fusion(lambda); + run.volume(); run.volume_fusion(lambda); - run.color_fusion(5); + run.density_fusion(ratio); run.compute_mean_color(); - run.print_class_info(); run.to_ppm(ima, "out.ppm", f); + run.print_class_info(); + //std::cout << " Number of nodes : " << run.number_of_nodes() << std::endl; } bool usage(int argc, char ** argv) { - if (argc != 4) + if (argc != 5) { - std::cout << "usage: " << argv[0] << " image div_factor lambda" << std::endl; + std::cout << "usage: " << argv[0] << " image div_factor lambda ratio" << std::endl; return false; } return true; @@ -92,7 +77,8 @@ image2d<value::rgb8> ima; ima = io::ppm::load<value::rgb8>(argv[1]); const int div_factor = atoi(argv[2]); - const int lambda = atoi(argv[3]); + const float lambda = atof(argv[3]); + const float ratio = atof(argv[4]); //make histo image3d<unsigned> histo = fill_histo(ima, div_factor); @@ -104,5 +90,5 @@ //debug::println(phisto); // Compute max_tree - compute_max_tree(ima, histo, c6(), div_factor, lambda); + compute_max_tree(ima, histo, c6(), div_factor, lambda, ratio); }

1 0

r2754: Allow to chain filters
by Maxime van Noppen 01 Nov '08

01 Nov '08

From: Maxime van Noppen <yabo(a)lrde.epita.fr> To: olena-patches(a)lrde.epita.fr Subject: r2754: Allow to chain filters URL: https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena/sandbox ChangeLog: 2008-11-01 Maxime van Noppen <yabo(a)lrde.epita.fr> Allow to chain filters. * max_tree.hh: Here. * v2.cc: Chain filters. --- max_tree.hh | 24 +++++++++++++++++++----- v2.cc | 5 +++++ 2 files changed, 24 insertions(+), 5 deletions(-) Index: branches/cleanup-2008/milena/sandbox/classif/max_tree.hh =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2753) +++ branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2754) @@ -50,6 +50,7 @@ is_active(f.domain()), mean_color(f.domain()) { run(); + level::fill(is_active, true); } void run() @@ -165,8 +166,6 @@ // Cut components with less represents than lambda void volume_fusion(int lambda) { - level::fill(is_active, true); - mln_fwd_piter(S) p(s); for_all(p) { @@ -177,8 +176,6 @@ void nb_represent_fusion(int lambda) { - level::fill(is_active, true); - mln_fwd_piter(S) p(s); for_all(p) { @@ -187,6 +184,18 @@ } } + void color_fusion(int lambda) + { + mln_fwd_piter(S) p(s); + for_all(p) + { + if (parent(p)[0] - p[0] < lambda && + parent(p)[1] - p[1] < lambda && + parent(p)[2] - p[2] < lambda) + is_active(p) = false; + } + } + template < typename J > void to_ppm(const J& ima, const std::string& file, unsigned f) { @@ -237,11 +246,16 @@ mln_fwd_piter(S) p(s); + //std::cout.width(5); + std::cout.precision(2); + + std::cout << "Color\t\tId\t\tdensity\t\tvolume\t\tnb_represent" << std::endl; + for_all(p) { if (is_active(p)) { - std::cout << "Class " << nb_class << " : " << p << std::endl; + std::cout << mean_color(p) << "\t\t" << nb_class << "\t\t" << density(p) << "\t\t" << vol(p) << "\t\t" << nb_represent(p) << std::endl; ++nb_class; } } Index: branches/cleanup-2008/milena/sandbox/classif/v2.cc =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2753) +++ branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2754) @@ -62,8 +62,13 @@ //run.number_of_nodes(); run.volume(); + run.nb_represent_fusion(lambda); + run.volume_fusion(lambda); + run.color_fusion(5); + run.compute_mean_color(); + run.print_class_info(); run.to_ppm(ima, "out.ppm", f); //std::cout << " Number of nodes : " << run.number_of_nodes() << std::endl;

1 0

r2753: Add some debug infos and some filters on max trees
by Maxime van Noppen 01 Nov '08

01 Nov '08

From: Maxime van Noppen <yabo(a)lrde.epita.fr> To: olena-patches(a)lrde.epita.fr Subject: r2753: Add some debug infos and some filters on max trees URL: https://svn.lrde.epita.fr/svn/oln/branches/cleanup-2008/milena/sandbox ChangeLog: 2008-11-01 Maxime van Noppen <yabo(a)lrde.epita.fr> Add some debug infos and some filters on max trees. * max_tree.hh, * v2.cc: Here. --- max_tree.hh | 40 ++++++++++++++++++++++++++++++++++------ v2.cc | 2 +- 2 files changed, 35 insertions(+), 7 deletions(-) Index: branches/cleanup-2008/milena/sandbox/classif/max_tree.hh =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2752) +++ branches/cleanup-2008/milena/sandbox/classif/max_tree.hh (revision 2753) @@ -156,9 +156,14 @@ for_all(p) mean_color(parent(p)) = (mean_color(parent(p)) + mean_color(p)) / 2.; + + for_all(p) + if (mean_color(p)[0] < 10 && mean_color(p)[1] < 10 && mean_color(p)[2] < 10) + std::cerr << "Warning " << p << " == " << mean_color(p) << std::endl; } - void simple_filter_1(int lambda) + // Cut components with less represents than lambda + void volume_fusion(int lambda) { level::fill(is_active, true); @@ -170,6 +175,18 @@ } } + void nb_represent_fusion(int lambda) + { + level::fill(is_active, true); + + mln_fwd_piter(S) p(s); + for_all(p) + { + if (nb_represent(p) < lambda) + is_active(p) = false; + } + } + template < typename J > void to_ppm(const J& ima, const std::string& file, unsigned f) { @@ -183,12 +200,7 @@ point3d node = p3; if (not is_node(p3)) - { - if (is_active(parent(p3))) - goto write; - node = parent(p3); - } while (not is_active(node)) node = parent(node); @@ -219,6 +231,22 @@ return s.nsites(); } + void print_class_info() + { + int nb_class = 0; + + mln_fwd_piter(S) p(s); + + for_all(p) + { + if (is_active(p)) + { + std::cout << "Class " << nb_class << " : " << p << std::endl; + ++nb_class; + } + } + } + bool is_root(const point& p) const { return parent(p) == p; Index: branches/cleanup-2008/milena/sandbox/classif/v2.cc =================================================================== --- branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2752) +++ branches/cleanup-2008/milena/sandbox/classif/v2.cc (revision 2753) @@ -62,7 +62,7 @@ //run.number_of_nodes(); run.volume(); - run.simple_filter_1(lambda); + run.nb_represent_fusion(lambda); run.compute_mean_color(); run.to_ppm(ima, "out.ppm", f);

1 0